- 26 Mar, 2020 40 commits
-
-
chrome://media-appTrent Apted authored
This adds a new IDR resource id, to decouple the shown-icon from any icon asset that gets brought in via DEPS. Bug: b/150637102 Change-Id: I55b98e9fe7cf0d3fde4a87661d9dfbd39dc12ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120661 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#753538}
-
Marc Treib authored
...into ComputePendingCredentialsState and BuildPendingCredentials. This will allow us to call ComputePendingCredentialsState twice in MultiStorePasswordSaveManager - separately for the account matches and the profile matches. Bug: 1012203 Change-Id: Ie017474b84e4dc8b0b82bb4bb35a483dfb1a9175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116039 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#753537}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/056caa9eda32..22ff3cfaf62e Created with: gclient setdep -r src-internal@22ff3cfaf62e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1052460,chromium:1058597 Tbr: jbudorick@google.com Change-Id: Ic3dc696055b5c39692f82a319eda7353847f9d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121536Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753536}
-
chrome://media-app-guestTrent Apted authored
chrome://media-app-guest runs unprivileged code that doesn't require any of the implicit powers that chrome:// schemes get. Switch it over to the new chrome-untrusted:// scheme that was built to cater for this use case. The approach here follows the approach used for the help app in r744077. But since the test harness for media-app-guest no longer has a webui it can piggyback off, the tests need to be migrated into a framework which allows the tests to be injected into the unprivileged frame within the context of the test harness that exists for the privileged webui. Bug: 996088 Change-Id: I41c9866375f86a032eff752ce9a3b9c1c00ed212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108400Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#753535}
-
David Tseng authored
Fixed by Suppress -Wpredefined-identifier-outside-function in SpeechMonitor TBR=dtseng@chromium.org Change-Id: I5e583e9b9c7c35778ca081ec7b3bd7e82da81af4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121474Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#753534}
-
Istiaque Ahmed authored
This CL makes the test load an actual extension from test dir instead of just creating a test extension object that is not loaded in extension system. The test flakily fails because the first call to network::BlockingDnsLookup doesn't resolve dns lookup. This CL is based on the wild intuition that as we use the extension's url in NetworkIsolationKey and the extension is not present in extension system, the test fails. Therefore, loading the extension would remove the failure cause. Two thousand runs with this fix survives in bots, where the test wouldn't without this CL. Bug: 1064832 Change-Id: Id75af472f9457b1205f1caef34b4e6686bbcaeee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121344 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#753533}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c2d325c1d67a..d8c6c0e0f3a6 git log c2d325c1d67a..d8c6c0e0f3a6 --date=short --first-parent --format='%ad %ae %s' 2020-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 540bdf92531d..77090261dabc (10 commits) Created with: gclient setdep -r src/third_party/skia@d8c6c0e0f3a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I5ce93795ea54ef374ae007458d221f72cff8f08a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121471Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753532}
-
Noel Gordon authored
DirectoryTree displays focus rings when the keyboard or pointer device (mouse/pointer/touch) is used for interaction in files-ng. Change that: only show focus rings for keyboard interaction, using the global focus-outline-visible class provided by the cr.ui.focus_outline visibility manager. Bug: 1062902, 992819 Change-Id: Idb94a7be5582cfa4ae7429f04d53b95c8c855596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114512Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#753531}
-
Rakina Zata Amni authored
This function might be called after the frame is removed now. Bug: 1064683 Change-Id: I3092d2f77eeb0652c072277b9724fe4191e2e580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120777Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#753530}
-
Hwanseung Lee authored
Use enum class instead of enum for views::LayoutFadeType. enum class is more type safety. Bug: 940736 Change-Id: I9c026d131835d77d212e4084bc84cb703a0638a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120837 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#753529}
-
Daniel Hosseinian authored
Store PDF version of the document as an enum field in DocumentMetadata. Bug: 93619 Change-Id: Ied76c6fd4cdaf379e822046af0fff4ab4ff8af12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118682Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#753528}
-
Hayato Ito authored
This reverts commit 105f5197. Reason for revert: build failure https://ci.chromium.org/p/chromium/builders/ci/android-archive-dbg/4471 Failure Step compile failed. Error logs are shown below: [86291/95274] SOLINK ./libvk_tests__library.cr.so FAILED: libvk_tests__library.cr.so libvk_tests__library.cr.so.TOC lib.unstripped/libvk_tests__library.cr.so /b/s/w/ir/cipd_bin_packages/cpython/bin/python "../../build/toolchain/gcc_solink_wrapper.py" --reade...(too long) ld.lld: error: undefined symbol: gfx::GpuMemoryBufferHandle::GpuMemoryBufferHandle(base::android::ScopedHardwareBufferHandle) >>> referenced by vulkan_android_unittests.cc:133 (../../gpu/vulkan/android/vulkan_android_unittests.cc:133) >>> obj/gpu/vulkan/android/vk_tests__library/vulkan_android_unittests.o:(gpu::VulkanImplementationAndroidTest_CreateVkImageFromAHB_Test::TestBody()) Original change's description: > Reland "VulkanImage: support create from GpuMemoryBufferHandle on Android" > > This is a reland of 838eb034 > > Original change's description: > > VulkanImage: support create from GpuMemoryBufferHandle on Android > > > > VulkanImage::CreateFromGpuMemoryBufferHandle() is added to replace > > VulkanImplementation::CreateVkImageAndImportAHB(), and will replace > > VulkanImplementation::CreateImageFromGpuMemoryHandle() as well. > > > > Bug: None > > Change-Id: I7c6e3cea685f1ec305790f4a6d7bb66164f26e55 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114587 > > Commit-Queue: Peng Huang <penghuang@chromium.org> > > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#753394} > > TBR=rjkroege@chromium.org,vasilyt@chromium.org > > Cq-Include-Trybots: luci.chromium.try:android_archive_rel_ng > Bug: None > Change-Id: Ie6132474ef4a386ed661116aa8f580fd8460901d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121442 > Reviewed-by: Peng Huang <penghuang@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753501} TBR=penghuang@chromium.org,rjkroege@chromium.org,vasilyt@chromium.org Change-Id: Ifbb45c4dbb1017d26d68c1216f3b5bdaece36991 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:android_archive_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120995Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#753527}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8351d2182b54..a8bbccaabeff git log 8351d2182b54..a8bbccaabeff --date=short --first-parent --format='%ad %ae %s' 2020-03-26 phoglund@google.com Remove histogram proto JSON converter code. Created with: gclient setdep -r src/third_party/catapult@a8bbccaabeff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: skyostil@google.com Change-Id: Id827eea4c6b4c36a48769007e06059f0afb5a4a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121376Reviewed-by:
-
Glen Robertson authored
This allows us to remove the cases where a TestABMD and ABMD coexisted and the workaround for that ie. all observers previously had to implement OnAppBannerManagerChangedForTesting. This is in prep for adding a new observer. Change-Id: I0fb1e87a1e7072a2ef28d6b5bb57c2a296659794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111253Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#753525}
-
Abhijeet Kandalkar authored
Migrate this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I11a272729c422a3eb48d07ea21493f7998fc226e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119465Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#753524}
-
chrome://media-appTrent Apted authored
Linters are cool. PRESUBMIT.py is the one that was in ui/file_manager, but with the path adjusted so it can find `web_dev_style`. .eslintrc.js is the one from ui/webui but with 'parserOptions': { 'ecmaVersion': 2018, 'sourceType': 'module', }, added. This is needed to support `await` and spread syntax, and matches our closure typechecking flags. Note we also inherit the .eslintrc.js configuration in src/.eslintrc.js. Fixes were mostly achieved by ./third_party/node/linux/node-linux-x64/bin/node \ third_party/node/node_modules/eslint/bin/eslint.js \ chromeos/components/media_app_ui/{test,resources/{js,mock}} --fix The remaining bits were: - document.getElementById is a restricted keyword. Recommendation is to use resources/js/util.js, but I'm not sure we need/want that dependency. Found a workaround (querySelector), but we might add that dependency in a follow-up. (Where we use getElementById is placeholder/ experimental code currently). - linter didn't like declaring a "namespace" like media_app. Changed to declare pageHandler directly. - linter also couldn't automatically fix the `==` -> `===`. Bug: b/152284689 Change-Id: Ib12765ade3cc5f3a9f46448ad8741eb3b8434737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119336Reviewed-by: -
sczs authored
Change-Id: I0782ba0e2879110475831d7e1d56b8cb91ddb0da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118581 Auto-Submit: Sergio Collazos <sczs@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#753522}
-
Alex Danilo authored
Bug: 1064478 Change-Id: Ief97408a822f6ff1ed2be2e1366d1d261ffc7062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121117Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#753521}
-
Jonah Chin authored
This change sets up a code path to render a simple canvas with OOP rasterization. It covers the most basic Canvas2D cases (ie. draw operations with stroke()). This CL also introduces diverging code paths based on the CanvasOopRasterization flag. OOP-R canvas functionality will remain divergent behind this feature flag as we work towards parity with the current code path, at which point the current code path will be removed. In this change, the flag is often used to bypass uses of GrContext, SkSurface and SkImage (all of which are unavailable with OOP-R). References to these objects will be replaced in future changes as we flesh out the OOP code path. This is being done as part of the OOPR-Canvas2D project. For more info about the project see the tracking bug here: crbug.com/1018894 Bug: 1023277 Change-Id: Iffd279418f7b104a84513f14495983fc63e623c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076555 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#753520}
-
Patrick Monette authored
This is a reland of b7526e4f, but by with an additional fix. When a PerProfileWorkerTaskTracker instance is deleted because StopUpdating() was called, then the removal notifications must not be sent to the task manager (as part of the TaskProvider's API contract). This is handled in WorkerTaskProvider by dropping the notification when IsUpdating() is false. Original change's description: > [Task Manager] Properly clear worker tasks on profile shutdown. > > Fixes PerProfileWorkerTaskTracker so that the WorkerTaskTracker is > notified when there are outstanding tasks that are about to be > deleted. > > Bug: 1060506 > Change-Id: Ic81ad1557c1e27a8fc96fc079f7447efcc2ce7f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110350 > Auto-Submit: Patrick Monette <pmonette@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751915} Bug: 1060506 Change-Id: I3c1a7f8f94a580d021b7e3658af885110bfa8d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118770 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#753519}
-
Trent Apted authored
This reverts commit 59211f2c. Reason for revert: Persistent failures on linux-chromeos-chrome waterfall bot starting https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/4305 errors like ../../chrome/browser/chromeos/accessibility/speech_monitor.h:64:54: error: predefined identifier is only valid inside function [-Werror,-Wpredefined-identifier-outside-function] const base::Location& location = FROM_HERE); Original change's description: > Include line numbers in SpeechMonitor async api > > Unfortunately, to resolve base::Location for each api call, we cannot support chaining. > > However, shortening the variable name for > |speech_monitor_| > to > |sm_| > and not having to indent, we actually save some indent space. > > Also, this change now includes all pending utterances (for understanding the state when the test is waiting). > > Sample output: > [158567:158567:0325/082550.588956:ERROR:speech_monitor.cc(276)] Still waiting for expectation(s). > Unsatisfied expectations... > ExpectSpeech("Fail!Rate 19 percent") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:931 > Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:933 > ExpectSpeech("Pitch 50 percent") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:934 > Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:936 > ExpectSpeech("Reset text to speech settings to default values") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:938 > Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:941 > ExpectSpeech("Rate 19 percent") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:942 > Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:943 > ExpectSpeech("Pitch 50 percent") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:944 > > pending speech utterances... > Volume 100 percent > Rate 19 percent > > Satisfied expectations... > Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:926 > ExpectSpeech("Reset text to speech settings to default values") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:928 > Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:930 > > Change-Id: If1bdbfb517014e681cb233800eab3f62f608188f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120741 > Reviewed-by: Akihiro Ota <akihiroota@chromium.org> > Commit-Queue: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753353} TBR=dmazzoni@chromium.org,dtseng@chromium.org,akihiroota@chromium.org Change-Id: Ib3acf61914b3dd81ce2d777961d16de060ae9192 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121598 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#753518}
-
Trent Apted authored
This reverts commit a3c46feb. Reason for revert: Landed on top of https://chromium-review.googlesource.com/c/chromium/src/+/2120741 which needs to be reverted Original change's description: > Re-enable some SpokenFeedbackTests > > General strategy: > - perform all actions (sm_.Call) > - gather pending utterances > - mix in Expect* calls between all Call actions (incrementally from the top) > - keep the tests mostly simple (limit UI interactions) to prevent flakes > - do use the async SpeechMonitor api which should be less flakey > - deleted one test who's behavior is still in flux (empty panel menu behavior) > > Some tests were still failing but due to external factors. Comments left. > > Change-Id: I7689880dbeeac3b31fe22a8029fae5078d975f0a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119382 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: Akihiro Ota <akihiroota@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753470} TBR=dmazzoni@chromium.org,dtseng@chromium.org,akihiroota@chromium.org Change-Id: I01288031b7aab5694da31522da5393bf25ff2018 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121636Reviewed-by:
-
Jeff Yoon authored
This is a reland of f039e78b Original change's description: > [ios] ios-simulator-cronet tryjob src side Chromium config > > ios-simulator-cronet under chromium.fyi has already been migrated. > Missed migrating the trybot with it. > > Bug: 1055164,912681 > Change-Id: Ia58340308ba719dc6f39cf65ab40f73c4c89929b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120051 > Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753391} Bug: 1055164, 912681 Change-Id: If39fc51bcf87744f46345630881bdd6074a88638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121136Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#753516}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b69c4e14c5e2..6719f54ac7ce git log b69c4e14c5e2..6719f54ac7ce --date=short --first-parent --format='%ad %ae %s' 2020-03-26 courtneygo@google.com Update Vulkan header and related repos Created with: gclient setdep -r src/third_party/angle@6719f54ac7ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I52959a4e93b1deb319188c24ed42a5589bf7c9d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121464Reviewed-by:
-
Jeff Yoon authored
- chromium recipe and xcode build version set in goma.star - additional_compile_targets in waterfalls.pyl - mb arguments in mb_config.pyl - clobber flag is set recipe side. Generated files: - chromium.goma.json - chromium.ci.json - cr-buildbucket.cfg Bug: 1055164, 912681 Change-Id: Ie7b99ec62aace430bd0a563fc341cf1104a32963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113431Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#753514}
-
tby authored
This removes the remaining references to the old 'cat' model, which we are no longer using. Bug: 1028447 Change-Id: I2d08e65e24fd979f485180338a03107902e57e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121597 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#753513}
-
Kenichi Ishibashi authored
All methods/fields that should remain //content have moved to ServiceWorkerRegistry so these comments are no longer needed. Bug: 1039200 Change-Id: I6282c4d43c4cc59bd7d9782ad20ddea416d8fbe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120660 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#753512}
-
Hayato Ito authored
Bug: 1064395 TBR: dominickn@chromium.org Change-Id: If8bcce47c110603e49155f5476104a2d7f30e104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120835Reviewed-by:
-
Gyuyoung Kim authored
This CL moves flex-factor-less-than-one.html test from css3/css-flexbox to external/wpt/css/css-flexbox with WPT styles, adding links to the relevant specs, and a test description. Bug: 1063749 Change-Id: Ia2403deb69ca5f7e44f43d9b51c8b6664a09c999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121596 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
-
Noel Gordon authored
Followup to CL:2066409. When quick-view first opens, it also opens the metadata box. Set the files-ng toolbar metadata info button's 'toogle' state (read the CL) to match the initial metadata box state [1]. [1] Missing from CL:2066409 and I missed it in code review :/ Bug: 992824 Change-Id: Ia81c809dc80f1290292379f2ef4cd63a949ed971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120833Reviewed-by:
-
Manuel Rego Casasnovas authored
These set of tests pass in Firefox but not in Chromium. They check what happens when you scroll an element with "text-overflow: ellipsis", right now in Chromium the rest of the content of the element is not visible at all (once truncated the text ellipsis is not moved). The solution would be to force a relayout during scrolling but it seems we prefer to keep current behavior to avoid performance issues on scrolling. The behavior is not mandatory according Both behaviors are allowed in the spec, so the tests are marked with the "should" flag: https://drafts.csswg.org/css-overflow/#ellipsis-scrolling Bug=745905 TEST=external/wpt/css/css-overflow/text-overflow-scroll-001.html TEST=external/wpt/css/css-overflow/text-overflow-scroll-rtl-001.html TEST=external/wpt/css/css-overflow/text-overflow-scroll-vertical-lr-001.html TEST=external/wpt/css/css-overflow/text-overflow-scroll-vertical-lr-rtl-001.html TEST=external/wpt/css/css-overflow/text-overflow-scroll-vertical-rl-001.html TEST=external/wpt/css/css-overflow/text-overflow-scroll-vertical-rl-rtl-001.html Change-Id: I975ca86dbdfedf92875c08736539fb2f33f68c54 Bug: 745905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113495 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#753508}
-
haozhe authored
The patch adds owning_element to CSSAnimation class. Now the CSSAnimations have an owning_element and we will clear the owning element if the animation disassociate from the owning_element. The next follow up patches will add the owning_element to CSSTransition and using owning element to compare the composite ordering. As per spec: https://drafts.csswg.org/css-transitions-2/#owning-element and: https://drafts.csswg.org/css-animations-2/#owning-element-section Bug: 1047316 Change-Id: I5ddb54b13330f851b830547f02d9acaad91f3e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108613 Commit-Queue: Hao Sheng <haozhes@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#753507}
-
Wei-Yin Chen (陳威尹) authored
This reverts commit 4a511800. Reason for revert: break compile on many Android bots. See crbug.com/1064847. Original change's description: > Enable -Wunreachable-code on Android. > > Bug: 346399 > Change-Id: I41c8cf8581bff1256a28a15c80bdd59a599b0cc2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119759 > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Bo <boliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753406} TBR=thakis@chromium.org,boliu@chromium.org Change-Id: I8cc1fea613255b63987bc1b1cc1c0af1972cf4b7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 346399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121468Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#753506}
-
Noel Gordon authored
Using setAttribute and removeAttribute is an anti-pattern in areas our code: toggleAttribute can be used to achieve the exact same result. Add a TODO about this.$.innerContentPanel.focus() not working. Comment is most likely out-of-date, we'll see. Bug: 992824 Change-Id: I58ab7ae8418273cde9eb41c78b9a9babfdd9658b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120775Reviewed-by:
-
Koji Ishii authored
Because we have |NGFragmentItem| for culled inline boxes, we don't have to loop and find descendants of inline boxes. This patch has no behavior changes. Bug: 982194 Change-Id: Iba288cfc788b0f30263c0f8910fa9a56ccd4bc2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120126Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Koji Ishii authored
|MoveToLastForSameLayoutObject| saves |NGInlineCursor| because it was written before |NGInlineCursorPosition| was added. This patch changes to save |NGInlineCursorPosition|, saving a bit of memory bandwidth. This patch has no behavior changes. Bug: 982194 Change-Id: Ia1b8ddbf303c2823b2f72e8f24883435602d8399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120372Reviewed-by:
-
Noel Gordon authored
Nothing using this yet, but the hope is we can use :host-context() CSS html queries along with other html .foo state. No-try: true Bug: 992824 Change-Id: I74f6b8c28bb9f38e00848fee4ff3a37e73e2d668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120776Reviewed-by:
-
Peng Huang authored
This is a reland of 838eb034 Original change's description: > VulkanImage: support create from GpuMemoryBufferHandle on Android > > VulkanImage::CreateFromGpuMemoryBufferHandle() is added to replace > VulkanImplementation::CreateVkImageAndImportAHB(), and will replace > VulkanImplementation::CreateImageFromGpuMemoryHandle() as well. > > Bug: None > Change-Id: I7c6e3cea685f1ec305790f4a6d7bb66164f26e55 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114587 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753394} TBR=rjkroege@chromium.org,vasilyt@chromium.org Cq-Include-Trybots: luci.chromium.try:android_archive_rel_ng Bug: None Change-Id: Ie6132474ef4a386ed661116aa8f580fd8460901d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121442Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#753501}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e1d6f39d..3714932e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I30d3fc19f46e39f3c209e67c372d857c59127b7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121279Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753500}
-
Marijn Kruisselbrink authored
Bug: 1064795 Change-Id: Ib9999b6b2366872a92c508a292e8268936d54109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121416 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#753499}
-
