- 05 Sep, 2018 40 commits
-
-
Hugo Holgersson authored
Previously we used the *layout* viewport's rectangle to determine if a certain node was visible or not. Let's use the *visual* viewport instead. Now: A visible node is a node that intersects the visual viewport. This logic is used by spatnav to rule out offscreen focus candidates and an offscreen activeElement. When activeElement is offscreen, spatnav doesn't use it as its search origin; the search will start at an edge of the visual viewport instead. For consistency, I replaced all other uses of LayoutViewport() with GetScrollableArea() - even though fixing HasOffscreenRect() was enough to fix Issue 823227. Bug: 823227 Change-Id: I8a89cfc98d896998b899a5246f2c38e23fe0171b Reviewed-on: https://chromium-review.googlesource.com/1204094 Commit-Queue: Hugo Holgersson <hugoh@vewd.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#588792}
-
Matt Falkenhagen authored
This reverts commit 0ee23351. Reason for revert: Top crash in canary and blocks dev release per bug 880021. Original change's description: > Count number of active touches in TouchActionFilter > > Right now we have a active_touch_in_progress_ to indicate whether there > is an active touch or not. It is true when we receive ACK for touch > start and false at touch end. > > From the current crash report, we are seeing multiple consecutive ack > for touch end, without any ack for touch start in between. > > This CL changes the active_touch_in_progress_ to num_of_active_touches_. > It is increased by one when we receive ack for touch start and decrease > by one at touch end. At touch end, we only reset touch action when this > number is zero. > > In theory, touch start and associated touch end should arrive in pair. > This CL does a DumpWithoutCrashing if this number is ever larger than > one. > > Bug: 851644 > Change-Id: I584f1aad56bf5bc5c08e20e3ae4ca36d5f9e3586 > Reviewed-on: https://chromium-review.googlesource.com/1196696 > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587813} TBR=dtapuska@chromium.org,xidachen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 851644, 880021 Change-Id: I265b573cef100ff6210683e7f5ec01dfcb28ea9f Reviewed-on: https://chromium-review.googlesource.com/1205923Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#588791}
-
Kent Tamura authored
https://web-platform-tests.org/writing-tests/testharness-api.html#harness-timeout Bug: 877104, 877300, 698165 Change-Id: I994550295c15f9b42273abc7d1b11f47dc0bb0c7 Reviewed-on: https://chromium-review.googlesource.com/1205917 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#588790}
-
Yutaka Hirano authored
On 301/302/303 redirect, we may change the request method to "GET". While that is done by net/ logic, we need to reset the body manually in CORSURLLoader for some cases. Bug: 870173 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Id864729a8adaa29af52bc4e7d8c3455b57e2528c Reviewed-on: https://chromium-review.googlesource.com/1205974 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#588789}
-
arthursonzogni authored
Cause of revert: =============== A few MediaLauncherActivityTest don't run on the CQ. They were waiting on SeparateTaskCustomTabActivity to finish, but it is no more used. Original description: ===================== Remove SeparateTaskcustomTabActivity for Android version > L. Make SeparateTaskcustomTabActivity to be used only for Android version pre L. The part used for Android version >= L is merged into CustomTabActivity. This is a prerequisite for skipping the ChromeLauncherActivity and directly launch the CustomTabActivity. TBR=tedchoc@chromium.org R=lizeb@chromium.org Bug: 681559 Change-Id: I121241a2f43f62c346a24adb153649bec3b80af3 Reviewed-on: https://chromium-review.googlesource.com/1201845Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#588788}
-
Yutaka Hirano authored
- send-redirect-bogus-sync.htm is not failing any more. Remove the entries. - send-authentication-existing-session-manual.htm and send-authentication-prompt-2-manual.htm are listed in NeverFixTests. Move the virtual/outoblink-cors[-ns] entries to the file as well. Bug: 870173 Change-Id: I6c94bb6b3559727133b94a1915f0b8cc89705525 Reviewed-on: https://chromium-review.googlesource.com/1206052 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#588787}
-
Valeriya Sinevich authored
Change-Id: I32ea66dcd6d7466573c0ed143038d9edb241ac86 Reviewed-on: https://chromium-review.googlesource.com/1199763 Commit-Queue: Valeriya Sinevich <valeriyas@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#588786}
-
Samuel Huang authored
This reverts commit bde179ef. Reason for revert: http://crrev.com/880583 : The ASan LSan problems disappeared even before the revert was included, and once revert was included there were no extra fix. Therefore relanding the CL. Original change's description: > Revert "Implement script and style attr/elem CSP directives" > > This reverts commit b691cab2. > > Reason for revert: http://crbug.com/880583 : ASan detected memory leaks, so speculatively reverting. > > Original change's description: > > Implement script and style attr/elem CSP directives > > > > The functionality is behind the > > ContentSecurityPolicyExperimentalFeaturesEnabled flag > > > > I2IS: Coming Soon > > > > Spec: > > https://w3c.github.io/webappsec-csp/#directive-script-src-elem > > https://w3c.github.io/webappsec-csp/#directive-script-src-attr > > https://w3c.github.io/webappsec-csp/#directive-style-src-elem > > https://w3c.github.io/webappsec-csp/#directive-style-src-attr > > > > Change-Id: Ic1638cac15c7ec488fcc7a4c9f6261b97502090a > > Reviewed-on: https://chromium-review.googlesource.com/1181050 > > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > > Reviewed-by: Mike West <mkwst@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#588534} > > TBR=mkwst@chromium.org,andypaicu@chromium.org > > Change-Id: I385cd9eae7190412199496b3625dbf94d1fa45a6 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/1205392 > Reviewed-by: Samuel Huang <huangs@chromium.org> > Commit-Queue: Samuel Huang <huangs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588674} TBR=huangs@chromium.org,mkwst@chromium.org,andypaicu@chromium.org Change-Id: Id0429ccdf59ec803077394f2300058051b0492c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1205478Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#588785}
-
Yutaka Hirano authored
ThreadableLoader re-creates the request on redirect for some cases. We need to remember whether we need notification for uploading. Bug: 870173 Change-Id: Ic7e4847c4d4c9facb57cd09cb85b04ca78ddfca7 Reviewed-on: https://chromium-review.googlesource.com/1206170Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#588784}
-
Richard Li authored
This CL aims to solve Issue 877341, which plans to replace content::ChangedVersionAttributesMask with a new mojom type: blink::mojom::ChangedVersionAttributesMask. Bug: 877341 Change-Id: I2670e5ad52fce4e01281567dd8a7e55165ece51e Reviewed-on: https://chromium-review.googlesource.com/1201350Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Richard Li <richard.li@intel.com> Cr-Commit-Position: refs/heads/master@{#588783}
-
Takashi Toyoshima authored
This makes CORSURLLoaderFactory use OriginAccessList to check the source origin and destination URL pairs in the allowed list. There is no caller in production code at this moment, but patch set to support the legacy path and NetworkService will follow respectively. Bug: 870172 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Iba37beb1d955edf05148ad9ac15731e64e58de1e Reviewed-on: https://chromium-review.googlesource.com/1196702 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#588782}
-
Chris Hall authored
TBR=stevenjb@chromium.org Bug: 879943 Change-Id: I2f6168bc46c5c5e42e422c7acd7af35618a27ffc Reviewed-on: https://chromium-review.googlesource.com/1201623Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#588781}
-
Han Leon authored
This CL removes the member |is_valid_| of blink::WebServiceWorkerInstalledScriptsManager::RawScriptData, which becomes easy to be replaced with blink::InstalledScriptsManager::ScriptStatus for the next step when we remove blink::WebServiceWorkerInstalledScriptsManager and move content::WebServiceWorkerInstalledScriptsManagerImpl into Blink. BUG=792778 Change-Id: I14fcdfbb276007fa87428b19a9029fb722b78647 Reviewed-on: https://chromium-review.googlesource.com/1200682 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#588780}
-
yoshiki iguchi authored
Previously all touch events were ignored on Chrome side on child notification. But that caused the issue on scrolling (see the issue). This CL changes the behabior to disable only top-level slide on child notifications so that scrolling is possible correctly even on them. Bug: 876430 Test: manual (observe no issue) Change-Id: Ieb88ad19a94f71612998039e3a9abe4e91fc3856 Reviewed-on: https://chromium-review.googlesource.com/1203757Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#588779}
-
Stuart Langley authored
Change-Id: Idb5857427ebb5134ec7c273f266e1f798322dbd2 Reviewed-on: https://chromium-review.googlesource.com/1205922 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588778}
-
Rune Lillesveen authored
Calling UpdatePlaceholderVisibility on StyleDidChange makes us mark style dirty in the middle of a layout tree rebuild. Bug: 868810 Change-Id: I070e9fd576e21768099297767f2eddaaf401068c Reviewed-on: https://chromium-review.googlesource.com/1205150Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#588777}
-
Chris Hall authored
Bug: 879943 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I66d8f9f539c27e908208a121882e5c5fb84eedc2 Reviewed-on: https://chromium-review.googlesource.com/1201504Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#588776}
-
Wang Qing authored
Bug: 872560 Change-Id: I58fbd5b4252eb6eae69e13a81ac5638cd27a83ec R: thakis@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1189518Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: 汪 清 <wangqing-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#588775}
-
Makoto Shimazu authored
ServiceWorkerContextClient requests its termination when the worker gets idle. However, when the browser knows DevTools is attached to the service worker, the termination request is silently dropped. After that, even if ServiceWorkerSubresourceLoader tries to trigger fetch events, those requests will be queued indefinitely. This CL is to notify the renderer to run tasks again when DevTools is attached. Bug: 878667 Change-Id: Iefdc4382489b68aae28aab57b5a7c96520795d14 Reviewed-on: https://chromium-review.googlesource.com/1194820Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#588774}
-
Takashi Toyoshima authored
There are some tests that call testRunner.addOriginAccessAllowListEntry even in navigation and security test directories. They are expected to call it to bypass renderer-side security checks, but let me run them in our outofblink-cors(-ns) virtual environments just in case. Also the security directory seems to contain many relevant tests that rely on CORS check on ResourceFetcher. Bug: 870172, 870173, 879991 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_mojo Change-Id: I55c75b6766da6b98c7a2d816fbcfec555d181b68 Reviewed-on: https://chromium-review.googlesource.com/1193524Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#588773}
-
Tom Anderson authored
R=sky Change-Id: I3e922309a769c1a3f7c8d3aab8703652112bb3ac Reviewed-on: https://chromium-review.googlesource.com/1205720Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#588772}
-
Sam McNally authored
Bug: 877043 Change-Id: Iab18132a8c4750de0f7f96601f6232c41e3aaf54 Reviewed-on: https://chromium-review.googlesource.com/1194544Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#588771}
-
Sam McNally authored
- Use DriveIntegrationService::GetMountPointPath() in GetDownloadLocationText() to get the Drive mount path. - Update the test to explicitly cover DriveFS-enabled and DriveFS-disabled cases. - Change DriveFsHost to return the expected mount path when unmounted. - Make test-only ProfileHelper methods public, making the list of friends mostly unnecessary. Bug: 879422 Change-Id: I162ef7e74d58b400d9242be599700c4491fba6c7 Reviewed-on: https://chromium-review.googlesource.com/1201632Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#588770}
-
Eriko Kurimoto authored
ChromeVox+O>E to enable logging. ChromeVox+O>D to disable logging. Bug: 880004 Change-Id: I25e618e1bb986432722b59cb7669808006bea354 Reviewed-on: https://chromium-review.googlesource.com/1201515Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#588769}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/85f4e40c5481..72a02112a99f git log 85f4e40c5481..72a02112a99f --date=short --no-merges --format='%ad %ae %s' 2018-09-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@72a02112a99f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: Idec39d365bed5736c161d045f9a5e2ae7ac83e3c Reviewed-on: https://chromium-review.googlesource.com/1205618Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588768}
-
Lei Zhang authored
Merge the two into content::GetAndroidOSInfo(), and update the that it is not actually available on Chrome OS. base: :SysInfo::HardwareModelName() header comment to reflect the fact Change-Id: I68573105d1025d701ea6c4b457d9ee5e0c033e38 Reviewed-on: https://chromium-review.googlesource.com/1198568Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#588767}
-
Raymes Khoury authored
Some content settings types don't support embedded patterns, however it's currently possible to set embedded patterns for these types. https://chromium-review.googlesource.com/c/chromium/src/+/1173192 stops this from being possible, however if these patterns were already written to a pref then they will still be there. This CL deletes those patterns. Bug: 802945 Change-Id: Ia7fd878ba3d1a635bb92215f0b6dbba04519a07c Reviewed-on: https://chromium-review.googlesource.com/1175518Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#588766}
-
David Tseng authored
The braille cursor (when content is wrapped) persists even after the content to which is pertains changes. Prevent this from happening by explicitly omitting the cursor when the start/end index of the cursor is -1. Change-Id: I5a0dbeea9e73e3d60bef25e7fe68be2cc6d97f0d Reviewed-on: https://chromium-review.googlesource.com/1200362Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#588765}
-
Takuto Ikuta authored
Currently browser_tests on win7_chromium_rel_ng sometimes took more than 10 mins. Let me increase the number of shards for such tests. e.g 753s https://ci.chromium.org/b/8936390613165886176 732s https://ci.chromium.org/b/8936406831776876544 706s https://ci.chromium.org/b/8936396862731996176 704s https://ci.chromium.org/b/8936363432077079248 Bug: 868114 Change-Id: I9a7eb07ce2c58f5b03e5f39152dba7ac6101f11b Reviewed-on: https://chromium-review.googlesource.com/1203519 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#588764}
-
Tom Anderson authored
These macros don't add much besides saving a single GtkWidget* parameter to the corresponding CHROMEG_CALLBACK macros. R=sky Change-Id: Ia64bb5b6f96df3f33d7adc61a50781f73bf0ae1c Reviewed-on: https://chromium-review.googlesource.com/1205597Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#588763}
-
Chris Hall authored
Bug: 879943 Change-Id: I005e99857d2609ffed42bba5d5968c84a23ad7d5 Reviewed-on: https://chromium-review.googlesource.com/1201642Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#588762}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f90f8c14. With Chromium commits locally applied on WPT: b691cab2 "Implement script and style attr/elem CSP directives" bde179ef "Revert "Implement script and style attr/elem CSP directives"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24076 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: If993c8d3e6dac20ea831a5d1704a6097ab0d239a Reviewed-on: https://chromium-review.googlesource.com/1205473 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#588761}
-
Max Moroz authored
Calling os.path.realpath seems to be an overkill, as it is used either: - for various local paths like LLVM binaries dir, output dir, etc which are fine to be symlinks; - for report files produced by llvm-cov tool, which do not seem to ever have symlinks. Leaving os.path.realpath() in there might seem harmless, but apparently there are cases when it causes troubles, e.g.: https://github.com/google/oss-fuzz/pull/1777#issuecomment-417805976 Tested locally with https://crrev.com/c/1184048. Bug: 866943 Change-Id: I4224664ef3bf5b7eb3f1fd3605e9db0fff11833c Reviewed-on: https://chromium-review.googlesource.com/1205594Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#588760}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3d61ac27ae8f..cc0466301999 git log 3d61ac27ae8f..cc0466301999 --date=short --no-merges --format='%ad %ae %s' 2018-09-05 tobine@google.com Use chromium mirror for jsoncpp Created with: gclient setdep -r src/third_party/angle@cc0466301999 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I9cf9dbc945986c127dfd9b1428aad65a82d4cab7 Reviewed-on: https://chromium-review.googlesource.com/1205615Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588759}
-
Luciano Pacheco authored
Add property names set to update event so event listeners can check if the metadata that they want has been updated in constant time. Add entriesMap to update event so event listeners can check if the relevant entry has been updated in constant time. These will be used in the directory_tree.js to update the 'shared' icon for sub-directories. Bug: 880187, 880189 Change-Id: I5bb21e8b82b208c8d971e3193840f8b6afb8546e Reviewed-on: https://chromium-review.googlesource.com/1203352Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#588758}
-
Fabio Tirelo authored
Currently, the refresh on Android is controlled by the same flag as on Desktop, which prevents us from enabling it by default. Bug: 874077 Change-Id: Ifd13ae50e243e605ecdcb2742fefa555b9be2a35 Reviewed-on: https://chromium-review.googlesource.com/1204834 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#588757}
-
Eriko Kurimoto authored
Bug: 816369 Test: None Change-Id: I9159fdfbe8fe9c156306e5e5783384f386d13654 Reviewed-on: https://chromium-review.googlesource.com/1195301Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#588756}
-
Kent Tamura authored
- fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom125.html - fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom200.html - virtual/scalefactor150/fast/hidpi/static/data-suggestion-picker-appearance.html - virtual/scalefactor200withzoom/fast/hidpi/static/data-suggestion-picker-appearance.html - virtual/scalefactor200/fast/hidpi/static/data-suggestion-picker-appearance.html They are marked as flaky, but they fail consistently. We'd like to check if they are still flaky after this rebaseline. TBR=yosin@chromium.org Bug: 681468 Change-Id: I1cccc27a70b7585ca0221bcf17ea1b24dbf1980f Reviewed-on: https://chromium-review.googlesource.com/1205911Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#588755}
-
Scott Chen authored
Bug: 832933 Change-Id: I86a97c2fcca2d00064a5ac72304c7a1e8591c703 Reviewed-on: https://chromium-review.googlesource.com/1187725 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#588754}
-
Paul Irish authored
Many tracing consumers collect the toplevel category only for this event, however the toplevel category is very chatty (~25-50% of a trace's bytes). This will allow downstream tools to collect much smaller traces. Bug: 874982 Change-Id: Ib41ded90f120ba9a703a10f83320d0d10233ed13 Reviewed-on: https://chromium-review.googlesource.com/791314 Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#588753}
-