GitLab

Currently, the password bubble opens up only on "webby" URLs i.e. it
does not work on URLs such as chrome: or file: but the save password
infobar shows up also for the "non-webby" URLs making both the prompts
behave in a different manner. This patch makes the behaviour for both
the prompts consistent.

BUG=393138

Review URL: https://codereview.chromium.org/582833005

Cr-Commit-Position: refs/heads/master@{#296701}

This test measures CPU and memory when we acquire a HD stream with
WebRTC. The existing local-video.html demo will acquire whatever is the
default, which currently is VGA.

The demo page is taken from our GitHub demo repository and is only
lightly edited to get js paths right.

BUG=413577

Review URL: https://codereview.chromium.org/551863005

Cr-Commit-Position: refs/heads/master@{#296700}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3d349bd..de6a362

TBR=ager@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/603113003

Cr-Commit-Position: refs/heads/master@{#296699}

BUG=None

Review URL: https://codereview.chromium.org/599373002

Cr-Commit-Position: refs/heads/master@{#296698}

Currently Blink is shut down before all the pending tasks in the message loop are deleted. This is problematic in Oilpan because a destructor of the pending tasks can touch Oilpan objects. Because Oilpan is already detached from the renderer thread at that point, touching Oilpan objects in the destructor leads to a crash. (See the bug report for a concrete scenario.)

To prevent Blink objects from getting accessed after Blink is shut down, this CL deletes all pending tasks in a message loop before shutting down Blink.

BUG=411026
TEST=None. I cannot reproduce the crash.

Review URL: https://codereview.chromium.org/583043005

Cr-Commit-Position: refs/heads/master@{#296697}

TBR=jkummerow@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/608473002

Cr-Commit-Position: refs/heads/master@{#296696}

We don't use the android_webview_java target anymore, get rid of it
and the resource_map entries.
Also, get rid of the res_hack folder since we now have a real resources
folder in our source tree.

BUG=None
TEST=compile on android_aosp bot
TBR=miguelg@chromium.org

Review URL: https://codereview.chromium.org/540993002

Cr-Commit-Position: refs/heads/master@{#296695}

BUG=405566

Review URL: https://codereview.chromium.org/508973003

Cr-Commit-Position: refs/heads/master@{#296694}

he middle of current channel transition.

For example:
1. User is currently on the beta channel and decides to switch to the dev channel.
2. In the middle of the switch the user decides to switch to the stable channel
   instead of currently downloading dev.

But update engine moves to UPDATE_STATUS_REPORTING_ERROR_EVENT because
target channel isn't equal to downloading channel, so request to start
downloading of stable channel fails. Almost immediately update engine moves
to UPDATE_STATUS_IDLE, but user needs to reload chrome://help page to initiate
update check. Current changelist handles the issue and implements automatic
update checks when update engine is idle.

BUG=311162
TEST=unit_tests:VersionUpdaterCrosTest.*

Review URL: https://codereview.chromium.org/578293002

Cr-Commit-Position: refs/heads/master@{#296693}

Revert of Removed the ScriptedSpeech content side. (patchset #2 id:20001 of https://codereview.chromium.org/598923002/)

Reason for revert:
I'm sorry, the ENABLE_SPEECH_RECOGNITION switch is still used in the Chrome on
Android repo. I don't see (on the short term) another way of handling this than
not removing that switch. I'm going to revert this change.

Original issue's description:
> Removed the ScriptedSpeech content side.
>
> Removal the corresponding changes in blink are applied in the following patch
> https://codereview.chromium.org/599863002/
>
> BUG=402536
>
> Committed: https://crrev.com/6b8dda12a7d842517c5c4ee155cf48951e908a7f
> Cr-Commit-Position: refs/heads/master@{#296655}

TBR=avi@chromium.org,mohan.reddy@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=402536

Review URL: https://codereview.chromium.org/602083002

Cr-Commit-Position: refs/heads/master@{#296692}

Event::flags() contains all the buttons that are being held down during event,
while MouseEvent::changed_button_flags() contains the buttons that are
actually pressed/released during the press/release event (and this is what we
really are interested in).

This is a follow up to https://codereview.chromium.org/302593002/ which caused problems
during integration, and it seems to me it got just closed, so I am opening a new one.

Review URL: https://codereview.chromium.org/585393002

Cr-Commit-Position: refs/heads/master@{#296691}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/abe9e39c..3d349bd

TBR=ager@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/600393003

Cr-Commit-Position: refs/heads/master@{#296690}

Conditions:
* Track processing is enabled.
* Experimental constraint is set.
* Keyboard mic is supported (reported via effect).
* The ordinary layout is stereo.

This CL will be landed last of the keyboard mic support CLs.

BUG=345296

Review URL: https://codereview.chromium.org/598563002

Cr-Commit-Position: refs/heads/master@{#296689}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/604743002

Cr-Commit-Position: refs/heads/master@{#296688}

TBR=niklase@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/597283005

Cr-Commit-Position: refs/heads/master@{#296687}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/664fffa..abe9e39c

TBR=ager@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/600423002

Cr-Commit-Position: refs/heads/master@{#296686}

BUG=416863
R=sdefresne@chromium.org,cmasone@chromium.org

Review URL: https://codereview.chromium.org/594203002

Cr-Commit-Position: refs/heads/master@{#296685}

Move history_types.{cc,h} and android_history_types.{cc,h} to the
history component and create a new target history_core_android.

BUG=371816

Review URL: https://codereview.chromium.org/584013002

Cr-Commit-Position: refs/heads/master@{#296684}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ed8ea3d..664fffa

TBR=ager@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/604703003

Cr-Commit-Position: refs/heads/master@{#296683}

There is no behavioral change (just a refactoring).

BUG=326429
TEST=content_unittests --gtest_filter=ObfuscatedFileUtilTest.*

Review URL: https://codereview.chromium.org/602043002

Cr-Commit-Position: refs/heads/master@{#296682}

BUG=173779,257276
NOTRY=true
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/601143002

Cr-Commit-Position: refs/heads/master@{#296681}

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/604643003

Cr-Commit-Position: refs/heads/master@{#296680}

Script injection wasn't working in app_shell because the ScriptInjectionManager
never got created.

BUG=352293

Review URL: https://codereview.chromium.org/602563003

Cr-Commit-Position: refs/heads/master@{#296679}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/890537c..ed8ea3d

TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org

Review URL: https://codereview.chromium.org/600273003

Cr-Commit-Position: refs/heads/master@{#296678}

This leaves some room for YUV conversion rounding errors.

BUG=91208

Review URL: https://codereview.chromium.org/601083002

Cr-Commit-Position: refs/heads/master@{#296677}

Using  base::StringPairs in base folder
Becuase base/strings/string_split.h defines:
typedef std::vector<std::pair<std::string, std::string> > StringPairs;

BUG=412250

Review URL: https://codereview.chromium.org/598323002

Cr-Commit-Position: refs/heads/master@{#296676}

Cr-Commit-Position: refs/heads/master@{#296675}

BUG=402536

Review URL: https://codereview.chromium.org/590083002

Cr-Commit-Position: refs/heads/master@{#296674}

So no need to remember the correct header name for one for string resources and one for image resources.

BUG=416395
TBR=jochen@chromium.org for name fix under chrome

Review URL: https://codereview.chromium.org/601733002

Cr-Commit-Position: refs/heads/master@{#296673}

BUG=402536

Review URL: https://codereview.chromium.org/590113002

Cr-Commit-Position: refs/heads/master@{#296672}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6811fe1..890537c

TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org

Review URL: https://codereview.chromium.org/599303003

Cr-Commit-Position: refs/heads/master@{#296671}

Revert of Revert of Add test for ChromeVox keyboard commands. (patchset #1 id:1 of https://codereview.chromium.org/603823002/)

Reason for revert:
sorry I reverted this incorrectly, the problem was that the isolate needed a nacl file. I'm not sure why it only needed it on debug cros and not release. I landed it in https://codereview.chromium.org/597283004/

Original issue's description:
> Revert of Add test for ChromeVox keyboard commands. (patchset #21 id:390004 of https://codereview.chromium.org/490443002/)
>
> Reason for revert:
> flakes, see http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31850
>
> failures:
> TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxPrefixKey/0
> TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxPrefixKey/1
> TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/1
> TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/0
> LoggedInSpokenFeedbackTest.AddBookmark
>
> Original issue's description:
> > Add test for ChromeVox keyboard commands.
> >
> > This is just a couple of quick sanity checks to prevent future regressions
> > like the one in the linked bug. It tests both a Search+Shift shortcut and
> > the corresponding Prefix Key shortcut.
> >
> > Adds support for sending the meta modifier key in
> > aura/x11 tests.
> >
> > BUG=404470
> >
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291547
> >
> > Committed: https://chromium.googlesource.com/chromium/src/+/8cab2737f1cb6e6011b0946f6bef5027868602c0
> >
> > Committed: https://crrev.com/91703961c10dfa0f452999ed7cb87945ea817362
> > Cr-Commit-Position: refs/heads/master@{#293687}
> >
> > Committed: https://crrev.com/15ea141544fedaf306c94890b5be19b7c5df885a
> > Cr-Commit-Position: refs/heads/master@{#296074}
>
> TBR=dtseng@chromium.org,sky@chromium.org,dmazzoni@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=404470
>
> Committed: https://crrev.com/14e5bdf573d0621dfdd553888a5d3c557fb699a0
> Cr-Commit-Position: refs/heads/master@{#296627}

TBR=dtseng@chromium.org,sky@chromium.org,dmazzoni@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=404470

Review URL: https://codereview.chromium.org/600373002

Cr-Commit-Position: refs/heads/master@{#296670}

Add nacl_irt_x86_64.nexe to interactive_ui_tests' isolate to make LoggedInSpokenFeedbackTest.AddBookmark pass.

BUG=414808
TBR=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/597283004

Cr-Commit-Position: refs/heads/master@{#296669}

explicit casts.

I didn't check whether there were other, better fixes here by changing more
underlying types/behaviors; I assumed the existing code was correct and just
made the typecasts explicit.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/601593002

Cr-Commit-Position: refs/heads/master@{#296668}

BUG=331299

Review URL: https://codereview.chromium.org/595943002

Cr-Commit-Position: refs/heads/master@{#296667}

by inserting explicit casts; I didn't try to actually change any behavior).

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/590413006

Cr-Commit-Position: refs/heads/master@{#296666}

Per bug discussion, add Standard: Cpp11 to encourage ">>" over "> >".

TBR=thakis@chromium.org
BUG=417296

Review URL: https://codereview.chromium.org/599093008

Cr-Commit-Position: refs/heads/master@{#296665}

Revert of Enable extended debugging symbols to including  better tracking. (patchset #3 id:40001 of https://codereview.chromium.org/362183003/)

Reason for revert:
Breaks with

FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang -MMD -MF obj/third_party/libwebp/enc/libwebp_enc.config.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=216630 -DCOMPONENT_BUILD -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_LOAD_COMPLETION_HACKS=1 -DUSE_NSS=1 -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -D_GLIBCXX_DEBUG=1 -Igen -I../../third_party/libwebp -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-strict-aliasing -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/Linux_Builder__dbg_/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -B/b/build/slave/Linux_Builder__dbg_/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-format -Wno-unused-result -m64 -march=x86-64 -O0 -g -gdwarf-4 -fvar-tracking-assignments -fvar-tracking -funwind-tables -gsplit-dwarf -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare   -c ../../third_party/libwebp/enc/config.c -o obj/third_party/libwebp/enc/libwebp_enc.config.o
clang: error: unknown argument: '-fvar-tracking-assignments'
clang: error: unknown argument: '-fvar-tracking'

See http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/79150/steps/compile/logs/stdio for more info.

Original issue's description:
> Enable extended debugging symbols to including better tracking.
>
> Adding -fvar-tracking-assignments and -fvar-tracking to improve
> tracking of variables and assignments. While mostly useful when
> compiling with optimisations on (-O flags), it does help with clang
> (and later gccs) which are doing many optimisations all the time.
> (It does sometimes default to on when compiling with -O flags.)
>
> From http://gcc.gnu.org/onlinedocs/gcc/Debugging-Options.html
> > -fvar-tracking
> >  Run variable tracking pass. It computes where variables are stored
> >  at each position in code. Better debugging information is then
> >  generated (if the debugging information format supports this
> >  information).
> >
> >  It is enabled by default when compiling with optimization (-Os, -O,
> >  -O2, ...), debugging information (-g) and the debug info format
> >  supports it.
> >
> > -fvar-tracking-assignments
> >  Annotate assignments to user variables early in the compilation and
> >  attempt to carry the annotations over throughout the compilation
> >  all the way to the end, in an attempt to improve debug information
> >  while optimizing. Use of -gdwarf-4 is recommended along with it.
> >
> >  It can be enabled even if var-tracking is disabled, in which case
> >  annotations are created and maintained, but discarded at the end.
>
> Committed: https://crrev.com/9f7cb7480b85d868fb3420b960018d9137c9954a
> Cr-Commit-Position: refs/heads/master@{#296662}

TBR=thestig@chromium.org,thakis@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/602023002

Cr-Commit-Position: refs/heads/master@{#296664}

BUG=406236

Review URL: https://codereview.chromium.org/494413002

Cr-Commit-Position: refs/heads/master@{#296663}

Adding -fvar-tracking-assignments and -fvar-tracking to improve
tracking of variables and assignments. While mostly useful when
compiling with optimisations on (-O flags), it does help with clang
(and later gccs) which are doing many optimisations all the time.
(It does sometimes default to on when compiling with -O flags.)

From http://gcc.gnu.org/onlinedocs/gcc/Debugging-Options.html
> -fvar-tracking
>  Run variable tracking pass. It computes where variables are stored
>  at each position in code. Better debugging information is then
>  generated (if the debugging information format supports this
>  information).
>
>  It is enabled by default when compiling with optimization (-Os, -O,
>  -O2, ...), debugging information (-g) and the debug info format
>  supports it.
>
> -fvar-tracking-assignments
>  Annotate assignments to user variables early in the compilation and
>  attempt to carry the annotations over throughout the compilation
>  all the way to the end, in an attempt to improve debug information
>  while optimizing. Use of -gdwarf-4 is recommended along with it.
>
>  It can be enabled even if var-tracking is disabled, in which case
>  annotations are created and maintained, but discarded at the end.

Review URL: https://codereview.chromium.org/362183003

Cr-Commit-Position: refs/heads/master@{#296662}