- 05 Nov, 2013 40 commits
-
-
dgrogan@chromium.org authored
to win_rel flakiness. BUG=314272 TBR=dominikg@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/60573004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233064 0039d316-1c4b-4281-b951-d872f2087c98
-
vrk@chromium.org authored
> Refactor MediaStreamManager to never output real device id. It now always output sourceId in the form of a HMAC. > DeviceMessageFilter now don't need to create a source id. > This also fix a bug that made the source ids useless unless you have called gum once. > Note that the sourceIds are still just using the security origin as salt. Next step is to add a random number that is stored in the profile somehow. > > This cl also make sure all public APIs are asynchronous by making sure all requests are posted on the UI thread and handled later. Before this change - there were code paths that posted on the UI thread and others that did not that could potentially happen after a request was cancelled. This also make it easier to fail a request based on the input arguments. > > BUG=269139 > > Review URL: https://codereview.chromium.org/34393006 TBR=perkj@chromium.org Review URL: https://codereview.chromium.org/60753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233063 0039d316-1c4b-4281-b951-d872f2087c98
-
pneubeck@chromium.org authored
This allows to remove the dependency of UserCloudPolicyManagerFactory on Profile in the next step. BUG=271392 R=erg@chromium.org, joaodasilva@chromium.org Review URL: https://codereview.chromium.org/52343002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233062 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233060 0039d316-1c4b-4281-b951-d872f2087c98
-
mark@chromium.org authored
r1230 (mac sender) NSLocalizedString compatibility (10.8 SDK and clang trunk -Wformat-extra-args). r1229 (processor) map_serializers_unittest: fix unused variable warning. r1228 (linux symupload) Print response code when sym_upload fails. r1227 (processor) Add some symbols missing from last commit. r1226 (processor) Add simple exploitability analysis for Linux crashes. r1225 (common) Switch to scoped_array instead of inappropriate scoped_ptr. r1224 (linux handler) Increase exception handler stack size for dumping thread. r1223 (mac handler) Remove define of mach_vm_region from mach_vm_compatibility.h. BUG=314109 R=thakis@chromium.org Review URL: https://codereview.chromium.org/60293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233059 0039d316-1c4b-4281-b951-d872f2087c98
-
bulach@chromium.org authored
Use the one defined in constants.py instead. BUG= TEST=build/android/test_runner.py instrumentation --test-apk ChromiumTestShellTest --test_data chrome:chrome/test/data/android/device_files --verbose --host-driven-root=chrome/android -f testDisableAndEnableSync --python-only Review URL: https://codereview.chromium.org/59713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233057 0039d316-1c4b-4281-b951-d872f2087c98
-
pneubeck@chromium.org authored
DBusThreadManager's GetSystemBus returns NULL if Chrome built for ChromeOS runs on Linux or in tests. BUG=275286 Review URL: https://codereview.chromium.org/57333002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233056 0039d316-1c4b-4281-b951-d872f2087c98
-
hubbe@chromium.org authored
BUG=313046 Review URL: https://codereview.chromium.org/48733010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233055 0039d316-1c4b-4281-b951-d872f2087c98
-
bartfab@chromium.org authored
This CL adds a DeviceLocalAccountExternalDataService that provides each device-local account with a DeviceLocalAccountExternalDataManager which fetches, caches and retrieves external policy data. BUG=256635 TEST=New browser test R=derat@chromium.org, joaodasilva@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233048 Review URL: https://codereview.chromium.org/25242002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233054 0039d316-1c4b-4281-b951-d872f2087c98
-
asargent@chromium.org authored
This is for the case where the dialog might overflow and we have to say "... and N more ..." TBR=finnur BUG=315192 Review URL: https://codereview.chromium.org/59883003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233052 0039d316-1c4b-4281-b951-d872f2087c98
-
bartfab@chromium.org authored
The CL broke compilation on Chrome OS. > Support policies referencing external data for device-local accounts > > This CL adds a DeviceLocalAccountExternalDataService that provides each > device-local account with a DeviceLocalAccountExternalDataManager which > fetches, caches and retrieves external policy data. > > BUG=256635 > TEST=New browser test > R=derat@chromium.org, joaodasilva@chromium.org > > Review URL: https://codereview.chromium.org/25242002 TBR=bartfab@chromium.org Review URL: https://codereview.chromium.org/60683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233051 0039d316-1c4b-4281-b951-d872f2087c98
-
kiyun@chromium.org authored
r232181 changed build/common.gypi to set ARCHS=i386 explicitly for target_arch==ia32. However, we don't want to set ARCHS=i386 for iOS device builds (because iOS devices are a different architecture entirely). This CL arranges to leaved ARCHS untouched for iOS builds, so that Xcode will use its defaults; this was the behavior before r232181. The non-intuitive aspect is that target_arch==ia32 for OS=="ios", because host_arch is set to 'ia32' at line 88 of build/common.gypi for 'OS=="win" or OS=="mac" or OS=="ios"' and target_arch is set from host_arch at line 117. With build/common.gypi fixed, we also need to fix discardable_memory_provider_unittest.cc for iOS device builds, now that it is being compiled with the correct architecture. BUG=314712 Review URL: https://codereview.chromium.org/58373003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233050 0039d316-1c4b-4281-b951-d872f2087c98
-
nasko@chromium.org authored
BUG= R=creis@chromium.org Review URL: https://codereview.chromium.org/58343006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233049 0039d316-1c4b-4281-b951-d872f2087c98
-
bartfab@chromium.org authored
This CL adds a DeviceLocalAccountExternalDataService that provides each device-local account with a DeviceLocalAccountExternalDataManager which fetches, caches and retrieves external policy data. BUG=256635 TEST=New browser test R=derat@chromium.org, joaodasilva@chromium.org Review URL: https://codereview.chromium.org/25242002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233048 0039d316-1c4b-4281-b951-d872f2087c98
-
dongseong.hwang@intel.com authored
LayerTreeHost instances can exists in multiple threads. e.g. Aura with --single-process. So this CL makes the sequence thread-safe. In addition, this CL removes unused s_num_layer_tree_instances. Review URL: https://codereview.chromium.org/57713004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233047 0039d316-1c4b-4281-b951-d872f2087c98
-
rileya@chromium.org authored
It wasn't used anywhere outside of the unit tests. BUG=313827 TBR=danakj Review URL: https://codereview.chromium.org/56713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233046 0039d316-1c4b-4281-b951-d872f2087c98
-
ianet@chromium.org authored
Added prefixLength to the items in the result of a getNetworkList. This allows the broadcast address to be calculated. BUG=149057 Review URL: https://codereview.chromium.org/47443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233045 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233043 0039d316-1c4b-4281-b951-d872f2087c98
-
dgrogan@chromium.org authored
Caused compile failures http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29%2832%29/builds/13904/steps/compile/logs/stdio FAILED: g++ -MMD -MF obj/third_party/WebKit/Source/wtf/wtf.PartitionAlloc.o.d -DANGLE_DX11 -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DCOMPONENT_BUILD -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_NSS=1 -DUSE_X11=1 -DENABLE_ONE_CLICK_SIGNIN -DGTK_DISABLE_SINGLE_INCLUDES=1 -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DWTF_IMPLEMENTATION=1 -DENABLE_CUSTOM_SCHEME_HANDLER=0 -DENABLE_ENCRYPTED_MEDIA_V2=1 -DENABLE_SVG_FONTS=1 -DENABLE_GDI_FONTS_ON_WINDOWS=0 -DENABLE_HARFBUZZ_ON_WINDOWS=0 -DENABLE_TOUCH_ICON_LOADING=0 -DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DENABLE_CALENDAR_PICKER=1 -DENABLE_INPUT_SPEECH=1 -DENABLE_INPUT_MULTIPLE_FIELDS_UI=1 -DENABLE_LEGACY_NOTIFICATIONS=1 -DENABLE_MEDIA_CAPTURE=0 -DENABLE_NAVIGATOR_CONTENT_UTILS=1 -DENABLE_ORIENTATION_EVENTS=0 -DENABLE_WEB_AUDIO=1 -DWTF_USE_WEBAUDIO_FFMPEG=1 -DENABLE_OPENTYPE_VERTICAL=1 -DWTF_USE_DEFAULT_RENDER_THEME=1 -DU_USING_ICU_NAMESPACE=0 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -I../../third_party/WebKit/Source -I../../third_party/WebKit -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I/usr/include32 -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -m32 -mmmx -march=pentium4 -msse2 -mfpmath=sse -O0 -g -Wno-c++0x-compat -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -Wno-c++0x-compat -c ../../third_party/WebKit/Source/wtf/PartitionAlloc.cpp -o obj/third_party/WebKit/Source/wtf/wtf.PartitionAlloc.o ../../third_party/WebKit/Source/wtf/PartitionAlloc.cpp: In function 'void WTF::partitionDumpStats(const WTF::PartitionRoot&)': ../../third_party/WebKit/Source/wtf/PartitionAlloc.cpp:534:328:error: format '%ld' expects argument of type 'long int', but argument 2 has type 'size_t {aka unsigned int}' [-Werror=format] > Blink roll 161254:161319 > > http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=161255:161319&mode=html > TBR= > BUG= > > Review URL: https://codereview.chromium.org/59393004 TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/60553003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233042 0039d316-1c4b-4281-b951-d872f2087c98
-
jln@chromium.org authored
The Credentials class now has basic support for unprivileged namespaces. BUG=312380 R=jorgelo@chromium.org Review URL: https://codereview.chromium.org/54643010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233041 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233040 0039d316-1c4b-4281-b951-d872f2087c98
-
eseidel@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=161255:161319&mode=html TBR= BUG= Review URL: https://codereview.chromium.org/59393004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233039 0039d316-1c4b-4281-b951-d872f2087c98
-
zelidrag@chromium.org authored
BUG=314623 TEST=ExtensionApiTest.ChromeOSInfoPrivateTest Review URL: https://codereview.chromium.org/57133003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233038 0039d316-1c4b-4281-b951-d872f2087c98
-
hclam@chromium.org authored
There's a problem with the buildbot that it is running an older binary. This caused WebrtcCastApiTest.Basics to fail consistently because it's running on a newer test javascript file. Disable this test for now in the js file so the tree doesn't break. TBR=kalman@chromium.org BUG=314971 Review URL: https://codereview.chromium.org/60643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233037 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
The parser just needs to always output an array for the list of parameters. BUG=315147 R=davemoore@google.com Review URL: https://codereview.chromium.org/60203003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233036 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
By delaying actually moving the window, we stop flooding the message loop. This helps, but doesn't perfectly solve, the performance problems with message dragging. This patch adds a lot of TRACE_EVENT calls which were used to narrow down exactly what was going on. BUG=313903 R=ben@chromium.org, piman@chromium.org Review URL: https://codereview.chromium.org/56053005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233035 0039d316-1c4b-4281-b951-d872f2087c98
-
dalecurtis@chromium.org authored
More extraction of debug code from my local test build. This adds: - Trace events for easy logging of AudioOutputController actions. - A wedge detection UMA statistic for field monitoring. BUG=160920 TEST=UMA stat is reported correctly when wedged and not. Review URL: https://codereview.chromium.org/51003005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233034 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
BUG=none R=palmer@chromium.org Review URL: https://codereview.chromium.org/55893003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233033 0039d316-1c4b-4281-b951-d872f2087c98
-
DHNishi@gmail.com authored
Example Image: http://i.imgur.com/u6f6Ewh.png NOTRY=true BUG=239196 Review URL: https://codereview.chromium.org/53403004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233032 0039d316-1c4b-4281-b951-d872f2087c98
-
lipalani@chromium.org authored
BUG=314863 R=kjiwa@google.com, rlarocque@chromium.org Review URL: https://codereview.chromium.org/53153010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233031 0039d316-1c4b-4281-b951-d872f2087c98
-
jianli@chromium.org authored
The new services subdir contains all google services related codes, currently including sync, invalidation and signin. We will move those codes to this new unified directory in future patches. BUG=314886 TEST=none R=thakis@chromium.org, tim@chromium.org Review URL: https://codereview.chromium.org/48123003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233030 0039d316-1c4b-4281-b951-d872f2087c98
-
jln@chromium.org authored
(This is a re-land of https://chromiumcodereview.appspot.com/51113009/) BUG=312380, 312572 TBR=jorgelo@chromium.org Review URL: https://codereview.chromium.org/60513003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233027 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
Removed the wrench menu badge, remove this too. R=cpu@chromium.org TBR=sky BUG=313473 Review URL: https://codereview.chromium.org/58833002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233026 0039d316-1c4b-4281-b951-d872f2087c98
-
lambroslambrou@chromium.org authored
This fixes a crash seen when connecting to a host from the Android Chromoting client. The painting code got called before a video frame had been decoded, and tried to dereference a null Bitmap. NOTRY=true Review URL: https://codereview.chromium.org/47873012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233025 0039d316-1c4b-4281-b951-d872f2087c98
-
hclam@chromium.org authored
This test is failing only on Win7 and a DISABLED_ prefix couldn't disable it. Make sure this test is disabled for now. TBR=kalman@chromium.org BUG=314971 Review URL: https://codereview.chromium.org/59383007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233024 0039d316-1c4b-4281-b951-d872f2087c98
-
jianli@chromium.org authored
It is renamed because we're going to add new "services" directory which holds all google services related codes, like sync, invalidation and signin. We do not want to have both "service" and "services" to cause the confusion. Since all codes under "service" deal purely with service process, we would like to rename it to "service_process". BUG=none TEST=none due to that this is just a dir renaming R=thakis@chromium.org, vitalybuka@chromium.org Review URL: https://codereview.chromium.org/57383010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233023 0039d316-1c4b-4281-b951-d872f2087c98
-
kbr@chromium.org authored
(Likely) caused timeouts in webgl_conformance_tests on Win and Mac Debug GPU bots. See Issue 314375 for more details. > [Telemetry] Fix image_decoding_measurement timeout. > > util.WaitFor polls which is not appropriate for PerformActionAndWaitForNavigate. > > Since DispatchNotifications blocks in recv until it gets some data, there is no > need to poll at an interval. Instead, we should call recv again as soon as > possible after dispatching a notification. > > In the case of the image decoding measurement, it runs timeline recording. There > were so many timeline messages to receive that we were not always getting to the > important Page.navigate message before timing out. > > Example: > http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%281%29/builds/27098 > > BUG=314375 > > Review URL: https://codereview.chromium.org/47013004 TBR=tonyg@chromium.org Review URL: https://codereview.chromium.org/60233004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233021 0039d316-1c4b-4281-b951-d872f2087c98
-
kaznacheev@chromium.org authored
BUG=315079 Review URL: https://codereview.chromium.org/59993002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233016 0039d316-1c4b-4281-b951-d872f2087c98
-
xiyuan@chromium.org authored
NOTIFICATION_APP_TERMINATING could happen before closing app list bubble on shutdown and breaks the assumption that start page contents should out-live app list. BUG=314567 R=mukai@chromium.org Review URL: https://codereview.chromium.org/57943005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233015 0039d316-1c4b-4281-b951-d872f2087c98
-
teravest@chromium.org authored
This change is being reverted due to some problems seen in integration testing. See http://crbug.com/314884 for test failure details. > Pepper: Move FileIO host from renderer to browser. > > This change is large because it moves QuotaFileIO and PepperFileIOHost all at > once to the browser process. Some code in the refactored PepperFileIOHost is > moved from what's provided in FileAPIMessageFilter. > > Tested locally with Bastion, From Dust, and Angry Bots. > > TBR=jschuh > BUG=246396 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232440 > > Review URL: https://codereview.chromium.org/33053002 TBR=teravest@chromium.org BUG=246396,314884 Review URL: https://codereview.chromium.org/60323002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233014 0039d316-1c4b-4281-b951-d872f2087c98
-