- 25 Mar, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f11e33152460..988ce0490a11 git log f11e33152460..988ce0490a11 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 kjlubick@google.com remove localmatrix parameter from Blend and Lerp compose shaders 2020-03-25 csmartdalton@google.com Properly detect integer support on WebGL 2.0 2020-03-25 csmartdalton@google.com Bootstrap a very simple viewer implementation in CanvasKit 2020-03-25 csmartdalton@google.com Don't add offsets to nullptr in GrGLOpsRenderPass Created with: gclient setdep -r src/third_party/skia@988ce0490a11 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Ifc188c636f91ea3f2adad39fff76df14ccf8cebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120903Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753339}
-
Theresa Wellington authored
Add FLAG_ACTIVITY_NEW_TASK to intents used to launch new activities in TabModelMergintTest, and reenable #testMergeOnColdStartIntoChromeTabbedActivity2 on Pie. BUG=1036551 Change-Id: I995f1f4e5aeeb0c533e55fc9b8000e534613e9aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120748 Auto-Submit: Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#753338}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0eb6932a. With Chromium commits locally applied on WPT: bb6643e9 "Simplify image-loading-subpixel-clip.html." d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I31d07fd5ba99d9a0cb7a9714fccba99f778ec728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120793Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753337}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4504b6a42842..21a3f16268e9 git log 4504b6a42842..21a3f16268e9 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 treehugger-gerrit@google.com Merge "Include progname in malloc hook logs." 2020-03-25 treehugger-gerrit@google.com Merge "Acknowledge flushes / stop with unknown data sources." Created with: gclient setdep -r src/third_party/perfetto@21a3f16268e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie8afd80901cbd6ac93be83b7f4d27f6be2ee6ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120902Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753336}
-
Brian Cui authored
This small CL disables the elements-tab-stops test in order to land DevTools Settings discoverability improvements [1]. [1] adds a new Settings button to the top-level toolbar, which appears as a tab-stop in this test. [2] fixes the test so that the new tab stop is in the expectations file. [1] https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2049183 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2118870 Bug: 1050855 Change-Id: I6fd5386f84220f22d00e54255a7bdcfe8b4cb9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117328 Commit-Queue: Brian Cui <brcui@microsoft.com> Auto-Submit: Brian Cui <brcui@microsoft.com> Reviewed-by:
John Emau <John.Emau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#753335}
-
Kevin Ellis authored
Disabling the tests pending a more thorough investigation into the underlying causes. Bug: 1064065, 1064127, 1064463 Change-Id: I1748cd23f1509bbc8ea4b7b37a1cac27f8b74dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120745 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#753334}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/540bdf92531d..8cef397d7dec git log 540bdf92531d..8cef397d7dec --date=short --first-parent --format='%ad %ae %s' 2020-03-25 bclayton@google.com CMake: Don't export LLVM_INCLUDE_DIR to PARENT_SCOPE 2020-03-25 bclayton@google.com CMake: Move LLVM rules out to third_party/llvm-7.0 2020-03-25 bclayton@google.com Add missing copyright header to CMakeLists.txt Created with: gclient setdep -r src/third_party/swiftshader@8cef397d7dec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I3504ce618e05eaa4c9bc9904ae74001e18259b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120901Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753333}
-
Elly Fong-Jones authored
A common problem when writing integration tests for Views UI is that the involved UI is hidden behind an interface which hides the Widget, since it is usually an implementation detail. Specifically, it is common to have a function like so: static void MyDialog::Show(...); which internally creates a Widget, initializes it, shows it, etc, and invokes some callbacks or notifies some controller when the Widget is done. However, this makes it difficult for tests that expect to touch that UI to actually get ahold of it, which leads to various hacky approaches, like adding globals to track the last Widget created by MyDialog and similar. However, even this hack is considerably ugly when the UI is instead shown via something like: MyController::WaitUntilReadyAndThenShow(...); because the test can rarely tell when the UI is actually being displayed, which results in ad-hoc things like spinning the RunLoop a set number of times. To achieve that, this change: 1) Adds a class AnyWidgetObserver, which can be used to observe events that happen on any Widget instance without needing to specifically register for that Widget instance; 2) Adds a class AnyWidgetObserverSingleton, which is what the AnyWidgetObservers actually register as observers of; 3) Has Widget notify AnyWidgetObserverSingleton of various interesting events; 4) Adds some tests for AnyWidgetObserver. Bug: None Change-Id: I36c9b3c59bcae3bbe889731720e797339e5675d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110812Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#753332}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d34983e8718f..26abd91781d5 Created with: gclient setdep -r src-internal@26abd91781d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1063994 Tbr: jbudorick@google.com Change-Id: If6aa1eeae014894160f0793de7e3ce40d12880ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120900Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753331}
-
Chris Harrelson authored
Bug: 1043619 Change-Id: I8a9a1c5f1c7a51e83685aebc02a336ffab6a8011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116936Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#753330}
-
Michael Thiessen authored
Calls to GURL#ensureNativeInitializedForGURL are much more common than anticipated (~7% of startups according to UMA), but I'm unable to hit this during startup locally, so I'd like to collect stacks from Canary to see where users are hitting this. Bug: 783819 Change-Id: If9b3681c9b6c786be77c5f1e82c8a7c757fdecf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120916Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#753329}
-
Nektarios Paisios authored
The use of ComPtr::GetAddressOf is banned see http://crbug.com/914910 Either the "&" operator or the ReleaseAndGetAddressOf method should be used. Also, the "CopyTo" method could be replaced with the "As" method which is easier to type and call. R=aleventhal@chromium.org, kbabbitt@microsoft.com RelNotes: N/A Bug: 914910 Change-Id: I4fda494dfe9d51247bd7e82c9ec80b3e5ad5813f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120093 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#753328}
-
Victor Costan authored
This is a scaffolding CL for NativeIO, a.k.a. Low-Level Storage. Most details will probably change over time, but the overall architecture is intended to be stable. To facilitate review, this CL aims to introduce enough aspects of the API for readers to reason about IPC security and general architectural concerns in the browser and in Blink. The summary below is also intended to facilitate review. * NativeIO introduces new per-origin storage. The per-origin model matches other existing storage APIs, so no new permissions are added. * NativeIO storage is structured as files in a flat per-origin namespace. Files are stored in a per-origin directory under the user's profile. * The browser-side implementation enforces access control at the file level. Once a renderer is allowed to open a file, the browser passes the file descriptor to the renderer. This approach aims to minimize the latency of I/O operations. * The renderer exposes two API flavors to web pages -- an asynchronous version and a synchronous version. The latter is only available in dedicated workers. The goal is to allow developers to experiment with both flavors of the API, and report back on performance and stability. * In the asynchronous API, all file I/O is done on tasks posted to Blink's worker thread pool. This avoids jank on the main thread, at the cost of two thread hops per I/O operation. This CL adds two READMEs with some minimal information. * //third_party/blink/renderer/modules/native_io/README.md * //third_party/blink/web_tests/external/wpt/native-io/README.md An API explainer is available at https://github.com/fivedots/nativeio-explainer Binary-Size: New Web Platform feature. Fugu P1. Bug: 914488 Change-Id: I2c8c794837c5332d81bfbab2ed0827e1f26f7cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093918 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#753327}
-
Aaron Gable authored
This reverts commit c00c874f. Reason for revert: Caused compile failures on non-RBE Goma See o/51853436 for context. See https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-cronet/103497 for sample failure. Original change's description: > clang build.py: change LLVM_ENABLE_ZLIB from ON to FORCE_ON > > This uses the FORCE_ON option to enable zlib to ensure that clang > actually finds and uses zlib. Also moved this setting out of > base_cmake_args so that it is only used in the main clang build, > since there is another 32-bit build that can't use this zlib. > > Also changed to remove and re-download the zlib source on > every build. > > Change-Id: Ifceabc2ba06e4e4a56464f18de80610a0f043641 > Bug: 1061189 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118674 > Commit-Queue: Amy Huang <akhuang@google.com> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753301} TBR=thakis@chromium.org,hans@chromium.org,rnk@chromium.org,akhuang@google.com Change-Id: I9dad136109c540c0c700d67632573639b2596e5c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1061189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121078Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#753326}
-
Michael Thiessen authored
There were some formatting errors that caused information to be missed, and I've added some clarifying examples, details, and debugging tips. Change-Id: I7dc35b1fe6085339aedcbdae91ba1af635d5dc5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121037Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#753325}
-
Olga Gerchikov authored
Bug: 1058888 Change-Id: Id09b04349960c2b8a47fa30c5c2a67b8ad8b4cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119254Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Cr-Commit-Position: refs/heads/master@{#753324}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bdb8301ab9c1..4a1f482cf07e git log bdb8301ab9c1..4a1f482cf07e --date=short --first-parent --format='%ad %ae %s' 2020-03-25 khokhlov@google.com [tracing] Ignore renderers without mainThread when computing metrics Created with: gclient setdep -r src/third_party/catapult@4a1f482cf07e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1059726 Tbr: skyostil@google.com Change-Id: I84b7e48c5c5881f83e52736197d9b75672d913f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120897Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753323}
-
Sahel Sharify authored
This is a reland of 352154b4 Original change's description: > [Payments][Android] Move PayerData.java into components/payments/.. > > This cl moves PayerData.java class into components/payments so that > the WebPaymentIntentHelper.java class can use it without depending on > chrome/browser. It also introduces a new Address class and its > converter utility class so that PayerData.java does not depend on > mojom.PaymentAddress. > > Change-Id: Idb737bc2697212af7542d3abbd1488461a7d3074 > Bug: 1026667 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110678 > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752597} TBR=kenrb@chromium.org,rouslan@chromium.org Bug: 1026667 Change-Id: I2d7eb6016a51060ae10d6d9aed73eba841aea68c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120963Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#753322}
-
Omer Katz authored
This reverts commit 5dba9870. Reason for revert: quick resolution to regressions in issue 1063593 Original change's description: > heap: Trace Vector buffer up to capacity > > Tracing to capacity means we don't need to check size_ during > tracing anymore. > > Bug: 986235 > Change-Id: Idae046fcbb6a1705c1522d56479d560091415ea4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107983 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751353} TBR=haraken@chromium.org,mlippautz@chromium.org,omerkatz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 986235 Change-Id: Ib5b207d4f81966fae2f2522bd1c806071ff82c55 Tbr: haraken@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119519 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#753321}
-
Victor Costan authored
This CL switches the Bind[Service]WorkerReceiver[ForOrigin[AndFrameId]]() helpers to use pointers to methods on RenderProcessHostImpl methods, instead of RenderProcessHost. This makes it easy to add a new interface without having to plumb it into RenderProcessHost. This is a refactoring CL facilitating https://crrev.com/c/2093918. No behavior change is introduced. Bug: 914488 Change-Id: Ib80011dab7a8d11e32becd40cbf961ef128a228a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118698Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#753320}
-
Patrick Monette authored
Bug: 993029 Change-Id: Iae20fa0ede4421782fc5fbf2851d21c83cfbf4c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095452 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#753319}
-
Chris Harrelson authored
If the image is in cache, then the onload handler could happen synchronously before the script had a time to add the handler. The fix is to set the src after the onload handler has been registered. Change-Id: I8586119c5b36f033f36a594cd021230cb8a2bb8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119634Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#753318}
-
Nate Chapin authored
If the form gets reparented, it should retain its old origin document. Bug: 1063549 Test: fast/forms/reparent-form-during-planned-navigation-task.html Change-Id: Ia4d2fbadc57b217dbc43ed2db26f6b38573726ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118292 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#753317}
-
Ian Wells authored
Bug: 1044139 Change-Id: I0eac7262fec61f477a31a61da5b277b685a32909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088409 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#753316}
-
Samuel Huang authored
Previously, SuperSize still asserts that a given .apk file would have a non-empty .so files, even if --java-only fiag is provided. This causes error when running SuperSize on TrichromeWebView.apk. This CL fixes the issue by skipping the check if --java-only is provided. Change-Id: Iaa30b0c27668cd6fd7df8705209487a701f2b12c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120964Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#753315}
-
Koji Ishii authored
This logic in |SetCachedLayoutResult| is also done in |ShrinkLayoutResults|, which |SetCachedLayoutResult| calls right after it executed the logic. This patch removes it. This patch should have no behavior changes. Bug: 982194 Change-Id: Ic060fdb46084f4eac5fcc120e5a8060d166272c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119893Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#753314}
-
Francois Beaufort authored
This CL adds Finch support to the Web NFC blocklist. This will allow the team to add NFC devices to be blocked without a full release of Chrome. Bug: 1060559 Change-Id: Ib8c8ee232565bdf17b4b85df4aa3de50c6be24ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106575Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Leon Han <leon.han@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#753313}
-
Caleb Rouleau authored
R=tdresser@chromium.org Change-Id: Ie6066c5f146534d530b3c224d76727e15b6e9726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119757Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#753312}
-
Sami Kyostila authored
NOTRY=true TBR=wenbinzhang@google.com Bug: 1064658 Change-Id: I1684eba39eeedec644dfe412525736934da1d620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120719Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#753311}
-
Lukasz Anforowicz authored
Motivation for the changes in the CL: - "Allowlisting" in the old test suite name focused on only 1 out of 4 parameters that the test cases are parametrized with (kAllowlisted, kOutOfBlinkCors, kAllowlistForCors, kDeriveOriginFromUrl). - "CrossOriginReadBlocking" focused only on CORB, when the test cases have already been covering also CORS (e.g. when covering the CorbAllowlistAlsoAppliesToOorCors feature). Changes in the CL: - The CrossOriginReadBlockingExtensionAllowlistingTest test suite is renamed to CorbAndCorsExtensionBrowserTest. This test suite is parametrized (see TestParam enum). - The CrossOriginReadBlockingExtensionTest test suite is renamed to CorbAndCorsExtensionTestBase. Most methods of the test suite are moved to the parametrized test suite (i.e. to CorbAndCorsExtensionBrowserTest). InstallExtension method from the base and from the derived class is flattened. InstallApp method is moved/inlined into the WebViewContentScript test case. - The following tests are moved from the non-parametrized test suite to the parametrized one: - FromBackgroundPage_NoSniffXml - FromForegroundPage_NoSniffXml - FromServiceWorker_NoSniffXml (note https://crbug.com/1051594) - ProgrammaticContentScriptVsWebUI Only the WebViewContentScript test case remains to be non-parameterized. Bug: 1061567 Change-Id: Ifa9ab33de02de2b8900edbdd402d93f4edbcb5a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119150 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#753310}
-
Sami Kyostila authored
NOTRY=true TBR=wenbinzhang@google.com Bug: 1064650 Change-Id: Ie0cb4a4f936cb3fedd8b5a97247f6f387e1b93e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120502Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#753309}
-
Andrey Zaytsev authored
Bug: 1015841 Change-Id: Ib2283cc37b3b4b3b06ae2f24a20249d35ae33f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120475Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#753308}
-
kylechar authored
In SkiaOutputDeviceGL we are creating a GrBackendRenderTarget and saying we have created a stencil buffer for it. From what I can tell, we haven't actually created the stencil buffer anywhere. In theory this should have no memory impact since Skia just thinks there is a stencil buffer but doesn't allocate it. Skia should only allocate a small C++ object to track the stencil buffer memory it thinks was allocated. However, pinpoint found a statistically significant memory difference with this change on some stories. This CL fixes skia category memory tracing to be more accurate as well. Bug: 1055190 Change-Id: Ic9a195f3fd68b8c58a65863018307c1b2d7da8b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112148 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#753307}
-
Benoit Lize authored
The OOM function changed to OnNoMemoryInternal recently. This is usually called from OnNoMemory, which is NOINLINE and recognized by the crash servers, but not always. As a consequence, some crashes are no longer tagged as OOMs. Mark the new function NOINLINE. This will require tagging on the server-side as well. Bug: 1062949 Change-Id: Icd1f3004c6d820e3ac3429a10ae59989fc58b816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110023 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#753306}
-
Dominique Fauteux-Chapleau authored
Also migrate chrome/browser/enterprise_reporting/ to chrome/browser/enterprise/reporting/ to have a uniform directory structure for enterprise code directly under chrome/browser/ Bug: 1064353 Change-Id: I71521da35ac38ded054cb4c01a8c0b110e207770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117318Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#753305}
-
Jeff Yoon authored
Creating src-side changes for Chromium for chromium.mac's ios-device. - xcode_build_version set to 11c29 in *.star files. Added support for cache and property flexibility in lib/ci.star. - gn_args migrated to mb_config.pyl. Added mixins as needed to reflect changes. - additional_compile_targets set in waterfalls.pyl. no tests run for ios-device generated files: - cr-buildbucket.cfg - chromium.ci.json - chromium.mac.json Bug: 1055164,912681 Change-Id: Ie143b00f3fb51f793f5fd93049f74bb348b46fea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119751 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#753304}
-
Caleb Rouleau authored
I am leaving Google. R=pasko@chromium.org Change-Id: Icc282671103d5e968b47ba08f6e554837e5a6cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118228 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#753303}
-
Illia Klimov authored
Bug: 1063023 Change-Id: If677c7251e68c904faadbb56f7d251299efb939f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107628 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#753302}
-
Amy Huang authored
This uses the FORCE_ON option to enable zlib to ensure that clang actually finds and uses zlib. Also moved this setting out of base_cmake_args so that it is only used in the main clang build, since there is another 32-bit build that can't use this zlib. Also changed to remove and re-download the zlib source on every build. Change-Id: Ifceabc2ba06e4e4a56464f18de80610a0f043641 Bug: 1061189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118674 Commit-Queue: Amy Huang <akhuang@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#753301}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/218c5d61fbba..ae5e8fb6311c git log 218c5d61fbba..ae5e8fb6311c --date=short --first-parent --format='%ad %ae %s' 2020-03-25 aerotwist@chromium.org Adds support for e2e parallelization 2020-03-25 petermarshall@chromium.org [ui] Add a border to text input on Workspace settings tab 2020-03-25 mathias@chromium.org Enable no-case-declarations lint rule 2020-03-25 sigurds@chromium.org [issues] Generate COEP releated issues in the front-end Created with: gclient setdep -r src/third_party/devtools-frontend/src@ae5e8fb6311c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2bb299b9303d3f006bb7f9b51e8d62f8eecbd202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120898Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753300}
-