- 03 Aug, 2017 40 commits
-
-
Tommy C. Li authored
Since this feature is completely rolled out, beleatedly turn it on as the default on Chromium. Bug: 696790 Change-Id: Id4b93d7d0882fb51e32326553b699b1ccbaf7e79 Reviewed-on: https://chromium-review.googlesource.com/599114Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#491844}
-
Stephen Martinis authored
Disables the https://www.flickr.com/ story in the thread_times.simple_mobile_sites benchmark TBR=nednguyen@google.com Bug: chromium:#752228 Change-Id: I00f08c1c9b99c6896906801ebc5abfb16e25c209 Reviewed-on: https://chromium-review.googlesource.com/601004 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#491843}
-
Ben Chan authored
On Chrome OS, the settings UI supports enabling and disabling SIM locking on a cellular modem, and changing the SIM PIN. In the current implementation, all these actions eventually triggers NetworkingPrivateChromeOS::SetCellularSimState, which then calls the org.chromium.flimflam.Device.RequirePIN and org.chromium.flimflam.Device.ChangePIN DBus API exposed by shill. The "Change Pin" action is available after SIM locking is enabled. RequirePIN is called once when SIM locking is enabled. After that, ChangePIN should be used to change the PIN. However, NetworkingPrivateChromeOS::SetCellularSimState currently handles the "Change Pin" action by first calling RequirePIN first and then ChangePIN upon the success completion of RequirePIN. That results in two successive RequirePIN calls, and the second RequirePIN isn't necessary and often fails as the modem complains about SIM locking is already enabled. This CL changes NetworkingPrivateChromeOS::SetCellularSimState to simply call ChangePIN for the "Change Pin" action. BUG=b:63803092 BUG=chromium:751792 TEST=Manually tested the following with a few cellular modems: Under the expanded view of "Settings > Network > Mobile data": 1. Enable and disable SIM locking: a. Turn on "Enable SIM locking". A SIM PIN dialog is shown and asks for a previously set PIN. b. Enter a wrong PIN. The action fails. c. Enter the correct PIN. The action succeeds. d. Turn off "Enable SIM locking". e. Enter a wrong PIN. The action fails. f. Enter the correct PIN. The action succeeds. 2. Enable SIM locking, change the PIN, and disable SIM locking: a. Turn on "Enable SIM locking". A SIM PIN dialog is shown and asks for a previously set PIN. b. Enter the correct PIN. The action succeeds. c. Click "Change Pin". A SIM PIN dialog is shown and asks for the current PIN, the new PIN and the confirmation of the new PIN. d. Enter a wrong current PIN. The action fails. e. Enter the correct current PIN, but the confirmation of the new PIN not matching the new PIN. The action fails. f. Enter the correct current PIN, the new PIN and the confirmation of the new PIN that matches the new PIN. The action succeeds. g. Turn off "Enable SIM locking". h. Enter the old PIN. The action fails. i. Enter the new PIN. The action succeeds. 3. Enable SIM locking, reboot the system, and enter PIN to unlock the SIM: a. Turn on "Enable SIM locking". A SIM PIN dialog is shown and asks for a previously set PIN. b. Enter the correct PIN. The action succeeds. c. Reboot the system. d. A "SIM card is locked" message is shown under "Mobile data". e. Click "Unlock". A SIM PIN dialog is shown and asks for a PIN. f. Enter a wrong PIN. The action fails. g. Enter the correct PIN. The action succeeds. h. The cellular connection can be established after the SIM is unlocked. Change-Id: Ia095c4243ffd777fcfc822a1dcf2b32003257c78 Reviewed-on: https://chromium-review.googlesource.com/595327Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#491842}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ad701e38..16721dfd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I2e37bcf113a9e6a344700feb61ccfbfb7edc67e0 Reviewed-on: https://chromium-review.googlesource.com/600735Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#491841}
-
Vladislav Kaznacheev authored
The screenshot implementation copies the layer tree and inherits the transform from the root window. When user zoom is applied, this transform contains scaling which affects the screenshot size. Resetting this transform on the copied layer tree root ensures that the screenshot is taken in screen pixels. TBR=lhchavez@chromium.org Bug: 752217 Change-Id: I5278217d0dc0c663b274ac695078c3d3bfff28fd Reviewed-on: https://chromium-review.googlesource.com/600849 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#491840}
-
Yoland Yan authored
This CL allow test information that was once listed by parsing proguard dump or dexdump to be produced by JUnit runner run all the tests without executing them. The TestListInstrumentationRunListener is registered in the BaseChromiumAndroidJUnitRunner and will write all tests to a json file which then will be pulled to host side by host side runner script BUG: 640116 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Iea277ea8c7a1d07a2367b1e0a286ce77199935be Reviewed-on: https://chromium-review.googlesource.com/590694 Commit-Queue: Yoland Yan <yolandyan@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Michael Case <mikecase@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#491839}
-
kapishnikov authored
The change improves the performance of CRNHTTPProtocolHandlerProxyWithClientThread and simplifies the code. Profiling indicates that the new postBlockToClientThread method is about 37% faster than the removed postToClientThread method. Bug: 740139 Change-Id: Ib35e17f1c04318845bc1a1e4cb19aa0876023845 Reviewed-on: https://chromium-review.googlesource.com/600112 Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#491838}
-
Nasko Oskov authored
Bug: 477840, 746407 Change-Id: Id10d8f38903bf64c67d0a8ca8dc0f09142907355 Reviewed-on: https://chromium-review.googlesource.com/600949 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#491837}
-
Nasko Oskov authored
Bug: 708139 Change-Id: Idb9eb18755219be4164b6fc2585aa43ed9798dc1 Reviewed-on: https://chromium-review.googlesource.com/601027Reviewed-by:
-
Etienne Pierre-Doray authored
This CL adds ImageIndex, which stores annotation of an image file for quick access to raw data and embedded references. Note that some functionality from EncodedView from original implementation have been moved into ImageIndex. Bug: 729154 Change-Id: I1d5353fc8093543f2be0400361affa8b57333924 Reviewed-on: https://chromium-review.googlesource.com/589809 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#491835}
-
Leslie Watkins authored
Do not start a scan when the Default network changes unless both the Default network and the Tether network are disconnected. This is done to prevent a scan from starting when Ethernet and Tether are both connected, and then Ethernet is disconnected (but Tether remains connected). This CL also ensures a scan on login, regardless of whether or not the Default network is connected. Bug: 672263, 738542 Change-Id: I062fdc3dc825df6a6e986db80964fa92732774f7 Reviewed-on: https://chromium-review.googlesource.com/598940 Commit-Queue: Leslie Watkins <lesliewatkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#491834}
-
David Benjamin authored
net/cert including net/ssl would be a circular dependency, but these includes aren't actually used. Bug: none Change-Id: I47ee0f9e3ccdca07b6127ba653798aeae0084ffa Reviewed-on: https://chromium-review.googlesource.com/578498Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#491833}
-
Dave Schuyler authored
This CL removes some CSS overrides that were making paper-icon-button-light ripple sizes incorrect. So this fix is to remove the overrides. (relates to 746584) Bug: 746584 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I88e1bae2eed231e6dd5b6a6f0e78405e5e220a64 Reviewed-on: https://chromium-review.googlesource.com/599070Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#491832}
-
Will Chen authored
After landing a batch of migrated tests, one of the tests got marked as flaky and then got reverted: * crbug.com/751906 * https://chromium-review.googlesource.com/c/599828 Bug: 667560 Change-Id: Ie5a819ca59b428a7a009a6ff21b3b66768ba0cd4 Reviewed-on: https://chromium-review.googlesource.com/600829Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#491831}
-
Michael Lippautz authored
Bug: Change-Id: I23ad4603ce6dcc8934827e0cfbef0f8427afe5ad Reviewed-on: https://chromium-review.googlesource.com/600189 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#491830}
-
Ulan Degenbaev authored
The patch marks the following histograms as obsolete: - V8.GCIdleTimeAllottedInMS - V8.GCIdleTimeLimit.Overshot - V8.GCIdleTimeLimit.Undershot BUG=chromium:751045 Change-Id: I78205e419373f38cc76d45599163cb0d87eabf68 Reviewed-on: https://chromium-review.googlesource.com/594729 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#491829}
-
Zentaro Kavanagh authored
This is a reland of 24f0eb87 Fix: - Removed 2 incorrect asserts that were reading uninitialized memory in unit tests. Original change's description: > Add a functionally equivalent NTLMv1 implementation. > > - Replacement NTLMv1 implementation. > - In preparation for new NTLMv2 implementation. > - Passes all unit tests and has the same behavior. > - Adds fuzzer for NtlmClient. > - Code is still not live. > > BUG=chromium:22532 > TEST=All unit tests pass. > > Change-Id: Idae533312805d21d49943fd634d54af3a93a7c00 > Reviewed-on: https://chromium-review.googlesource.com/598307 > Commit-Queue: Zentaro Kavanagh <zentaro@google.com> > Reviewed-by: Asanka Herath <asanka@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491611} Bug: chromium:22532 Change-Id: I425914904d13d94214d4249ff75648775bf1c84c Reviewed-on: https://chromium-review.googlesource.com/600388Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@google.com> Cr-Commit-Position: refs/heads/master@{#491828}
-
Xida Chen authored
In our current implementation, we have a Canvas2DImageBufferSurface that inherits from ImageBufferSurface. The Canvas2DImageBufferSurface keeps a RefPtr to Canvas2DLayerBridge, and pretty much all the functions in Canvas2DImageBufferSurface directly calls the functions in Canvas2DLayerBridge. The reason for this design is that Canvas2DLayerBridge is a RefCounted class, so that the MailboxInfo could keep a pointer to Canvas2DLayerBridge. This CL does a refactor in a way that makes Canvas2DLayerBridge directly inherits from ImageBufferSurface. Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iceaff82d7561f1d064a0e2cc546f47098dd8e110 Reviewed-on: https://chromium-review.googlesource.com/576994Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#491827}
-
Sunny Sachanandani authored
This CL removes totally dead code. R=jbauman BUG=NONE Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id43675523896342b3a701655c81c1819edab4c8e Reviewed-on: https://chromium-review.googlesource.com/598437Reviewed-by:
John Bauman <jbauman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#491826}
-
Scott Graham authored
Notably includes https://fuchsia.googlesource.com/magenta/+/396b28ef2039e962c19f9d972d72ed56aa665d5b which makes the POSIX-y impl of PartitionAlloc work on Fuchsia, so enable those tests. TBR=wez@chromium.org Bug: 706592, 707030 Change-Id: I81969597e87969c755afb6e538bccf5ab1cf1eb9 Reviewed-on: https://chromium-review.googlesource.com/600987Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#491825}
-
Matt Menke authored
The main cache used to be configured in ProfileImpl and ProfileImplIOData (And OTRProfileIOData). This CL moves it over to ProfileNetworkContextService and NetworkContext, for both OTR and non-OTR profiles, and move the code to disable caching for the system URLRequestContext from IOThread to SystemNetworkContextManager. Bug: 715695 Change-Id: I479068778088a292dae29371f92e6a8958aa3c9d Reviewed-on: https://chromium-review.googlesource.com/587612Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#491824}
-
Bence Béky authored
This CL lands server change 163977115 by diannahu. BUG=488484 Change-Id: Iea6fd4a982db4cb3dbaf8e004a0e70e865f23550 Reviewed-on: https://chromium-review.googlesource.com/600247 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
-
Achuith Bhandarkar authored
* browser_type may not be specified in blink_perf.py * WebKit/PerformanceTests/TestData, and WebKit/PerformanceTests/SVG are necessary. * Get rid of bogus svn links. BUG=chromium:664196,chromium:651219,chromium:749868 TEST=manual Change-Id: Idd5fbbb32e01f88a21f37e8e55a288f86a776f89 Reviewed-on: https://chromium-review.googlesource.com/599018Reviewed-by:
-
Duc Bui authored
Since we want to record UMA for session-restored tabs only when they are initially foreground, we need to track restored-in-foreground tabs. This CL adds tracking of tabs which are created by session restore and initially in foreground. IsTabRestoredInForeground() API added by this CL will be used in SessionRestorePageLoadMetricsObserver to measure FP, FCP and FMP for foreground tabs during session restore (http://crrev.com/2930013005/). started_in_foreground in PageLoadMetricsObserver::OnStart() cannot be used to determine whether a tab is initially foreground after it is created by session restore or not. For example, when browser-side navigation is disabled and a restored tab is created in background, switching to it before it loads will yield started_in_foreground as true. Bug: 731901 Change-Id: I58c6c0330bf6121e78d9d9b9cad72729faeb8885 Reviewed-on: https://chromium-review.googlesource.com/599507Reviewed-by:
Zhen Wang <zhenw@chromium.org> Reviewed-by:
Fadi Meawad <fmeawad@chromium.org> Commit-Queue: Duc Bui <ducbui@google.com> Cr-Commit-Position: refs/heads/master@{#491821}
-
Luna Lu authored
WebUIWebViewBrowserTest.AddContentScriptIncognito WebUIWebViewBrowserTest.AddMultiContentScripts WebUIWebViewBrowserTest.AddContentScript https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests Change-Id: I6913b1bfcc5f666826ace9538142e5ef29bc6301 Bug: 751907 TBR: hanxi Change-Id: I6913b1bfcc5f666826ace9538142e5ef29bc6301 Reviewed-on: https://chromium-review.googlesource.com/600633 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#491820}
-
Dmitry Gozman authored
BUG=734762,745345 Change-Id: Ia9fa22f8259eb50281e1fd9087162e3c087df052 Reviewed-on: https://chromium-review.googlesource.com/597007Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491819}
-
Ned Nguyen authored
This benchmark has been disabled for a long time without anyone reviving it. It also has some design problem make it hard to maintain, so we better remove it & design it from scratch when the time come for this benchmark to be a priority. This CL also removes chrome_signin_archive_000.wpr.sha1 (legacy WPR archives format) Bug: 551938, 713327, 730036 Change-Id: I64abd43757a8111e2c7a25a3104b0b1a121b42f0 Reviewed-on: https://chromium-review.googlesource.com/600767 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#491818}
-
Nasko Oskov authored
Bug: 662160 Change-Id: If252b4f8765eb70218f6c89d8794c05566700fbe Reviewed-on: https://chromium-review.googlesource.com/600768Reviewed-by:
-
Eric Holk authored
Bug: v8:6514 Change-Id: Idcd54185eecc4d4b15756ab4e1633e1e6e7b2427 Reviewed-on: https://chromium-review.googlesource.com/599031Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#491816}
-
Karl Schimpf authored
Collect compile time separately form asm.js and Wasm functions. Depends on CL https://chromium-review.googlesource.com/c/598930 Bug: chrome:709684 Change-Id: Ic0ccb42445c8f98ce7175da5ac44d6f958114558 Reviewed-on: https://chromium-review.googlesource.com/598542Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
-
Sergey Ulanov authored
CancelableSyncSocket unittests were not testing all cases properly. There was only one test for Shutdown() that only verified that it works properly with ReceiveWithTimeout(). Receive() wasn't tested with Shutdown(). Bug: 741783 Change-Id: I722d328e8904d2b48c3b86a0b5ce15d3661c9b13 Reviewed-on: https://chromium-review.googlesource.com/598648 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#491814}
-
Qiang Xu authored
changes: (1) no hover state highlight (2) update search result tile selection highlight (3) update search result simple row selection highlight (4) another opened search box background color change: when search box is opened (state is STATE_SEARCH_RESULTS), the background color should be #FAFAFC 100%. specs: https://screenshot.googleplex.com/thXHXNn3Vmt screenshot: https://screenshot.googleplex.com/UXtpfwpqHJY Test: test with and without fullscreen app list flag Bug: 750690 Change-Id: I090462bf36305393a55fcc1083c1c48fb5ae7a5a Reviewed-on: https://chromium-review.googlesource.com/600729 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by:
-
Scott Graham authored
TBR=wez@chromium.org Bug: 752220, 738275 Change-Id: I839aca92ea3d4421139ce0b2113983bce780dd16 Reviewed-on: https://chromium-review.googlesource.com/600493Reviewed-by:
-
Luna Lu authored
This reverts commit 260cd28a. Reason for revert: suspect causing the failure on https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/62043 Original change's description: > Update the DEPS to use the most recent libaddressinput version. > > Bug: 752122 > Change-Id: I90870a875855161b49e03bd1b4e7870f76dec694 > Reviewed-on: https://chromium-review.googlesource.com/600289 > Reviewed-by: Mathieu Perreault <mathp@chromium.org> > Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491754} TBR=mathp@chromium.org,sebsg@chromium.org Change-Id: I642f76aa363a09951b64788615908ae4e618584e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 752122 Reviewed-on: https://chromium-review.googlesource.com/600635Reviewed-by:
-
chrome://net-exportchrome://aboutPierre Neter authored
Signed-off-by:
Pierre Neter <pierreneter@gmail.com> Bug: 751391 Change-Id: I6b2d4d1102f2424cff411147637bae6c31c1acd0 Reviewed-on: https://chromium-review.googlesource.com/596988 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491810}
-
sebsg authored
Change-Id: I2672c0ed867ed66a446b6483f4f54e81f4029d5d Reviewed-on: https://chromium-review.googlesource.com/587304 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Anthony Vallee-Dubois <anthonyvd@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#491809}
-
Xiaocheng Hu authored
This patch adds the interactive rebaseline functionality to test-expectations.html, so that after checking the test results, a selective rebaselining can be easier: 1. Click the "Select" button next to "Select tests to rebaseline" 2. A checkbox appears by each shown test 3. Check the checkboxes which needs rebaseline 4. Click the "Done" button 5. A dialog with some rebaseline script appears, with the script already copied to clipboard. Run the script [1] locally in your terminal in LayoutTests/ (or platform/xxx/, flag-specific/xxx/ if the tests are platform/flag dependent) to download the new expectation files to create a rebaseline patch. The initial purpose of this patch is to help the the development of TextIteratorNG [2], which creates a lot of unexpected failures. Some of them are due to resolution of existing bugs (and hence, these tests should be rebaselined), but others are due to new bugs (so these tests shouldn't be rebaselined). This patch makes the selective rebaseline much easier. [1] The script is currently Linux-only [2] https://chromium-review.googlesource.com/c/580371 Bug: Change-Id: If869509f27f8d32e938f9778f636513045845a01 Reviewed-on: https://chromium-review.googlesource.com/597388 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#491808}
-
Steven Bennetts authored
Bug: 750741 Change-Id: I2e9d55b9e08901d9ac80bd91634936c99831b5b7 Reviewed-on: https://chromium-review.googlesource.com/594640 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#491807}
-
Francois Doray authored
The ScopedAsyncTaskScheduler in chrome_component_updater_configurator_unittest.cc was useless. This CL simply removes it. Bug: 708584 Change-Id: Ia1cb9bfb343ddc5810421dc655227128c3a40979 Reviewed-on: https://chromium-review.googlesource.com/591949 Commit-Queue: Francois Doray <fdoray@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#491806}
-
Nasko Oskov authored
This test passes with iteration count of 100 locally. It should not be flaky, but let's try and see. Bug: 660288 Change-Id: I8f190be7f6b6639e048ea59f040ca0421c3b51bd Reviewed-on: https://chromium-review.googlesource.com/600492Reviewed-by:
-
