- 20 Mar, 2019 40 commits
-
-
Chris Hall authored
R=aboxhall,dmazzoni BUG=889370 Change-Id: I423a97dccb1de48deaec862e66dfa3add7ec8341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519969 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#642387}
-
Alexandre Courbot authored
Creating a VideoFrame instance from a V4L2 buffer reference is a common operation. The best place to do this is in the buffer reference itself, since it can export the required DMABUFs itself, has a reference to its own device, knows about its own layout, and can cache and reuse the VideoFrame instance instead of creating a new one for each request. This CL adds (and uses) such a method. Although it only works for MMAP buffers, it will probably be extended in the future to other kinds of buffers when they support queueing a VideoFrame directly. Bug: 792790 Test: VDA unittest passed in regular and import mode on Hana. Test: VEA unittest passed on Peach_pit. Change-Id: If387d8f11f8a5c72d7fc26907f5c9bea4835d8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517503 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#642386}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c75272708a80..d537949d45f3 git log c75272708a80..d537949d45f3 --date=short --no-merges --format='%ad %ae %s' 2019-03-20 dhanyaganesh@chromium.org chromeos_config: Change the sanitizer builds to be full builds 2019-03-20 tcwang@google.com chromite: Update HWTests in toolchain builders. Created with: gclient setdep -r src/third_party/chromite@d537949d45f3 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I090a7d922eb687129b3e7c71b407c6d85a19bbb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531763Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642385}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I0c9842f44a344337f6b71a579f1f0b9d4d45009e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529490Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#642384}
-
Devlin Cronin authored
The preferencesPrivate API is no longer used. Remove it. Bug: 593166 Change-Id: I5d56c3c79d0423b6534a7298f3d5103a09bc6707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529119Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#642383}
-
Hwanseung Lee authored
Get rid of NetworkHintsInterface and replace it with WebPrescientNetworking. Mock classes which subclass NetworkHintsInterface for tests also changed to subclass of WebPrescientNetworking. Bug: 939636 Change-Id: I12aa8a2769262490377d20ea89a1ab0bfbd68a88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513796 Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#642382}
-
Hayato Ito authored
- Tracking bug: https://crbug.com/906494 - Explainer (WIP): http://goo.gl/UjCQnz No web-facing behavior change. To performance sheriffs, I expect that this CL brings the performance improvements on perf tests, such as blink_perf/shadow_dom. Please assign me to a bug if you observe any performance improvements or regressions other than that. Bug: 906494 Change-Id: I6a473b7938a1aa71ac36a7dc776f34684b066861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1360197Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#642381}
-
Kunihiko Sakamoto authored
This reverts commit b495cf02. Reason for revert: Broke win-google-rel build (crbug.com/943912) Original change's description: > Navi: Add check for Local NTP flag before testing experiment variations > > Bug: 938093 > Change-Id: Ib09b75a213d46536caf180bacb6eaf480372af2c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529386 > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: John Lee <johntlee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642230} TBR=sky@chromium.org,hcarmona@chromium.org,johntlee@chromium.org Change-Id: I886cfcebc0e1a4be203d5bed6f5feacd83ec683b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 938093,943912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530365Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#642380}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7b49eeb4960b..2894d13a0d9b git log 7b49eeb4960b..2894d13a0d9b --date=short --no-merges --format='%ad %ae %s' 2019-03-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 2dc0303903b1..f2564656e7af (3 commits) 2019-03-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-19 halcanary@google.com Documentation: notes on example fiddles 2019-03-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 9b050f846a06..df35e382de78 (2 commits) 2019-03-19 bsalomon@google.com Reland "Add small offset to t in GrLinearGradientLayout." Created with: gclient setdep -r src/third_party/skia@2894d13a0d9b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:938592 TBR=brianosman@chromium.org Change-Id: Ia6f66c7ccc4d33a1ed9ab98c81deeaf201e85ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531760Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3580425baa28..8e85c22df678 git log 3580425baa28..8e85c22df678 --date=short --no-merges --format='%ad %ae %s' 2019-03-20 vadimsh@chromium.org [lucicfg] Bump lucicfg version 1.5.4 -> v1.5.6. Created with: gclient setdep -r src/third_party/depot_tools@8e85c22df678 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If1b578fab3dd6762c8805eb2f598688511509d24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531761Reviewed-by:
-
Regan Hsu authored
Currently, the input enable does not update correctly when words are added or removed from the user's spell check dictionary. This CL ensures that the input enable is updated correctly. Bug: 914738 Change-Id: I743a0dd50a33af030d0e11bbd68938c02dc9256a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529709Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#642377}
-
Peter Kasting authored
* Use constexpr * Change override comments to match more common style * Call superclass methods (more technically correct) * In OnWidgetActivationChanged(), call superclass method before doing override code instead of after; this makes it harder to omit calling the superclass via early return * Use CloseWithReason(), as BubbleDialogDelegateView does * Shorten code by using conditional instead of switch, and not handling DCHECK failure Bug: none Change-Id: Iffe3a4f229924fad13fd9b08e431a31308821fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531652 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#642376}
-
Eliot Courtney authored
Bug: 942991 Test: unit test Change-Id: Id1956d3fe239c0740770274a95ba9119f6fe2bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529500Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#642375}
-
rajendrant authored
Bug: 932634 Change-Id: Icb5009f436181c1686885dbbfea724dc8a67b77a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522926Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#642374}
-
Rachel Wong authored
Existing tests are also updated to reflect the new description requests. Bug: 916420 Change-Id: I5be994335ec54f78c0faea86e6930eee2ca4c411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505742Reviewed-by:
Michael Martis <martis@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#642373}
-
David Bertoni authored
Previously, incrementing inflight events for service workers only worked on the UI thread code path. This CL makes it work on the IO thread code path as well. Change-Id: I488ebf980f951bf384f727e73f58f408ecff3e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522548 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This is a part of moving manifest implementation to blink. content::ManifestUmaUtil would be removed after completing to move the manifest implementation from content to blink. Bug: 704441 Change-Id: I5ae55cc02c01c3b3f30268bb0da8dadc83b84f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524818Reviewed-by:
-
Meilin Wang authored
Tests failed because assistant was disallowed by account type for the following reasons: - Autotest with real gaia login: Caused by a race between chromeos login finished and account info fetch finished. - Tast with fake gaia login: Account info fetch not be faked under fake gaia env. This changes fixes these issues by first retry to initiate assistant when account info updated, and also bypass the account type check in assistant::IsAssistantAllowedForProfile under fake gaia env. Misc: Add IsGaiaServicesDisabled helper function in chromeos_swithes. Bug: 942781, 939146, 940618 Test: local compile and run autotest/tast tests on DUT. Change-Id: I25bdcda9587988426745c2dd036da1b8be6f636a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530119 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#642370}
-
Rakina Zata Amni authored
There are multiple ways to make <select> not use the menulist, including adding the multiple attribute or using the size attribute. Bug: 943195 Change-Id: Ie1b31a977321c1ae7f6e00fbe93337c214594a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530323 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
-
Robert Liao authored
This is a run of run-clang-tidy.py -checks="-*,google-explicit-constructor" -header-filter=ui/views/* \\src\\ui\\views\\ BUG=940732 TBR=sky@chromium.org Change-Id: I6690fe5a5f4db5fb43711912ca370952d99e16f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531728Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#642368}
-
Rakina Zata Amni authored
When scrollIntoView was called on an element in locked subtree, we will send the beforeactivate event and commit the locked ancestors. Bug: 882663 Change-Id: I503bb6dc6c0cce9e5df53f52b432060a04680dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528131 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#642367}
-
Kunihiko Sakamoto authored
TBR=wangxianzhu@chromium.org Bug: 943907 No-Try: True Change-Id: I603abad7d311f62431cfec20a3bb84ea7527d8fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531218Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/924b8b1c0a7f..0861b5e50a7f Created with: gclient setdep -r src-internal@0861b5e50a7f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ksakamoto@chromium.org,mmentovai@chromium.org,carlosk@chromium.org,hendrich@chromium.org Change-Id: Iea94f046117b20d0919074df334caeafd4f4fc29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531351Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642365}
-
Vlad Tsyrklevich authored
Previously cfi-icall was disabled because I mistakenly thought is_cfi=true would enable cfi-icall. Enable it explicitly. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_cfi_rel_ng Bug: 942060 Change-Id: I0949e0f547f5ea17c54bb2fb4c99e269daf0f67f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529360Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#642364}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c2074b14014e..6ce1be5a5a53 git log c2074b14014e..6ce1be5a5a53 --date=short --no-merges --format='%ad %ae %s' 2019-03-19 ynovikov@chromium.org Vulkan: move platform defines to Vulkan Headers build file. Created with: gclient setdep -r src/third_party/angle@6ce1be5a5a53 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I3fe60d1f035486bf1d989bb48891837ba40a3f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531350Reviewed-by:
-
Ethan Jimenez authored
1. Adding a method in `AXPlatformNodeDelegate` to provide a localized string for the Landmark Type property of an element. A cross-platform browser test to validate such method is created. 2. Introducing support in `AXPlatformNodeWin::GetPropertyValue` for UIA Landmark Type and Localized Landmark Type properties. 3. Adding unit tests for both properties in `AXPlatformNodeWinTest`. 4. Updating role mapping for Windows and Linux platforms to be more consistent with the CORE-AMM specification. See: https://www.w3.org/TR/html-aam-1.0/#html-element-role-mappings https://www.w3.org/TR/core-aam-1.2/#mapping_role_table Bug: 844149 Change-Id: I7a2f47ff6b7b127907b8bfff63ae84852e153f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509907 Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#642362}
-
Rakina Zata Amni authored
This CL adds a new function, NearestLockedInclusiveAncestor, to DisplayLockUtilties, so that it can be reused in multiple places (example: https://chromium-review.googlesource.com/c/chromium/src/+/1528123/2/third_party/blink/renderer/core/inspector/inspector_highlight.cc#291) Bug: 882663 Change-Id: Ia7408f10635f7304cebee483c14773c626d6bec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528126Reviewed-by:
-
Hajime Hoshi authored
This CL switches task runners at several places from per-thread to per-frame. The purpose of this change is to make it possible to freeze tasks for bfcache. We found an actual case that JavaScript is executed: browser_tests --gtest_filter=WebViewScrollGuestContentBrowserPluginSpecificTest.OverscrollControllerSeesConsumedScrollsInGuest Bug: 870606 Change-Id: I34d1cb8b94955798a896e741b76135dec6f8c031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530314Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#642360}
-
Hajime Hoshi authored
This CL switches task runners at several places from per-thread to per-frame. The purpose of this change is to make it possible to freeze tasks for bfcache. We found an actual case that JavaScript is executed: browser_tests --gtest_filter=PrintBrowserTest.SelectionContainsIframe Bug: 870606 Change-Id: If7027d9a104513408f2d14507f6938308273bd7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529501Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#642359}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f7104562e5e4..e065d4ecc451 git log f7104562e5e4..e065d4ecc451 --date=short --no-merges --format='%ad %ae %s' 2019-03-19 eugenis@google.com Annotate UnsafeMemcpy for HWASan. Created with: gclient setdep -r src/third_party/perfetto@e065d4ecc451 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:112438058 TBR=perfetto-bugs@google.com Change-Id: I86803e1238d34fb4d555c30d33dc16f7aee52bee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531349Reviewed-by:
-
Sam McNally authored
Currently, all DriveFS change notifications are forwarded to the UI. Some parts do their own checks for matching the expected directory, but others do not; one part that does not is DirectoryTree, which triggers a rescan of any changed directories. Filter to just directories with a registered watcher like the old Drive client does. Bug: 943886 Change-Id: If106ef054e5bfbdd16697e41d74b176996c6750f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529896Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#642357}
-
Robert Liao authored
This is a run of run-clang-tidy.py -checks="-*,google-readability-casting" -header-filter=ui/views/* \\src\\ui\\views\\ BUG=940732 TBR=sadrul@chromium.org Change-Id: I94071fabfa471259ae70acae3ef692f6f588ceef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531712Reviewed-by:
-
Staphany Park authored
Change-Id: Ic1fbc244161497ef64acea02eca5bd795ba693db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529585 Auto-Submit: Staphany Park <staphany@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#642355}
-
Peter Kasting authored
MaterialDesignController requires COM to be initialized. Without this, various views_unittests tests fail when run individually. (This probably means there's a second bug somewhere where something is holding COM initialized that shouldn't be, or the tests would have failed all the time.) It looks like initializing at the test suite level is roughly where other places are doing this (e.g. ContentTestSuite), so hopefully this is the right place. Bug: none Change-Id: I5e6de4d45c6118b6a2bc69ba960904fa0fd8087d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531422 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#642354}
-
Peter Kasting authored
BubbleDialogDelegateView observes multiple widgets. It's possible for the anchor widget to be activated after the bubble widget has been created but before it's visible (e.g. for ExtensionPopup). Ensure we're actually observing the right widget. Bug: none Change-Id: If266fb3ed900f1bd345296f1fb1d37ff1c0eee0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531720 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#642353}
-
Dmitry Gozman authored
This frame type is only used for navigations, so we should plumb it using WebNavigationInfo instead of WebURLRequest. This patch removes SetFrameType, but not GetFrameType and field, which will be done in a follow up. This corresponds to the step 6.h from the doc linked to the bug. Bug: 855189 Change-Id: I8eec45b95884bf8738d35adf3be021e566bc478c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512940 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#642352}
-
Josh Nohle authored
Note: The C++ style guide states, "Type conversion operators, and constructors that are callable with a single argument, must be marked explicit in the class definition." Bug: 899080 Change-Id: I013f807d451fd540190dbd8f06b1977a83b6b013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521280 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#642351}
-
Kunihiko Sakamoto authored
This is a partial revert of https://crrev.com/c/1526781. Adding back some expectations for tests that still fail on bots. TBR=atotic@chromium.org Bug: 726520 Change-Id: I2c04afe59e72a6dfb700ba41685ce10c6e26d787 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530360Reviewed-by:
-
Lan Wei authored
In order to remove the timer to send the fake mouse move event, we decide the best place to send the fake mouse move event is at the next begin frame right after we have seen a gesture scroll end event. This CL is working on scrolls happening on main thread. Bug: 877132 Change-Id: I4e92650943c4d0a5c9ce290e8100e8e2b52d3385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517168 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#642349}
-
Jay Harris authored
This is a security UX improvement for RTL domains. Before this change http://مثال.com/ would be displayed as com.مثال instead of مثال.com Bug: 943362, 943366 Change-Id: I967216bb402b12dc437e05274ff8ea63e1544f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529975 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
-
