- 24 May, 2018 37 commits
-
-
Mitsuru Oshima authored
This is a regression in http://crrev.com/c/1053116. The target widget is used in DetachedTitleAreaRenderer and WideFrameView. BUG=b/33693796 TEST=covered by unittest Change-Id: I839d13113a40abde4d25d7e634ad549937dac30b Reviewed-on: https://chromium-review.googlesource.com/1067319 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#561355}
-
Xiaohan Wang authored
DecryptingAudioDecoder was added to support decrypt-and-decode of audio buffers by a CDM using the Decryptor interface. Since then CDMs have evolved and today there's no CDM supporting this path in production. Though in browser tests, this paths is still used where the Clear Key CDM can decrypt-and-decode audio. This CL changes DefaultDecoderFactory such that by default DecryptingAudioDecoder will not be created except when External Clear Key is enabled, which typically is only set in browser tests. This will save an IPC round trip during initialization when playing media with encrypted audio, and hopefully will improve start-to-play time. Note that decrypt-and-decode of audio is supported on Android, but via MojoAudioDecoder directly, not through an explicit Decryptor interface. Bug: 846064 Test: browser tests still pass Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iffcbd488e613b63d50bf077dc27b4e5c4105adc3 Reviewed-on: https://chromium-review.googlesource.com/1070554Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#561354}
-
Aaron Leventhal authored
Items in single selection containers that have accessibility focus should get the selected state. Code to mirror focus to selection exists, but the selected state must be refreshed. Bug: 846089 Change-Id: I90eb6aaec3be196b78126241ebf7e3d38ccda7c2 Reviewed-on: https://chromium-review.googlesource.com/1070520 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#561353}
-
Charles Zhao authored
(1) Update native_inference.h, native_inference.cc, example_preprocessor_config.pb to be the newest model. (2) Update tab_score_predictor_unittest.cc (3) Add amoylan as extra owner of this directory. Change-Id: Iffb2f84e5cbf65ae20d864fccc2edface051055e Reviewed-on: https://chromium-review.googlesource.com/1068952 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#561352}
-
Hiroshige Hayashizaki authored
This CL replaces ScriptLoader::Execute() with PendingScript::ExecuteScriptBlock(). To do this, this CL clears ScriptLoader::pending_script_ in ScriptLoader::PendingScriptFinished(), i.e. slightly before ScriptLoader::Execute(). Bug: 842349 Change-Id: Ia010d370ce1e139808b39e66ad4557f9151e2a47 Reviewed-on: https://chromium-review.googlesource.com/1054553 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#561351}
-
Tim Zheng authored
Bug: 824549 Change-Id: Ifd8d5c83b2c62d4cdf60cc8f0345f5a736e49a66 Reviewed-on: https://chromium-review.googlesource.com/1067681Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Tim Zheng <timzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#561350}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f1e34db090a1..1986f5a957da $ git log f1e34db09..1986f5a95 --date=short --no-merges --format='%ad %ae %s' 2018-05-21 benjhayden Change "minutes" legacy unit to timeInMsAutoFormat. 2018-05-23 benjhayden Add dashboard/v2spa.yaml and v2spa_dev.yaml. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I2f8210d32f75d073b8bf9f1dab9eb778910f2257 Reviewed-on: https://chromium-review.googlesource.com/1071000Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561349}
-
Jinho Bang authored
After a long discussion, Web Payment Working Group decided to remove the `currencySystem` member[1]. The currency code should be well-formed 3-letter alphabetic code and is allowed even if that is not part of the official ISO 4217 list. [1] https://github.com/w3c/payment-request/pull/694 Intent to remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/-jtNNH_Bb6c Bug: 839402 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I17ac51c93e457c4bae00db365a4c7322274c8d4f Signed-off-by:
Jinho Bang <jinho.bang@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/1042427Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#561348}
-
Sonny Sasaka authored
When Bluetooth adapter goes away, this could be caused by BlueZ crash or chip error. In any case, we should make sure to clear all discovery sessions, otherwise out-of-sync about discovery sessions can happen between Chrome and BlueZ. BUG=837656 Change-Id: Id1956039a94da32fe95a0d2c023eb97eef8d99fa Reviewed-on: https://chromium-review.googlesource.com/1069934 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Cr-Commit-Position: refs/heads/master@{#561347}
-
Michael Giuffrida authored
Tests the experimental group that enables TabRanker for ML-based tab discarding. Bug: 838030 Change-Id: I4304420f3841b2f6c189239f9aca30fc1d03f17c Reviewed-on: https://chromium-review.googlesource.com/1068205 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#561346}
-
Fredrik Hubinette authored
Bug: 836952 Change-Id: I381042fd107b954b5d47f1dae7e392e5bd3752dc Reviewed-on: https://chromium-review.googlesource.com/1069804 Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#561345}
-
Esmael El-Moslimany authored
Use SELECT_EXISTING_FOLDER when choosing an unpacked extension. Disable folder creation for SELECT_EXISTING_FOLDER and SELECT_UPLOAD_FOLDER (for all desktop platforms excluding kde). For GTK when selecting a folder, show only folders. Bug: 772180 Change-Id: I0f513180ff7f10b5af91e8c518b3d9fd4b0fc8f1 Reviewed-on: https://chromium-review.googlesource.com/1019732 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#561344}
-
junweifu authored
We can hopefully find these conversion locations in the future if we find a better solution for Mojo-IDL intero although TypeConvert is deprecated. Use LUCI for chromium tests on Windows 10 in PRSUBMITs.py. BUG=841649 Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng Change-Id: Ic235bcf98ecd53c5d873a8faf4ed72f1f60530b3 Reviewed-on: https://chromium-review.googlesource.com/1063291 Commit-Queue: Junwei Fu <junwei.fu@intel.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#561343}
-
Brandon Wylie authored
This composite reporter will be used to report events to as many sources as required. The first concrete use will be to implement a debugging reporter. Bug: 843251 Change-Id: Ia847715ee1da4200c644bde426e5a0daccfb65f2 Reviewed-on: https://chromium-review.googlesource.com/1056295 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#561342}
-
Saman Sami authored
This CL introduces ClientFrameSinkVideoCapturer, a client-side library that interacts with FrameSinkVideoCapturer and can handle viz crashes. This CL converts FrameSinkVideoCaptureDevice to use ClientFrameSinkVideoCapturer but the DevTools usages of FrameSinkVideoCapturer aren't converted yet. Bug: 806377 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I982ca324491fafe9331de4b660cb81f93fcc4605 Reviewed-on: https://chromium-review.googlesource.com/1066224Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#561341}
-
CJ DiMeglio authored
Currently, we are able to initiate a SubmitSingleFrame at any time. This ignores two edge cases, both of which have us accessing VideoResourceUpdater and VideoResourceProvider while they are null (which means we never intialized VideoFrameResourceProvider (VFRP)). Case one occurs when we call SubmitSingleFrame before we were able to initialize VFRP the first time. The second can occur while we are re-intializing VFRP on context loss. Because we cannot just check if we have a context_provider to prove that we are safe from these cases (it might be null because we are in software compositing mode), we instead just check for the initialization. Bug: 842471 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If3b31ed83908668ec21fbd0d2abbd7d45d454e67 Reviewed-on: https://chromium-review.googlesource.com/1069843Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#561340}
-
Joe Downing authored
There is a chance that the FullscreenControlHost work will not be ready for M68 so I am adding a feature check for the keyboard lock api feature flag to enable this control. Note that the control will not appear for mouse / touch users, only in the keyboard lock scenario where the escape key has been locked. BUG=680809 Change-Id: I4eb1fa4608f59d89d418200d1b0b88bc334be8c1 Reviewed-on: https://chromium-review.googlesource.com/1070877Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#561339}
-
Tessa Nijssen authored
Previously, after a section of text was removed and the removal was undone, the cursor was placed after the text. The desired behavior would be a selection of the re-placed text. This change saves the current selection range on delete or replace. The selection range is then restored on undo. Changed tests: - TextfieldModelTest.UndoRedo_CutCopyPasteTest - OmniboxViewTest.UndoRedo Added tests: - TextfieldModelTest.Undo_SelectionTest Bug: 615345 Change-Id: I9ce001099de7175da688a993ed3bfd29d296660c Reviewed-on: https://chromium-review.googlesource.com/1066675 Commit-Queue: Tessa Nijssen <tnijssen@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#561338}
-
Sasha Morrissey authored
the console should show the recorded metrics correctly. Test: Set metrics.log = true and try and open one of each file type; Bug: 846136 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I95bc7439f79a2f8c616a4ca655938b956b5bfd59 Reviewed-on: https://chromium-review.googlesource.com/1070907Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#561337}
-
Koji Ishii authored
The `style_variant_` field was originally added when we introduced NGStyleVariant[1] and extended to all fragments[2], but it was not initialized and suddenly starts failing for box fragments to have kEllipsis in some tests when '--run-layout-test' option is used. This patch initializes it to kStandard. [1] https://chromium-review.googlesource.com/956552 [2] https://chromium-review.googlesource.com/1068781 Bug: 714962 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ib7013e9c80f54550f9fc1262345ffd2fa18b3790 Reviewed-on: https://chromium-review.googlesource.com/1068793Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#561336}
-
Michael Lippautz authored
This avoids writing a pointer for each traced wrapper on dispatch. It also brings the wrapper tracing descriptor closer to the regular trace descriptor. Bug: chromium:841830 Change-Id: I6be7566a465184b12d9021926b3a61cd66934bc6 Reviewed-on: https://chromium-review.googlesource.com/1067572Reviewed-by:
-
Quentin Fiard authored
- Improve the documentation of TimeDelta::InXYZ methods to clarify that they return a truncated value (aka rounded towards zero). - Add a new InDaysFloored method to convert a TimeDelta into a floored number of days. - Fix the implementation of InMillisecondsRoundedUp for negative time deltas. Bug: 831545 Change-Id: I4afd256308f6f28ff459925772059fdfc5824995 Reviewed-on: https://chromium-review.googlesource.com/1049906Reviewed-by:
-
Vlad Tsyrklevich authored
Blacklist base::Callback as a conservative solution to crbug.com/845855 Also add two files that call dlsym() resolved functions identified by looking at functions that immediately trap (consist of only a ud2 instruction) after enabling cfi-icall. BUG=845855 Change-Id: I54a74902fd5db5d85f396f200f96f97bd8e1e463 Reviewed-on: https://chromium-review.googlesource.com/1071090Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#561333}
-
Patrick Hulce authored
- Convert dropdowns to radio/checkbox inputs - Resize icons/line height/padding - Overlay size fix - Minor typographic adjustments - Disable start audit button when on active view BUG=844331,844334,844374,844352,844324,844318 Change-Id: Ieb87ce0994031c69a260bddf83f8ad995c8ea70c Reviewed-on: https://chromium-review.googlesource.com/1066302 Commit-Queue: Patrick Hulce <phulce@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#561332}
-
Chris Harrelson authored
Bug: 823365 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia97f4fac5a0fd9929d8ff03b109057db7171e8f3 Reviewed-on: https://chromium-review.googlesource.com/1070621 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#561331}
-
Xu Xing authored
BUG=821176 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: If78dca0b4526fb85f09ff6a641b5dc7e18bb12b3 Reviewed-on: https://chromium-review.googlesource.com/1068649Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#561330}
-
Mohamed Heikal authored
This renames "Startup.Android.Experimental.Cold.TimeToFirstNavigationCommit" to "Startup.Android.Cold.TimeToFirstNavigationCommit.Tabbed" similarly for "Startup.Android.Experimental.Cold.TimeToFirstContentfulPaint". This also creates another suffix ".WebApk" for these histograms to track startup numbers for PWAs in chrome. The new histograms now use "Medium Times" which has a shorter range since the long tail is no longer a problem. This change also refactors the Activity related tracking code in UmaUtils into AcitivityTabStartupMetricsTracker.java Change-Id: Ia8c309f1c791a2c491832f3945bb54b47952f821 Bug: 842023 Reviewed-on: https://chromium-review.googlesource.com/1063011 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#561329}
-
Scott Violet authored
If the bounds don't change, but the LocalSurfaceId does, then the request needs to be processed. This is important for windows that have LocalSurfaceId, such as at the embedding. This bug resulted in the ksv not drawing correctly initially. BUG=837684 TEST=covered by test Change-Id: I0bf67a15bc2af0ae42df07378908d3c1a8d90885 Reviewed-on: https://chromium-review.googlesource.com/1070689 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Aga Wronska authored
Bug: 835436 Change-Id: Ie7d07234197b0159a429a69de84e1e3c1724c1c0 Reviewed-on: https://chromium-review.googlesource.com/1025395 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#561327}
-
Trent Apted authored
A range of factors were leading to the ChromeOS "Sign out" button getting an incorrect text color (details: https://crbug.com/779732#c21 ). The button is constructed using TrayPopupItemStyle::TextStyle::BUTTON and TrayPopupUtils::CreateTrayPopupBorderlessButton(..), but nothing else was using these. Move the construction code into user_view.cc, which is the only place that needs it. Use a views::style::TextContext, CONTEXT_TRAY_POPUP_BUTTON, to adopt the standard way of configuring the button's font. The color is trickier. Hardcode gfx::kChromeIconGrey to keep the current behaviour. It's the only text in the menu using gfx::Font::Weight::MEDIUM, so using the same color as other text (#212121) makes it look too dark. kChromeIconGrey is lighter and matches the icons in the menu. The old codepaths (using TrayPopupItemStyle::TextStyle::BUTTON) were trying to set #212121 and would get clobbered by ui::NativeTheme to use kChromeIconGrey instead. Bug: 779732 Change-Id: If87a11a9296980c0925c10bca2021cc5e6edd208 Reviewed-on: https://chromium-review.googlesource.com/1065597Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
-
Nektarios Paisios authored
R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 845651 Change-Id: I797678c5bd39e191e1511d6397d112a8a04ab35c Reviewed-on: https://chromium-review.googlesource.com/1069807 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#561325}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5dd3fccb3c7d..13235d8966e4 $ git log 5dd3fccb3..13235d896 --date=short --no-merges --format='%ad %ae %s' 2018-05-23 csmartdalton Revert "ccpr: Handle winding and even-odd in the same shader" 2018-05-23 fmalita [skottie] SK_API-export public classes 2018-05-23 scroggo Alternate between two SkBitmaps in SkAnimatedImage 2018-05-23 scroggo Make DNG decodes single threaded on Android Created with: roll-dep src/third_party/skia BUG=chromium:78866720,chromium:78878033 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=allanmac@chromium.org Change-Id: Icdded072680d84c7b34590c332626f47cb8a722e Reviewed-on: https://chromium-review.googlesource.com/1070927 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561324}
-
Helen Li authored
These two field trials are not actively being worked on. It's unclear whether tuning the buffer size is still relevant given the other changes (with respect to socket buffers) that landed since. This CL removes the field trials from the code. Bug: 631140 Change-Id: If4fc665551f76d35f36b702055fef64499e4e582 Reviewed-on: https://chromium-review.googlesource.com/1070650Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#561323}
-
Trent Apted authored
Currently BrowserWindowController and BrowserFrameMac set some delegates on the NSWindow object during construction for validating and dispatching commands in the mainMenu bar (and other means). These are not cleared upon destruction. However, AppKit may retain NSWindows on NSEvents and things, resulting in validation or dispatch attempts attempting to lookup a Browser* for the window and finding null. This CL adds plumbing in MacViews so that the NSWindow customisation done at construction has a symmetric destruction opportunity as well. Adds some test coverage to simulate the codepath that currently DCHECKs that covers both Views and Cocoa browser windows. Bug: 828738 Change-Id: I96f69c7912328abf84076f202c98617f4729f38a Reviewed-on: https://chromium-review.googlesource.com/1068906Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#561322}
-
Gary Kacmarcik authored
Rather than have each platform convert Unicode combining characters before adding them to the DomKeyboardLayout, with this change each platform adds the Unicode combining characters and they are converted into printable characters as the LayoutMap is being created for the user. Bug: 832811 Change-Id: Ie1b23b228c1227b7c4be6e5409dba881ef1ff586 Reviewed-on: https://chromium-review.googlesource.com/1070756Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#561321}
-
John Rummell authored
BUG=658026 TEST=new fuzzers run Change-Id: I8251f3b77a561985f626e079cecd18a756cca240 Reviewed-on: https://chromium-review.googlesource.com/1067494 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#561320}
-
Emily Stark authored
As an enterprise requirement for the HTTP-Bad rollout, we need to support wildcard hostname patterns like *.foo-corp.com for the --unsafely-treat-insecure-origin-as-secure flag and policy. This CL supports this requirement by expanding the whitelist configured by that flag to allow hostname patterns. Unfortunately, this means that the whitelist is now made up of std::strings instead of url::Origins; origins are still canonicalized and serialized before being placed into the whitelist. Consumers of the whitelist now check for exact origin matches as well as pattern matches. Bug: 844885 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I6ccea22f499045bf7ec50bfb903320baa8e37095 Reviewed-on: https://chromium-review.googlesource.com/1068262 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#561319}
-
- 23 May, 2018 3 commits
-
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8dd790d49a52..f1e34db090a1 $ git log 8dd790d49..f1e34db09 --date=short --no-merges --format='%ad %ae %s' 2018-05-23 wangxianzhu Fix frame viewer ui issues Created with: roll-dep src/third_party/catapult BUG=chromium:842238 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I9df8041171da342c420309e0267c3103c4b87267 Reviewed-on: https://chromium-review.googlesource.com/1070651 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Theresa authored
This reverts commit b422141f. Reason for revert: Suspect that this broke ui automator tests Original change's description: > Clean up scrim logic in LocationBarLayout > > Scrim visibility in the location bar is now completely controlled by > a single function. The scrim observer is now added and removed based > on the scrim visibility to avoid conflict with other observers (like > the bottom sheet). > > Bug: 834927 > Change-Id: I172ca637dde5bc026b1b7f629bc34c6d939dff2d > Reviewed-on: https://chromium-review.googlesource.com/1026168 > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558785} TBR=tedchoc@chromium.org,twellington@chromium.org,mdjones@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 834927 Change-Id: I46401b29a91f67cfa6aa6611b7d9bf854d1fd610 Reviewed-on: https://chromium-review.googlesource.com/1070890Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#561317}
-
Chris Harrelson authored
Bug:823365 Change-Id: I188e8521d0981c3da23f978caaffdc0009190691 Reviewed-on: https://chromium-review.googlesource.com/1070887 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
