- 27 Mar, 2019 40 commits
-
-
Doug Arnett authored
Step 1 of dropping HintCacheStore interface - it uses a using definition to avoid more changes for this CL and keep diffs meaningful. Next step will be to rename HintCacheLevelDBStore to HintCacheStore. Change-Id: I94997cd0506ee834958f6096179128041d66557b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539006Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#644906}
-
Aaron Leventhal authored
Enable JAWS Insert+T read title command in alert dialogs by exposing xml-role:alertdialog on them. Bug: 867273 Change-Id: I6654ffc8bd8f65e641ff9c40c50fa2882e51ae56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540071Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#644905}
-
Justin Cohen authored
Bug: 945865 Change-Id: Ief57de24729bd99e7dff1612677e594ac109dc63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540059 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#644904}
-
Scott Violet authored
Crash data seems to indicate after the call to SetBubbleWidth(). AFAICT the functions that are called after SetBubbleWidth() can be moved *before* the call to SetBubbleWidth(), so moving them in hopes of fixing the crash. BUG=943564 TEST=none Change-Id: I271fdc0e90a89f8d3ce4f45a848e4dcbeee0c1dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540308Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#644903}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5fa32da9cc18..8eba309d78ab git log 5fa32da9cc18..8eba309d78ab --date=short --no-merges --format='%ad %ae %s' 2019-03-27 lalitm@google.com trace_processor: implement string pooling class Created with: gclient setdep -r src/third_party/perfetto@8eba309d78ab The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I9b9c6f3fe62b6ff6f946512fd20c0938098c9c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541590Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644902}
-
Eric Seckler authored
These were only applied to the ChromeEventBundle sink originally, but should also affect the TrackEvent sink. Bug: 928738 Change-Id: I8ea1c3baa2c70b2b224c890025b5f92fa74da95e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541091Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#644901}
-
Nate Chapin authored
Bug: 914587 Change-Id: Ifdb8f3f3a56fe49968e3e85fc01ca1e25095ebec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538776 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#644900}
-
rbpotter authored
A couple tests: PrintPreviewSettingsSelectTest.All PrintPreviewOtherOptionsSettingsTest.All were flaky on Mac. This is because on Mac, the initial settings returned from C++ after the print-preview-app was detached and the new model instance was attached. These tests don't expect print-preview-app to be running as they are unit tests for the elements they test, but print preview app still ran onInitialSettingsSet_ when the new Model instance resolved the whenReady() promise. To fix this, get the model whenReady() promise in attached(), and store it in print-preview-app. Clear it when the app is detached and check its value before dereferencing. This ensures that the app only continues to initialize everything if its own model is still attached. Also changing settings select test to add binding after setting the settings property, for consistency with other tests. Bug: 945846 Change-Id: Id59bd412071af3a88e9e778c61b02bc729234856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540072Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#644899}
-
Yann Dago authored
Bug: b/129150645 Change-Id: I59db03be0f44d1f1c90bf315999456a58babc31e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538004 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#644898}
-
Justin Cohen authored
If WKWebView crashes during slimnav restore, the navigation manager gets stuck in the restoring state. In this case, it's safe to drop out of restore so the user can type in the omnibox to navigate away. Bug: 945425 Change-Id: I903732598319f015cfdad7b78bd9b50423123b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540371 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Nico Weber authored
See also https://chromium-review.googlesource.com/c/chromium/tools/build/+/1541637 Bug: 740301 Change-Id: I394765a19a1ef4f4b0a9bb99411a077607bf626c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541817 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#644896}
-
Christian Biesinger authored
Change-Id: Icb6c6320895b75f2e085cc45c835d92f32c0be56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538856 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#644895}
-
Michael Ludwig authored
Change-Id: Icc26306afd6c8ba25d81c96162ee4f3af671d936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521276 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#644894}
-
Findit authored
This reverts commit 66b27048. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 644435 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNjZiMjcwNDhlZWQ4YTYzZjdlNzgzZWQ5YWY0NmNlMjJlZjk3M2M5OQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/12017 Sample Failed Step: non_single_process_mash_browser_tests Sample Flaky Test: AccountManagerPolicyControllerTest.ExistingSecondaryAccountsAreRemovedAfterPolicyApplication Original change's description: > Apply crOS Account Manager policy to remove Secondary Accounts > > If SecondaryGoogleAccountSigninAllowed policy is set to false, it sets > the kSecondaryGoogleAccountSigninAllowed preference to false. This > should result in any existing Secondary Accounts in Chrome OS Account > Manager being removed. > > Please check https://crbug.com/934492#c6 for a Design Document. > > Bug: 934492 > Test: browser_tests --gtest_filter="*AccountManagerPolicyControllerTest*" > Change-Id: Ib620a8347b9859dae0245957a0e240490d450545 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538185 > Commit-Queue: Kush Sinha <sinhak@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644435} Change-Id: Iddc86e15909b54317dda77323bfd1cbb972c1767 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 934492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542136 Cr-Commit-Position: refs/heads/master@{#644893}
-
Eric Seckler authored
Some TracePackets (e.g. service-emitted or metadata ones) don't use incremental state, so shouldn't be skipped even if the incremental_state_cleared flag wasn't yet seen. Bug: 928738 Change-Id: Iadc649e5460b00fb4af5a8f30c03ed9b17aace9c TBR: oysteine@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541163Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/49191a7ef481..f122d248accb git log 49191a7ef481..f122d248accb --date=short --no-merges --format='%ad %ae %s' 2019-03-27 tsepez@chromium.org Retain bitmap in CPDF_RenderStatus::LoadSMask(). Created with: gclient setdep -r src/third_party/pdfium@f122d248accb The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idfa0f189758ece785dbb13ef57f2bad4470fe05b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541979Reviewed-by:
-
Sam Goto authored
This reverts commit 7781b4c2. The windows tests were failing to load the mojo files without the file:// scheme. Bug: 878979 Change-Id: Icf1f309b7fede30b039d7a7b7dc777e0fa182be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534734 Commit-Queue: Sam Goto <goto@chromium.org> Auto-Submit: Sam Goto <goto@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#644890}
-
Ella Ge authored
This reverts commit c5620d27. Reason for revert: suspect causing test failing on https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Trusty%20MSAN/13550 Original change's description: > Implement ReadableStreamNative > > Add C++ implementation of ReadableStream behind the "StreamsNative" > Blink feature. > > The implementations of tee() and pipeTo() are excluded from this CL for > reasons of size. There are many failing test expectations as a result. > They will be added in followup CLs. > > Design doc: > https://docs.google.com/document/d/1n0IIRmJb0R-DFc2IhhJfS2-LUwl6iKSBNaR0klr3o40/edit#heading=h.7nki9mck5t64 > > Also add fetch tests to virtual/streams-native web tests. > > BUG=902633 > > Change-Id: I8acc918ddb84f6e51614bd23373a74f0c79ccc74 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523212 > Commit-Queue: Adam Rice <ricea@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644740} TBR=ricea@chromium.org,yhirano@chromium.org Change-Id: I395a1acf76552a9e0b2d300466b09a63d834ade4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541475Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#644889}
-
Adam Langley authored
The parsing code rejected any list of versions with more than two elements, but this precludes any future versions from being added to the version list. Also, only duplication of recognised protocols was caught, while any duplication, even of unknown versions, should be an error. Bug: 946542 Change-Id: Ie9974de4b5beaa79fa0d8a2f7f880b51b91a6125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534868 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#644888}
-
Xiaohui Chen authored
Unit tests are generally preferred and covers all existing test needs. Bug: None Test: locally build and run chromeos_unittests Change-Id: I8cee7e2faf0446899ba6dd76c1c8540df52c6e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536764Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#644887}
-
Amit Hilbuch authored
This test checks that when a PeerConnection receives an offer from an SFU indicating that the SFU wants to receive simulcast, it generates an answer that negotiates sending simulcast. Bug: None Change-Id: I1b6623169a1c2fd18ee453bfbf8e63cee95e5bd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540306Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Amit Hilbuch <amithi@chromium.org> Cr-Commit-Position: refs/heads/master@{#644886}
-
Jérôme Lebel authored
Creating SigninResult enum with 3 values: + CANCELED + SUCCESS + SIGNED_IN_AND_OPEN_SETTINGS This enum is used by SigninInteractionController, when the user taps on either "cancel", "yes I'm in", or "settings". This patch prepares the new UI to present the settings before starting the sync: crrev.com/c/1539036 Bug: 883075 Change-Id: Ic5db6ff7d67d0ec7ba356741391c13f51198cf36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538509 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#644885}
-
Brian White authored
Bug: 923083 Change-Id: Ie09e756610fd6fd9f2f52f02ca2cf2b329fe6dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538001Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#644884}
-
Ella Ge authored
Failing on both Win/Mac/Linux https://ci.chromium.org/p/chromium/builders/ci/linux-xenial-rel/7836 https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/89693 https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/35599 Tbr: shaktisahu@chromium.org No-Try: true Bug: 946574 Change-Id: Ib9c9dfae3986c3d7e1ee54032cb2181818015dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541473Reviewed-by:
-
Sean Gilhuly authored
Some AA pixels tests are not passing on SkiaRenderer. De-parameterize them, and use the prefix DISABLED_ so they can be run without modifying the test code. These tests can be run with: out/Default/viz_unittests --gtest_filter=SkiaRendererAAPixelTest* --gtest_also_run_disabled_tests Bug: 939442 Change-Id: I3a88baddd379c401d62722ec460aaac0f4caf332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541939Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d935763366ad..7ba455088b7b Created with: gclient setdep -r src-internal@7ba455088b7b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=robertocn@chromium.org,noel@chromium.org,eirage@chromium.org Change-Id: I669466da1f12a0bf41a240580dfde29730ceed31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541977Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644881}
-
Kyle Horimoto authored
Before this CL, tabbing to the subpage arrow of a network list item and pressing Enter would cause two "show-detail" events to be fired instead of one. In the settings page, the outcome of this error was that users would be navigated to the details page but would have to click the back arrow twice to go to the previous page. This issue was caused by the use of <iron-a11y-keys>; this element handled the "keydown" event by dispatching its own "keys-pressed" event, which was handled by <cr-network-list-item> to navigate to the next page. <cr-network-list-item> stopped propagation of the event, but this was not good enough, since the event it was stopping was the "keys-pressed" event, not the "keydown" event. Since the default action of pressing Enter when a button is focused is to simulate a click, this still occurred and caused the subpage arrow's click handler to be called. Additionally, a second issue was caused by the interaction of <iron-a11y-keys> and <iron-list>. Since both of these handle the "keydown" event and <cr-network-list-item> only handles the "keys-pressed" event, the <cr-network-list-item> could not stop propagation onf the original "keydown" event, resulting in the <iron-list>'s handler also being invoked. This CL fixes these issues by: (1) Removing use of the <iron-a11y-keys> element and replacing it with explicit "keydown" listeners via this.listen(). (2) Stopping the propagation of the "keydown" event instead of of the "keys-pressed" event. (3) Preventing the default action of the "keydown" event. Bug: 736963 Change-Id: Ibb1c8c0484a1bc243586ebdee95fe1e3e357b94a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540676Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#644880}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/53dd1f3c1a33..4d9df38d829d git log 53dd1f3c1a33..4d9df38d829d --date=short --no-merges --format='%ad %ae %s' 2019-03-27 sprang@webrtc.org Add new more flexible VideoEncoder::SetRate() method. 2019-03-27 mbonadei@webrtc.org Do not assume /DUNICODE and /D_UNICODE. 2019-03-27 jonasolsson@webrtc.org Make some constants in the bitrate prober configurable. 2019-03-27 nisse@webrtc.org Delete transitional includes from common_types.h Created with: gclient setdep -r src/third_party/webrtc@4d9df38d829d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If577c1a2ac98d45a3906f94deaf953f862f01954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541976Reviewed-by:
-
Gabriel Charette authored
This reverts commit 8f6536d9. Reason for revert: root caused fixed by crrev.com/644548 As mentioend @ https://bugs.chromium.org/p/chromium/issues/detail?id=938126#c42 Original change's description: > Disable flaky test ArcFileSystemBridgeTest.GetFileName > > Test has been identified as flaky by Findit. Analysis can be found > in the referenced bug. Disabling the test as too much time passed > since first flake occurred and finding the CL to revert is going to > be to long. > > TBR=nya@chromium.org > > Bug: 939935 > To-Be-Reviewed: nya@chromium.org > Change-Id: Ide6ac6b1333a71034f49779e659c32e70a1fe298 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514678 > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#639478} TBR=sdefresne@chromium.org,nya@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 939935 Change-Id: I0aa031e2e259c324f21dc6687dac7808815e0693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542037Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#644878}
-
Sadrul Habib Chowdhury authored
The test has been timing out on mac and win-7. So disable. NOTRY=true TBR=perezju@chromium.org BUG=944978, 946495 Change-Id: I6d1c757c603cd4998e7ea47c534a0e643a589949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541470Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#644877}
-
Javier Ernesto Flores Robles authored
TBR=mahmadi@chromium.org Bug: 946533 Change-Id: I27c1aaabbef66662b004595defbef16578371be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541089Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#644876}
-
Stefan Zager authored
Previously, subtree_throttled_ was only set once, when an iframe was attached to the layout tree, and then never updated. I haven't seen any bugs resulting from this, but it's clearly wrong, and fixing it appears to claw back some of the performance regression in the bug. BUG=941116 Change-Id: I5a094a7c35d0c0a673de358f4cb095bb8f6de032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531680 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#644875}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1d6b43ae. With Chromium commits locally applied on WPT: 685a1df9 "Extend canvas getContextAttributes WPTest" 11eae161 "HTMLVideoElement: implement playsinline and auto-fullscreen." 1bf12f7c "Revert "Fix external/wpt/event-timing/event-timing-onloadobserve.html to be more deterministic"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I689277d51f41204dc1f0f5de0b24a44a01d46291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541936Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644874}
-
Sammie Quon authored
More info in the bug, but you have to use google.com to view. The crash state points to CaptionContainerView::SetBackdropVisibility, but the stack shows we are recieving OverviewGrid::OnWindowBoundsChanged after shutdown of overview, so remove overview grid's observers when shutting down. Test: manual Bug: 946301 Change-Id: Ifbec5cee8502f577011080b4a2809a7bcf128d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541440Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#644873}
-
Fabio Tirelo authored
Bug: 943700 Change-Id: I00df18d2ef02a106b622058b58a5b793ebdf6720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531383Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#644872}
-
Eric Seckler authored
Bug: 928738 Change-Id: I13d91605be1e988391de9cca9eefb6600ff22563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541085Reviewed-by:
-
Raul Tambre authored
The scripts still work with Python 2. There are no intended behaviour changes. Bug: 941669 Change-Id: I7e29b1736295957df30f82b5943b58f5ce843029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536184Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#644870}
-
Liquan(Max) Gu authored
FCP++ uses IdForNode() to get node ID. But IdForNode() has the side effect of creating an id for node if it doesn't exist. As FCP++ uses IdForNode() for every removed node regardless of whether it's content node, it's a costly operation. FCP++ only cares about the removal of the nodes that have already been recorded. This indicates that the nodes already have node id. Based on this characteristic, FCP++ can ignore the nodes that do not have node id, so as to reduce cost. This CL is to implement this idea. Bug: 945405 Change-Id: I03602d3d79f5f5ed4c087a7a2cf0a44aec1accbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540263 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#644869}
-
Chris Cunningham authored
WMPI occasionally destroys the reporter in circumstances where we aren't using our default local pipeline (remoting, flinging, media player). When we revert to the local pipeline (e.g. remoting ends) we call CreateVideoDecodeStatsReporter() to get going again. This works ok today but it relies on the assumption that categories of reasons to destroy or recreate the reporter are never overlapping/interleaved. For instance, maybe flinging has stopped, so from its perspective its time to recreate the reporter, but meanwhile some other state has changed such that this is undesired. No such case exists yet, but I want to firm up the contract to add clarity for upcoming work to record encrypted stats. Bug: 907909 Change-Id: Ic9e764d02b09d1760f518e842a4e781208c6040a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540581Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#644868}
-
Peter Wen authored
Also add missed transitive testonly dep from: https://crrev.com/c/1493204 Not security critical, original CL already approved, no need for additional licensing or security review for this transitive dep. Bug: 946331 Change-Id: Ide882486466ae43487484c83789926c99043033d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541588Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#644867}
-
