- 29 Sep, 2020 40 commits
-
-
Xing Liu authored
When startForeground called with a cancelled notification update, startForeground() will be bypassed in DownloadForegroundServiceManager. startOrUpdateForegroundService(). This leads to an Android crash. Instead we need to create an dummy notification and still call startForeground() with it to avoid the crash. This dummy notification will be dropped immediately in DownloadNotificationService. Bug: 1121096 Change-Id: I0f68bff47403b7478f504af6ee03f154c727c82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436511 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#811871}
-
Yi Gu authored
TBR=dmazzoni@chromium.org Bug: 1084871 Change-Id: I21e47bc71cdf5655a4b741ee938b155c77bb2d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438734Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811870}
-
Hiroki Nakagawa authored
These were added by https://codereview.chromium.org/6625066 for the legacy prerender, but these are not used for the current no-state-prefetch. Bug: 755921 Change-Id: I7536260cbf2f33f7f99da8bfa458fdc1702bff55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437553Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#811869}
-
Patrick Noland authored
Disables testTabSwitcherModeTriggeredBeyondThreshold and testTabSwitcherModeNotTriggeredWithinThreshold Bug: 1130696 Change-Id: Iea001954b5bcff71be17d0e6ec7b29de8ba9c610 TBR: wychen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437746Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#811868}
-
Dominic Mazzoni authored
This is one more step towards enabling the flag AccessibilityExposeHTMLElementEnabled to include the HTML element in the accessibility tree. Bug: 1063155 Change-Id: I19a1e7e8daba1f2186db3428cfab5c0cc9ee41a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427878 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#811867}
-
David Dorwin authored
Also renames both methods in feedback_registration.h to be more accurate. This is a follow-up to https://crrev.com/c/2315796. Change-Id: I4960a7b1cc076ee00bd22e043e08e44ec476a57c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422155 Commit-Queue: David Dorwin <ddorwin@chromium.org> Auto-Submit: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#811866}
-
Patrick Noland authored
This reverts commit 773b24b9. Reason for revert: Tests are failing on android-arm-official-tests https://ci.chromium.org/p/chrome/builders/ci/android-arm-official-tests/1369 Original change's description: > [Android] Implement tests for SyncErrorCardPreference > > This cl adds render tests for different types of sync errors in > SyncErrorCardPreference. > > Bug: 1107420 > Change-Id: I3ebc308932eadb677310ea041559bb54bbb1765c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353255 > Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Alice Wang <aliceywang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811273} TBR=treib@chromium.org,triploblastic@chromium.org,aliceywang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1107420 Change-Id: Ib86c9353dd3f5389ec7446add5c60b1031f59893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438611Reviewed-by:
-
Miriam Zimmerman authored
The Platform.UncleanShutdownsDaily and Platform.UserCrashesDaily histograms are used to assess Chrome OS system health, so we need them to stay around. BUG=chromium:1089270 TEST=CQ Change-Id: I413c6191f9c484fa407a0141f3b2cea5f90c93d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427064 Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#811864}
-
Zhenyao Mo authored
From histogram data, they are 100% renderable on all Mac. Avoid runtime check, where CheckFramebufferStatus() hangs from time to time. Also, limit this to AMD/Intel/Nvidia GPUs. BUG=1127387 TEST=bots R=kbr@chromium.org Change-Id: If7567f3410090241c2ab861b93bd45c117051c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436386Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#811863}
-
Ali Juma authored
This CL makes FakeSafeBrowsingService::ClearCookies call the callback it is given, fixing BrowsingDataRemoverImplTests when Safe Browsing is enabled by default. Bug: 1028755 Change-Id: Id586113c49a62133de4568b3dce35b9cdf17cae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438733 Commit-Queue: Ali Juma <ajuma@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#811862}
-
Klaus Weidner authored
The shaders were originally copied from VR Browser, and AR mode doesn't need support for a border region. Remove that to simplify it. Change-Id: I5ac59e32e4b029e6f94d54a64a1638a7df92f758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438610 Commit-Queue: Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Auto-Submit: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#811861}
-
Michael Thiessen authored
I'm doing a series of cleanups on ChromeActivityTestRule. 1. ActivityTestRules are supposed to take in the exact class to be launched - we hack around this in ChromeActivityTestRule, but we really don't need to and it's confusing for those familiar with ActivityTestRule. To this end I plan to prevent directly using ChromeActivityTestRule in favor of derived classes specific to the Activity you actually want to launch. 2. (Almost) All existing usage of ChromeActivityTestRule is actually using ChromeTabbedActivity, and so should be using ChromeTabbedActivityTestRule. 3. A bunch of functions on ChromeActivityTestRule only apply to ChromeTabbedActivity, so I'll be moving the functions to ChromeTabbedActivityTestRule instead. 4. Right now some types of ActivityTestRule will finish the Activity between tests, and some won't (for batched tests). I intend to make this behavior consistent for all ActivityTestRules. This change kicks this off by deprecating the public ChromeActivityTestRule constructor and migrating some of the usages. A few followups will get the remainder of the usages as there are many. Bug: 989569 Change-Id: Ia16a252f0d77a053dc9e1733d52d8ea290574a48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435724Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#811860}
-
Patrick Noland authored
This reverts commit b2925a91. Reason for revert: The re-enabled test is failing on several android builders Original change's description: > Wait for GPU initialization completion > > In RTC video decoder factory, wait until initialization of GPU is > finished before querying supported formats and creating a decoder. > Timeout is configurable via RtcDecoderSupportTimeout field trial. > The feature is enabled by default. The default timeout is 10 seconds. > > Bug: 1047994 > Change-Id: I9d827507664228f903e4ce46e2949785b13192ba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411935 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Commit-Queue: Sergey Silkin <ssilkin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811143} TBR=fdoray@chromium.org,sandersd@chromium.org,guidou@chromium.org,chromium-reviews@chromium.org,etiennep@chromium.org,ssilkin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1047994 Change-Id: I19aec959a1542425d747b58acafdcaab3721b6aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438570Reviewed-by:
-
Lei Zhang authored
Bug: 646113 Change-Id: Ie687bd9a3930d2cf5edbf39a019df717d93263a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436384Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#811858}
-
Boris Sazonov authored
Extends Signin.AndroidGetAccountIdsTime, Signin.AndroidGetAccountsTime, Signin.AndroidGetAccountsTimeUiThread to M89. Bug: 1089513 Change-Id: Ib1de4de350bdce417727ea11ff04d3893402c44a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435231Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#811857}
-
Lei Zhang authored
base::LazyInstance is deprecated. Change-Id: Ic8b37b335004ae0c5cd3cad1c82cb06f25551499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438575Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#811856}
-
Sven Zheng authored
The target is running on following bots and I've checked the tests are stable. Lollipop Tablet Tester Lollipop Phone Tester Marshmallow 64 bit Tester Marshmallow Tablet Tester android-arm64-proguard-rel android-marshmallow-x86-rel-non-cq android-pie-x86-rel Bug: 1117345 Change-Id: Ide487d7b48454d5779f03ff95106aeb66891deb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437229Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#811855}
-
Yi Gu authored
The test has been flaky since it was introduced. See bug for details. TBR=ssid@chromium.org Bug: 1133434 Change-Id: I7ecb38170912745d7b86fc3128b1601c8e6537e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438969Reviewed-by:
-
Sorin Jianu authored
This is an attempt to reland https://chromium-review.googlesource.com/c/chromium/src/+/2414847 after a couple of changes: * obviously, remove the dependency on WinRT, which is not available on Windows 7. * refactoring how the WRL module is configured at build time. * cleaning up headers a bit. The issue with the crashing code is that on the RPC client side of the updater, both update and control services must be instantiated. They both called WRL::Module::Create, which caused WRL code to assert. The server side of RPC also initializes the module, in a slightly different way. Therefore, module initialization in the App base class is not practical. It has to be done in a way specific to the client, or the server, or the mode App is instantiated as. Using a leaky singleton is not great. However, there is singleton already in the WRL::Module, so a leaking singleton in the updater just shows that fact. Bug: 1128748 Change-Id: Ib198161e2dda81d780658e7ee51157f7f13f0f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432131 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#811853}
-
Robert Ogden authored
Make sure surrounding whitespace, like a trailing newline, doesn't fail the probe. Bug: 1115731 Change-Id: I0acc753c7dd04dfa519b7a773870f5f2fdeb1d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432210Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#811852}
-
Etienne Bergeron authored
This CL is merging the TtsControllerTestHelper class into a base testing::Test class. Tests are converted to use that pattern: TEST_F(TtsControllerTest,...) The goal of that cleanup is to simplify the next refactoring where a content::BrowserTaskEnvironment is required for each test. Change-Id: Id3757b58fc05a93ac6ebacdf3ba11ec8b234e9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432751Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#811851}
-
Yi Gu authored
The test has been flaky on several bots: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests&tests=media%2Fcontrols-styling-strict.html TBR=mlamouri@google.com NOTRY=TRUE Bug: 1083605 Change-Id: Ia0736180fc02f8e258f88d2566a03fe0dc293cdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437915Reviewed-by:
-
My Nguyen authored
Update languages' dialogs to have 24px padding. UX is fine with these dialogs's paddings deviate from others. Change device language: http://screen/xQa4J5bcswqWrJj Add languages: http://screen/5BFTcGwzKfxE9hg Add input methods: http://screen/37GF8UyM3z8THcM Bug: 1113439 Change-Id: Id3d7ed561120d519aae66dc65a22004ecceb7b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437074 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#811849}
-
Gayane Petrosyan authored
Bug: 1102382 Change-Id: I6ef96d347ac4864a1eb2e6fc547b77858baf54a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432143Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Auto-Submit: Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#811848}
-
Liquan (Max) Gu authored
Change: * Add an ability for Android browser test to click the close button on the opened payment handler UI. * Test launching payment handler twice to prevent crbug.com/1131874 from happening again. Bug: 1131874 Change-Id: Id43def5f2d2be4a40e34eda1219942dabd70485e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434769 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#811847}
-
edchin authored
URLs dragged from bookmarks are wrapped in URLInfo, so drops onto the tab grid must unwrap URLInfo. Change-Id: I8c1eb8b4e3c8b9b8222473313919066fb659e7e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436521 Commit-Queue: edchin <edchin@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#811846}
-
My Nguyen authored
https://crrev.com/c/2421989 added Sanskrit, but it was misspelt. Bug: 889763 Change-Id: Ia8f94a969e444a4df0d105c6999cb774127f01c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437676Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#811845}
-
Marijn Kruisselbrink authored
This is a reland of 57b51303 In this reland the features browser tests are disabled on Android. The API is not currently enabled on Android (and there are no plans to change that in the near future), so we don't need to run these tests on Android. Original change's description: > [FS] Remove Native File System base::Feature. > > The base::Feature has been enabled by default for many many milestones > now, so it seems unlikely we'd ever want to turn it off again. Remove it > to make code simpler to maintain. > > Embedders can still turn off the API using the blink runtime feature. > > Change-Id: Ifad92d39adac1e656cf75a02918f33409aea44ea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427287 > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810742} Tbr: michaelpg@chromium.org Change-Id: I6973c9100aeef471f7ce476d7054854fc986bf47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436756 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#811844}
-
Matt Jones authored
Overlays need to ensure they propagate the correct background information up the tree. In this case the bottom toolbar wasn't doing this which would cause screen flashing in some cases. Bug: 951115 Change-Id: I9c7af7844345c95ed07215802137c2bf67bcf77b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437022Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#811843}
-
Mike Wittman authored
Updates the name to be consistent with the source and tests in //chrome/common/profiler. Change-Id: Ic181aa3a67435a2af3e3e4592d06f5492ebb1f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437603 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#811842}
-
George Burgess IV authored
`string::operator=(int)` turns into `string::operator=(char)` by casting the RHS of the assignment, so this code turns into `env = "\x01"`; `env = "1"` was probably what was intended. Bug: 1130867 Change-Id: I8a1a1e268c65246c35d864314502fb4aab62e6b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425333Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#811841}
-
Eugene Zemtsov authored
Taking supported profiles into account when choosing when to use an accelerated video encoder. Bug: 1119636, 1127073 Change-Id: I8dd52bf6270342f48ba7ec734c91dc4b24e1196c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437783Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#811840}
-
Sophey Dong authored
Bug: 1129670, 1120093 Change-Id: I8b48d2c3ff9fda7fc347219f40deed60b9dd206d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426481 Commit-Queue: Sophey Dong <sophey@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#811839}
-
dpapad authored
A previous CL at r809271 accidentally uploaded incorrect screenshots causing some confusion to translators. Bug: None Change-Id: I5fb8a60a0c2511f563252f87b03a7b720805b5ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438519 Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#811838}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601380366-03c4c1b9f0c0034a1b47d4510e955a5823e9948c.profdata to chrome-linux-master-1601402113-7fdca9625e1fa7a11789090d4f40670ef10ac97f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Ia8ccc7ddb17613e74f3a12ba73c2598aaa8ef5af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438291Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811837}
-
Hans Wennborg authored
I didn't mean to commit that. Bug: 1015315 Change-Id: I5f69aa5160219e63d4334976888e39c25b2bfe34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437381 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#811836}
-
dpapad authored
There are a couple of Polymer Behaviors currently defined in the ui/webui/resources/html/* and ui/webui/resources/js/* folders. Since Polymer Behaviors can only be used in Polymer elements, makes more sense to define them in cr_elements/ along with other such behaviors. Moreover this simplifies the testing code by being able to leverage cr_elements_browsertest.js. Bug: 1133385 Change-Id: I66eb64812ae4c502452971da003b7a84f5f9d3fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435820Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#811835}
-
Ben Kelly authored
As pointed out by mek@, currently BlobDataItem::ShrinkBytes only resizes the number of elements in the backing std::vector. The backing capacity of the vector remains the same. For any blob less than 512KB this will result in wasted memory usage. Bug: 1133110 Change-Id: I71de9ce6cf75afbc7029d86841c8e5a754b69b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436868Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#811834}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601380366-c2cef07ee462371a6daba327da84ce5730b353c6.profdata to chrome-mac-master-1601402113-90af030cdb9e3c62fe724fde5c9a9eda66c16b0e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ide1f8862dd0488007fb22e5bcb70abfbbcd676da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438820Reviewed-by:
-
Elly Fong-Jones authored
Bug: 1096586 Change-Id: Ied4e1b49ee7e6f154395762a1054924abe6a85a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438730Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#811832}
-
