GitLab

The function snprintf is not available in Visual Studio prior to VS
2015. In some places this omission is dealt with with a #define to map
snprintf to _snprintf. This was never a good idea (_snprintf doesn't
guarantee null-termination) and with VS 2015 it is not even legal.

This change conditionally disables one instance of this remapping.

The build errors that occur without this change are:

stdio.h(1926): warning C4005: 'snprintf': macro redefinition
stdio.h(1926): note: command-line arguments:  see previous
definition of 'snprintf'
stdio.h(1929): fatal error C1189: #error:  Macro definition of
snprintf conflicts with Standard Library function declaration

R=scottmg@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/1069433002

Cr-Commit-Position: refs/heads/master@{#324157}

This CL abstracts Me2Me and It2Me under one common interface
remoting.Activity.

Instead of littering desktop_remoting.js with if statements based on the
mode, all Me2Me specific logic can be moved into
remoting.Me2MeActivity and likewise for It2Me.

BUG=466406
NOTRY=true
TEST=All integration tests passed on chromoting bots.
https://chromium-swarm.appspot.com/user/task/26aed85d041d9d10

Review URL: https://codereview.chromium.org/1054273002

Cr-Commit-Position: refs/heads/master@{#324156}

BUG=343237
TEST=WindowSelectorTest.BasicWithDocked, plus manual

Review URL: https://codereview.chromium.org/1059903002

Cr-Commit-Position: refs/heads/master@{#324155}

TBR=sky@chromium.org
BUG=465815

Review URL: https://codereview.chromium.org/1062293004

Cr-Commit-Position: refs/heads/master@{#324154}

Don't use the canvas() from the PaintContext so that we can have the
PaintContext be backed by a DisplayItemList instead in the future.
Access to the Canvas should be done through a PaintRecorder.

R=piman@chromium.org, sadrul
BUG=466426

Review URL: https://codereview.chromium.org/1066183002

Cr-Commit-Position: refs/heads/master@{#324153}

It seems all of the known bugs with Mali-400 are related to framebuffer
discarding.  Blacklist framebuffer discarding universally on Mali-400
and reenable ganesh and canvas where it was still blacklisted on Mali-400.

There was a preexisting workaround applied to all ARM < 4.4 which was
originally written in the context of Mali-T604; this explains why the
bugs only reproed on some Mali-400 devices.  Add a new one for all 4xx.

Also, a recently added Nexus 6 workaround did essentially the same
thing, but at the level of making the discard do nothing instead of not
advertising the extension.  In OpenGL ES 3, this is a core method so
failing to advertise won't be sufficient, so merge the two workarounds
and remove the "_ext_" from the name.

BUG=449488,451230

Review URL: https://codereview.chromium.org/1068573004

Cr-Commit-Position: refs/heads/master@{#324152}

BUG=474749

Review URL: https://codereview.chromium.org/1069503002

Cr-Commit-Position: refs/heads/master@{#324151}

BUG=445542

Review URL: https://codereview.chromium.org/1050043003

Cr-Commit-Position: refs/heads/master@{#324150}

This custom polymer element is used as a button to toggle the cast-mode-player (hide/show). It is styled after the current cast extension's drop down button.

BUG=464222

Review URL: https://codereview.chromium.org/1032533002

Cr-Commit-Position: refs/heads/master@{#324149}

BUG=381338,474622
TEST=ctrl+alt+z; navigate to html5demos.com/geo; observe speech is as expected (reads contents of bubble).

Committed: https://crrev.com/36318aa45e02cf0b5cf871bf38bbe47f3431cc8d
Cr-Commit-Position: refs/heads/master@{#323982}

Review URL: https://codereview.chromium.org/1067113002

Cr-Commit-Position: refs/heads/master@{#324148}

BUG=390991

Review URL: https://codereview.chromium.org/1062803003

Cr-Commit-Position: refs/heads/master@{#324147}

Turn on the DrawCallPerf test set on the Windows 7 Nvidia GPU bot.

BUG=468852

Review URL: https://codereview.chromium.org/1069103002

Cr-Commit-Position: refs/heads/master@{#324146}

We don't support API level 14 and 15 anymore. \o/

Also remove CreateSingleBuffered which is dead code not being used.

BUG=473837

Review URL: https://codereview.chromium.org/1060233002

Cr-Commit-Position: refs/heads/master@{#324145}

BUG=none
R=grt@chromium.org

Review URL: https://codereview.chromium.org/1024943002

Cr-Commit-Position: refs/heads/master@{#324144}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/bb4a1cf..6c27535

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1060423002

Cr-Commit-Position: refs/heads/master@{#324143}

This is only used for usage statistics (without which we can't apply smart ordering to masked credit card suggestions, or sync usage stats between devices for unmasked cards).

There was already code in place for IDs for addresses, which was essentially unused (ID was always empty). This generates an ID to help identify server addresses for the usage stat tracking.

The tables are not actually synced yet (that's TODO).

BUG=none

Review URL: https://codereview.chromium.org/1042353003

Cr-Commit-Position: refs/heads/master@{#324142}

Review URL: https://codereview.chromium.org/1059183004

Cr-Commit-Position: refs/heads/master@{#324141}

Instead of completely regenerating all of the data each time anything
extension-y happens, have the extensions ui observe specific events and only
regenerate/update the extensions that were modified. Start by limiting events
to loaded/unloaded and error added events.

Also add a basic browsertest for some of the extensions page functionality.

BUG=461039

Review URL: https://codereview.chromium.org/1049483003

Cr-Commit-Position: refs/heads/master@{#324140}

Use the permission_broker's new CheckPathAccess method to filter
devices presented to the user by whether or not Chrome will be able to
open them later.

By having FakePermissionBrokerClient and the base UsbDevice class always
return true to access requests a number of #if defined(OS_CHROMEOS)
checks can be removed.

//third_party/cros_system_api is rolled from 95c486f3 to aea83430 to
pull in the new kCheckPathAccess definition in service_constants.h.

BUG=441526

Review URL: https://codereview.chromium.org/1034333002

Cr-Commit-Position: refs/heads/master@{#324139}

Revert of Add the ability to build Chrome tools to the Win Clang build script. (patchset #2 id:20001 of https://codereview.chromium.org/1068603002/)

Reason for revert:
Broke all bots on http://build.chromium.org/p/chromium.fyi/console?category=win%20clang , they fail with:

________ running 'C:\b\depot_tools\python276_bin\python.exe src/tools/clang/scripts/update.py --if-needed' in 'C:\b\build\slave\CrWinClang\build'
usage: update.py [-h] [--no-clobber] [--tools [TOOLS [TOOLS ...]]]
update.py: error: unrecognized arguments: --if-needed

Probably easy to fix (just add a dummy --if-needed parameter to argparse), but reverting to get that waterfall back to green.

Original issue's description:
> Add the ability to build Chrome tools to the Win Clang build script.
>
> BUG=424436,467287
>
> Committed: https://crrev.com/475949d9430b6a759ce759f2133dd3a1577d0d0b
> Cr-Commit-Position: refs/heads/master@{#324089}

TBR=hans@chromium.org,dcheng@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=424436,467287

Review URL: https://codereview.chromium.org/1063273002

Cr-Commit-Position: refs/heads/master@{#324138}

Don't use the canvas() from the PaintContext so that we can have the
PaintContext be backed by a DisplayItemList instead in the future.
Access to the Canvas should be done through a PaintRecorder.

R=sadrul
BUG=466426

Review URL: https://codereview.chromium.org/1064133003

Cr-Commit-Position: refs/heads/master@{#324137}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0cdfa90..f36d5e0

TBR=falken@chromium.org,cbiesinger@chromium.org

Review URL: https://codereview.chromium.org/1063223002

Cr-Commit-Position: refs/heads/master@{#324136}

BUG=N/A
TBR=pthatcher@chromium.org
CC=ronghuawu@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1066233002

Cr-Commit-Position: refs/heads/master@{#324135}

BUG=471354

Review URL: https://codereview.chromium.org/1061283004

Cr-Commit-Position: refs/heads/master@{#324134}

VS 2015 includes time.h from stdlib.h which leads to redefinition
warnings when threads_windows.h defines the timespec struct.

Ideally threads_windows.h shouldn't be defining CRT structs at all, but
I am doing the minimum scoped change to move VS 2015 development
forwards.

_MSC_VER == 1900 represents the VC++ 2015 compiler.

R=reillyg@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/1067093002

Cr-Commit-Position: refs/heads/master@{#324133}

BUG=338886

Review URL: https://codereview.chromium.org/1064693002

Cr-Commit-Position: refs/heads/master@{#324132}

This removes some special-case code used to register and load
gtbp and o1d PPAPI plugins on Linux and ChromeOS. It also removes
infrastructure used to launch these plugins.

TEST=Run PDF (out-of-process) and NaCl (in-process) plugins
BUG=392002

Review URL: https://codereview.chromium.org/374773002

Cr-Commit-Position: refs/heads/master@{#324131}

BUG=472340

Review URL: https://codereview.chromium.org/1062873003

Cr-Commit-Position: refs/heads/master@{#324130}

VS 2015 RC says, when compiling device_monitor_win.cpp:
error C3848: expression having type 'const device::`anonymous-namespace'
::CompareGUID' would lose some const-volatile qualifiers in order to
call 'bool device::`anonymous-namespace'::CompareGUID::operator
()(const GUID &,const GUID &)'

For details see the STL Breaking Changes (VS14 CTP1) section of:
http://blogs.msdn.com/b/vcblog/archive/2014/06/06/
c-14-stl-features-fixes-and-breaking-changes-in-
visual-studio-14-ctp1.aspx

The complaint, apparently, is that operator() is non-const. Whether this
is actually invalid is for the language lawyers to decide. Marking it
const is more accurate anyway.

R=reillyg@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/1064153002

Cr-Commit-Position: refs/heads/master@{#324129}

Don't use the canvas() from the PaintContext so that we can have the
PaintContext be backed by a DisplayItemList instead in the future.
Access to the Canvas should be done through a PaintRecorder.

R=pkasting
BUG=466426

Review URL: https://codereview.chromium.org/1066133002

Cr-Commit-Position: refs/heads/master@{#324128}

Correct paint invalidation was not occurring for the plugin placeholder
content in Chromium when WebPluginContainer paint invalidation is
delayed until the paint invalidation phase of the document lifecycle.

Here we set the needs layout and needs full paint invalidation flags so that layout is re-done on the plugin content at the next opportunity.

Depends on Blink review https://codereview.chromium.org/1056893003

R=tommycli
BUG=472348

Review URL: https://codereview.chromium.org/1056643002

Cr-Commit-Position: refs/heads/master@{#324127}

BUG=454959
TEST=Attach to cellular network.  A systray notification should appear,
prompting to download Data Saver.  Click to go to CWS Data Saver page.

This is a first draft, so folks can try it out.  All new functionality is behind the "enable-datasaver-prompt" experimental flag.  UMA code and possible UI tweaks still to come.

Review URL: https://codereview.chromium.org/1022333002

Cr-Commit-Position: refs/heads/master@{#324126}

BUG=

Review URL: https://codereview.chromium.org/1067033002

Cr-Commit-Position: refs/heads/master@{#324125}

BUG=N/A

Review URL: https://codereview.chromium.org/1066153002

Cr-Commit-Position: refs/heads/master@{#324124}

To test the lifecycle of a memory buffer we used to use
glCopyTextureCHROMIUM. This has some limitations due to the extension
spec (i.e: limited subset of formats), and doesn't test the general
lifecycle of the memory buffer.

This patch changes GpuMemoryBufferTest.Lifecycle to test the lifecycle
of the GpuMemoryBuffer writing directly to the backbuffer.

BUG=

Review URL: https://codereview.chromium.org/1066073002

Cr-Commit-Position: refs/heads/master@{#324123}

This makes CalculateVisibleRects try to re-use the to_target and
from_target transforms stored in transform nodes whenever it needs to
compute a transform. Since these baked transforms incorporate the
target's sublayer scale, the fallback path now also includes sublayer
scale for consistency.

Testing locally on a z620, this improves property tree computation time
by 7% on Gmail, and by 20% on rAF-driven poster circle.

BUG=474725

Review URL: https://codereview.chromium.org/1060413002

Cr-Commit-Position: refs/heads/master@{#324122}

When both a URL as Intent.EXTRA_TEXT and a screenshot as Intent.EXTRA_STREAM
present, most apps favor the latter.
So we need to use a new extra name for a screenshot so that a URL could be
prioritized as it is.

BUG=455996

Review URL: https://codereview.chromium.org/1060243002

Cr-Commit-Position: refs/heads/master@{#324121}

Don't access the canvas() through the PaintContext, to allow the
PaintContext to be backed by a DisplayItemList instead of a Canvas in
the future.

R=piman@chromium.org, sadrul
BUG=466426

Review URL: https://codereview.chromium.org/1064103002

Cr-Commit-Position: refs/heads/master@{#324120}

BUG=473408
TBR=davidben

Review URL: https://codereview.chromium.org/1067723002

Cr-Commit-Position: refs/heads/master@{#324119}

1. Use window.performance.timing instead of statsCollectionController to get page loading time.
2. Fix waiting condition to avoid racing condition

BUG=472603,467964

Review URL: https://codereview.chromium.org/1056533003

Cr-Commit-Position: refs/heads/master@{#324118}