- 12 Mar, 2018 40 commits
-
-
Nico Weber authored
Standard C++ doesn't allow implicit conversion from pointer-to-function to void*. MSVC does allow it, and so does clang-cl (but with a warning). This fixes these warnings. It also enables the warning, so that converting a function pointer to an object pointer will get a diagnostic both when targeting Windows and non-Windows. I first tried using FARPROC instead of void* all over the place (here: https://chromium-review.googlesource.com/c/chromium/src/+/937443) since having a pointer-to-function instead of a poiner-to-object seemed more correct to me. But dcheng pointed out that a void* can't be accidentally called without casting it to the right type while the FARPROC could be called with too few parameters, so now I keep the sandbox function pointers void* and just add casts where needed. TBR=jochen Bug: 550065 Change-Id: I0c369275d4b56f786cb32b2fa8d101ee12bea62d Reviewed-on: https://chromium-review.googlesource.com/957129 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#542520}
-
Becca Hughes authored
Adds two tests for MEI on Android. The first is a unit test that ensures that MEI flags are disabled on Android. The second modifies the browser tests to make sure that MEI has no effect on Android. BUG=819315 Change-Id: I6577da1dcd4fb92cb8234289cd20c7393e19dae6 Reviewed-on: https://chromium-review.googlesource.com/957730Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#542519}
-
Cary Clark authored
First step in several to move YUV support into public interfaces that are not in core, for consumption by chrome. See https://skia-review.googlesource.com/c/skia/+/110880 R=fmalita@chromium.org Change-Id: I237adcc03cd54402a2ca021dd91b821d0b2ad7db Reviewed-on: https://chromium-review.googlesource.com/941661Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#542518}
-
Michail Pishchagin authored
In Cocoa the NSTextInputContext automatically enables secure text input when activated and it's in the secure text entry mode. RenderWidgetHostViewMac did the similar thing for ages following the WebKit example. views::Textfield needs to do the same thing in a fashion that's sycnrhonized with RenderWidgetHostViewMac, otherwise the race conditions are possible when the Textfield gets focus, activates the secure text input mode and the RWHVM loses focus immediately afterwards and disables the secure text input instead of leaving it in the enabled state. BUG=818133,677220 Change-Id: I6db6c4b59e4a1a72cbb7f8c7056f71b04a3df08b Reviewed-on: https://chromium-review.googlesource.com/943064 Commit-Queue: Michail Pishchagin <mblsha@yandex-team.ru> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#542517}
-
Tom Anderson authored
BUG=None TBR=estade@chromium.org Change-Id: Ib338d415f8396d674bb80b3c076fb23645e78b51 Reviewed-on: https://chromium-review.googlesource.com/959175Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#542516}
-
Christian Dullweber authored
The test is flaky. TBR=jam@chromium.org Bug: 820995 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I2b0f7baa9491e29184595febf039fb2402358af5 Reviewed-on: https://chromium-review.googlesource.com/959014Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#542515}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 770603 Change-Id: If833ca44fbf30eaa592905d4283c593f353908af Reviewed-on: https://chromium-review.googlesource.com/958765Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#542514}
-
James Cook authored
For mash, the ash window manager runs outside the browser process. Remove direct access to ash::Shell from ChromeVoxPanel. * Init the panel widget using mus properties * Introduce mojo API for setting whether the panel should be fullscreen * Remove mash checks from AccessibilityManager * Close ChromeVoxPanel immediately on shutdown and during reloads by session state changes and multi-profile user switching. This helps prevent having multiple panels open during shutdown, especially in tests. ChromeVox doesn't read things yet under mash, but at least the panel opens now. Bug: 628655 Test: existing ash_unittests, browser_tests Change-Id: I14cbf946809787791115930ad33c1c1d3357bf88 Reviewed-on: https://chromium-review.googlesource.com/956235Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#542513}
-
liberato@chromium.org authored
This rebaselines the following tests, which had minor visual differences from their refs: media/audio-controls-rendering.html media/controls-after-reload.html media/controls-layout-direction.html media/controls-styling.html media/controls-styling-strict.html media/controls-without-preload.html media/media-controls-clone.html media/video-controls-rendering.html media/video-display-toggle.html media/video-empty-source.html Change-Id: Ic664381c7d16a85f94724d69fa65cb179ef5ea66 Bug: 612442, 654477, 821025 Reviewed-on: https://chromium-review.googlesource.com/956227 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
-
Daniel Bratell authored
Change-Id: I2a22b99caa64cc0d1c3b8d74425375b76b1dca67 Reviewed-on: https://chromium-review.googlesource.com/957737Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#542511}
-
Theresa authored
Remove BottomSheetContentController and all of the related classes/logic. The only type of bottom sheet content left is SuggestionsBottomSheetContent. There is a new ContextualSuggestionsManager that simply constructs and shows SuggestionsBottomSheetContent in the bottom sheet. This class will evolve soon. BUG=814528 Change-Id: I479deba21393b377dc228f1959624506754c502d Reviewed-on: https://chromium-review.googlesource.com/956722Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#542510}
-
Justin Cohen authored
Per feedback from dev and design, this makes the doodle too small. Ignoring new spec and reverting to old spec. Bug: 805645 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic8b01e028ef504f4d03760e67d89808fe95ed9f4 Reviewed-on: https://chromium-review.googlesource.com/957916Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#542509}
-
Michael Thiessen authored
This flag was really only for development while we weren't sure how to handle VR Intents. With Chrome VR browsing already shipped, there's no reason not to allow Intents to launch it. Change-Id: Ibbc7e5ea41668c073a4a04340ec45bfe40025b0f Reviewed-on: https://chromium-review.googlesource.com/959051 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#542508}
-
Balazs Engedy authored
-- In preparation for introducing ScopedU2fVirtualDiscoveryFactory, create a base class ScopedU2fDiscoveryFactory and let ScopedU2fFakeDiscoveryFactory derive from that. -- In preparation for a wider adoption of FakeU2fDiscovery in tests that could not care less about when a discovery starts, add a version of the fake discovery where SimulateStarted()/SimulateStopped() is called automatically. Bug: 785955 Change-Id: I4b1c9bd962c6e225be45971bbb0d5aad3b05a68a Reviewed-on: https://chromium-review.googlesource.com/959001 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#542507}
-
Alexei Svitkine authored
This reverts commit 9dd1ef42. Reason for revert: Latest canary data did not have expected recovery on Omnibox.CharTypedToRepaintLatency and had a regression on Omnibox.CharTypedToRepaintLatency.ToPaint. Reverting to see if that movement is related to this CL or whether there were other changes in the meanwhile. Original change's description: > Cache brand code on Windows. > > Querying the registry is expensive and contributes to start up time, > omnibox query time and idle. Since the brand code is not expected to > change on Windows during the course of a session, this CL caches > the value, so that future queries are free. > > This should restore the Omnibox perf that regressed by > https://chromium-review.googlesource.com/c/chromium/src/+/824363 > and also improve perf elsewhere since the caching is now done at > a lower level than that change. Since this is expensive only on > Windows, the caching is done in the Windows codepath only. > > Bug: 816698, 806130 > Change-Id: I458fad29f18b1b1ff2d55b9334ae733fa448eec9 > Reviewed-on: https://chromium-review.googlesource.com/947522 > Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541009} TBR=pkasting@chromium.org,asvitkine@chromium.org,grt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 816698, 806130 Change-Id: I09e12c17011f72f25ecb369ca3075e2067013f8a Reviewed-on: https://chromium-review.googlesource.com/958012Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#542506}
-
Fredrik Söderquist authored
We're just about to destroy said object, and since this is only issuing "local" (client-only, no ancestors) invalidations they will have no effect. Bug: 769774 Change-Id: Ib8d0afecb65a80bd89990906940e792cadcc2dcb Reviewed-on: https://chromium-review.googlesource.com/958903Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#542505}
-
Justin Cohen authored
Bug: 805636 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I38c1003c7bf4935bbc1071efad166fb113ba471b Reviewed-on: https://chromium-review.googlesource.com/957915Reviewed-by:
-
Moe Ahmadi authored
This fixes a problem on iOS where <select> elements with negative tabindex values are not being filled. This is because on iOS they are considered non-focusable and autofill manager does not autofill nonfocusable fields. This doesn't change the behavior on other platforms since filling non-focusable <select> elements is already allowed: https://cs.chromium.org/chromium/src/components/autofill/content/renderer/form_autofill_util.cc?l=881 Bug: 820618 Change-Id: Ie01f2611362dcaadf4ec22c39f645cfe51652d04 Reviewed-on: https://chromium-review.googlesource.com/959106 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#542503}
-
Jialiu Lin authored
Also added finch experiment to fieldtrial_testing_config.json Bug: 804490,818559 Change-Id: I70b0bfdaf7d59ca91f27d634363221b5f3cdb403 Reviewed-on: https://chromium-review.googlesource.com/942308 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#542502}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 770603 Change-Id: I86da709fa40b3540322c7cacf51975bd00397821 Reviewed-on: https://chromium-review.googlesource.com/958746Reviewed-by:
-
https://skia.googlesource.com/skia.git/+log/947326638a25..689d02d4b480 $ git log 947326638..689d02d4b --date=short --no-merges --format='%ad %ae %s' 2018-03-09 caryclark harden pathmeasure and fix empty case 2018-03-09 fmalita Extend SkTrimPathEffect semantics 2018-03-09 reed remove unused ConvertRadiusToSigma from SkBlurMaskFilter 2018-03-12 borenet Fix binary size analysis 2018-03-12 caryclark fail on mdout error Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I4223618e68c8ba6cd24f83bbaaf3da087e3c5c18 Reviewed-on: https://chromium-review.googlesource.com/959043 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542500}
-
Friedrich Horschig authored
Currently, the color of the search icon is changed to white by setting a ColorFilter. Because the loaded Drawable is a reference to a static resource, this means all activities using the same resource would apply the same filter. By calling |mutate| on the drawable, we receive a copy of the resource and ensure the recoloring remains local. Bug: 820038 Change-Id: I09719b05bf65e0701a0cf0e6e66b3a6322d1c515 Reviewed-on: https://chromium-review.googlesource.com/956133Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#542499}
-
https://webrtc.googlesource.com/src.git/+log/0f1c0bd3265d..b619936dee28 $ git log 0f1c0bd32..b619936de --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7a94738b719d2b3ef3b0edc3055f73c762cfda80 Reviewed-on: https://chromium-review.googlesource.com/957756 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542498}
-
sczs authored
- Moves RecentTabs behind Phase1 flag. - Renames RecentTabsFlag to Collections and moves it to feature_flags. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I93b9ed6b0b63f28639a10d67f5890333dacb0b58 Reviewed-on: https://chromium-review.googlesource.com/956092Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#542497}
-
Peter E Conn authored
This is a reland of ebe5bdf8 Original change's description: >
🤝 Use Origin class for canonically representing origins. > > Constructing origins manually and storing them in Urls is error-prone > (eg the port could be missed out) and there are discrepancies in how > the origin could be formed (eg GURLUtils has a trailing '/' while > current manually formed origins don't). This is especially important as > origins are critical to security. > > This CL creats an Origin class that offloads all the heavy lifting to > the well tested native origin class and allows the type system to > prevent the errors listed above. > > Bug: 800422 > Change-Id: I87759ea12a87f2b57bbdf40994d35ec468a43cff > Reviewed-on: https://chromium-review.googlesource.com/934289 > Commit-Queue: Peter Conn <peconn@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540825} Bug: 800422 Change-Id: I60a9531afa1cbfb0bda9b1ef4553c46c39f07f75 TBR: bauerb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/958962Reviewed-by:Peter Conn <peconn@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#542496}
-
Charles Harrison authored
Some field trial params implement things like csv or json within a particular param value. If some control characters are not %-encoded, it can lead to confusing error messages. This CL adds a hint in the error message for an invalid --force-fieldtrial-param. Bug: 783943 Change-Id: I0247e6ebf6d43c39e4002760d8bcbb053ba3f49a Reviewed-on: https://chromium-review.googlesource.com/957913Reviewed-by:
-
https://pdfium.googlesource.com/pdfium.git/+log/073b99d51c7a..0e2e8db7e6e8 $ git log 073b99d51..0e2e8db7e --date=short --no-merges --format='%ad %ae %s' 2018-03-12 brianosman Stop excluding SkDumpCanvas from Skia. It no longer exists. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ice072ad842d984317fe902469aa579c015ec9251 Reviewed-on: https://chromium-review.googlesource.com/957759Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542494}
-
Michael Thiessen authored
Bug: 820993 Change-Id: I12fe9b0a899152802d8d3e509fb8513f0356c51a Reviewed-on: https://chromium-review.googlesource.com/959048Reviewed-by:
-
Bernhard Bauer authored
Bug: b/73160522 Change-Id: Ifc93354e3f71d55ab6d5808cf0778cb06fe6efdd Reviewed-on: https://chromium-review.googlesource.com/959007Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#542492}
-
Sidney San Martín authored
Bug: 815161 Change-Id: I1c55ee5d540faab02d8383776c041dad76317f1e Reviewed-on: https://chromium-review.googlesource.com/958209Reviewed-by:
-
Luna Lu authored
Bug: 816026 Change-Id: I28fb2575e76f9f3a0dd55e8373b6909abb156f4a Reviewed-on: https://chromium-review.googlesource.com/959117 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#542490}
-
Patrik Höglund authored
It hits flaky renderer crashes. Bug: chromium:820934 Change-Id: I7d379fb5a4bfb5e50caf6109632756d7fb03b7ee Reviewed-on: https://chromium-review.googlesource.com/958519 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#542489}
-
Paul Miller authored
It was bumped down by f99c4ade, but the newly intervening shouldDisableThreadChecking() call doesn't actually have anything to do with the data directory. Move the comment back to its original location, for clarity. Change-Id: I83495386fe11cf78acd186369cd791f1962dae0d Reviewed-on: https://chromium-review.googlesource.com/958098Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#542488}
-
Daniel Bratell authored
Change-Id: I9ce1985082125ab6099f3576d6742aaed73d21d7 Reviewed-on: https://chromium-review.googlesource.com/958165Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
Tommi authored
This call got removed in my last CL by mistake: https://chromium-review.googlesource.com/c/chromium/src/+/890738 Bug: 808801, 820936, 820769, 820830, 820827 Change-Id: I6c6efb3d40d43bc564e18b013ddf5d5d3b09e1eb Reviewed-on: https://chromium-review.googlesource.com/958218 Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#542486}
-
Tibor Goldschwendt authored
This is a reland of 83931b97 Original change's description: > [vr] Add compatibility to component 1.y, check integrity of WAV files > > Bug: 811987 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I5c33b4210727b62357e0706c7b19800b98bdebc4 > Reviewed-on: https://chromium-review.googlesource.com/956251 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Christopher Grant <cjgrant@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542128} TBR=waffles@chromium.org,cjgrant@chromium.org Bug: 811987 Change-Id: I806e84ff18a771fda9ea38f2bfe435b0cdba84f2 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/958008Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#542485}
-
Jeremy Roman authored
Currently the exception is not thrown until after serialization. This makes us consistent with Gecko and WebKit, which throw before serialization. This fixes the second test case in https://github.com/w3c/web-platform-tests/pull/9672 (not yet pushed to upstream WPT). Bug: 816447 Change-Id: I30b798b5d21dc8d6f2a40d049ced6aa7f60dd090 Reviewed-on: https://chromium-review.googlesource.com/956254Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#542484}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/42dd0fcc..7e11bad4 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ibf93d6f4568d856119cda3dfcac30fb2468a938b Reviewed-on: https://chromium-review.googlesource.com/957910Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#542483}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a9778699. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13763 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: Ibe2f1dba251ca56dc114b86bba342d232950b3dc Reviewed-on: https://chromium-review.googlesource.com/957909 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#542482}
-
Misha Efimov authored
Bug: 819302 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I218c03a6a308afa265468876db28ff710a09399b Reviewed-on: https://chromium-review.googlesource.com/957126 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#542481}
-
