- 16 Feb, 2018 40 commits
-
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b55c62b2..c0a22f5a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ie384364e801af4c67cfcc7fddd942c6eec8ff6cf Reviewed-on: https://chromium-review.googlesource.com/922502Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#537222}
-
Peter Collingbourne authored
Avoid using "cmd /c" on non-Windows platforms. This fixes the Windows cross build in a couple of cases. Change-Id: I4da82e50abbc392dbd90afe34befacc9bce9a593 Reviewed-on: https://chromium-review.googlesource.com/920762Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#537221}
-
Kenneth Russell authored
TBR=jbudorick@chromium.org, machenbach@chromium.org, ynovikov@chromium.org Bug: 792780 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I423a0a2fcedf8d9caa86d53f0c6ad13147574a99 Reviewed-on: https://chromium-review.googlesource.com/923563 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#537220}
-
Siddhartha authored
BUG=791205 Change-Id: I13e256c1876d6c0ce7e3dc3044bce716666d01e5 Reviewed-on: https://chromium-review.googlesource.com/922889Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#537219}
-
Steve Kobes authored
Bug: 711468 Change-Id: I036ac47727885a4ea57367e384e9fc388b5a7bf5 Reviewed-on: https://chromium-review.googlesource.com/917422 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#537218}
-
Yuta Kitamura authored
WebTaskRunner is gone, and "Web" prefix does not make sense anymore. Bug: 794845 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I88fc46250b6c178886827967240c142bc67a4b83 Reviewed-on: https://chromium-review.googlesource.com/920126Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#537217}
-
Eric Stevenson authored
Decoding crashes on Samsung Galaxy S5 devices running L (potentially due bugs in the system libs). Bug: 807059 Change-Id: Iab24378247c3f8c460d54a6515d75f0e1396999c Reviewed-on: https://chromium-review.googlesource.com/919319 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#537216}
-
chrome://policyGanesh Borle authored
Bug: 804322 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie114ad5c38fbef3cd32b3f830eaa663596041c9d Reviewed-on: https://chromium-review.googlesource.com/908668Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#537215}
-
Ganesh Borle authored
Bug: 561800 Change-Id: I1d92457335d4ee13b7289ce3601160083702e367 Reviewed-on: https://chromium-review.googlesource.com/919021 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#537214}
-
edchin authored
This CL creates a simple grid view controller. It also adds an entry in showcase. Partly to avoid name collision, we name the single grid as a GridViewController. The parent tab switcher with multiple panels and other controls is called the TabGridViewController. Bug: 804496 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib5b06befc35408958b8613a776f2c93742137bc7 Reviewed-on: https://chromium-review.googlesource.com/920641 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#537213}
-
Mike Wasserman authored
Add plumbing to check if a content setting bubble is showing. Use that to test for bubble presence, not GetAllWidgets. See http://crrev.com/c/922268 for GetAllWidgets changes. Bug: 811940 Change-Id: I5b8e36c5dcddb8dfd407ad0f889ad74fb9804273 Reviewed-on: https://chromium-review.googlesource.com/919922Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#537212}
-
Peter Kasting authored
This upgrades --interactive to a test-launcher-scope switch (necessarily renaming it to --test-launcher-interactive) and treats it as a timeout specifier. For browser UI tests on Windows, this means the parent process will now get an (effectively) unlimited timeout and not just the child process, so the test won't terminate early. BUG=none TEST=none Change-Id: Ic94c5bff322846c2b7f69cad4b805f549dbcaa29 Reviewed-on: https://chromium-review.googlesource.com/919074 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#537211}
-
Dave Tapuska authored
Approved Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/MAHQkH4vvUQ/i0yCobrMCQAJ BUG=244688 Change-Id: I76f996b728bac093033f6e12d239cb3819616a91 Reviewed-on: https://chromium-review.googlesource.com/919201 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#537210}
-
Danyao Wang authored
With LegacyNavigationManager, Tab calls |requirePageReconstruction| to free the WKWebView so that it'll be recreated with the user agent of the newest navigation item. This approach doesn't work for WKBasedNavigationManager because deleting the WKWebView would require reconstruction of history. Luckily with iOS9+, WKWebView.customUserAgent can be updated on an existing WKWebView and will cause the new header to be sent to the server. This CL uses this mechanism to update the UA before loading a request based on the current NavigationItem. This alone only reloads the visible page with the new UA under WKBasedNavigationManager because there is no URL change. So to create a back/forward entry, the URL is reloaded using restore_session.html with a client-side redirect. This CL fixes RequestDesktopMobileSiteTestCase for new nav manager. Bug: 798836 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7f23232b10a7c83db16f545cd29445a514eaa57c Reviewed-on: https://chromium-review.googlesource.com/919175 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#537209}
-
Yuta Kitamura authored
WebTaskRunner has became SingleThreadTaskRunner. So, the class name WebTaskRunnerImpl does not make sense anymore. Bug: 794845 Change-Id: Ibdb105e889febe98a1b10f96b2f4547657f3f79d Reviewed-on: https://chromium-review.googlesource.com/920724Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#537208}
-
Koji Ishii authored
Following bot results are included. 3782 3785 3787 3788 3795 3798 3 lines were removed and 9 lines were deflaked by consecutive results since 3731. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I5983d8b830015170ad8c4ee5d90be8eac0079b96 Reviewed-on: https://chromium-review.googlesource.com/920050 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#537207}
-
Darren Shen authored
Currently StylePropertyMap.set doesn't actually work with calcs. The current way to check if something is, say, a <length> is to check its CSSStyleValue::Type. However, this doesn't return the right value for CSSMathValues, whose types may be quite complicated. The correct way is to use the CSSNumericValue matching algorthms: CSSNumericValue::MatchesLength, which also takes into account CSSMathValues and percent hints. This patch changes the following to make this work: - Removed base types from CSSStyleValue::StyleValueType. A base type like "length" is not really a CSSStyleValue type. - Removed unused StyleValueTypeToString. - Changed "Percent" to "Percentage" in CSSProperties.json5 as that's the correct term. - Changed make_cssom_types to use the matching algorithms from CSSNumericValue. Bug: 545318 Change-Id: I16aa71a4873e9992749f0f52ba641671d109170e Reviewed-on: https://chromium-review.googlesource.com/901002 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#537206}
-
John Chen authored
This reverts commit 425707a6. Reason for revert: ChromeDriver build bot lacks permission to read gs://chrome-signed/ bucket. Original change's description: > [ChromeDriver] Automatic update Android app on waterfall > > On the ChromeDriver Android build bot on the waterfall, automatically > update the Chrome app when necessary. > > Change-Id: I1af1bb8835c1fea63493b5f76a98923067744f13 > Reviewed-on: https://chromium-review.googlesource.com/907334 > Commit-Queue: John Chen <johnchen@chromium.org> > Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#535152} TBR=johnchen@chromium.org,kereliuk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ia2e5ff249bedb54d5356feb898c0c64495040ea1 Reviewed-on: https://chromium-review.googlesource.com/922325 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#537205}
-
Dominic Mazzoni authored
Based on initial user feedback, move the user profile name to the end, and don't ever include it if there's only one profile. Bug: 783479, 784676 Change-Id: I03cb9a16f5d8fd98a72afe5a4e009ef350ea3092 Reviewed-on: https://chromium-review.googlesource.com/922915 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#537204}
-
Nicolas Pena authored
This CL is the first step in merging the Performance and WorkerPerformance idls. The following are the full set of steps: 1. Rename Performance.h to WindowPerformance.h. 2. Rename PerformanceBase.h to Performance.h. 3. Merge Performance.idl and WorkerPerformance.idl. The following is roughly how it would look like after all steps are completed: https://chromium-review.googlesource.com/c/chromium/src/+/919983 Bug: 707392 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib99ade431badca0fad9bf61dbd580f3549cbab91 Reviewed-on: https://chromium-review.googlesource.com/922927Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#537203}
-
Takeshi Yoshino authored
Bug: 812960 Change-Id: I1bb1f5db9bdc5ceb7ca73ee52ac7edc0ad5545f9 Tbr: rsleevi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/923502 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#537202}
-
Miguel Casas authored
This CL extracts VaapiDecodeSurface out of VaapiVideoDecodeAccelerator into a file on its own, because vaapi_video_decode_accelerator.cc is quite large at 1902 lines. It also introduces =default and adds DISALLOW_COPY_AND_ASSIGN to the extracted class. Otherwise no new code, just moving things around. There's also a side bonus: VaapiVideoDecodeAccelerator::VaapiDecodeSurface uses are shortened in vaapi_video_decode_accelerator. Test: Compile and run in simplechrome on soraka. Ran vp8, vp9 videos of crosvideo.appspot.com, verified GpuVideoDecoder engaged. Bug: 717265 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ibd7c88357b2f993a5d72e45f65dfff5d67c4194a Reviewed-on: https://chromium-review.googlesource.com/922981 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#537201}
-
Miguel Casas authored
6630558 10 bit YUV to 10 bit BGR by Frank Barchard Bug: libyuv:777, Change-Id: Ib8c2f19b702585785562ea8d2ed80fd497eeedb4 Reviewed-on: https://chromium-review.googlesource.com/922984Reviewed-by:
Frank Barchard <fbarchard@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#537200}
-
Yi Gu authored
In patch https://chromium-review.googlesource.com/906830 we renamed cc side animation related classes but there are some variables missing, e.g. animation_id instead of keyframe_model_id. This should be fixed before next patch which will rename AnimationPlayer to Animation so that it won't conflict with the new "animation_id". Bug: 807667 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id5a8d07a7e551fff78b746728fce3dd139bb5b21 Reviewed-on: https://chromium-review.googlesource.com/922342Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#537199}
-
Mike Reed authored
This is needed to enable the starter impl CL for decal: https://skia-review.googlesource.com/c/skia/+/107420 Bug: skia:7638 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I00638d8f54b48e8a0b04b10c2c0a556e0c6023ae Reviewed-on: https://chromium-review.googlesource.com/922804Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Mike Reed <reed@chromium.org> Cr-Commit-Position: refs/heads/master@{#537198}
-
James Cook authored
Picks up this change: Author: James Cook <jamescook@chromium.org> Date: Thu Feb 15 14:30:24 2018 -0800 checkdeps: Add "noparent" support, similar to OWNERS files Adding "noparent = True" to a DEPS file will cause that directory not to inherit rules from its parents. This is useful for a directory like //ash/components, where you want each component to explicitly declare all its dependencies and not inherit from the long list in //ash/DEPS. Bug: 812299 Test: added to checkdeps_test.py TBR=dpranke@chromium.org Bug: 812299 Change-Id: I59d2f18780b82cc40bbba5bcfa8a623f3023bea5 Reviewed-on: https://chromium-review.googlesource.com/923389Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#537197}
-
Evan Stade authored
This was added due to TetherNotificationPresenter being a MessageCenterObserver that modifies the message center. That was only the case due to a misunderstanding (it should have used NotificationDelegate) and is now fixed. No MessageCenterObserver instance should modify the MC during iteration. The change queue made that possible, but that just allowed abuse of MessageCenterObserver. Bug: 795331 Change-Id: I25f94853e0c8b29f3929d7459ed3cd3bfd2ed780 Reviewed-on: https://chromium-review.googlesource.com/829983 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Mitsuru Oshima (In Tokyo) <oshima@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#537196}
-
Tommy Steimel authored
This CL makes CSS and structural changes to audio-track-only videos to make the controls look like audio controls. This solves an issue where the controls are not visible/usable on MediaDocument for audio files, since MediaDocument uses a video tag with an audio source. This change only applies for modern media controls. Bug: 811377 Change-Id: Ic73f65585c19047dec1d5904b50c7c4be496c5f5 Reviewed-on: https://chromium-review.googlesource.com/917610 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#537195}
-
Kent Tamura authored
Probably, this CL doesn't change behavior. Either of the elements is <span>, another is one of an element for which IsElementForRemoveFormatCommand() returns true. So, there should be no differences between CloneDataFromElement() and CloneAttributesFromElement(). Change-Id: Ia95e156411fef3decded414e1c08c5c99497a063 Reviewed-on: https://chromium-review.googlesource.com/920966Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#537194}
-
Ashley Enstad authored
We are down to one waterfall json generated by this file so we should have easier to read code. Bug: 781312 Change-Id: I9e3c770691362690c5967947001ebf219844ca8c Reviewed-on: https://chromium-review.googlesource.com/923282 Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#537193}
-
Naina Raisinghani authored
Bug: 812432 Change-Id: If94615836edd6413b211acc323c6d8644ffcbda3 Reviewed-on: https://chromium-review.googlesource.com/920326 Commit-Queue: nainar <nainar@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#537192}
-
Eve Martin-Jones authored
Remove existing single OS enabled_features from BUILD files. Update existing flags to match GN-style names where needed. Change-Id: I052c1b25d2ee79194fe82132df59fd95cce88598 Reviewed-on: https://chromium-review.googlesource.com/920561Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Eve Martin-Jones <evem@chromium.org> Cr-Commit-Position: refs/heads/master@{#537191}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I1530eca57ad6000ec87eff1160d31c9e9515043b Reviewed-on: https://chromium-review.googlesource.com/923581Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#537190}
-
Lakshmi Kumar Dabbiru authored
Specifically if it had a valid card number and/or expiration date. Change-Id: I8303aaa6658ee233864ff7ec52f23538280a3beb Reviewed-on: https://chromium-review.googlesource.com/890080 Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#537189}
-
Alexander Alekseev authored
Bug: 812581 Change-Id: Idb9ff4831263c31b21292342804bd6633f993878 Reviewed-on: https://chromium-review.googlesource.com/923412Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#537188}
-
Kunihiko Sakamoto authored
Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/T-OkMDASYfk Bug: 740886 Change-Id: I494bc350b5a7eaa2d3f46e4fa948ef1c3b014d37 Reviewed-on: https://chromium-review.googlesource.com/923221Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#537187}
-
Peter Boström authored
Covers widget dialog title sentence case for bookmark_component_strings.grdp. TBR=blundell@chromium.org Bug: chromium:810111 Change-Id: I7e0fda476aaaf43d7906a50e302fd4ccc9227142 Reviewed-on: https://chromium-review.googlesource.com/917424Reviewed-by:
Rachel Blum <groby@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#537186}
-
Tetsui Ohkubo authored
This CL * Adds a new flag --enable-ash-new-system-menu. We already have --enable-ash-sidebar flag, but we are going to do system menu restyling and system menu & notification center integration separately. Alternative considered: Instead of adding a new flag, we considered using FeatureVariation in about_flags.cc, but it seems no one in ash/ is using this, and the primary use case of FeatureVariation looks different from this. * Changes background and icon colors of system menu. These views are still subject to change, or will be even removed, as they are still largely different from the spec. Spec: http://shortn/_1MHrIdbuHM Design doc: go/cros-qs-restyling TEST=manual BUG=811641 Change-Id: I8da914e02ebfe67519f07ea3b9f3ee16c96ccbff Reviewed-on: https://chromium-review.googlesource.com/917842 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#537185}
-
Yuzhu Shen authored
So that we could get more consistent data across runs. BUG=717744 Change-Id: I78eba114b1d4b603448725fefcc20ce3a3e1db71 Reviewed-on: https://chromium-review.googlesource.com/919314Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#537184}
-
Takayoshi Kochi authored
M65 is already branched, and we have to put off at least 2 milestones before the removal. Bug: 523952 Change-Id: I1aa3950a07bbf12720e7aed8d94f3f6e3e380d2e Reviewed-on: https://chromium-review.googlesource.com/921002 Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#537183}
-