- 07 Nov, 2019 40 commits
-
-
Eric Roman authored
Bug: 1021236 Change-Id: Ib6d9239de1291281fd01fd683b9df88fc6427085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898623Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Eric Roman <eroman@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#713578}
-
Avi Drissman authored
It's not used any more, and the calling script was changed to no longer provide it. Bug: 913074 Change-Id: I01250b226eddb40fd4d523c75f9132c97629a8be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904232 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#713577}
-
Jeremy Roman authored
This saves about 90 kB of Android APK size, and should be nearly as fast. This adds up mainly because we have a sufficient number of Mojo methods that this code is very heavily repeated. For example, network::mojom::NetworkContextRequestValidator::Accept (1,592 bytes) is replaced with a 24-byte function and a 720-byte table, and the strings "NetworkContext RequestValidator" and "NetworkContext ResponseValidator" are replaced with a single "NetworkContext" that may even be further deduped. Change-Id: I772145a839b9607098311b3309fd49e94e43991e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896773 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#713576}
-
Jacques Newman authored
Fix: Modified the decrease in level logic to only be applied when the node would be part of a set. Bug: 1021279 Change-Id: I26fa167cb062d36599d38f20a41eededd74f8bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893118 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#713575}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/50d2ff30828b..5d41eaf0f6ae git log 50d2ff30828b..5d41eaf0f6ae --date=short --no-merges --format='%ad %ae %s' 2019-11-07 skyostil@google.com Merge "Lift function debug signature into a compiler specific macro" 2019-11-07 lalitm@google.com trace_processor: rework xBestIndex handling by making it more flexible 2019-11-07 lalitm@google.com trace_processor: fix broken iteration logic in thread and proces tables 2019-11-07 lalitm@google.com trace_processor: add missing new/legacy views Created with: gclient setdep -r src/third_party/perfetto@5d41eaf0f6ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135177627 Change-Id: I30a65b202867a91e1ec513faaadbd2b8e9578c8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903888Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713574}
-
Dave Tapuska authored
Define shared skia component for the mojom traits so it can link correctly. Remove unused image_filter_mojom_traits.cc and the skbitmap_for_blink.typemap that is unneeded in this refined setup. BUG=1008432 Change-Id: I8045cdeff554ea471875d1bf0f276287db208db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899316Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
-
ckitagawa authored
The fuzzer found a pathological case when the section size is 0 but the offset is outside of image. This resulted in header parsing skipping the section since the size was 0; however, later processing creates a region of size 0 that is outside the image causing checks to fail. The solution here is to check if the offset is outside the image and the size is 0. This suggests that the data is ill formed and we should reject the image entirely. Bug: 1019271 Change-Id: If47d099aa4f919b097d4e15804048eaf64a59201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903886Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#713572}
-
Sarthak Shah authored
This CL plumbs the viewport size to the fling controller. There will be follow up CL which will utilize this value for configuring fling animation curve. Fling curve uses the viewport size to determine the upper bound on how much distance a fling can travel/scroll. Bug: 647137 Change-Id: I25896d9c514661ecc16e4f98b28e3d7c1f3b9f2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884758 Commit-Queue: Sarthak Shah <sarsha@microsoft.com> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#713571}
-
Andrew Xu authored
This CL adds user actions for pressing the home button and the back button. Bug: 1018916 Change-Id: I0d97812cbe53a0334dff7c32bbe016bd82d41c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900389Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#713570}
-
Jorge Lucangeli Obes authored
We're still seeing good progress in the clean-up tracked by this histogram but it will probably be safer to remove the code in M81 rather than in M80. BUG=980946 Change-Id: I42039e2a747f84c13d8fb684bf6aa07c40d33bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901426Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#713569}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e9f663c8cb8c..7c1fb4156d24 git log e9f663c8cb8c..7c1fb4156d24 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 peah@webrtc.org Removing old scheme for dumping internal AGC diagnostic data 2019-11-07 mbonadei@webrtc.org Remove double declaration of cricket::kH264CodecName. 2019-11-07 sprang@webrtc.org Fixes incorrect probe timing check. 2019-11-07 ilnik@webrtc.org Enable FEC protection of packets with VideoTimingExtension Created with: gclient setdep -r src/third_party/webrtc@7c1fb4156d24 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I474f9f903bb988b011d94e5260ec2df6ab90e078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903651Reviewed-by:
-
Xiaocheng Hu authored
This patch migrates the Blink CSS minifier to GRIT and applies it whenever GRIT creates a CSS resource. This allows us to minify all CSS resources in a unified and effortless manner. As a result, this patch achieves 12k Android binary size reduction: https://ci.chromium.org/p/chromium/builders/try/android-binary-size/368229 Bug: 1015410 Change-Id: Ief8efe57d26f2e26c3b53523d8c973d1d193d20b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900259Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#713567}
-
Ken Rockot authored
DataDecoderService is currently set up to allow only a single client pipe. This is reasonable for the out-of-process case in most production environments. For the in-process case (in tests and on iOS) however, it is possible and reasonable for a single instance to have multiple DataDecoderService pipes connected to it. This upgrades the lone Receiver to a ReceiverSet, allowing for multiple clients. Fixed: 1022313 Change-Id: Iaeea6e1b1316351da0b6f57ae4a432eed62b5575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903748Reviewed-by:
-
Jamie Walch authored
Change-Id: I060578b0ca87d4eecd5fed2ab35fbffee6cb5aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902275 Auto-Submit: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#713565}
-
Jacques Newman authored
Images with an explicitly empty alt attribute should be ignored. Images that do not have the alt attribute explicitly empty will have automatic image annotation done when possible, so we shouldn't ignore them. Bug: 1018853 Change-Id: If8f95d8ed7376797e24707047b5b291bde1555bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881124 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#713564}
-
Scott Violet authored
These got lost in the rename. BUG=none TEST=none TBR=jam@chromium.org Change-Id: I0273dd26860950d0eb87215f84914d5c511205f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903758Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#713563}
-
Yi Xu authored
Enable web developers to be able to update ImageRendering quality on OffscreenCanvas. When ImageRendering quality changed between auto and pixelated, the OffscreenCanvasPlaceHolder sends the update to CanvasResourceDispatcher to update the CanvasResource of OffscreenCanvas. Demonstration of classes interaction: https://docs.google.com/document/d/1M-E7euqa7fLLcUlgPkPAtVMck7s7u0hmsA-uLL1H7J0/edit tests added: OffscreenCanvasImageRenderingAuto.html OffscreenCanvasImageRenderingPixelated.html Bug: 1001335 Change-Id: I9846d8ba851d55270a2a3e0380bd76a6b924a742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779188 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#713562}
-
Chris Harrelson authored
Previously, we would fail to call NotifyBeforeLayout for all such ancestors that are scrollers, causing subtree layouts to completely fail to maintain a scroll anchor for such ancestors. Bug: 920289 Change-Id: I899634949739f5d4f3af1f282b598cbc4ef0e3e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902767 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#713561}
-
Xiaohan Wang authored
When the "Protected content" permission decision is different from the default value, "Protected content" will show up in the PageInfo. See screenshots at: https://photos.app.goo.gl/Rmd5S75gTUNU7vZVA Similar change on Android will be done in a separate CL. Bug: 593210 Test: Manually tested. See screenshots linked above. Change-Id: I4200ec867f143edc67a1215dc9dc755575c89a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900113Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#713560}
-
Lei Zhang authored
Move content::AccessibilityTreeFormatter::FormatAccessibilityTree(), which exposes BrowserAccessibility, to AccessibilityTreeFormatterBase, and rename it to FormatAccessibilityTreeForTesting(), since the only caller is in test support code. Then introduce content::TestBrowserAccessibility, which is an opaque class that represents content::BrowserAccessibility. Use it inside content/public/test to avoid exposing BrowserAccessibility publicly. With TestBrowserAccessibility, add a static FormatAccessibilityTree() method to give tests access to FormatAccessibilityTreeForTesting(), which this CL took away from AccessibilityTreeFormatter. Change-Id: Ie89bfb6284f639fe3b8c34155b706b3808bdb4fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900360 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#713559}
-
Tibor Goldschwendt authored
Change-Id: If996bf87eb9903ffd92257967c8f63ab2a24a298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903757 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#713558}
-
Andrew Grieve authored
Found via SuperSize query: size_info.symbols.WhereFullNameMatches(r'\bk[A-Z]').WhereInSection('d') TBR=agrieve # Trivial refactor Bug: 747064 Change-Id: Ib9615718e0f6cacb081f9ea2f5295348d32cdcb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901641 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#713557}
-
Gang Wu authored
Bug: 1022086 Change-Id: I925c5d170a32988db678dafb3daf73c0d231681f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902241 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#713556}
-
Dominique Fauteux-Chapleau authored
Add Windows specific code to test registry provider blocked by the policy. Bug: 1019160 Change-Id: I5ae7c383028b2a6a51075d76b60ae01dc507034c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893572Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#713555}
-
Peter Kotwicz authored
This CL adds CustomTabActivityTabProvider#registerTabObserver() CustomTabActivityTabProvider#unregisterTabObserver() These methods register (and unregister) a TabObserver for the CustomTabActivity's active tab. The tab being observed is changed when the CustomTabActivity's active tab changes. This differs from TabObserverRegistrar#registerTabObserver() which registers the passed-in TabObserver for all newly created tabs. BUG=1020911 TEST=TabObserverRegistrarTest.testObserveActiveTab Change-Id: Ie5c4b8f287209b672e89184a3e9f0710c69102ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896140 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#713554}
-
Peter Kasting authored
We want this to happen every time a row is BUTTON_FOCUSED. Hoisting it to the location where that's actually handled guarantees this and results in shorter code. It also makes more sense for the popup model to be instructing the result views of this than it does OmniboxViewViews, which ideally wouldn't know much about the popup views. Bug: none TBR: stkhapugin Change-Id: I0b1da7d8d459f79f25dc7246dc7a1c4c81e9f25e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900254Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#713553}
-
Toni Barzic authored
Calling OnHomeLauncherTargetPositionChanged() can change shelf bounds, which in turn causes display work area update, and window bounds change. With cross fade bounds update the window transition to home screen looks broken (as cross fade creates a layer copy that is not animated). There's an open bug to fix excessive work area updates, but in the meantime, disabling the window animations while calling OnHomeLauncherTargetPositionChanged() works around the issue. BUG=1005366 Change-Id: Idf97b88204984660831cd6b025d5bdd93b7bd958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902480Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#713552}
-
Nicolás Peña Moreno authored
This CL uses ParseCommaDelimitedHeader() to split the header into strings before doing any processing on the string. In particular, the UseCounter for '*' now includes headers with star but extra whitespace, such as ' *'. Change-Id: I31cc61b83b13b88fb8e460a609bca3f983ba8eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898437 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#713551}
-
Reid Kleckner authored
The new version was built from LLVM revision e0dd8f36ce49f47099e56e317207de5304a1ccbb, and has a fix for crbug.com/1019517. I tested that the new dsymutil works by locally building tls_edit with a new version of clang and this dsymutil version on Mac. R=ellyjones@chromium.org, thakis@chromium.org Bug: 1019517 Change-Id: If3e787b438fd55c327205568a94660114ae8319f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904090Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#713550}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9ab047e78be3..72a245e4c678 git log 9ab047e78be3..72a245e4c678 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 gbeaty@chromium.org Fetch the input commit ref when both ref and id are specified. Created with: gclient setdep -r src/third_party/depot_tools@72a245e4c678 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:922150 Change-Id: Ic5461d34fbbbfb7cc57d4a0651f544ab4d89219c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903965 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/48dc2da07f5b..afa7840d8e0c git log 48dc2da07f5b..afa7840d8e0c --date=short --no-merges --format='%ad %ae %s' 2019-11-07 cjmcdonald@chromium.org Revert "DependencyService: Provide exact eclass dependency paths" Created with: gclient setdep -r src/third_party/chromite@afa7840d8e0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I366a74a7112265e6036acbcfda643b4a13966976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903648Reviewed-by:
-
Vladislav Kaznacheev authored
This is a reland of b2af1539 which was reverted due to being pointed out by SoM as a cause of an Android compile failure. Original change's description: > Fix crash when exiting mirror mode on tablet > > Attempting to create ShelfWidget while shelf is in-app is causing > a crash because ShelfWidget::DelegateView::UpdateOpaqueBackground is > called before the widget is initialized. > > Moving that call from ShelfWidget::DelegateView constructor into > ShelfWidget::DelegateView::OnWidgetInitialized. > > Added a unit test. > > Bug: 1021662 > Test: manual, DisplayManagerTest.ExitMirrorModeInTabletMode > Change-Id: I32a5f91c834d673b109ab518bc2600908d8dea5c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902273 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Manu Cornet <manucornet@chromium.org> > Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713464} TBR=oshima@chromium.org Bug: 1021662 Change-Id: If28233c15d870fca0c9f6818e9031d98276bfe16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904159 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
-
Jeroen Dhollander authored
This CL introduces the Autotest APIs used to test that the |NEW_READY| signal is sent out when the Assistant is ready to handle queries. Change-Id: I1dd1c366dece11be8b4c6c84e6a5c808bb110453 BUG: b/143381021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881968 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#713546}
-
Tobias Sargeant authored
Change-Id: Ia3add86b7cab7697b5f48f6412932563cbd8af2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901084Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#713545}
-
Hongchan Choi authored
See details in: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVySQsSBUZsYWtlIj5jaHJvbWl1bUBicm93c2VyX3Rlc3RzQFdlYkJsdWV0b290aFRlc3QuV2ViQmx1ZXRvb3RoQWZ0ZXJDcmFzaAw TBR=reillyg@chromium.org Bug: 1022321 Change-Id: I01fcb892eea350bc60a05fc8f5b1aab9088cffc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904191Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Auto-Submit: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713544}
-
Wei-Yin Chen (陳威尹) authored
Add some basic render tests in StartSurfaceLayoutTest, including a test for INITIAL_SCROLL_INDEX_OFFSET. Bug: 983170 Change-Id: Ie06cd2f3620a980b3c095eb0619704a7c714fd68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903402 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#713543}
-
Scott Violet authored
This informs observers of events related to the set of tabs. BUG=none TEST=TabListCallbackTest* Change-Id: I6e1975f7d59ffcf1a92dce072fc7d8f0194f10ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902130 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#713542}
-
David Benjamin authored
Client certificates involve unnecessary IO/UI hops. We go from network service to UI to IO (for ClientCertStore) to worker, back to IO, to UI, back to IO, and then back to network service. The IO thread is just a remnant of the old ResourceDispatcherHost logic where everything lived on the IO thread, because ClientCertStores live on IO. This CL moves the ClientCertStore to the UI thread (it just wraps an async worker PostTask) which then drags the rest along with it. Two complications: 1. We now need to worry about reentrant callbacks. To avoid surprising callers, I've added PostTasks where necessary. 2. CrOS's ResourceContext dependency is messier. See https://crbug.com/1018972 for a summary. This CL hides a UI/IO round-trip in ClientCertFilterChromeOS for now. This is still the same number of thread hops as before. Notes for reviewers: start by reading the (tiny) //content/public changes. The rest of //content can be reviewed relative to the API change. chrome_content_browser_client.{cc,h}, chrome/browser/profiles and chrome/browser/net can then be reviewed as one unit. chrome/browser/chromeos/certificate_provider can be reviewed as a unit. This CL just removes the now unnecessary thread-hopping. Finally, chrome/browser/chromeos/net preserves the CrOS threading constraints, and the rest is mechanical. Bug: 1011576 Change-Id: I414077aa8979753a2b6418b9dd437eba566701a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888118 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#713541}
-
meacer authored
Bug: 991726 Change-Id: I9083f49ea712cecd0f23d1c434c3d8d813d36137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903749 Auto-Submit: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#713540}
-
James Vecore authored
The Bluetooth toggle button disables itself after being pressed while the hardware state is changing (to prevent click spamming) and re-enables when the new state takes effect. The problem is that Chromevox is reading the disabled state after a toggle and never announces the updated enabled state after the hardware state is applied. By making the element "aria-live" we request that Chromevox announces the new state when the element state changes. This solution results is some spammy Chromevox output, but that is better than never announcing the state change at all. Fixed: 1007378 Change-Id: I0632138bdea96c56edb0a0f1b9cca05d3ca2d9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895255Reviewed-by:
-
