GitLab

Also update the attribute name to "value" to match the spec, and
change the type to a plain String, to avoid interning random
developer strings inside AtomicString when we don't need to.

In the original spec for Typed OM, every StyleValue subclass was
immutable, so you'd need to create new ones if you wanted to udpate
something. It turns out that this can be expensive due to garbage
collection churn, and it's now been changed so that StyleValue
subclasses are mutable.

CSSKeywordValue spec (note no "readonly" keyword on value now)
https://drafts.css-houdini.org/css-typed-om/#csskeywordvalue

BUG=545318

Review-Url: https://codereview.chromium.org/2893823002
Cr-Commit-Position: refs/heads/master@{#474962}

This is added so that we can compare the impressions in old UI and
the new one.

BUG=720231

Review-Url: https://codereview.chromium.org/2897233002
Cr-Commit-Position: refs/heads/master@{#474961}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/45f760062ed4..91b60843fbfc

$ git log 45f760062..91b60843f --date=short --no-merges --format='%ad %ae %s'
2017-05-25 dtu [pinpoint] Add iron-form and paper-checkbox to polymer components.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ibbae2549597d3cfd8ccb7c3adeca8bae0697d765
Reviewed-on: https://chromium-review.googlesource.com/516806
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474960}

This patch generates diffs for all fields on StyleRareInheritedData

Future work: Remove all references to StyleRareInheritedData in
ComputedStyle.h

Diff: https://gist.github.com/7db928ec119076f5526f3f6d2117d407/revisions
Review-Url: https://codereview.chromium.org/2897193005
Cr-Commit-Position: refs/heads/master@{#474959}

When we generate RareNonInheritedData, we would no longer generate
helper methods like ReflectionDataEquivalent. These need to be
handwritten in ComputedStyle. This patch moves these helper methods
from RareNonInheritedData to ComputedStyle.

This is preparation for generating RareNonInheritedData.

BUG=628043

Review-Url: https://codereview.chromium.org/2907713002
Cr-Commit-Position: refs/heads/master@{#474958}

TBR=gsennton@chromium.org,isherman@chromium.org

Bug: 725379
Change-Id: I20682c13346285b427b94f04300eb2056f0b5835
Reviewed-on: https://chromium-review.googlesource.com/517003Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474957}

GetSystemCommitCharge() isn't available. It likely won't be as the
general system design doesn't allow a process much information other
than about itself.

EnableTerminationOnHeapCorruption() doesn't have an analog (at least
today).

GetParentProcessId() doesn't have a direct mapping. We could retrieve
the parent job, but that wouldn't be a process. In any case, getppid()
isn't implemented, so the test would currently fail.

Bug: 706592
Change-Id: I218f80d92a64e92ac3f49aa21ec55ef522cd0435
Reviewed-on: https://chromium-review.googlesource.com/516523
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474956}

Rename StringCallback to FunctionStringCallback
in DataTransferItem interface.

spec:
https://html.spec.whatwg.org/#the-datatransferitem-interface

BUG=701477

Review-Url: https://codereview.chromium.org/2896183002
Cr-Commit-Position: refs/heads/master@{#474955}

Currently we have wpt tests verifying Clients.{get,matchAll} can return
clients with type 'window' or 'sharedworker' correctly, this CL adds
support for another type 'worker'.

BUG=705685
TEST=blink_tests

Review-Url: https://codereview.chromium.org/2884843004
Cr-Commit-Position: refs/heads/master@{#474954}

This is done in order to improve UX by getting rid of a "minibar" toolbar
(to be done in a follow-up patch) and bring more app-like feel to PWAs.

In a long run this will help bring implementation of Minimal-UI, which requires
replacing "minibar" with a new "minimal-ui" toolbar.

BUG=709889

Review-Url: https://codereview.chromium.org/2829943002
Cr-Original-Commit-Position: refs/heads/master@{#474625}
Committed: https://chromium.googlesource.com/chromium/src/+/7c7e9e600d256af4d2af1dbf68b59b030be0ab25
Review-Url: https://codereview.chromium.org/2829943002
Cr-Commit-Position: refs/heads/master@{#474953}

PageHandler::ScreencastFrameCaptured creates a gfx::Image and uses it on
another sequence. However, the usage causes a data race as gfx::Image has
a non-threadsafe ref count internally, and its copies can't cross sequences. 

Bug: 600237, 725706
Change-Id: I645d529db1b8887b3c67f81a7916cdab0940b1d0
Reviewed-on: https://chromium-review.googlesource.com/513665Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Taiju Tsuiki (tzik) <tzik@google.com>
Cr-Commit-Position: refs/heads/master@{#474952}

Bug: 719439
Change-Id: I3e742aa5ffe59a9ad8be87af522cba22d2941c11
Reviewed-on: https://chromium-review.googlesource.com/516903
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474951}

This patch makes TextIndentType an enum class for better type
safety.

BUG=684966

Review-Url: https://codereview.chromium.org/2905493008
Cr-Commit-Position: refs/heads/master@{#474950}

Currently, the word-break property is a 'storage_only' field,
so it has no generated public getters/setters. This patch changes it to
a 'keyword' field so that its getters/setters can be generated as well.
We also generate the EWordBreak enum and use the generated
CSSValueID <-> EWordBreak mappings.

Diff of generated files:
https://gist.github.com/0d411e2cb2db07f1d076383656211816/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2898363002
Cr-Commit-Position: refs/heads/master@{#474949}

This change refactors the CSS ConversionCheckers to inherit from a common
CSSConversionChecker class that removes some of the boiler plate code in
using the InterpolationEnvironment.

This patch introduces no changes in behaviour.

BUG=671904

Review-Url: https://codereview.chromium.org/2812213002
Cr-Commit-Position: refs/heads/master@{#474948}

Moves another event handling flow from CVC to ViewAndroid:

- Introduced a new native class for drag event (DragEventAndroid)
- Updated ViewAndroid to handle both drag/motion events
  in its hit testing logic.
- Clarify that layout in VA is in CSS unit, which was not
  clear and prone to error.

Tested manually with target sdk set to 25.

BUG=622847

Review-Url: https://codereview.chromium.org/2896993002
Cr-Commit-Position: refs/heads/master@{#474947}

This patch adds class level comments to ComputedStyle. A future patch
will document ComputedStyleBase as well.

Review-Url: https://codereview.chromium.org/2892483003
Cr-Commit-Position: refs/heads/master@{#474946}

This patch adds class level comments to ComputedStyleBase.

Review-Url: https://codereview.chromium.org/2886093002
Cr-Commit-Position: refs/heads/master@{#474945}

This patch makes TextEmphasisMark an enum class for better type safety.

BUG=684966

Review-Url: https://codereview.chromium.org/2900633003
Cr-Commit-Position: refs/heads/master@{#474944}

BUG=

Review-Url: https://codereview.chromium.org/2907463003
Cr-Commit-Position: refs/heads/master@{#474943}

Annotation unique_id of components/certificate_reporting/error_reporter.cc was
not unique and is updated.

BUG=656607

Review-Url: https://codereview.chromium.org/2902893003
Cr-Commit-Position: refs/heads/master@{#474942}

The disclosure can now be shown for and HTTPS search engine that has
been set to the default, and which uses the geolocation API.

BUG=700250

Review-Url: https://codereview.chromium.org/2909583002
Cr-Commit-Position: refs/heads/master@{#474941}

renamed
* maximize_mode_xxx files to tablet_mode_xxx
* Class name MaximizeModeXxx to TabletModeXxx
* variable names maximize_mode(xxx) to tablet_mode(xxx)
* comments "maximize mode" to "tablet mode"

BUG=726476
R=skuhne@chromium.org, sky@chromium.org, reveman@chromium.org
TEST=None

Review-Url: https://codereview.chromium.org/2906803002
Cr-Commit-Position: refs/heads/master@{#474940}

Bug: 719439
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I894af08090aace180312dfc11d2d773d35cd6d3f
Reviewed-on: https://chromium-review.googlesource.com/516862
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474939}

Add boilerplate based on libevent and/or posix versions of these. This
is just a mechanical change so that subsequent CLs will be more able to
focus on the meat of the implementations of these classes without
getting excessively large.

Bug: 706592
Change-Id: Ia9e1356a863576acdf5ba7892f3fe853386e928c
Reviewed-on: https://chromium-review.googlesource.com/516486
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474938}

Also, increase tests version for Mac (previously enabled in https://codereview.chromium.org/2783053002)

BUG=686608

Review-Url: https://codereview.chromium.org/2841443002
Cr-Original-Commit-Position: refs/heads/master@{#472023}
Committed: https://chromium.googlesource.com/chromium/src/+/386add8ced87b5b0c91d4f91b0f3e41be71c3d2c
Review-Url: https://codereview.chromium.org/2841443002
Cr-Commit-Position: refs/heads/master@{#474937}

Currently, the speak property is a 'storage_only' field,
so it has no generated public getters/setters. This patch changes it to
a 'keyword' field so that its getters/setters can be generated as well.
We also generate the ESpeak enum and use the generated
CSSValueID <-> ESpeak mappings.

Diff of generated files:
https://gist.github.com/aba737ebdcd44f1ee7c05cf332c64324/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2896723003
Cr-Commit-Position: refs/heads/master@{#474936}

This CL ensures that the diff functions are generated in the order that
they are specified in the JSOn input file as opposed to in the alignment
order as specified in the groups.

Diff: https://gist.github.com/ffa56bb0036497ad3a104a1e2f79d0bf/revisions

BUG=710938

Review-Url: https://codereview.chromium.org/2911593002
Cr-Commit-Position: refs/heads/master@{#474935}

Cr-Commit-Position: refs/heads/master@{#474934}

BUG=726358

Review-Url: https://codereview.chromium.org/2906783002
Cr-Commit-Position: refs/heads/master@{#474933}

These wraps were overlooked in crrev.com/2622043003.

Replaces many of the calls to RefPtr::Release with a std::move wrap,
which returns a RefPtr instead of a PassRefPtr. As the code currently
stands, most methods still expect a PassRefPtr and so the RefPtr is
implicitly converted to a PassRefPtr.

Future patches will change the types passed from PassRefPtr to RefPtr.

Does not handle RefPtr::Release calls in return statements that
default to move. This will be handled in a future patch.

BUG=494719

Review-Url: https://codereview.chromium.org/2905823003
Cr-Commit-Position: refs/heads/master@{#474932}

Also update tests to check for private memory footprint on Windows, which is now
implemented.

BUG=

Review-Url: https://codereview.chromium.org/2904703002
Cr-Commit-Position: refs/heads/master@{#474931}

Now that shared memory's unique ids are portable, shared memory usages
can be counted. This CL inserts incrementing and decrementing shared
memory usages when map/unmapped.

BUG=604726

Review-Url: https://codereview.chromium.org/2867193004
Cr-Commit-Position: refs/heads/master@{#474930}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/621c724fe4f9..45f760062ed4

$ git log 621c724fe..45f760062 --date=short --no-merges --format='%ad %ae %s'
2017-05-25 rnephew [Telemetry] Add ability to check if device has AOSP build to android platform backend.

Created with:
  roll-dep src/third_party/catapult
BUG=713222


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I41e298e1e172af495c7930c82a4a0bf1608b8897
Reviewed-on: https://chromium-review.googlesource.com/516510
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474929}

In CSSProperties.json5, to deal with type_names that are defined in
other files, we use the "field_type_path" parameter. For example, if we
wanted to use "Length" as the type_name, we can specify
"field_type_path" as "platform/Length" and the generator will
automatically include "platform/Length.h". We would also deduce that
the type_name is Length. However, this does not cater for type_names
like "Vector<String>", where multiple files need to be included.

This patch generalises "field_type_path" to "include_paths", which is
simply a list of files containing definitions for the types in
type_name. Since "include_paths" can contain multiple files, we can no
longer deduce the type_name, so we have to explicitly specify the
type_name.

BUG=628043

Review-Url: https://codereview.chromium.org/2904483003
Cr-Commit-Position: refs/heads/master@{#474928}

To avoid duplicate reports, this CL adds an ExpiringCache, keyed by
request hostname+port, to not send repeated Expect-CT reports.

As noted in a comment, it's possible that the same host+port could generate
legitimately different Expect-CT reports and it could be useful for the server
operator to receive both of them. However, this seems unlikely to happen in
practice. In a future refactor in which we move the Expect-CT reporting code
into //net, it would be easier to use more of the report contents as the cache
key (so that meaningfully different reports would not share a cache key), but
keying by host+port should suffice for now.

BUG=679012

Review-Url: https://codereview.chromium.org/2901183002
Cr-Commit-Position: refs/heads/master@{#474927}

This patch makes EImageRendering an enum class for better type safety.

BUG=684966
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2899633002
Cr-Commit-Position: refs/heads/master@{#474926}

This breaks most of our layout tests, since most things
depend on numbers and lengths, but it's better to be in
a single half state than have two half states hanging
around.

BUG=545318

Review-Url: https://codereview.chromium.org/2867883003
Cr-Commit-Position: refs/heads/master@{#474925}

Currently, there are a few *DataEquivalent functions in ComputedStyle
that take a pointer. All these functions assume that the pointers are
not null, so we can simply replace them with references.

BUG=628043

Review-Url: https://codereview.chromium.org/2905793002
Cr-Commit-Position: refs/heads/master@{#474924}

This patch makes RubyPosition an enum class for better type safety.

BUG=684966

Review-Url: https://codereview.chromium.org/2897883002
Cr-Commit-Position: refs/heads/master@{#474923}