GitLab

It's known to be very slow, and we've related layout-forcing changes in flight.

BUG=505670,427743,485428

Review URL: https://codereview.chromium.org/1214163003

git-svn-id: svn://svn.chromium.org/blink/trunk@198030 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/1217893004

git-svn-id: svn://svn.chromium.org/blink/trunk@198029 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=chromium:502437
R=adamk

Review URL: https://codereview.chromium.org/1214113005

git-svn-id: svn://svn.chromium.org/blink/trunk@198028 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=505518

Review URL: https://codereview.chromium.org/1219733002

git-svn-id: svn://svn.chromium.org/blink/trunk@198027 bbb929c8-8fbe-4397-9dbb-9b2b20218538

V8 enabled the --harmony-arrays flag by default in
https://chromium.googlesource.com/v8/v8/+/325fbd0,
adding many methods to Array and the various TypedArrays.

The intent to ship was posted to v8-users:
https://groups.google.com/forum/#!msg/v8-users/WIdC-t1zmKQ/lXpufXhNj3UJ

This patch adds the appropriate expectations for the aforementioned
methods, as well as several bits that changed while these tests
were disabled:

  - Added CanvasRenderingContext2D#filter (runtime enabled)
  - Added MediaDevices#getUserMedia (runtime enabled)
  - Added PerformanceResourceTiming#workerStart
  - Removed ServiceWorker#terminate

From my review of the commit log, all four of the above changes were
intentional and appropriate.

BUG=502308

Review URL: https://codereview.chromium.org/1217073002

git-svn-id: svn://svn.chromium.org/blink/trunk@198026 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove bg threads and responsiveness bar from timeline overview.

Review URL: https://codereview.chromium.org/1213143003

git-svn-id: svn://svn.chromium.org/blink/trunk@198025 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is part of a series of patches to update the client side API of what was
formerly known as navigator.connect to follow the new spec based on
navigator.services and a new ServicePort type.

This patch removes the old client side API from blink, and removes now
redundant code from the layout tests.

[1/3] https://codereview.chromium.org/1191393003 Blink side changes
[2/3] https://codereview.chromium.org/1192713004 Content side changes
[3/3] https://codereview.chromium.org/1198653004 This patch

BUG=426458

Review URL: https://codereview.chromium.org/1198653004

git-svn-id: svn://svn.chromium.org/blink/trunk@198024 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is in preparation for adding the DOMSharedArrayBuffer object, which needs
to be able to share allocated array memory between multiple WTF::ArrayBuffers.

BUG=497295
R=jochen@chromium.org,haraken@chromium.org

Review URL: https://codereview.chromium.org/1186863005

git-svn-id: svn://svn.chromium.org/blink/trunk@198023 bbb929c8-8fbe-4397-9dbb-9b2b20218538

redirect happens

BUG=500554

Review URL: https://codereview.chromium.org/1175113009

git-svn-id: svn://svn.chromium.org/blink/trunk@198022 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In cases where smooth scrolling is enabled, this test was previously
flaky. Disabling smooth scrolling should fix the issue.

BUG=

Review URL: https://codereview.chromium.org/1220783002

git-svn-id: svn://svn.chromium.org/blink/trunk@198021 bbb929c8-8fbe-4397-9dbb-9b2b20218538

That bug is obsolete.

BUG=133097

Review URL: https://codereview.chromium.org/1212353003

git-svn-id: svn://svn.chromium.org/blink/trunk@198019 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=504687

Review URL: https://codereview.chromium.org/1216523005

git-svn-id: svn://svn.chromium.org/blink/trunk@198018 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The old flexbox implementation did that. This still used to work halfheartedly
by accident until the fix for bug 498770, though, because we used to mark
out-of-flow positioned children in updateBlockChildDirtyBitsBeforeLayout(). But
it never worked for anything other than direct children. Added one test for the
recent regression (out-of-flow child) and one test that has probably never
passed, until now (out-of-flow grandchild).

We need to be inside layout() when setting the height of an object, or we won't
be able to detect any changes and thus fail to relayout positioned descendants
that may be affected.

BUG=504239
R=leviw@chromium.org

Review URL: https://codereview.chromium.org/1213843002

git-svn-id: svn://svn.chromium.org/blink/trunk@198017 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=198006

BUG=505411
TBR=caseq@chromium.org

Review URL: https://codereview.chromium.org/1214193005.

git-svn-id: svn://svn.chromium.org/blink/trunk@198016 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With DocumentLoader now being on the heap, keep a strong
back reference to the loader.

R=haraken
BUG=393516

Review URL: https://codereview.chromium.org/1220713004

git-svn-id: svn://svn.chromium.org/blink/trunk@198015 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=caseq@chromium.org
BUG=505411
NOTRY=true

Review URL: https://codereview.chromium.org/1220513003

git-svn-id: svn://svn.chromium.org/blink/trunk@198014 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch refactors BoxClipper to be a little cleaner. There should be
no change in behavior.

Changes:
1) BoxClipper::pushedClip has been removed as it was deadcode.

2) LayoutBox& is now const.

3) LayoutPoint m_accumulatedOffset has been removed since it was only
needed in the constructor.

4) bool m_pushedClip has been removed in favor of checking whether the
clip type is not uninitialized.

5) roundedRects heap allocation has been moved inside the
displayItemConstructionIsDisabled check.

This has been pulled out of https://codereview.chromium.org/1193433004.

BUG=484943

Review URL: https://codereview.chromium.org/1212293003

git-svn-id: svn://svn.chromium.org/blink/trunk@198013 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=392046,331583
TBR=thakis@chromium.org,scottmg@chromium.org

Review URL: https://codereview.chromium.org/1210073008

git-svn-id: svn://svn.chromium.org/blink/trunk@198012 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=198005

BUG=382491
TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/1211323005.

git-svn-id: svn://svn.chromium.org/blink/trunk@198011 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Obviously, an empty text is a valid text for a stylesheet. No need to
throw.

BUG=505358
R=pfeldman

Review URL: https://codereview.chromium.org/1212643005

git-svn-id: svn://svn.chromium.org/blink/trunk@198010 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=198001

BUG=505411
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/1213143004.

git-svn-id: svn://svn.chromium.org/blink/trunk@198009 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Report accurate Overscroll on handleWheel. Currently 
invalid ScrollResult is returned on overscroll.

compositor changes @
https://codereview.chromium.org/1203693003/

Bug=442859

Review URL: https://codereview.chromium.org/1195803003

git-svn-id: svn://svn.chromium.org/blink/trunk@198007 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=fmalita@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1214193004

git-svn-id: svn://svn.chromium.org/blink/trunk@198006 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move one of them that still fails to a new bug.

BUG=382491

Review URL: https://codereview.chromium.org/1216493002

git-svn-id: svn://svn.chromium.org/blink/trunk@198005 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=aboxhall
NOTRY=true

Review URL: https://codereview.chromium.org/1216933003

git-svn-id: svn://svn.chromium.org/blink/trunk@198004 bbb929c8-8fbe-4397-9dbb-9b2b20218538

"Copy as cURL" command in Network panel produces an output that
is platform-dependent: escapings are different for cmd and posix

However many Windows user use unixy shell (for instance msys / git bash)
and hence it makes sense to expose them a unixy curl command.

BUG=488371

Review URL: https://codereview.chromium.org/1136843010

git-svn-id: svn://svn.chromium.org/blink/trunk@198003 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The StylesSidebarPane should be force-refreshed on undo/redo command
happens.

BUG=501310
R=pfeldman

Review URL: https://codereview.chromium.org/1221663002

git-svn-id: svn://svn.chromium.org/blink/trunk@198002 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After https://codereview.chromium.org/1180903006, the GPU results for
fill-stroke-clip-reset-path.html are slightly different for path vs.
rect fills.  Unfortunately this means a ref test is no longer feasible.

Change fill-stroke-clip-reset-path.html to be a simple pixel test, and
mark for rebaseline.

BUG=505411
TBR=bsalomon@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/1211303005

git-svn-id: svn://svn.chromium.org/blink/trunk@198001 bbb929c8-8fbe-4397-9dbb-9b2b20218538

They convert from LayoutRect to FloatRect and back again, which is far from free.

BUG=321237

Review URL: https://codereview.chromium.org/1183863003

git-svn-id: svn://svn.chromium.org/blink/trunk@198000 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=438023

Review URL: https://codereview.chromium.org/1193333002

git-svn-id: svn://svn.chromium.org/blink/trunk@197999 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=503852
R=wangxianzhu

Review URL: https://codereview.chromium.org/1217753002

git-svn-id: svn://svn.chromium.org/blink/trunk@197998 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=490047
TBR=pfeldman

Review URL: https://codereview.chromium.org/1217833002

git-svn-id: svn://svn.chromium.org/blink/trunk@197997 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dgozman
NOTRY=true

Review URL: https://codereview.chromium.org/1212153003

git-svn-id: svn://svn.chromium.org/blink/trunk@197996 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=504412
TBR=pfeldman

Review URL: https://codereview.chromium.org/1218853002

git-svn-id: svn://svn.chromium.org/blink/trunk@197995 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=503887
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1213693006

git-svn-id: svn://svn.chromium.org/blink/trunk@197994 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=488371
TBR=pfeldman

Review URL: https://codereview.chromium.org/1217863002.

git-svn-id: svn://svn.chromium.org/blink/trunk@197993 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=505395

Review URL: https://codereview.chromium.org/1214173002

git-svn-id: svn://svn.chromium.org/blink/trunk@197992 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=alph
BUG=502186

Review URL: https://codereview.chromium.org/1219693002

git-svn-id: svn://svn.chromium.org/blink/trunk@197991 bbb929c8-8fbe-4397-9dbb-9b2b20218538

While transitioning Blink to Oilpan, there will be LifecycleNotifier<>s
not on the Oilpan heap, but with some of their LifecycleObserver<>s being
on the heap.

Should a GC strike while such a notifier iterates over its observer set,
dead observers may remove themselves (eagerly) while being finalized
during that GC. This will mutate the notifier set, which isn't currently
assumed nor supported.

There's no need to support this when fully transitioned, Oilpan will
handle GCs across such iterations gracefully, but in the meantime we will
have to support this by snapshot'ing the observer set and explicitly
checking for liveness. Like already done over ContextLifecycleNotifier,
where such dynamic unregistrations are supported.

Notice that this issue isn't tied to lazy sweeping; indeed, lazy sweeping
without eager finalization of lifecycle observers will potentially make this
bug rarer.

R=haraken
BUG=480837

Review URL: https://codereview.chromium.org/1214963002

git-svn-id: svn://svn.chromium.org/blink/trunk@197990 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The width and height should be valid, but add a size check while
we figure out the root cause of issue 504690.

BUG=504690

Review URL: https://codereview.chromium.org/1212333005

git-svn-id: svn://svn.chromium.org/blink/trunk@197989 bbb929c8-8fbe-4397-9dbb-9b2b20218538