- 16 Jun, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ca72cad60197..4569f66309b6 2020-06-16 bsalomon@google.com Remove coverage-as-alpha flag from GrAlphaThresholdFP If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: I83d7e9027150ae886a868076583e2f6a989d32b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248036Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778916}
-
Devlin Cronin authored
If extension APIs get arguments that they don't think should be possible from a renderer, the renderer will be killed for sending a bad message (this is WAI). The [browserAction|pageAction].setIcon() API has been killing renderers for sending invalid data. Some early metrics added indicate that this happens when the arguments passed include neither an iconIndex nor imageData key (which theoretically shouldn't happen). After some investigation, it seems this *could* happen if there are some tricky getters or settings on the Object prototype, which would prevent us from construction an object with the proper values. Defend against this by using a gin::DataObjectBuilder in the renderer (which uses v8::Object::CreateDataProperty() internally, which doesn't hit the Object prototype), as well as assigning a null prototype to the resulting arguments. Also add a regression test. Bug: 1087948 Change-Id: I45d34024f8f3066eb547b974d564c1e41f064993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246836Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#778915}
-
Javier Ernesto Flores Robles authored
Add a11y label to the ConfirmationAlertViewController help button. Merge after: https://chromium-review.googlesource.com/c/chromium/src/+/2241999 Bug: N/A Change-Id: I5387d0cc732aee368c91d612ba3b2a6fab8e1bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241972Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#778914}
-
Bailey Berro authored
This change creates a new pref, prefs::kAudioDevicesGainPercent, to store the gain values for each of a user's input devices. A new pref is created because the default value for input gain was changed to 50 rather than 75, and any users of mic gain before the switch will have the old value stored in prefs rather than the new one. Bug: b:158677629 Change-Id: I536b375dba02c00fa021688be09881eb59a81adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246231 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Hsinyu Chao <hychao@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#778913}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9d178021d3b7..fbbd9ca81f96 2020-06-16 sadrul@chromium.org rendering: Fix alerts for dropped frames. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1095186 Tbr: eseckler@google.com Change-Id: I48cdc33e46650e4d9b1a627566a7d0f3ce978a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248440Reviewed-by:
-
Andrew Grieve authored
Bug: None Change-Id: Iede91c33f4a17e8451b4977e95047f56675fb824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245050 Commit-Queue: Gang Wu <gangwu@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#778911}
-
Darwin Huang authored
Sqlite is using v3.32.1 now. Change-Id: I2a0aece45733c23482cc2cf597bf9f9031e06a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247172Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#778910}
-
Mikhail Khokhlov authored
Adds a simple TBMv3 metric with power estimation based on CPU usage for comparison with power rails metric. Bug: b/155073796 Change-Id: I61a6ee52280a4c6542fee1f9f26cb67760f9f87a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247025 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#778909}
-
Sergey Ulanov authored
Previously SkiaOutputDeviceBufferQueue has dependency on gl::GLSurface. That made it impossible to reuse that class on platforms that don't have native GL implementation, particularly Fuchsia. Added a new interface OutputPresenter that abstracts display buffer allocation and presentation. OutputPresenterGL implements that interface on top of GLSurface. Fuchsia will use a different implementation. Bug: 1090447 Change-Id: Ib92916319af670906514a3a5ad0033e84bd4ad06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236232Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#778908}
-
Anastasia Helfinstein authored
Currently, when a secondary color is used with a dashed focus ring, it is hard to see, because its width is split across both sides of the primary color. This change increases the width on either side to increase visibility. AX-Relnotes: n/a. Bug: 1094069 Change-Id: If68505b4f374c3e0af0f09c8c7649d819edc7126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244192Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#778907}
-
zhaoyangli authored
Built a special EG2 host app target with the test application delegate. Adapted chrome_test_case test filtering logic to EG2. Created the EG2 suite. Bug: 1093981 Change-Id: Ie210dd9ad55c1e3cda57ef25e43c4f0bd7d35277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243583Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#778906}
-
Jordan Bayles authored
This patch includes several cleanups of the mirroring service. TBR=mfoltz@chromium.org Bug: 1015458, 1002603 Change-Id: I5df1a99694b17641388ecf6387805e24058c6fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240907 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#778905}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 29 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-12-13. TBR=chromium-metrics-reviews@google.com Change-Id: I44077a33d243d6340f2b41e88eb689f15c1e69d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248378Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#778904}
-
Clark DuVall authored
The popup blocked infobar uses the ConfirmInfoBar, so we will need the equivalent functionality in WebLayer. Since ConfirmInfoBar inherits from InfoBar which was forked in http://crrev.com/c/2224869, we also need to fork ConfirmInfoBar. The layout for non-compact infobars was componentized in http://crrev.com/c/2243579 and can be used between both Chrome and WebLayer. The initial patchset here has a clean copy of the Chrome files, and the subsequent patchsets have changes for WebLayer. Bug: 1019922 Change-Id: I76e093e6113c26990dd1041ac4c901690489bad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248538Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#778903}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f88dd4d00256..103a73ea1ff1 2020-06-16 mbonadei@webrtc.org Remove unneeded GN import. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8fbbf4c08dabbfeb50442d3e7448338df86f441d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248030Reviewed-by:
-
Mohamed Heikal authored
TBR=martiniss@chromium.org Change-Id: I4c3cf635944dfbded42c6cc2851dcbb8ad8e3ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248123Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#778901}
-
Lei Zhang authored
- Use early returns in HandleGetPasswordCompleteMessage(). - Consolidate some checks in HandleResetPrintPreviewModeMessage(). - Change SetTwoUpView() to HandleSetTwoUpViewMessage() and consistently validate the message like other handlers. Also mark this message handler private. - Make comment style consistent through out the file. Change-Id: Ie437086adf83015f90858a864e1acdb9e826bf34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242853 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#778900}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592297885-4df3e1395ccce5fa6318db5c6c03cffe6093fff6.profdata to chrome-win32-master-1592318647-7dde799a5671d21565d3d7d630fb811f29f03533.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I76b8587dabbac4c3df0030432b00723744073343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248034Reviewed-by:
-
Sebastien Lalancette authored
Adding histograms for Sharing scenarios and actions. The first histogram "Mobile.Share.EntryPoints" is used to view at an aggregate level what type of sharing occurs the most in Chrome, and the other per-entry-point histograms (two right now) show which actions are used the most per scenario. Googlers may visit go/bling-share-metrics-revamp for more details. Change-Id: Iee0c58dadc9daf20a8a5b410ca8bcb49bbbe6d01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225843 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#778898}
-
Roman Aleksandrov authored
Bug: 1093879 Change-Id: Ia12ff9a9d337bb9e425b5e5aa06e9d5bf5ecb352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247885Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#778897}
-
Mehran Mahmoudi authored
This fixes a problem where paint preview player view was not displayed on Chrome startup. Bug: 2231179 Change-Id: If5bea69fcac0563ed1aeaf091e2caa1e45098106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246980 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#778896}
-
Robbie Gibson authored
Currently, part of the ios cookie blocking implementation relies on injected Javascript to block access to various Javascript data accessors (e.g. document.cookie). However, future WebKit changes could cause these overrides to fail. Failures should be tracked to alert us if cookie blocking starts to fail. Fixed: 1082151 Change-Id: I4dee8c8c5eab93981556d211ad8cbea33f9fdcfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246143 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#778895}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 129 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-12-13. TBR=chromium-metrics-reviews@google.com Change-Id: Ib4648de66acd7793f047981de906e3fe53f451eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248379Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#778894}
-
Sadrul Habib Chowdhury authored
For the FrameSequenceTracker trace-events, generate a 'Frame' step only if the frame produced had updates from the desired thread. For example, for a FrameSequenceTracker representing a main-thread animation, create a 'Frame' step only if the presented frame had updates from the main-thread. BUG=1095186 Change-Id: I0ded17b4a05b6de4da0d6e3607c5dec787b02633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247522 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#778893}
-
Khushal Sagar authored
We currently assume that a decode task can always be created for every decode request. But this is not the case for bitmaps (where no decoding is needed) or hardware accelerated decodes. Ensure that this case is handled correctly. R=cblume@chromium.org Bug: 1083100 Change-Id: Idf3812ee8005369d335ff8887391ea3ad1ca0735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246796Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#778892}
-
Kevin Babbitt authored
Code cleanup in preparation for making system color keywords compute to themselves. Bug: 1081945 Change-Id: I72921d005fcf1ddc31957cdf939b51a8fdfdb4e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247150Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#778891}
-
Andres Calderon Jaramillo authored
This CL enables H.264 decoding with BufferAllocationMode::kNone. The main blocker for enabling this was increased CPU consumption due to busy work when there is an available surface but the corresponding picture buffer has not come back from the client (see [1]). This CL does not eliminate this busy loop. Instead, it makes sure that the number of requested buffers is at least 13 (picked to imitate the value returned by VP9Decoder::GetRequiredNumOfPictures()). This makes it more likely that the decoder can get a buffer without waiting on one to come back from the client. As validation, this is the output of dump_intel_rapl_consumption while playing http://crosvideo.appspot.com/?codec=h264&resolution=1080&loop=true on an i7 eve (with the new VD disabled): Before this CL: ======================================================================== package-0 core uncore dram psys 2.667667 1.359338 0.188050 0.860169 2.832958 1.492605 0.466284 0.179845 0.761450 1.859494 2.465552 1.333110 0.173884 0.826528 2.429251 1.836305 0.701381 0.175284 0.825935 2.083826 1.397930 0.331338 0.175203 0.764998 1.783907 1.453937 0.396079 0.175568 0.762897 1.804858 1.617633 0.551016 0.172171 0.770288 1.930921 1.398794 0.377560 0.178041 0.762288 1.761070 1.309214 0.300763 0.171568 0.748048 1.685083 4.094596 2.987037 0.221237 0.785434 3.152690 After forcing BufferAllocationMode::kNone without any other changes: ======================================================================== package-0 core uncore dram psys 10.091497 8.403499 0.137035 1.066655 6.793493 6.107595 4.291023 0.142334 1.282748 4.898286 4.173701 2.382291 0.132389 1.202908 3.855559 4.276854 2.500189 0.126471 1.216745 3.911385 4.716722 3.027957 0.134404 1.154900 4.138097 4.547350 3.342606 0.137797 0.721388 3.806403 5.852608 4.761959 0.133650 0.685367 4.167034 6.440512 5.366580 0.130992 0.692277 4.334328 6.471564 5.462571 0.135755 0.610058 4.239434 6.522625 5.574209 0.130200 0.602120 4.179017 After this CL: ======================================================================== package-0 core uncore dram psys 7.261862 5.491319 0.183383 1.410826 5.420041 5.723818 3.829009 0.142398 1.491444 4.720379 4.364147 2.652774 0.137776 1.144099 3.956767 1.597286 0.459902 0.141311 0.751768 2.134646 1.428828 0.465833 0.140055 0.718547 1.791793 2.307202 1.213556 0.141450 0.792714 2.334663 1.753186 0.647150 0.136820 0.764778 2.088220 1.276018 0.308548 0.134811 0.728569 1.546158 1.285961 0.308340 0.140440 0.719776 1.522937 1.579406 0.594378 0.131040 0.720050 1.698702 Note that according to top -d 0.5, the CPU usage of the GPU process hovers at around 20%. ======================================================================== Therefore, increasing the number of required buffers allows us to enable kNone without regressing on power consumption. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=910986#c32 Bug: 910986, 1054097 Test: dump_intel_rapl_consumption on eve while playing 1080p H.264. Change-Id: Ib1aa566e2af54439d9c6c3339c522758c5f699a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246846Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#778890}
-
zhaoyangli authored
This was disabled due to test crash happening on iOS 12 devices. The crash doesn't happen any more when we switched to running XCTest based unit tests on iOS 12 devices, but not launching tests with idevice-app-runner (bug: crbug/1087078, CL: crrev/c/2219108). So this test can be re-enabled to close the bug. Bug: 1083299 Change-Id: Id1182e132fba2fad64cdc1777440d758b4dcd099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243836Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#778889}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592254457-49e6f7cc818263441b4a68ab874369702506c19f.profdata to chrome-win64-master-1592318647-c846006b87aca0f87b5615080933ac03d3857a36.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie071c43d02c6b20061867c94e16de01eec7e4b42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248033Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e364dd820b29..f82b08b1e252 2020-06-16 liviurau@chromium.org Revert "Support formatting python3 scripts" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ifdd4448742794e41abf4ad045956f866956dabff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248035Reviewed-by:
-
Jérôme Lebel authored
Fixing: +[URLOpener openURL:applicationActive:tabOpener:startupInformation:] This method needs to check if Chrome is presenting the FRE. With FRE URL should be dropped. This can be reproduced with multi-windows enabled, or when Chrome is active when receiving the URL (this can be done with split-view). Fixed: 1092492 Change-Id: Id9313e5eea484b262574d19c9ce30ceec1fab469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243132 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
-
Stephen Chenney authored
Extend these expiring histograms and try to bring them into alignment with the other Blink.*.UpdateTime histograms. This will be a gradual process as histograms expire. Bug: 1095031, 1095030 Change-Id: I01ea65da538b5bd4c3f6e24892865c9fc6d03eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246555 Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#778885}
-
Brandon Wylie authored
Bug: 1091191 Change-Id: I02f4b3c8f4e34928d53c70772fe8ab50a271de7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246992 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#778884}
-
Chris Lu authored
SaveCard's acceptance action involves passing the card credentials to be saved. Thus, it can't use the InfobarBannerMainActionResponse like other InfoBars. Thus, the banner's response to bannerInfobarButtonWasPressed: will use SaveCardMainAction to accept the banner InfoBar action. Bug: 1071914 Change-Id: I9e5495f422cd43ea315a8b6096466e9ea2fb829f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246951 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#778883}
-
Scott Violet authored
BUG=1042771 TEST=AwOriginMatcherTest* Change-Id: I5ee9eb34a36d21de91694ad996cfdc51907ee672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242748 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#778882}
-
Alex Chau authored
- Should always instantiate service in factory, otherwise the service will stay nullptr until Chrome restart. Pref should be checked inside - Shutdown NearbyConnections if Nearby Sharing is disabled - Introduced FakeNearbyConnectionsManager as the basis for testing further NearbySharingServiceImpl methods Bug: 1084283 Change-Id: Ia3e01cf257757b023d38c2832c2ce482dedf6441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247879 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#778881}
-
Alice Wang authored
Change-Id: I819a7368990de4e0242cbcc90e250ff9e5c9acde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247779Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#778880}
-
Yuzu Saijo authored
This CL implements BackForwardCache Timeout and Ack. When we cannot put a page into bfcache in a certain time period, we give up putting the page into cache. Ack function allows us to know whether the page is before/during/after the process of caching, instead of whether it is in/out of cache. Change-Id: I921076636afeddcd172889a8dd5f68687c8e0ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2192793 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#778879}
-
Eric Seckler authored
With the addition of per-thread UMAs, the collection became a little bit more expensive. This patch moves it to a background thread and reduces the collection interval for the browser and GPU processes, which (i) are persistent processes (so data loss at termination is less of an issue) and (ii) tend to execute many small main thread tasks. Bug: 1081760,1094434 Change-Id: I847179ae78c024bb506772c1c42804e9d896f762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245906 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:Bo <boliu@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#778878}
-
Patrick Noland authored
This change has MenuButton control its tab switcher animation drawing internally so that ToolbarPhone doesn't need to keep track of which Drawable to use. It also adds some regression tests. Bug: 1082771 Change-Id: I792712106ec7660f1a717e031514e17695d5062a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238368Reviewed-by:
-
