1. 02 Sep, 2020 6 commits
    • Olivier Yiptong's avatar
      FontAccess: ChromeOS and Linux platform implementation · 2668acad
      Olivier Yiptong authored
      This change implements font enumeration for ChromeOS and Linux platforms.
      Both platforms make use of fontconfig for enumeration.
      
      Font Data Access is already supported by a previous change adding
      @font-face src local matching.
      
      Bug: 1043306
      Change-Id: I4a04f94e488e481d2d444469b225178f44f907fb
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388103
      Commit-Queue: Olivier Yiptong <oyiptong@chromium.org>
      Reviewed-by: default avatarJoshua Bell <jsbell@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#803715}
      2668acad
    • Anastasia Helfinstein's avatar
      Make EventGenerator a shared class amongst a11y extensions · 349b3992
      Anastasia Helfinstein authored
      AX-Relnotes: n/a.
      Bug: None.
      Change-Id: I55408877bd816dfc71764182c106c84ec980ae88
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300985
      Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
      Reviewed-by: default avatarDavid Tseng <dtseng@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#803714}
      349b3992
    • Sangwoo Ko's avatar
      Use LabelButton::SetImageModel() instead of SetImage(). · 0fbae61f
      Sangwoo Ko authored
      ui::ImageModel should be preferred to ui::Image or ui::ImageSkia.
      There's no intended behavior change.
      
      Bug: 1100034
      Change-Id: Iaf12012c2da76503a04062e29527118b3f730f3f
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385035Reviewed-by: default avatarScott Violet <sky@chromium.org>
      Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#803713}
      0fbae61f
    • Xianzhu Wang's avatar
      Let blink runtime features override the default status of chromium features · 05355f4a
      Xianzhu Wang authored
      This honors blink feature status ("test", "experimental", "stable")
      in third_party/blink/renderer/platform/runtime_enabled_features.json5,
      overriding of the default status of the corresponding chromium features,
      unless the status of the chromium feature is overridden by finch trial
      or command line switches.
      
      This resolves the following problems of blink features with
      status:"test", status"experimental", status:"stable" when the
      corresponding chromium feature is disabled:
      1. unexpected disabling of the blink feature for web tests
      2. unexpected enabling of a blink feature for unit tests (in which case
         the blink feature should not have a status).
      
      This CL only affects how blink features with status are enabled with
      --enable-experimental-web-platform-features
      (or chrome://flags/#enable-experimental-web-platform-features)
      --enable-blink-test-features when the corresponding chromium feature is
      disabled by default.
      
      This doesn't affect
      1. finch experiments (which still controls the blink features through
         the chromium features);
      2. other command line flags that affect blink features (either directly
         or indirectly through chromium features);
      3. the priority relationship among 1 and 2 and the changed factors
         mentioned above.
      
      The features that will be affected by this CL have been prepared in
      either of the following methods (tracked by crbug.com/1121839, based
      on feedbacks in https://docs.google.com/spreadsheets/d/1DAtdbGy7XZCC_1_IXHXZKx568pw0eDlVETCtJBexqZc/edit#gid=0):
      a) For features that should be enabled for web tests but were not
         because of the chromium feature disabled by default, temporarily
         explicitly enable it in content/child/runtime_features.cc.
         An example is crrev.com/c/2380213.
         These changes are removed in this CL.
      b) For features that are not ready to be enabled for web tests, or are
         not meaningful to be enabled for web tests (e.g. the feature is
         implemented at both chromium side and blink side), the blink status
         is removed to let the chromium feature fully control the blink
         feature. An example is crrev.com/c/2376067.
      
      Bug: 1048656, 1121839
      Change-Id: I8b2f15e30767dce9212097f79c8c07a373af892d
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375886
      Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
      Reviewed-by: default avatarJason Chase <chasej@chromium.org>
      Reviewed-by: default avatarScott Violet <sky@chromium.org>
      Reviewed-by: default avatarPhilip Rogers <pdr@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#803712}
      05355f4a
    • James Cook's avatar
      lacros: Support high DPI notification icons and images · b10c2671
      James Cook authored
      Convert icons and images to use the newly-stabilized ImageSkia mojo
      transport. This allows high DPI images. It is also higher performance
      than the existing crosapi::Bitmap serializer because it uses shared
      memory for large images.
      
      Lacros still sends icons and images in the old format to allow
      backwards compatibility with older ash. We can remove this old
      serialization in 6 weeks or so. Until then we won't see the
      performance benefit.
      
      Manually tested on gLinux with high-DPI screen.
      
      Bug: 1113889
      Test: added to unit_tests
      Change-Id: I1cf4b86512fd59e287a32dfb4ac2d59d2962a6f4
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388152Reviewed-by: default avatarJun Mukai <mukai@chromium.org>
      Reviewed-by: default avatarErik Chen <erikchen@chromium.org>
      Reviewed-by: default avatarGreg Kerr <kerrnel@chromium.org>
      Commit-Queue: James Cook <jamescook@chromium.org>
      Auto-Submit: James Cook <jamescook@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#803711}
      b10c2671
    • Amr Aboelkher's avatar
      Revert "Reland "PSM: Support PSM RLWE based message definitions in Chromium"" · 79bb0c73
      Amr Aboelkher authored
      This reverts commit 2cb2db95.
      
      Reason for revert: tree is broken cause of win related issues, see: https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/17181?
      
      Original change's description:
      > Reland "PSM: Support PSM RLWE based message definitions in Chromium"
      > 
      > This reverts commit 6e670242.
      > 
      > Reason for reland: shell-encryption tests were failing for Win and Android, see: crbug.com/1124018. Then all tests have been disabled for all platforms except for ChromeOS, until the problem being solved from the upstream, then being rolled into Chromium.
      > 
      > Original change's description:
      > > Revert "PSM: Support PSM RLWE based message definitions in Chromium"
      > >
      > > This reverts commit 33d4fbea.
      > >
      > > Reason for revert: We believe this is causing the build failure that closed the tree: https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/17171?
      > >
      > > Original change's description:
      > > > PSM: Support PSM RLWE based message definitions in Chromium
      > > >
      > > > This CL adds the communication between client and server
      > > > for issuing and retrieving determination using PSM. It also
      > > > supports the usage of private_membership third_party protos
      > > > package in device_management_backend.
      > > >
      > > > BUG=chromium:1094675
      > > >
      > > > Binary-Size: Increase is temporary.
      > > > Change-Id: If791aa1a4a936e1d42fde397a33c1a19c640359d
      > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245131
      > > > Reviewed-by: David Benjamin <davidben@chromium.org>
      > > > Reviewed-by: Amr Aboelkher <amraboelkher@chromium.org>
      > > > Reviewed-by: Pavol Marko <pmarko@chromium.org>
      > > > Commit-Queue: Amr Aboelkher <amraboelkher@chromium.org>
      > > > Cr-Commit-Position: refs/heads/master@{#803532}
      > >
      > > TBR=davidben@chromium.org,emaxx@chromium.org,tikuta@chromium.org,pmarko@chromium.org,amraboelkher@google.com,amraboelkher@chromium.org
      > >
      > > Change-Id: I33f2f9200c3ef24d7c6059d116a88807d83aa0f0
      > > No-Presubmit: true
      > > No-Tree-Checks: true
      > > No-Try: true
      > > Bug: chromium:1094675
      > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388267
      > > Reviewed-by: Tommy Martino <tmartino@chromium.org>
      > > Commit-Queue: Tommy Martino <tmartino@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#803555}
      > 
      > # Not skipping CQ checks because this is a reland.
      > 
      > 
      > TBR=davidben@chromium.org,emaxx@chromium.org,tmartino@chromium.org,tikuta@chromium.org,pmarko@chromium.org,amraboelkher@google.com,amraboelkher@chromium.org
      > 
      > Bug: chromium:1094675
      > Binary-Size: Increase is temporary.
      > Change-Id: Ia5c92b07b3614228823d2b4e883eb03e80474f37
      > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388621
      > Commit-Queue: Amr Aboelkher <amraboelkher@chromium.org>
      > Reviewed-by: Amr Aboelkher <amraboelkher@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#803700}
      
      TBR=davidben@chromium.org,emaxx@chromium.org,tmartino@chromium.org,tikuta@chromium.org,pmarko@chromium.org,amraboelkher@google.com,amraboelkher@chromium.org
      
      Change-Id: I884e0bd9295696b2434e34f62f90eb39d4551c9e
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:1094675
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388123Reviewed-by: default avatarAmr Aboelkher <amraboelkher@google.com>
      Commit-Queue: Amr Aboelkher <amraboelkher@google.com>
      Cr-Commit-Position: refs/heads/master@{#803710}
      79bb0c73
  2. 01 Sep, 2020 34 commits