- 12 Jul, 2019 40 commits
-
-
Eugene But authored
WKWebView has undefined behavior regarding start the navigation on iOS 13. It's not a bug, just a difference in behavior from iOS 11 and 12, where navigation always starts on simulator but never starts on device. The test is disabled for iOS 13, because it's not possible (and unnecessary) to test undefined behavior. Bug: 983150 Change-Id: I69f5b503bc994bebd803fda4021cb88d4ba0c3e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698779Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#676878}
-
Aga Wronska authored
This reverts commit b026d472. Reason for revert: Kiosk Next not needed any more Original change's description: > Fix status area color when immersive app is opened > > Status area background color was incorrect when switching from > KioskNext home to immersive app, because shelf turns to auto-hide > mode then and both shelf and status area are not visible. > > Bug: 949289 > Change-Id: I28213355ea0f65d7638bd59714e50fbaceef3371 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577944 > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Aga Wronska <agawronska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#653016} TBR=jamescook@chromium.org,agawronska@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 949289 Change-Id: Ic83ce3aae5e93f0c4a138786f24b17e5e7e3ac1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700041Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#676877}
-
Aga Wronska authored
This reverts commit 71bbd6d8. Reason for revert: Kiosk Next not needed any more Original change's description: > Fix shelf being visible on kiosk next home screen > > Shelf should not be visible on Kiosk Next home screen. Starting drag > gesture during transition to home screen can cause shelf remaining stuck > and visible. To prevent that cancel drag gesture when home screen > animation is finished. > > Bug: 968635 > Change-Id: I89cfaebbfc9eed0e8ef916b382fdb88f470399f0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638917 > Commit-Queue: Aga Wronska <agawronska@chromium.org> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665561} TBR=xiyuan@chromium.org,michaelpg@chromium.org,agawronska@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 968635 Change-Id: I9b6ebf663ffbc76e2fd39a2aa185833908516528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698531Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#676876}
-
Ivana Zuzic authored
The icon is going to lead to a password editing activity which doesn't exist yet and will be created in the next CL. The icon is flag-guarded since the feature of editing passwords is still in the making. Bug: 377410 Change-Id: Ibd7d702b884d1a9ab0228e6f8b8c7be424a04946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695353 Commit-Queue: Ivana Zuzic <izuzic@google.com> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#676875}
-
Alex Clarke authored
USER_VISIBLE tasks on the UI thread are now run at a lower priority than default / USER_BLOCKING tasks. This caused the test to become flaky because it runs 100 USER_VISIBLE tasks to call OnProgress but the QuitClocure task is run at USER_BLOCKING priority so occasionally it can run too soon. This patch fixes that by running the Quit at USER_VISIBLE priority. Change-Id: I93bc93c9c583b160aa1ff4326a021c432eab525a BUG: 863341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697204 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#676874}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/11820502b840..01d04fac7548 git log 11820502b840..01d04fac7548 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 artit@webrtc.org Revert "Add wrapper to normalize flags." 2019-07-12 philipel@webrtc.org Add VideoEncoderFactory::GetImplementations function. 2019-07-12 mbonadei@webrtc.org Revert "Optimize PacketRouter/RTPSender interactions." 2019-07-12 mbonadei@webrtc.org Revert "Pass RtpRtcp::Configuration to RtcpReceiver ctor and initialize ssrcs" Created with: gclient setdep -r src/third_party/webrtc@01d04fac7548 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4d5bdf515b540e024487e27245c974de0fc821e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699990Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676873}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7938579ef96f..93193c0ebf2f Created with: gclient setdep -r src-internal@93193c0ebf2f The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=wjmaclean@google.com,mpearson@google.com,hayato@google.com,pmarko@google.com Change-Id: Idaf5bc1b4c9161541815c594e890f89e6c65110e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699991Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676872}
-
Camille Lamy authored
This CL allows FrameLoader::CommitDocumentLoader to commit a specified DocumentLoader instead of the provisional DocumentLoader. This is part of a series of CLs that aim at removing the provisional loader (step 8k in the linked doc in the bug). Bug: 855189 Change-Id: Ic59f1793c1db01d4a6f05546a67ce42ec5f70cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611818 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#676871}
-
Ilya Bizyaev authored
This adds a feature flag that will be used in the near future to test experimental access control features related to Crostini (restricting VM CLI tools access, restricting Crostini root access). Test: compile Change-Id: Ia60944e2af4bbe9109f31737f2657ba176c16dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698203 Commit-Queue: Ilya Bizyaev <ilyabiz@google.com> Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Alex Oldemeier <aoldemeier@chromium.org> Cr-Commit-Position: refs/heads/master@{#676870}
-
Fernando Serboncini authored
Bug: 959357 Change-Id: I3ec12e7cbbf42a5cb1d113264ec6a39405933eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697109 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#676869}
-
kylechar authored
Graphics code was updated to use OnceCallbacks which support move only types without base::Passed(). Finish cleaning up unnecessary base::Passed() usage and replace with std::move(). Bug: 714018 Change-Id: I5bb3c3fdd3c195fbdb5cca33c2eb0de378e8aeda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699207Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#676868}
-
Camille Lamy authored
This CL re-organizes FrameLoader::CommitNavigation and DocumentLoader::StartLoading, so that PrepareForCommit is called directly from the FrameLoader. This is step 8i of the doc linked in the bug. Bug: 855189 Change-Id: I74d16740136edab0a248368543cf11ba982830e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609783 Commit-Queue: Camille Lamy <clamy@chromium.org> Auto-Submit: Camille Lamy <clamy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#676867}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/da391939c524..cba4ff0049c8 git log da391939c524..cba4ff0049c8 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 eseckler@google.com Merge "Revert "build: Attempt to use system includes for gtest/mock in chromium"" 2019-07-12 lalitm@google.com Merge "Revert "Update jsoncpp version"" 2019-07-12 khokhlov@google.com Merge "Trace_processor: export instant and async events in json format" 2019-07-12 khokhlov@google.com Merge "Update jsoncpp version" 2019-07-12 eseckler@google.com Merge "build: Attempt to use system includes for gtest/mock in chromium" Created with: gclient setdep -r src/third_party/perfetto@cba4ff0049c8 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ifa1c9109e3d404a4f354cec3a828d35ac22b6ce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699987Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676866}
-
Egor Pasko authored
Bug: None Change-Id: I50ef287f7a31c10735e9c2f2dbe749cbc2bfbab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695413Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#676865}
-
Peter Beverloo authored
Otherwise their own members wouldn't be properly destroyed. Also address some tiny style nits. Change-Id: Ia0f08d5d5b972022025e8ca0cc031482fde77b7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697207 Commit-Queue: Peter Beverloo <peter@chromium.org> Auto-Submit: Peter Beverloo <peter@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#676864}
-
Alex Oldemeier authored
This test fails consistently on Mac10.10, Mac10.11, Mac10.12, and Mac10.13 builders. I can reproduce flakiness on my Linux machine, so I am disabling this test for now. TBR=blundell@chromium.org Bug: 983061 Change-Id: Icb65b137d6b5c80d2c0bb798dc7aa763147cffb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698371 Commit-Queue: Alex Oldemeier <aoldemeier@chromium.org> Reviewed-by:
Alex Oldemeier <aoldemeier@chromium.org> Cr-Commit-Position: refs/heads/master@{#676863}
-
Robbie Gibson authored
Although our typical blue is pretty similar to the default system blue, our blue in dark mode is somewhat different. Thus, we want to use our blue on all buttons, etc. To limit the possibility of errors, this change will be made in steps, which is why this only changes the tint color of bar button items inside a table view navigation controller. Bug: 974255 Change-Id: Ic0aeb07e5f4177ffad2179183fd462a8e7634958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696967Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#676862}
-
Clemens Arbesser authored
A recent change from explicit UMA sizes to implicitly inferred ones is causing an issue with one of our UMA histograms, DropOutReason ('Histogram Android.AutofillAssistant.DropOutReason has mismatched construction arguments'). This CL reverts back to using explicit UMA sizes, which fixes the issue for now. A proper fix will likely require a change of UMA code. Bug: 806868 Change-Id: I9ec291d0ed3f4a8e49b90a4f751ea9e66acc8134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699606 Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#676861}
-
Luke Zielinski authored
This list was generated manually as part of auditing baseline files for running WPT on CQ. Any baseline that couldn't obviously be mapped to a test was included in this CL, and then some were trimmed away based on trybot results. Bug: 801368 Change-Id: I0d4392aeb2a9297476de16c5aba45fb52bfc244f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697427Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#676860}
-
Kuo Jen Wei authored
Fix the bug introduced by crrev/c/1657082 not fallbacking to normal getUserMedia. Test: On HAL v1/v3 device, CCA preview can show normally. Change-Id: I873b99722b262b406e3afd454e08921493d05935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699525Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#676859}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5081512502df..55adf4cf707b git log 5081512502df..55adf4cf707b --date=short --no-merges --format='%ad %ae %s' 2019-07-11 zoddicus@users.noreply.github.com Update execution scope rules for WebGPU (#2730) 2019-07-11 33432579+alan-baker@users.noreply.github.com Extra small storage validation (#2732) 2019-07-11 jbolz@nvidia.com Add validation for SPV_EXT_demote_to_helper_invocation (#2707) Also rolling transitive DEPS: src/third_party/spirv-headers/src de99d4d834ae..123dc278f204 Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@55adf4cf707b The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,cwallez@chromium.org Change-Id: Ia1b2ab106f0a87ee40a22e547207b770ec5cf48d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699116Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676858}
-
Jérôme Lebel authored
The primary identity is now set after loading the accounts. So the reconciler needs to start once the primary identity is set. This patch fixes those failing tests: -[ExternalURLSigninTestCase testSignInAddAccountCommand] -[ExternalURLSigninTestCase testSignInReauthenticate] -[ExternalURLSigninTestCase testSignInOneUser] Bug: 983141 Change-Id: Iaa6c47b64573838b55035d3b78dcb50dc2901d3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698506 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#676857}
-
Maksim Moskvitin authored
"Upgrade low risk" replaced with "First-time sign in", to make value meaning more clear. "Upgrade high risk" removed, it was never used and we have no plans to use it. Minor changes to align code with modern style guide. Bug: 983183 Change-Id: Ic4c204c2b4bd7684f96c80509fad25090cd65128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698364 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#676856}
-
Julian Pastarmov authored
s/https://myaccounts.google.com/https://myaccount.google.com BUG=981550 TBR=ljusten Change-Id: I3c4f701b5ed3d0a3d638ae59e790391a48f26905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698530Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#676855}
-
Mike West authored
We're currently measuring whether or not a document is replaced by the execution of a JavaScript URL (e.g. if the JavaScript resulted in a string during navigation, in which case we navigate to a doc whose body is that string). We should figure out how many pageviews rely on `javascript:` execution generally, as that's going to be a larger number. R=andypaicu@chromium.org Change-Id: I474ed7a5072f99e90ddab56351fbc8e5fe327909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698529 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Auto-Submit: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#676854}
-
Gyuyoung Kim authored
Some files of //ios have been including account_consistency_method.h even though they don't use AccountConsistencyMethod or DiceMethodGreaterOrEqual(). This CL removes all unnecessary account_consistency_method.h includes. Instead, this CL adds the include to the files where AccountConsistencyMethod is used actually. Bug: 970268 Change-Id: I7a7e18614523bd8783b73d09abb0ce0898f9ce9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699564 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#676853}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that the latter is only one subclass of O2TS. It moves ClearCache() and ClearCacheForAccount() into PO2TS and this CL stops exposing O2TS::RegisterTokenResponse() which adds a token to the cache since it's handled inside OAuth2AccessTokenManager. Bug: 967598 Change-Id: I1b05b0ac7fe2e6f8d0b22873d9eadaf370e2b78a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699354 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#676852}
-
Javier Ernesto Flores Robles authored
Bug: 976640 Change-Id: I800958a1e853e1c4c23cc76d178c8a64b6563e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698369 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#676851}
-
Javier Ernesto Flores Robles authored
Bug: 976640 Change-Id: I6c02f60414bd525880af64e7edbd9cc3c5fd4c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699603Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#676850}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. It moves StartRequest*(), InvalidateAccessToken(), and InvalidateTokenForMultilogin() from O2TS to PO2TS as there is no instance which refers to O2TS and all instances referred to O2TS take PO2TS with a precursor CL [1]. [1] https://crrev.com/c/1699262 Bug: 967598 Change-Id: I05be40a70f2304f72cc0aca53177800f1e4074e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695741 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#676849}
-
Eric Stevenson authored
https://chromium-review.googlesource.com/c/chromium/src/+/1695855 will convert all native methods to use @NativeMethod interfaces. This CL updates cronet packaging to ignore SysUtilsJni.class as well as SysUtils.class. Bug: 929661 Change-Id: I7eaa3f76a0362d1c4ce332b5a21e46469a84e5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698668 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#676848}
-
Mugdha Lakhani authored
manager was disabled. This becomes a problem if the callback is non-trivial. In this case, a barrier closure in BackgroundSyncLauncher was waiting on this to be called. BackgroundSyncManager: :FireReadyEventsImpl() wasn't calling a callback when the Change-Id: I043bdd8bc4b32fd419d8012dd0a127f0a3bd8615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697742 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#676847}
-
Manuel Rego Casasnovas authored
The following tests are failing on Mac because of crbug.com/983503: * external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-select-elem-001.html * external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-select-elem-002.html BUG=983503 Change-Id: I71c33780fd04fd8c1f9bf37187f429ae303cf352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698398Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#676846}
-
Mario Sanchez Prada authored
Convert implementation (RenderFrameHostImpl) in the browser process and the clients in the renderer process (FrameTest & LocalFrameClientImplTest), as well as the definition of the GetFrameHostTestInterface() in the interface blink.mojom.DocumentInterfaceBroker. Bug: 955171, 978694 Change-Id: I718629681aa83a69764a172c52e4d246d89651b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689196Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#676845}
-
Sylvain Defresne authored
Instead of using IdentityTestEnvironmentChromeBrowserState adaptor, convert the tests to work with a real AuthenticationService (backed by a fake ChromeIdentityService). See design doc: https://docs.google.com/document/d/11cqV7S3WCaeOaP63WQWvzNdvSFflgzwZs8GCgdwQ7Bc/preview Bug: 983171 Change-Id: I72b1395c4a0d733a7f37a45845a4520505ed5d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698502 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#676844}
-
Nasko Oskov authored
These histograms don't seem useful at this point in time and I think they can safely be removed. Bug: 975220 Change-Id: Iac6f8f069d97f96865dd88e120d1b58188feed6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697364 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#676843}
-
Michael van Ouwerkerk authored
Bug: 972061 Change-Id: I9874fa48ac18e82d79fb1d9353c0174be1313f10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697609Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#676842}
-
Ramin Halavati authored
A policy is added to enforce browser to start in guest mode. Bug: 953269 Change-Id: I0e76f40643a5d1dbfe2398247df87c37bcf3c097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657892 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#676841}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5085d9783708..d84fd2677c30 git log 5085d9783708..d84fd2677c30 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 vapier@chromium.org cipd: fix lint errors Created with: gclient setdep -r src/third_party/chromite@d84fd2677c30 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Id4ff59ea1b5a31a2aee1128cff1bdd7351432e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699560Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676840}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios/+log/a53be27c2404..dd575bd308de git log a53be27c2404..dd575bd308de --date=short --no-merges --format='%ad %ae %s' 2019-07-11 andrewoverton@google.com Merge branch 'release-candidate' into stable Created with: gclient setdep -r src/ios/third_party/material_components_ios/src@dd575bd308de The AutoRoll server is located here: https://autoroll.skia.org/r/material-components-ios-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:ios-internal-mdc TBR=bling-p10-rolls@google.com Change-Id: I60b265df2a6d9a365a7aff5f893046b00f7b0c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697079Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676839}
-