GitLab

Mac was calling RequestRepaintForTesting() in production code on
Show. This is just wrong. The reason this code existed is no longer relevant
as far as I can tell. Delete it.

Bug: 840545
Change-Id: I17ebbcbd430860e568223a39d865ed14710ac503
Reviewed-on: https://chromium-review.googlesource.com/1112497Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570116}

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I43d9aea4fa423681080f672ec3d455587e80cd86
Reviewed-on: https://chromium-review.googlesource.com/1112389Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570115}

Fixes a buffer overflow bug (see bug link below).

https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/159d060dceec..7a8bc9a90ca9

$ git log 159d060dc..7a8bc9a90 --date=short --no-merges --format='%ad %ae %s'
2018-06-22 deadbeef Switching from localtime to localtime_r on non-Windows platforms.
2018-06-14 tuexen Ensure that the ip6_plen is provided in network byte order.
2018-06-06 tuexen Improve compliance with RFC 4895 and RFC 6458.
2018-06-02 tuexen Don't overflow a buffer if we receive an INIT or INIT-ACK chunk without a RANDOM parameter but with a CHUNKS or HMAC-ALGO parameter. Please note that sending this combination violates the specification.
2018-05-29 tuexen Try to please the Windows compiler.
2018-05-29 tuexen Plug memory leak recently introduced.
2018-05-28 weinrank Suppress 'type-limits' warning for GCC
2018-05-28 tuexen Fix mask.
2018-05-26 tuexen Allow sys tunables to be set before calling usrsctp_init().
2018-05-26 tuexen Add range check for sysctl set functions.
2018-05-21 tuexen Fix typo.
2018-05-21 tuexen Cleanup and sync with FreeBSD sources.
2018-05-21 tuexen Backport https://svnweb.freebsd.org/changeset/base/333813.
2018-05-21 tuexen Whitespace change.
2018-05-14 tuexen Sync FreeBSD ID and minor cleanups.
2018-05-14 tuexen Ensure MTUs are a multiple of 4.
2018-05-14 ruengeler m_last is not needed
2018-05-09 ruengeler Build clusters
2018-05-09 ruengeler Set DF Flag correctly
2018-05-08 tuexen Remove stray =.
2018-05-08 tuexen Don't invalidate the sockets, since even they are closed, the value is used to join the corresponding threads.
2018-05-08 tuexen Fix typos.
2018-05-08 tuexen When reporting ERROR or ABORT chunks, don't use more data that is guaranteed to be contigous. Thanks to Felix Weinrank for finding and reporting this bug by fuzzing the usrsctp stack.
2018-05-08 tuexen sctp_get_mbuf_for_msg() should return NULL if mbuf is too small.
2018-05-06 tuexen Don't dereference a NULL pointer.
2018-05-06 tuexen Handle the case of m == NULL in m_copym().
2018-04-26 justin.kim recv_thread: Invalidate socket after closing
2018-04-08 tuexen Fix logical inversion bug.
2018-04-08 tuexen Small cleanup, no functional change.
2018-04-08 tuexen Fix a signed/unsiged warning.
2018-03-27 deadbeef Fix increment in sctp_connectx_helper_add
2018-03-27 deadbeef Fix cast in sctp_findassociation_ep_addr
2018-03-23 weinrank Fix warnings for "atomic_init"
2018-03-23 weinrank Check for "-Wstrict-prototypes"
2018-03-21 tuexen Use HTTP/SCTP PPID.

Created with:
  roll-dep src/third_party/usrsctp/usrsctplib

Bug: chromium:854883, chromium:811477
Change-Id: Ib3db2407c2e591b4162c675596346d8be00955a6
Reviewed-on: https://chromium-review.googlesource.com/1112590Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Taylor Brandstetter <deadbeef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570114}

- migrate many methods into the handler
- update loading/error screen specs

Bug: b/78190629
Test: Manual
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I7a590f547cc85309f982c58421f0984721a4f04b
Reviewed-on: https://chromium-review.googlesource.com/1112716Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570113}

This patch prevents the location bar from attempting to show the scrim
before the view it is supposed to appear behind is inflated (thus
making the params null).

Bug: 856225
Change-Id: I7fabcd421251602cc25132db71fbb0482312458f
Reviewed-on: https://chromium-review.googlesource.com/1113953Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570112}

This class serves as the source of truth for which device is the host
for the logged-in account; additionally, it provides the ability to set
the host on the back-end.

If an attempt fails, it is retried every 5 minutes until it either
succeeds or until AttemptToSetMultiDeviceHostOnBackend() is called with
a new device.

Bug: 824568
Change-Id: I61239ac85b84d57a53b259bc05209aee751f7cee
Reviewed-on: https://chromium-review.googlesource.com/1112838
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570111}

Grab the global SecureChannelClient instance in EasyUnlockServiceFactory,
and inject it into EasyUnlockServiceRegular and EasyUnlockServiceSignin.

This change has allowed me to manually verify that Smart Lock works with
the new SecureChannel API, in the regular, lock-screen case. Additional
work still needs to be done to fully integrate the sign-in case, which
will come in subsequent CLs.

R=jhawkins@chromium.org, khorimoto@chromium.org

Bug: 824568, 752273
Change-Id: I77952966eace55dabb6895569c8b18ac03cd1189
Reviewed-on: https://chromium-review.googlesource.com/1108880
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570110}

This reverts commit d37409a1.

Reason for revert: external/wpt/css/css-sizing/min-content-soft-hyphen-001.html failed on Windows 10

https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/36928

Original change's description:
> Move a test for min-content for a soft-hyphen to wpt
> 
> This tests when the inline-size is [min-content]:
> * A `­` produces a break opportunity when computing the
>   min-content inline size.
> * The hyphen character generated by `­` is included into
>   the min-content inline size.
> 
> Originally developed in [CL:1111895].
> 
> [min-content]: https://www.w3.org/TR/css-sizing-3/#valdef-width-min-content
> [CL:1111895] https://chromium-review.googlesource.com/c/chromium/src/+/1111895
> 
> Bug: 636993
> Change-Id: Ib492b2db023a5169247ca00e5b745e42ec33d197
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
> Reviewed-on: https://chromium-review.googlesource.com/1113085
> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570066}

TBR=cbiesinger@chromium.org,kojii@chromium.org

Change-Id: I3fb91c7c2d66e775a12994734a14afc566d05a3e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/1113667Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570109}

When clicking on a link in a PDF to another page/position in the same
document, open in a new window (if shift was pressed) or a new tab
(if ctrl was pressed or if the click was on the middle button).

Use PDF open params to do so, specifying page and y position.

Bug: 720180
Change-Id: I535b707d592056a020033cbbd00a689f3de8e821
Reviewed-on: https://chromium-review.googlesource.com/1112479
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570108}

The CL that causes the flakiness has been reverted. See:
https://chromium-review.googlesource.com/c/chromium/src/+/1112777
Landed as e4144ed1.

This CL enables flaky tests in DownloadActivityTest.

TBR=dtrainor@chromium.org

Bug: 855389,855219,855168,855167
Change-Id: Id53085ed71c5188cd1e7588998bda6f00c7b89a5
Reviewed-on: https://chromium-review.googlesource.com/1113910Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570107}

Change-Id: Iaf5ca9c7787b9ce22a217943ce412ccdca137dcf
Reviewed-on: https://chromium-review.googlesource.com/1093989Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570106}

Sometimes the dialog should not be dismissed, such as when there are no users.

Bug: 839583
Change-Id: Iee275fb636e5842ba2e99b799b8c04539ea1c3bd
Reviewed-on: https://chromium-review.googlesource.com/1093882
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570105}

In preparation for detecting a mismatch between the running sync client
cache guid, and the one persisted in the metadata, a new field is
introduced in model_type_state.proto such that the cache_guid is
persisted togethter with other model type state fields.

Mismatch detection will be used to prevent leak of sync data between
different accounts syncing on the same device.

Bug: 820049
Change-Id: If537753f0e3011148692c27bd3b63a0742872a28
Reviewed-on: https://chromium-review.googlesource.com/1113338
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570104}

This reverts commit a0c1584a.

Reason for revert: It broken Chrome PFQ, see crbug.com/856142 for more details.

Original change's description:
> Reland "Reland "Update fontconfig to 6cc99d6a""
> 
> This reverts commit 812edd08.
> 
> Reason for revert: libuuid1:i386 should now be installed on the bots (bug 853048)
> 
> Original change's description:
> > Revert "Reland "Update fontconfig to 6cc99d6a""
> > 
> > This reverts commit 0c91664f.
> > 
> > Reason for revert: Broke Linux Builder (dbg)(32)
> > 
> > Still missing libuuid:
> > 
> > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20%28dbg%29%2832%29/83697
> > 
> > [775/4337] ACTION //tools/v8_context_snapshot:generate_v8_context_snapshot(//build/toolchain/linux:clang_x86)
> > FAILED: v8_context_snapshot.bin 
> > python ../../build/gn_run_binary.py ./v8_context_snapshot_generator --output_file=v8_context_snapshot.bin
> > ././v8_context_snapshot_generator: error while loading shared libraries: libuuid.so.1: cannot open shared object file: No such file or directory
> > ./v8_context_snapshot_generator failed with exit code 127
> > 
> > Original change's description:
> > > Reland "Update fontconfig to 6cc99d6a"
> > > 
> > > This is a reland of e6db40d9
> > > 
> > > Reason for reland: All bots should now have libuuid1 installed (bug 853048).
> > > 
> > > Original change's description:
> > > > Update fontconfig to 6cc99d6a
> > > >
> > > > Changelog [1].  This is necessary to pick up [2] for fixing undefined-shift
> > > > UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround,
> > > > [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to
> > > > fix a use-after-free.
> > > >
> > > > Fontconfig also now requires libuuid as a dependency, so whitelist it as a
> > > > dependency since we statically link fontconfig.
> > > >
> > > > [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> > > > [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e
> > > > [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914
> > > > [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74
> > > > [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c
> > > > [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> > > >
> > > > BUG=831146,822737,787020,829890,847323
> > > > TBR=thestig,dnicoara
> > > >
> > > > Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec
> > > > Reviewed-on: https://chromium-review.googlesource.com/1095538
> > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > > Reviewed-by: Lei Zhang <thestig@chromium.org>
> > > > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#567445}
> > > 
> > > TBR=thestig,dnicoara
> > > 
> > > Bug: 831146, 822737, 787020, 829890, 847323, 853048
> > > Change-Id: Id42738aaf5841bd219dc0e9209680c87e88f4869
> > > Reviewed-on: https://chromium-review.googlesource.com/1104759
> > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#568221}
> > 
> > TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,thomasanderson@chromium.org
> > 
> > Change-Id: Icd39638df79083776546d4283675c3e172bbefe4
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 831146, 822737, 787020, 829890, 847323, 853048
> > Reviewed-on: https://chromium-review.googlesource.com/1105539
> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#568346}
> 
> TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,ortuno@chromium.org,thomasanderson@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 831146, 822737, 787020, 829890, 847323, 853048
> Change-Id: I5fe29b3ff4ba7ec81498878124a39c70d5e9a8be
> Reviewed-on: https://chromium-review.googlesource.com/1112179
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Elliott Friedman <friedman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#569800}

TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,friedman@chromium.org,ortuno@chromium.org,thomasanderson@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 831146, 822737, 787020, 829890, 847323, 853048
Change-Id: Ic4c518680efb4480a9568829996f5ceebaf459e7
Reviewed-on: https://chromium-review.googlesource.com/1113840Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570103}

The Android horizontal tab switcher currently feels very "slippery." This is
largely because we currently have a bug in the logic that gives flings a "boost"
to the next tab where, if you start dragging a tab over so that it's already the
centered tab, we apply the boost anyway, so you actually end up scrolling by two
tabs. The minimum scroll distance to move over by one tab is also currently
fairly large, which makes it easier to run into the bugging fling boost
behavior.

This CL fixes these two issues. I'm also introducing some non-linearity into the
scroll distance function. After this CL, the velocity range to scroll by one tab
is fairly large, then the velocity range to scroll by two tabs is somewhat
smaller, and then the ranges to scroll by 3 through 11 tabs are fairly small,
and then the range to scroll by 12 tabs is fairly large again.

Bug: 849417
Change-Id: I9f3d442a191091a126410526c9097c445eb9fe40
Reviewed-on: https://chromium-review.googlesource.com/1109212
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570102}

https://skia.googlesource.com/skia.git/+log/c050a1a185bf..ed55419d859b


git log c050a1a185bf..ed55419d859b --date=short --no-merges --format='%ad %ae %s'
2018-06-25 herb@google.com Use indices into the vectors shared by runs
2018-06-25 caryclark@skia.org fix path measure fuzzes
2018-06-25 brucewang@google.com Implement onMakeClone(const SkFontArguments& args) in classes: SkTypeface_Empty, SkTypeface_Stream, SkTypeface_File
2018-06-25 robertphillips@google.com Add bullet proofing for preAbandonContext
2018-06-25 egdaniel@google.com Make GrVkBackendContext no longer derive from SkRefCnt.


Created with:
  gclient setdep -r src/third_party/skia@ed55419d859b

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@chromium.org

Change-Id: I93b01085a5d5cb6814bb2b040761af55aae4eec1
Reviewed-on: https://chromium-review.googlesource.com/1113819Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#570101}

The capture window will not receive events while locked because
there is an extra mechanism to block events in locked state, but
having capture window in locked state will make lock UI unusable
by mouse/touch.

Explicitly release capture so that mouse/touch event works
when locked.

BUG=788782
TEST=covered by unittest

Change-Id: I01849f71ec0f059a21b433295fbdf816962d44d4
Reviewed-on: https://chromium-review.googlesource.com/1112938Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570100}

Since now we need to prepare password hash for both sync, other gaia
and enterprise passwords, we should rename the function as
PasswordStore::PreparePasswordHashData(..) and don't gate on empty
sync username.

Also fix minor UMA logging issue in
PasswordStore::SaveProtectedPasswordHashImpl

Bug: 830998
Change-Id: I26cb613babcdd0268785e61b52c021aa9f343cb5
Reviewed-on: https://chromium-review.googlesource.com/1112586Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570099}

Because other features (capping heavy pages in particular) wish to us
incredibly similar functionality as the previews opt out blacklist, this
should be moved to a component. components/blacklist will be a component
for consumable blacklists and opt_out_blacklist is a sub directory of
one such blacklist.

TBR=pwnall@chromium.org

Bug: 852593
Change-Id: I1b0b041eac6a715c70eaa3cf24542f63977caa50
Reviewed-on: https://chromium-review.googlesource.com/1109035
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570098}

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic7258e4b4e03988344412e2e15893ea30f68ae38
Reviewed-on: https://chromium-review.googlesource.com/1112939Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570097}

The extensions network throttle (ExtensionThrottleManager) used
to use the net::NetLog to log throttling activity. Logging was
only done if ExtensionThrottleManager::set_net_log was called,
but that was removed nearly four years ago in refs/heads/master@{#298862}
(https://codereview.chromium.org/631203003).

This change removes the logging implementation as these classes
will soon be moving to the render process.

Bug: 784576
Change-Id: I1025dd6f3134d438e549165f5b7045b3ecf2dc61
Reviewed-on: https://chromium-review.googlesource.com/1113899
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570096}

This CL changes the |origin_time_| and |zero_time_| of DocumentTimeline
to TimeTicks.

Change-Id: Idd51311085539cf5ed4c8a5b2e1b9bb21187be65
Reviewed-on: https://chromium-review.googlesource.com/1110956Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570095}

bug: b/110702574, 855396
Change-Id: I3be9d02d2ed07b39bfa10535f3cafee86e01d044
Reviewed-on: https://chromium-review.googlesource.com/1112871
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570094}

R=amineer@chromium.org

Cq-Include-Trybots: luci.chromium.try:closure_compilation;luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8498e15ed6611c2fc853e0aff3e0c97ca8a94516
Reviewed-on: https://chromium-review.googlesource.com/1114000Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570093}

WebContents::GetURL() is deprecated because there's no way to know
*what* URL it's giving you. In this particular case, it pulled a
URL from the *future* of a page's navigation history, which caused
a loop to not terminate properly.

(And all the metrics are wrong :( ouch )

BUG=854430
TEST=as in bug

Change-Id: I798af0278ffde3421fa933644513fafba8bd0b2d
Reviewed-on: https://chromium-review.googlesource.com/1113660Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570092}

Bug: 824568
Change-Id: Ia0c761353aff3ca86848e36ec90f85d6a7ff7373
Reviewed-on: https://chromium-review.googlesource.com/1112953Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570091}

This CL modifies the V4L2JpegDecodeAccelerator::ConvertOutputImage
method to pass the coded size of the output VideoFrame to libyuv instead
of passing the size of the V4L2 output buffer.

The motivation is that the coded size of the V4L2 can be larger than the
coded size of the VideoFrame. For example, on an elm (CrOS 10802.0.0),
decoding a 41x22 image causes the V4L2 buffer to be 64x24 while the
coded size of the VideoFrame is 42x22. So, it doesn't seem safe to pass
64x24 to the libyuv conversion routines assuming that the VideoFrame is
backed by memory that's only enough for a 42x22 frame.

This doesn't fix the referenced bug, but it should make copies safer
even for even-sized images. I tested one of the modified paths on an elm
(when output_buffer_pixelformat_ == V4L2_PIX_FMT_YUV422M and the
output_buffer_num_planes_ != 1) to make sure the tests still pass. I
couldn't find a device to test the path when
output_buffer_pixelformat_ == V4L2_PIX_FMT_YUV420M and
output_buffer_num_planes_ != 1, so relying on automated testing.

Bug: 852236
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Id0acef8f6f6c5e144ff4d6620dd3db3b53bff415
Reviewed-on: https://chromium-review.googlesource.com/1111247Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570090}

This reverts commit 8fe6701f.

Reason for revert: webkit_unit_tests failing on chromium.mac/Mac10.13 Tests


Original change's description:
> Scheduler: Bug in FrameAndTaskPriorityExperiment.
> 
> LowPriorityForSubFrameThrottleableTask study isn't using is_subframe
> signal. That is, all throttleable tasks are assigned low priority
> regardles of the type of the frame.
> 
> Change-Id: I1e924ef483b458a9b0d21e81a91d275901b9cb37
> Reviewed-on: https://chromium-review.googlesource.com/1112248
> Commit-Queue: Farah Charab <farahcharab@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570043}

TBR=altimin@chromium.org,farahcharab@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Bug: 856255
Change-Id: I0236f77b0f551610fca97a93c148c9016d8f7bb9
Reviewed-on: https://chromium-review.googlesource.com/1113838Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570089}

Drive-by fix some lint.

Bug: 851940, 856176
Change-Id: Ia42c0902b58cd278afc2c4703a50982204ef75b8
Reviewed-on: https://chromium-review.googlesource.com/1099235
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570088}

This CL removes the copy constructor from the gfx::GpuMemoryBufferHandle
replacting it with move operations. This is preparatory step to make
GpuMemoryBufferHandle using the new shared memory classes that are move-only.

GpuMemoryBufferHandle holds a system resource that should be properly closed
after use. Move semantics allow to introduce the more clear ownership model
and prevent resource leaks.

Bug: 854594
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I27907d7a8b09aa4003de2c846966bf7d97aaa30c
Reviewed-on: https://chromium-review.googlesource.com/1109972Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570087}

Allows the Cast display configurator to configure the lookup tables for
degamma and gamma.

BUG=b/109942195
TEST=Compile

Change-Id: I9d3f738ca9024060484dd5eef8202884b38cc3b8
Reviewed-on: https://chromium-review.googlesource.com/1113803Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570086}

Add feature flag for copying image to system clipboard.

Bug: 163201
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8110f65f739891b01b82b866215b122dd93ac0aa
Reviewed-on: https://chromium-review.googlesource.com/1112661
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570085}

Adds two workarounds for Chrome being resumed or started too early when
entering VR. These can be removed if/when the platform-side issue that
causes these issues is fixed in VrCore.

Bug: 854327, 762724
Change-Id: If9645c58e9d208a734582992aad5c85d378f5f40
Reviewed-on: https://chromium-review.googlesource.com/1112761Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570084}

Bug: 844670
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Icd830a0791b891393f2608aa11c487639d6a9a72
Reviewed-on: https://chromium-review.googlesource.com/1095734
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570083}

The G is made 16x16 within a circle of diameter 24.
This icon is used for default and knowledge graph
answer results.

Bug: 855723
Change-Id: Ia8b48837208606b4dcf515412b642ad780e16718
Reviewed-on: https://chromium-review.googlesource.com/1112643
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570082}

CallbackBufferSize() were scattered around many classes for no specific
reason. This CL cleans them up and contains it to
DefaultAudioDestinationNode.

Bug: 854229
Change-Id: I9116cf8ecd9398108fcdcac89cbbfb8c42de957e
Reviewed-on: https://chromium-review.googlesource.com/1112072
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570081}

This patch removes U+FFFC from characters to have zero-width.

LayoutNG does not have this specialization, and Edge and Gecko
do not make U+FFFC zero-width either.

As part of the investigation, zero-width-characters.html was
changed to testharness.js.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I278778bd030d87f6691de0e217b53e5cd62287a1
Reviewed-on: https://chromium-review.googlesource.com/1110182Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570080}

Bug: 803494
Change-Id: Ie8e7d6b4cf14be21cecc4e0b9bd6f808cef487c4
Reviewed-on: https://chromium-review.googlesource.com/1102436Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570079}

https://chromium.googlesource.com/catapult.git/+log/29f3b8927f88..7d423fc5614b


git log 29f3b8927f88..7d423fc5614b --date=short --no-merges --format='%ad %ae %s'
2018-06-25 perezju@chromium.org [Telemetry] Remove workaround for closing browser before tracing stops


Created with:
  gclient setdep -r src/third_party/catapult@7d423fc5614b

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:854212
TBR=sullivan@chromium.org

Change-Id: I3c562b6ca2fdc6a3d7c2c758c0f1e4dde5b70e8e
Reviewed-on: https://chromium-review.googlesource.com/1113478Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#570078}

Adds logic to DisplayCutoutHostImpl to only use the viewport
fit value from the current fullscreen frame. If there
is no fullscreen frame then we should default to auto.

Also renames a mojo call from ViewportFitChanged to
NotifyViewportFitChanged to avoid a naming collision with
WebContentsObserver.

BUG=838400

Change-Id: I78498db747739b5def5f19b70563d9ea18612700
Reviewed-on: https://chromium-review.googlesource.com/1105510Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570077}