- 10 Apr, 2019 40 commits
-
-
Anthony Cui authored
Add build flags for async VR. Add proguard configs for keeping VR compatible with base. Bug: 947544 Change-Id: Ibbfc1eb9325d09e6ceb3e241bc82ef4ff0ad1f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552020Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Anthony Cui <cuianthony@google.com> Cr-Commit-Position: refs/heads/master@{#649670}
-
Guohui Deng authored
CastAudioOutputStream::CmaWrapper failed to set the correct value on |channel_layout| in |audio_config|. The default value is considered to be invalid and causes error when sent through Mojo pipe. Bug: internal b/129642940 Test: None Change-Id: Ie449ee966c4d79717a4951e18b1953f62a109929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562089Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Guohui Deng <guohuideng@chromium.org> Cr-Commit-Position: refs/heads/master@{#649669}
-
Ehsan Karamad authored
This CL tracks certain important metrics for MimeHandlerView. The metrics are mostly around postMessage API usage for embedded MimeHandlerView which would determine the use cases for cross vs. same origin resources. Expected Outcome: * Determine the popularity of the API; and in specific, the type of messages. * Determine the usage of the API for cross-origin resources. This would help decide the path forward for CORB vs. embedded PDF. * Frequency of postMessage to embedded PDF. If the usages are small UKMs might help track down the users of the API and possibly deprecate the postMessage API in favor of window.postMessage *after* MimeHandlerViewInCrossProcssFrame ships. TBR=lazyboy@chromium.org Bug: 659750, 929300 Change-Id: Id2d59a2891c7fe192bb4932eff761d49e64771d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558615 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#649668}
-
John Delaney authored
This a precursor change that tracks mime type counts for all resource types in frames. This will allow future changes to record other mime types without adding separate counters to FrameData. Bug: 951480 Change-Id: I700c8ce9f3065082a621ce8e69027fa8607105e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562291Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#649667}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/280474c2a985..77b3499b8809 git log 280474c2a985..77b3499b8809 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@77b3499b8809 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I5d43f8a410484cba53663171bea6ae243ff1316b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562492Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649666}
-
Rakib M. Hasan authored
This CL had to be reverted because GPU bots were failing because the results_merger.py script could not handle the test_name_prefix field that was still getting populated in the JSON results. This CL will add the metadata field along side the test_name_prefix field in the Optional fields list in the results_merger.py script. It also removes the checking of test_name_prefix in the gpu unit tests because the test_name_prefix field will be removed from the top level of the results in a future CL. Bug: chromium:698902 Change-Id: I4867e60ca5a97d426d5fd1a4de08e26c14d326ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559492 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#649665}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/14003828df72..1208002548e8 git log 14003828df72..1208002548e8 --date=short --no-merges --format='%ad %ae %s' 2019-04-10 egdaniel@google.com Revert "Remove unnecessary flush in RenderYUVAToRGBA (take 2)" 2019-04-10 mtklein@google.com make to_vec template parameters explicit 2019-04-10 mtklein@google.com tweak SkVx to play nicely with others 2019-04-10 herb@google.com Add an index to SkGlyphPos 2019-04-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-04-10 brianosman@google.com Make SkShaper's GN setup more DLL friendly 2019-04-10 brianosman@google.com Make Skottie's GN setup more DLL friendly 2019-04-10 ethannicholas@google.com moved files generated from .fp files into generated/ directories 2019-04-10 herb@google.com Reland "Do not use sub-pixel positioning for source space" 2019-04-10 robertphillips@google.com Remove unnecessary flush in RenderYUVAToRGBA (take 2) Created with: gclient setdep -r src/third_party/skia@1208002548e8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I30ca000d4eb2321a0ab82f9fbcdd5c4d6164b2f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562066Reviewed-by:
-
Marc Treib authored
SyncerErrors with type NETWORK_CONNECTION_UNAVAILABLE should only be created through the NetworkConnectionUnavailable() factory function, to make sure that the expected net_error_code is always set. Bug: 842096 Change-Id: Ibad86d6f0be6a36306db8b7e0e0d28404321f841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560190 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#649663}
-
Tina Wang authored
Bug: 242119 Change-Id: Ia83d5b52366f12828c6623a0e601e7691b196b44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559262 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#649662}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7274e4b5..790137c1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0f1e9124f6d4dbee65ae0c9ecd9c0e459341b82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562083Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649661}
-
Jérôme Lebel authored
Don't sign out the user when FirstSetupComplete flag is off when UnifiedConsent is on. Bug: 948681 Change-Id: I8da53595d1e89652e9e566d5402a2733aec21f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554672 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#649660}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7682feb30b68..21a8eca7b39f Created with: gclient setdep -r src-internal@21a8eca7b39f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=harrisjay@chromium.org,ellyjones@chromium.org,btolsch@chromium.org Change-Id: I96006ce9507ad6d6040184a6a2230a1a4f45c64d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562490Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649659}
-
Theresa authored
SparseArray#valueAt(int index) takes an int index param where the previous assert was passing a key. Use SparseArray#get(int key) instead. BUG=950744 Change-Id: I4842a1718b09bdec00bce74117e1e9389a313bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562084Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#649658}
-
Jamie Madill authored
This was preventing configs from finding new builders added that had a different number of cores. Bug: 822310 Change-Id: I59f452cb913a10cae8a54d8f0062f5fd2dc5cdff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562452Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#649657}
-
Kenneth Russell authored
Builder's name in job was incorrect, so it wasn't getting scheduled. Bug: 948902 Change-Id: I8731c706a77514f2b4d5e6e592d93a777ce113ef Tbr: martiniss@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562614Reviewed-by:
-
Jacob Dufault authored
Previously when ResetScreen was allocated it'd force set itself as the active screen. This is the only screen that does this and it does not play well with pre-allocating screen instances ahead of time. Bug: None Change-Id: Ie70a0e64dd1f6891935fd0f6d39c99ab1d4999d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560437 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#649655}
-
Tommy Steimel authored
This CL adds a check to prevent handling media keys when the screen is locked. Bug: 951485 Change-Id: I1a2481894e20ceee1879d32066cf969a0b4263bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562370Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#649654}
-
Yue Zhang authored
Add tint for NewTabButton(+) in top tool bar when tabgrid is enabled. Bug: 946290 Change-Id: I4e1ad838789b63720465f818294f82042b2a6475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559209Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@google.com> Cr-Commit-Position: refs/heads/master@{#649653}
-
Devlin Cronin authored
Clean up various extension action-related manifest constants: - Instead of prefixing with "PageAction", just say "Action". - Rename kPageActionId to kFileBrowserHandlerId, since that's the only thing that uses it. - Remove undefined constant kInvalidPageActionPopupHeight - Combine kInvalidPageActionPopup and kInvalidPageActionPopupPath - Remove unused constants kPageActionTypePermanent and kPageActionTypeTab Bug: 893373 Change-Id: Ic22f6d6f0ba1399c1f2dbbaeea3eac62e954e32d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559767 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#649652}
-
chrome://systemdpapad authored
Bug: 677338 Change-Id: Ief7c222727c34edbec0a0112103b2902fb4f4848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561967Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#649651}
-
Toni Barzic authored
This fixes a race in GaiaScreenHandler method for setting test user credentials not to start AddUserFlow (and force GAIA reload) if the auth extension load has started (in addition to when the gaia frame started loading) - this was causing issues because the flow would clear up the current sign-in partition, without stopping the current auth extension load (and later attempt to authenticate would crash on current signin storage partition session being empty). NOTE: This is a wider issue that I plan to look more closely into, but this change should unblock tests. BUG=936041,891277 Change-Id: Ie1f76daf0278af59af8b85c4a0fd82b9b0223555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560534 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Auto-Submit: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
Alexandre Frechette authored
Bug: 948675 Change-Id: I674f924ef3fb7bf4351cce0140f096c5a2707109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549195 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#649649}
-
David 'Digit' Turner authored
This CL introduces a new script that can be used to check and try to fix various locale-related files in the Chromium source directory. This is essentially a replacement for build/android/check_android_grit_strings.py that will be extended to support more features over-time, most of them not Android specific. This will be used to ease the addition of translations for new locales. Example usage: # Print list of locales supported by Chrome. build/locale_tool.py list-locales # Print list of locales supported by Chrome, as JSON build/locale_tool.py list-locales --as-json # Check all .grd and BUILD.gn for locale-related issues build/locale_tool.py check-all --scan-dir . # Does the same and tries to fix bad files. build/locale_tool.py check-all --scan-dir . --fix-inplace # Only check and fix Android .xml outputs in .grd files: build/locale_tool.py check-grd-android-outputs \ --scan-dir . --fix-inplace # Try to add android_webview .xtb outputs in .grd files # for new locales 'aa' and 'zz': build/locale_tool.py check-grd-translations \ --scan-dir android_webview/ \ --add-locales 'aa zz' \ --fix-inplace # Perform internal consistency check between this script # and the content of build/config/localges.gni build/locale_tools.py check-locales BUG=944606 R=agrieve@chromium.org, govind@chromium.org, jshin@chromium.org, estevenson@chromium.org Change-Id: I3753bb528f6a56bec94cce8ec7b5b802f438857e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553425 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by: -
Zhenyao Mo authored
Also, check in results for from build 3363 to 4131. Data might be deleted and lost forever at a future point. Such data is valuable to understand the issues with IPG and potential solutions for reliable power measuring. BUG=867155 TEST=manual R=sunnyps@chromium.org Change-Id: Iee41152a10993c72e13b3daff4c3d6e08ac5bee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558747 Auto-Submit: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
ishell@chromium.org authored
With enabled pointer compression empty V8 instance reports memory usage values less than 1 MB which makes the test fail for Memory.Experimental.Renderer2.V8.* metrics. Bug: v8:7703, chromium:949157 Change-Id: I285731326732157b592efc197c1fda1a5016c686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559141Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#649646}
-
John Budorick authored
Follow-up to crrev.com/c/1560141 Bug: 861983 Change-Id: I8c8a51fc8b6c44b2e2e693e5746e2d370bacde53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562290 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#649645}
-
Jun Mukai authored
This adds to mark the tracing of overview enter/exit animation to ease the performance analysis. Bug: 949227 Test: manually in chrome://tracing Change-Id: Ia616dbbc8f825fd459e1253b2d60915a1f653250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560307 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#649644}
-
Scott Violet authored
As part of https://chromium-review.googlesource.com/c/chromium/src/+/1547051 InvalidateLayout() was changed to result in a Layout() at a later date. This means there may be an additional Layout() called. AppsGridView cancels any animations if Layout() is called. Currently, an async layout is being triggered as part of preparing for the animation. Which means the reorder animation is canceled. The fix is to explicitly force a layout (which makes the pending layout do nothing) and further ignore the layout call. BUG=949713 TEST=see steps in bug. Change-Id: I9aa887e4e49b182a2912a6c599fa26618429e1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562372Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#649643}
-
Tibor Goldschwendt authored
Bug: 949154 Change-Id: Ifbaeb87a60580192780ad7f2e9c41495d50433c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550684 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#649642}
-
Yining Wang authored
ManifestWebAppBrowserController is a derived class from WebAppBrowserController. It should be able to control the UI look for focus mode windows. Bug: 950182 Change-Id: I28ebe4e123a719d44a52fabe7b86bb1b92e4c46f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553083 Commit-Queue: Yining Wang <yiningwang@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#649641}
-
Jesse Selover authored
Bug: 795089 Change-Id: I22a904cc0fb8dd1445424c6d526dbbc9bfbed788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1475204 Commit-Queue: Jesse Selover <jselover@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#649640}
-
Alexander Alekseev authored
Automatic time zone detection metrics report external location provider health status and should be kept until we use this API. Bug: 933191 Change-Id: I635053e47bdb604f126c5d67ec06d4e9dedb62dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559339 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#649639}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0951cfd13e29..408a3c63d37b git log 0951cfd13e29..408a3c63d37b --date=short --no-merges --format='%ad %ae %s' 2019-04-10 noahric@chromium.org Add explicit stride options to I420BufferPool. 2019-04-10 eshr@google.com Reland "Add new field trial for controlling congestion window settings" 2019-04-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 23e69401..19364ba5 (649414:649524) Created with: gclient setdep -r src/third_party/webrtc@408a3c63d37b The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia3c4eeaeeb9cb29fe7776347aa72bdbbc492363d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562048Reviewed-by:
-
Junbo Ke authored
Bug: b/120907590 Merge-With: eureka-internal/260345 Test: Manual test on device Change-Id: I5c2063815cbeae78761496871db1bf2e804c82a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554901Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
-
Marialicia Villarreal Garcia authored
1. This change hooks up UIA_AutomationFocusChangedEventId for views. 2. This change moves NotifyAccessibilityEvent to fire UIA events until after our internal state is up-to-date. We need to do this due to a bug where Narrator focus does not follow keyboard focus since NotifyAccessibilityEvent is called before updating the focused item in SetPopupFocusOverride. Bug: 928949 Change-Id: I0635b7f93c8a4e5ac223f4b379eb7082e99aad17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559161Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Maria Villarreal <mavill@microsoft.com> Cr-Commit-Position: refs/heads/master@{#649636}
-
Chris Lu authored
Bug: 919685 Change-Id: Idf3c2a5f3c4f2dc4658b684fea5b5e02104a9c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561831Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#649635}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/28fa257fa607..73904e05a2db git log 28fa257fa607..73904e05a2db --date=short --no-merges --format='%ad %ae %s' 2019-04-10 treehugger-gerrit@google.com Merge "Show buffer overruns in ProfileProto." Created with: gclient setdep -r src/third_party/perfetto@73904e05a2db The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I839e5a467af12f1f7a299760fc8509b84f524095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562047Reviewed-by:
-
Victor Costan authored
The method and its derivatives are supposed to be used in tests, so it's good to be exact. Change-Id: Ifc4d6c278a32a125e79c2f1bc6cb3defd01494ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558158Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#649633}
-
Justin Cohen authored
iOS 12.2 has a bug where the WKWebView internal page doesn't display. Bug: 950488, 793317 Change-Id: Idf3e26125b121a7b753f65e176337f5fc67ce2ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562218Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#649632}
-
Justin Cohen authored
Original code was changed to use GetLastCommittedURL instead of GetVisibleURL to bandaid over the NTP pending item bug in crrev.com/c/1456639. That bandaid was disabled in crrev.com/c/1534359, but didn't change the NTP check back to GetVisibleURL. Bug: 931569 Change-Id: I1f8a8acc2ec151c67ca2103602a457b90e65dd09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562224 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
