- 18 Sep, 2018 40 commits
-
-
Danyao Wang authored
This method looks up the current NavigationItem associated with WKBackForwardList.currentItem and updates its URL to handle two edge cases for location.replace. The lookup crashes if WKBackForwardList.currentItem is nil. The correct NavigationItem to update in this case is |self.currentNavItem|. An egtest that triggers this scenario is added; though it's not clear if this is the only case. Bug: 866142 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I5c76ad50296127234f498741a62b796fb4397461 Reviewed-on: https://chromium-review.googlesource.com/1228442Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#592175}
-
Leonard Mosescu authored
By default only official builds have build-ids. Setting force_local_build_id = true can be used to add build-ids to local builds as well. Bug: 870919 Change-Id: I007ffbfb0d6005e980b4dea5a394471396ad3d92 Reviewed-on: https://chromium-review.googlesource.com/1231374 Commit-Queue: Leonard Mosescu <mosescu@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592174}
-
Kevin Strohbehn authored
Bug: 869325 Change-Id: I7d939b5484869cb8e620f2f8152f240e433b3086 Reviewed-on: https://chromium-review.googlesource.com/1229361Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Kevin Strohbehn <ginko@google.com> Cr-Commit-Position: refs/heads/master@{#592173}
-
Dave Tapuska authored
Use wtf_size_t when dealing with WTF types. BUG=879657 Change-Id: I125b0857c16db2b96835052c043e7d246cb3eb31 Reviewed-on: https://chromium-review.googlesource.com/1228129 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592172}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cb44953479a1..57efeca83c87 Created with: gclient setdep -r src-internal@57efeca83c87 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ife44e18c35e59166b98af85f3f3f624f5bea097e Reviewed-on: https://chromium-review.googlesource.com/1231975Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592171}
-
edchin authored
This reverts commit 92d8795b. Reason for revert: Failures on iOS 10 devices and simulator bots: ipad10-device-x64 ipad10-simulator-x64 ios_chrome_ui_egtests (iPad Air iOS 10.3.3) on iOS-10.3.3 SideSwipeTestCase/testSideSwipeTopToolbar: [0918/100933.388949:WARNING:embedded_test_server.cc(239)] Request not handled. Returning 404: /favicon.ico ../../ios/chrome/test/earl_grey/chrome_earl_grey.mm:188: error: -[SideSwipeTestCase testSideSwipeTopToolbar] : Exception: AssertionFailedException Exception Name: AssertionFailedException Exception Reason: (([condition waitWithTimeout:base::test::ios::kWaitForUIElementTimeout]) is true) failed Exception Details: Failed waiting for web view containing Echo Bundle ID: com.google.gtest.ios-chrome-ui-egtests Stack Trace: ( 0 EarlGrey 0x0000000105c58748 -[GREYDefaultFailureHandler handleException:details:] + 780 1 ios_chrome_ui_egtests 0x0000000100a05cc8 +[ChromeEarlGrey waitForWebViewContainingText:] + 628 2 ios_chrome_ui_egtests 0x0000000100a543fc -[SideSwipeTestCase checkSideSwipeOnToolbarClass:] + 1196 3 CoreFoundation 0x0000000187ea4e80 <redacted> + 144 4 CoreFoundation 0x0000000187d9a2c4 <redacted> + 292 5 EarlGrey 0x0000000105c495c8 -[GREYTestCaseInvocation invoke] + 84 6 XCTest 0x0000000105aacf3c __24-[XCTestCase invokeTest]_block_invoke_2.198 + 68 7 XCTest 0x0000000105b14560 -[XCTMemoryChecker _assertInvalidObjectsDeallocatedAfterScope:] + 68 8 XCTest 0x0000000105ab57c0 -[XCTestCase assertInvalidObjectsDeallocatedAfterScope:] + 112 9 XCTest 0x0000000105aacec4 __24-[XCTestCase invokeTest]_block_invoke.192 + 196 10 XCTest 0x0000000105b01710 -[XCTestCase(Failures) performFailableBlock:testCaseRun:shouldInterruptTest:] + 64 11 XCTest 0x0000000105b01628 -[XCTestCase(Failures) _performTurningExceptionsIntoFailuresInterruptAfterHandling:block:] + 108 12 XCTest 0x0000000105aacb38 __24-[XCTestCase invokeTest]_block_invoke + 812 13 XCTest 0x0000000105b07298 -[XCUITestContext performInScope:] + 264 14 XCTest 0x0000000105aac744 -[XCTestCase testContextPerformInScope:] + 100 15 XCTest 0x0000000105aac7f8 -[XCTestCase invokeTest] + 140 16 EarlGrey 0x0000000105c40e6c -[XCTestCase(GREYAdditions) grey_invokeTest] + 392 17 XCTest 0x0000000105aae39c __26-[XCTestCase performTest:]_block_invoke_2 + 44 18 XCTest 0x0000000105b01710 -[XCTestCase(Failures) performFailableBlock:testCaseRun:shouldInterruptTest:] + 64 19 XCTest 0x0000000105b01628 -[XCTestCase(Failures) _performTurningExceptionsIntoFailuresInterruptAfterHandling:block:] + 108 20 XCTest 0x0000000105aae2b4 __26-[XCTestCase performTest:]_block_invoke.337 + 96 21 XCTest 0x0000000105b11a58 +[XCTContext runInContextForTestCase:block:] + 216 22 XCTest 0x0000000105aada50 -[XCTestCase performTest:] + 648 23 XCTest 0x0000000105aee88c -[XCTest runTest] + 60 24 XCTest 0x0000000105aa8ec4 __27-[XCTestSuite performTest:]_block_invoke + 296 25 XCTest 0x0000000105aa87c4 -[XCTestSuite _performProtectedSectionForTest:testSection:] + 68 26 XCTest 0x0000000105aa8a5c -[XCTestSuite performTest:] + 272 27 XCTest 0x0000000105aee88c -[XCTest runTest] + 60 28 XCTest 0x0000000105aa8ec4 __27-[XCTestSuite performTest:]_block_invoke + 296 29 XCTest 0x0000000105aa87c4 -[XCTestSuite _performProtectedSectionForTest:testSection:] + 68 30 XCTest 0x0000000105aa8a5c -[XCTestSuite performTest:] + 272 31 XCTest 0x0000000105aee88c -[XCTest runTest] + 60 32 XCTest 0x0000000105aa8ec4 __27-[XCTestSuite performTest:]_block_invoke + 296 33 XCTest 0x0000000105aa87c4 -[XCTestSuite _performProtectedSectionForTest:testSection:] + 68 34 XCTest 0x0000000105aa8a5c -[XCTestSuite performTest:] + 272 35 XCTest 0x0000000105aee88c -[XCTest runTest] + 60 36 XCTest 0x0000000105b1eb2c __44-[XCTTestRunSession runTestsAndReturnError:]_block_invoke + 176 37 XCTest 0x0000000105b1ec5c __44-[XCTTestRunSession runTestsAndReturnError:]_block_invoke.80 + 60 38 XCTest 0x0000000105ac08fc -[XCTestObservationCenter _observeTestExecutionForBlock:] + 524 39 XCTest 0x0000000105b1e8ac -[XCTTestRunSession runTestsAndReturnError:] + 612 40 XCTest 0x0000000105a8dad4 -[XCTestDriver runTestsAndReturnError:] + 416 41 XCTest 0x0000000105b0e274 _XCTestMain + 1436 42 libXCTestBundleInject.dylib 0x0000000105915724 __copy_helper_block_ + 0 43 CoreFoundation 0x0000000187e4d30c <redacted> + 20 44 CoreFoundation 0x0000000187e4cb28 <redacted> + 288 45 CoreFoundation 0x0000000187e4a998 <redacted> + 728 46 CoreFoundation 0x0000000187d7ada4 CFRunLoopRunSpecific + 424 47 GraphicsServices 0x00000001897e5074 GSEventRunModal + 100 48 UIKit 0x000000018e02ec9c UIApplicationMain + 208 49 ios_chrome_ui_egtests 0x0000000100045618 main + 536 50 libdyld.dylib 0x0000000186d8959c <redacted> + 4 ) Screenshots: { "Screenshot At Failure": "/var/mobile/Containers/Data/Application/8AE3CF5E-F002-4373-8F6F-826C6E868992/Documents/SideSwipeTestCase_testSideSwipeTopToolbar-AssertionFailedException-001584B5-0BD5-480A-BE35-237D1281481F/SideSwipeTestCase_testSideSwipeTopToolbar.png", "Visibility Checker Most Recent Before Image": "/var/mobile/Containers/Data/Application/8AE3CF5E-F002-4373-8F6F-826C6E868992/Documents/SideSwipeTestCase_testSideSwipeTopToolbar-AssertionFailedException-001584B5-0BD5-480A-BE35-237D1281481F/SideSwipeTestCase_testSideSwipeTopToolbar_before.png", "Visibility Checker Most Recent Expected After Image": "/var/mobile/Containers/Data/Application/8AE3CF5E-F002-4373-8F6F-826C6E868992/Documents/SideSwipeTestCase_testSideSwipeTopToolbar-AssertionFailedException-001584B5-0BD5-480A-BE35-237D1281481F/SideSwipeTestCase_testSideSwipeTopToolbar_after_expected.png", "Visibility Checker Most Recent Actual After Image": "/var/mobile/Containers/Data/Application/8AE3CF5E-F002-4373-8F6F-826C6E868992/Documents/SideSwipeTestCase_testSideSwipeTopToolbar-AssertionFailedException-001584B5-0BD5-480A-BE35-237D1281481F/SideSwipeTestCase_testSideSwipeTopToolbar_after_actual.png" } UI hierarchy (ordered by window level, front to back as rendered): Legend: { "[AX]": "Accessibility", "[UIE]": "User Interaction Enabled", "[Window 1]": "Frontmost Window" } Original change's description: > [iOS] Check SideSwipe location in window coordinates > > This CL changes the way the SideSwipe is checking if the touch location > is inside the toolbar frame or not by passing it in the window > coordinates instead of in the gesture's view coordinates. > This starts creating an issue as the toolbar frame is now contained in > a container, changing its frame's origin. > > Bug: 883694 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs > Change-Id: Iaf42b36ce01c47addd87ae71772abff605e75a1c > Reviewed-on: https://chromium-review.googlesource.com/1224387 > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592014} TBR=justincohen@chromium.org,eugenebut@chromium.org,kkhorimoto@chromium.org,gambard@chromium.org Change-Id: I8ea07375dc2c910264e05ecd58ade762c99a582c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 883694 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1231828Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592170}
-
Mohamed Heikal authored
ToolbarControlContainer contains references to mToolbar which could be null if the toolbar is inflated asyncronously. This cl adds null checks before calling methods on mToolbar. Bug: 884607 Change-Id: Ib444dada288822ee85bcd493c793bb07b0008291 Reviewed-on: https://chromium-review.googlesource.com/1228310Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#592169}
-
Nico Weber authored
g_font_collection and g_font_fallback can be cleaned up by process exit instead. Bug: 404525 Change-Id: I4190a260a6b4f84d76598a29e0c6c241879c82e5 Reviewed-on: https://chromium-review.googlesource.com/1231674Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592168}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/345f5513..c623fabe Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I323a045a1bb0f599a566889f0706a9ac9ca81543 Reviewed-on: https://chromium-review.googlesource.com/1231696Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592167}
-
Sergei Istomin authored
Class StreamMixer::ExternalMediaVolumeChangeRequestObserver, OnMuteChangeRequest member function doesn't allow to mute audio. It changes media volume in the function body instead of muting audio. Bug: 114035326 Change-Id: I755aaa94470dc8ba33a458d6139ef9254655d3e4 Reviewed-on: https://chromium-review.googlesource.com/1214689Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Sergei Istomin <sistomin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592166}
-
Khushal authored
We currently leave the original matrix in PlaybackParams uninitialized in the setup for RasterCHROMIUM commands. Since this matrix is applied to the matrix in SetMatrix ops during raster, the canvas ends up with an arbitrary matrix. R=enne@chromium.org, ericrk@chromium.org BUG: 877615 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I93dd697052a5b08a94dc01a7112a113c66b0025e Reviewed-on: https://chromium-review.googlesource.com/1228504Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#592165}
-
Denis Kuznetsov authored
Bug: 885086 Change-Id: I1eb764626437c07008a0f44d4a7b0f47b05f931a Reviewed-on: https://chromium-review.googlesource.com/1232093Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#592164}
-
Stéphane Marchesin authored
Like the subject says, since this passes skia gold tests we are enabling GPU rasterization on Imagination GPUs. BUG=b:65493006 TEST=build on elm, see GPU rasterization enabled Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I78e015241d12ad8c7804737c972667026b815394 Reviewed-on: https://chromium-review.googlesource.com/1229034Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Stéphane Marchesin <marcheu@chromium.org> Cr-Commit-Position: refs/heads/master@{#592163}
-
Christian Biesinger authored
Based on Ian's patch here: https://chromium-review.googlesource.com/c/chromium/src/+/1190763 I had to rename kNone because it conflicts with a different enum. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ib721e8985165f9b55f123faf023f8267da9a87e0 Reviewed-on: https://chromium-review.googlesource.com/1220129 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#592162}
-
Filip Gorski authored
Bug: 714109 Change-Id: Ife7a4af9c151bfffc094ac1f5deccc5f4b10fbde Reviewed-on: https://chromium-review.googlesource.com/1229154Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#592161}
-
chrome://discardsSigurdur Asgeirsson authored
Convert the imperative implementation to all-declarative polymer (for the most part). Add closure_compile build configuration and fix the problems it showed up. This change should be a no-op in terms of the UI presented. Bug: 879660 Change-Id: I60d607f1b556a5a2a31f7cb776abb1ff6db38660 Reviewed-on: https://chromium-review.googlesource.com/1210385 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592160}
-
Sebastien Marchand authored
See https://chromium-review.googlesource.com/c/chromium/src/+/1231633 for more details about this issue. Bug: 844426 Change-Id: Icad060f8105602a2e0805e55f6ffd8b11ce5effa Reviewed-on: https://chromium-review.googlesource.com/1231815Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#592159}
-
sebsg authored
There is a small window where it can be null before the sync service is done initializing. Not clearing the data then doesn't matter, since the server db either points to the local db which is cleaned next, or to an in memory server db which doesn't exist yet, so there is nothing to clear. This code is less than ideal and will be refactored along with the database helper and the personalDataManager in the coming weeks. Bug: 883713 Change-Id: I9e754985bf5c14750100dee57efe4ed1a3e252d8 Reviewed-on: https://chromium-review.googlesource.com/1231916Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#592158}
-
Aldo Culquicondor authored
This moves the logic of handling the Cardboard trigger out of the scheduler. It also avoids unnecessary operations in Cardboard. Additionally, we submit vsync to the WebXR session after an input state has been obtained. Bug: 875291 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia8723a2fa50dac7ddcca4f6468dadd9c1836f6db Reviewed-on: https://chromium-review.googlesource.com/1216942 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#592157}
-
Allen Bauer authored
This is a reland of 9c5131ad Cannot reproduce the flake. Relanding for more information. Original change's description: > Under refresh, use the same menu options for Windows/Linux as under Mac > > Use the BubbleBorder for the menus since the drop-shadow under Windows > doesn't track the shape of the menu. We also have much more control over > the shape and depth of the drop-shadow. > > Bug: 837782 > Change-Id: I91b9340251c2cd0b60e3b3f66d450a4791113007 > Reviewed-on: https://chromium-review.googlesource.com/1159532 > Commit-Queue: Allen Bauer <kylixrd@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590731} TBR=ellyjones@chromium.org TBR=msw@chromium.org TBR=estade@chromium.org Bug: 837782 Change-Id: I80a07fb2d716c9372d18a8d48df3e7e00ff286ab Reviewed-on: https://chromium-review.googlesource.com/1229173 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#592156}
-
Etienne Pierre-Doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /components/sync. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=tschumann@chromium.org Bug: 874080 Change-Id: I291ccbeca7b5115053ad57bb3ba072eaad10172f Reviewed-on: https://chromium-review.googlesource.com/1194103 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#592155}
-
Vladimir Levin authored
This patch puts isolation nodes for elements with contain: paint. The nodes act as a boundary where any subtree elements of the contained element cannot reference elements higher up in the tree from the isolation nodes. This, in turn, allows us to put a performance boundary skipping subtree walks for an isolated subtree when the subtree itself has not changed. R=chrishtr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Icd0ff26f7c28d3df226755b7c501e227f532001d Reviewed-on: https://chromium-review.googlesource.com/1168390Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592154}
-
David Tseng authored
- within a single line, delete all words using Ctrl+Backspace - type until a line wraps. This triggers the inclusion of a new inline text box. - delete until a wrapped line moves up one line - delete words until all words on a wrapped line are deleted In all of these cases and many others, the previous line (surrounding the previous selection) and the current line are *different* lines. In some cases, the previous line is no longer valid because the underlying data is invalid. In all other cases, the lines are both valid, but refer to two different inline text boxes. In order to get the appropriate context, this change uses the surrounding paragraph to get the right diff of the previous and current value along with the selection. This fixes: 1. deletions that happen to trigger a line change. The easiest way to reproduce this is via Ctrl+backspace inside of a long paragraph 2. insertions that trigger the addition of a new line. The easiest way to trigger this is to set typing echo to none and start typing without inserting hard line breaks (i.e. pressing enter). When a new line is inserted (soft wrap), ChromeVox used to read the new line's text (the newly wrapped word). This no longer occurs. Bug: 833252 Test: manual and chromevox_tests. Change-Id: I5095eb4714932cad050f9fc5162072f918008b20 Reviewed-on: https://chromium-review.googlesource.com/1228790 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#592153}
-
chrome://discardsSebastien Marchand authored
Change-Id: If43a304a2deee1abc05df6c62344f538dd8b1de1 Reviewed-on: https://chromium-review.googlesource.com/1217447Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#592152}
-
kylechar authored
The function is only used on Chrome OS and is no longer necessary. Ozone DRM provides display refresh rates and vsync interval through the command buffer. The function seems to be leftover from X11 Chrome OS where Xrandr provided better refresh rate data than the GL context. GpuProcessTransportFactory::SetAuthoritativeVsyncInterval() is also broken currently and not setting the interval. Bug: 885169 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I66ffa73f5b32418cd83553c52ff97293e1b10657 Reviewed-on: https://chromium-review.googlesource.com/1230578Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#592151}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/748e4927773d..2426fe64bffb git log 748e4927773d..2426fe64bffb --date=short --no-merges --format='%ad %ae %s' 2018-09-18 dhanyaganesh@chromium.org failed_stage metric: Add important field 2018-09-18 dhanyaganesh@chromium.org Chromite: Add Common Metric Fields for all metrics Created with: gclient setdep -r src/third_party/chromite@2426fe64bffb The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I7d30a22fbe1cc15e0fca19a22affc1504514b60d Reviewed-on: https://chromium-review.googlesource.com/1231493Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592150}
-
Xiaohan Wang authored
I found some test files were added without updating the README file. So adding this presubmit check to remind people to do so. Here's an example of the warning when updating test files without updating the README file: ----------------------------------------- ~/chromium/src$ git cl presubmit --upload Running presubmit upload checks ... ** Presubmit Warnings ** When updating files in media/test/data, please also update media/test/data/README: media/test/data/vorbis-asd \ media/test/data/vorbis-packet-0 \ media/test/data/vorbis-packet-0_for_test Presubmit checks took 1.4s to calculate. ----------------------------------------- Bug: 818048 Change-Id: Ibc8b5d82aa7b0fd2688a01b736a57d8bf0e11e29 Reviewed-on: https://chromium-review.googlesource.com/1229497Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592149}
-
Tom Anderson authored
BUG=882854 R=pkasting Change-Id: I8dc419e43882d723a117da19e87abe20505aa01a Reviewed-on: https://chromium-review.googlesource.com/1228201 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#592148}
-
Nico Weber authored
Ports the changes to memory_monitor_linux.cc in https://codereview.chromium.org/2321313002/ to Windows. Bug: 404525 Change-Id: Ibb92bb419292b0dd7298ad8c3ce7ae5268e6000a Reviewed-on: https://chromium-review.googlesource.com/1231673 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
-
Ryan Hansberry authored
In the process, this also adapts HostConnectionMetricsLogger to use the MultiDevice APIs to properly log to the "Background" versions of its metrics. Bug: 824568, 752273, 854885, 857302 Change-Id: I77fc52b3d07d903fe61ac62de2620216984d28de Reviewed-on: https://chromium-review.googlesource.com/1117897Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#592146}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/804797362e1d..1aa405fd859a git log 804797362e1d..1aa405fd859a --date=short --no-merges --format='%ad %ae %s' 2018-09-18 sergiyb@chromium.org Add an option to disable adding CC emails automatically 2018-09-18 nodir@google.com [gclient] Fix typo in get_gerrit_patch_root 2018-09-18 nodir@google.com [bot_update] Add gclient.get_gerrit_patch_root 2018-09-18 vadimsh@chromium.org [cipd] Pin hashes of CIPD packages. 2018-09-18 borenet@chromium.org Revert "gerrit_util: Support OAuth2 bearer tokens in CookieAuthenticator" Created with: gclient setdep -r src/third_party/depot_tools@1aa405fd859a The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:878303,chromium:694348,chromium:694348,chromium:870166 TBR=agable@chromium.org Change-Id: I439b74e4283ec9962446dd2b14a101175f7fbb4d Reviewed-on: https://chromium-review.googlesource.com/1231496Reviewed-by:
-
Robert Flack authored
A few changes were needed to get this to work in BGPT: - Create a StubChromeClientForSPv2 so that we have a LayerTreeHost, without which BGPT does not create composited animations. - Change StubChromeClientForSPv2 to tell the LayerTreeHostEmbedder to use layer lists when running with BGPT - Check for filter animations as well as current filters when deciding if we need a filter on a given object. Bug: 874253 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7e057d8a225ead67728d68070e62ac62f7a33f19 Reviewed-on: https://chromium-review.googlesource.com/1230438 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592144}
-
Andrew Grieve authored
Change-Id: Iaa78ac6b6ad9050479c0e326e36c80cabb9800f3 Reviewed-on: https://chromium-review.googlesource.com/1231386Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#592143}
-
David Black authored
There are instances in which we want links to be able to open new tabs in the browser. With this change, they will be able to do so by specifying target="_blank". Bug: b:115782814 Change-Id: Id4a08c5fbde342c723f47e363c9cf97e76f1578e Reviewed-on: https://chromium-review.googlesource.com/1227502Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#592142}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/892036cb879f..cb44953479a1 Created with: gclient setdep -r src-internal@cb44953479a1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:856278 TBR=mmoss@chromium.org Change-Id: Ie53026c25d38525322ffee7ac6c19f6f601acf20 Reviewed-on: https://chromium-review.googlesource.com/1231495Reviewed-by:
-
Weilun Shi authored
When there are multiply profiles opened at the same time. The renderer creation process will be called multiple times which might cause incorrect behavior. Make sure the renderer created only for the corresponding profile. Bug: 847606 Change-Id: I4d47d22220cab2197ad59feedacd3e6a5bc0dabb Reviewed-on: https://chromium-review.googlesource.com/1229193Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#592140}
-
Vladimir Levin authored
This patch disambiguates two functions: - SetDescendantNeedsPaintPropertyUpdate, which is a breadcrumb - SetSubtreeNeedsPaintPropertyUpdate, which is a dirty bit By renaming the latter to: SetSubtreeNeedsForcedPaintPropertyUpdate. R=chrishtr@chromium.org, pdr@chromium.org Change-Id: Ia00d845fc114e1eef94987a650b453e363d431cd Reviewed-on: https://chromium-review.googlesource.com/1231384Reviewed-by:
-
Ben Pastene authored
Cycle time looks good. (Caps out at about 30min for analyze exclusions.) Flake rate looks like it's pretty much 0. Though the bot is currently red due to a broken webrtc roll (that this bot would have caught). Need to wait on reverting that before this can land. Bug: 646404 Change-Id: I26ddec32ad1b90165068c0c17946c2ac6cdc330b Reviewed-on: https://chromium-review.googlesource.com/1229076Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#592138}
-
Erik Chen authored
This CL removes the flag kCheckLayoutTestSysDeps and modifies Content Shell to run CheckLayoutSystemDeps for layout tests. Previously, run_web_tests.py would first run Content Shell with kCheckLayoutTestSysDeps to check system dependencies, and then subsequently run Content Shell with kRunWebTests to run the actual layout tests. The goal was for the former step to discover system misconfigurations and early-exit so that developers would not lose time debugging system configuration failures. This CL's changes has several benefits: * kCheckLayoutTestSysDeps was using a different mechanism for starting and stopping the main thread's run loop. This was likely responsible for flaky crashes. * run_web_tests.py would exit with SYS_DEPS_EXIT_STATUS upon encountering a crash in kCheckLayoutTestSysDeps. This failure was not recoverable. Now, flaky crashes are caught using the normal layout test runner mechanism, and are appropriately retried. * It simplifies the logic for both Content Shell [removing a flag] and web_test_runner.py [removing yet another mechanism for launching the driver and parsing its results]. Bug: 884776 Change-Id: I7472f5e3b90e6d2578d2ed0be906e0e57ae9dbaa Reviewed-on: https://chromium-review.googlesource.com/1229240 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:Camille Lamy <clamy@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#592137}
-
Michael Nye authored
Bug: b/80441180 Change-Id: I66bd3265c724229c818d54289479c6262a2e28a9 Test: Ran on device Reviewed-on: https://chromium-review.googlesource.com/1148803Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Michael Nye <michaelnye@chromium.org> Cr-Commit-Position: refs/heads/master@{#592136}
-
