- 18 Sep, 2018 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 50dec7d9. With Chromium commits locally applied on WPT: 87da8d40 "[Background Fetch] Miscellaneous cleanups." 29028a2d "[css-tables] Force layout when colgroups are removed or added" 50dec7d9 "[css-layout-api] Add test for percentage height in quirks mode." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24803 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I0b794e989f5942c9e301dcfaca8cec8eea15645b Reviewed-on: https://chromium-review.googlesource.com/1232197 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#592266}
-
Theresa authored
Add accessibility support the EoC toolbar button: - Pull content descriptions and accessibility announcent string ids from BottomSheetContent - Update content description for close button - Don't set null click listener on ToolbarView to prevent it from being focusable in touch exploration - Allow title TextView to be focusable in touch mode BUG=827342 Change-Id: Icafbca847f9d4c9439cbfdbf758e9d9cb7d2f53a Reviewed-on: https://chromium-review.googlesource.com/1227292 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#592265}
-
Kyle Horimoto authored
A future CL will move these resources to chrome://resources, which does not have support for $i18n (see [1]). Instead, each $i18n{foo} instance was replaced with [[i18n('foo')]]. [1] https://cs.chromium.org/chromium/src/ui/webui/resources/cr_components/README.md Bug: 884041 Change-Id: I4d6ee99f0cd66aee55cf12a47673fc01e46c87a4 Reviewed-on: https://chromium-review.googlesource.com/1232415 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#592264}
-
Azeem Arshad authored
This CL adds checks for additional flags of features that android sms service depends on. Fixes issue with crash on login when using incorrect feature flag combination. Bug: 885264 Change-Id: I38a0202761d9a6984f76caa707efc73738c29981 Reviewed-on: https://chromium-review.googlesource.com/1232519Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592263}
-
Jinsuk Kim authored
This CL gets ChromeDownloadDelegate to implement UserData, and instantiates lazily on the first call. Tab doesn't need to keep a reference, so deletes it. Bug: 877878 Change-Id: I6218fb870603ad5508831cd2e059fcebd772f2c5 Reviewed-on: https://chromium-review.googlesource.com/1226951 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#592262}
-
Xianzhu Wang authored
Previously PaintLayerPainter and PaintLayerClipper assumed that all fragments of an object share the same transform state. This is not true for repeating fixed-position objects with PaintOffsetTranslation: The fragments have different PaintOffsetTranslations. Previously we use infinite clip rect to avoid the problem of incorrect cull rects for repeated fragments. However, that also caused we painted too much for each page because of the infinite cull rects, causing slow printing and too much memory usage. Changed the following places to calculate correct cull rects for repeating fixed-position objects: 1. PaintLayerFragment now saves root_fragment_data to indicate its coordinate space; 2. PaintLayerPainter::AdjustForPaintProperties() no longer uses infinite cull rect when printing; 3. In PaintLayerPainter before painting the LayoutObject, cull_rect is adjusted from the border box space of |fragment.root_fragment_data| to the containing transform's space; 4. In PaintLayer::CollectFragments(), for each fragment, the input dirty rect is adjusted to the current root fragment's border box space; 5. PaintLayerClipper::CalculateRectsWithGeometryMapper() is simplified to just map using transform states. Bug: 848839,869554 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6d86e3716e91dbe5422cbf5e58b99fa2282d94dd Reviewed-on: https://chromium-review.googlesource.com/1090009 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592261}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dd2ce986ce25..07b5283a4ea1 git log dd2ce986ce25..07b5283a4ea1 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 tandrii@chromium.org Revert "gclient: delete unversioned directory before adding cipd dep for the same path" 2018-09-18 nodir@google.com [bot_update] Use get_gerrit_patch_root 2018-09-18 tandrii@chromium.org gerrit_util: document hack. Created with: gclient setdep -r src/third_party/depot_tools@07b5283a4ea1 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:882611,chromium:694348,chromium:881860 TBR=agable@chromium.org Change-Id: I761e53cff80b5562c3e581360f0f3180b5e8350d Reviewed-on: https://chromium-review.googlesource.com/1232024Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592260}
-
Gang Wu authored
Implement error handling in journal storage, and change callback in java to lambda. Bug: 884231 Change-Id: Ib6c43e36c5f478634ee28a8dd9e2dc277f067f3c Reviewed-on: https://chromium-review.googlesource.com/1227602 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#592259}
-
Amos Lim authored
This CL has no behavior changes. Bug: 770603 Change-Id: I1224d6eaeecccfcffc3c205595b526f5be272671 Reviewed-on: https://chromium-review.googlesource.com/1230453Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#592258}
-
Darwin Huang authored
drag-and-drop wouldn't initiate when shift was held down - Reproduced bug by adding layout tests in third_party/WebKit/LayoutTests/fast/dnd/dropEffect-for-modifier-*.html - Fixed bug in selection_controller.cc R=pwnall@chromium.org Bug: 646339 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I57bb7071d0db81364aa5d2113c93a4cbf9fc09f2 Reviewed-on: https://chromium-review.googlesource.com/1223032 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#592257}
-
Kevin Strohbehn authored
Bug: 874202 Change-Id: I19db72345f8646ffa1100d2b51672990e12041e2 Reviewed-on: https://chromium-review.googlesource.com/1228998 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#592256}
-
Hayato Ito authored
This CL is a follow-up for https://chromium-review.googlesource.com/c/chromium/src/+/1212255. It looks WebKit also landed the CL: https://trac.webkit.org/changeset/236002/webkit. fast/dom/shadow/shadow-boundary-events.html is the only existing test which needs the rebase. BUG=883650 Change-Id: Iecee6777a207b956b1dad6cc842061fd460ec6ab Reviewed-on: https://chromium-review.googlesource.com/1229741Reviewed-by:
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /content/browser/devtools. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=caseq@chromium.org Bug: 874080 Change-Id: Ib5b94340df750c17a0a3ab0b8dd76f4fc70c5c5e Reviewed-on: https://chromium-review.googlesource.com/1191678Reviewed-by:Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#592254}
-
Christopher Cameron authored
Add a method to chrome::mojom::AppShim that will create a views_bridge_mac::BridgeFactory. Add a views_bridge_mac::BridgeFactoryHost member to chrome::AppShim. (This will be plumbed to NativeWidgetMac::InitWidgetMac via the BrowserFrameMac sub-class, which lives in chrome). Add myself as an OWNER for chrome/app_shim and chrome/browser/apps/app_shim. Bug: 859152 Change-Id: I1aaa46376599e0bf88f6f16b461c941c851c431c Reviewed-on: https://chromium-review.googlesource.com/1229697 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#592253}
-
Jun Mukai authored
It seems UIControlsAsh is still used for interactive_ui_tests, which isn't the case with Mash. Thus I changed the installation of UIControls for this, meaning: - do not install the UIControlsAsh on Main of interactive_ui_tests - create and install UIControlsOzone during PreRunTestOnMainThread. This needs to be here since it needs a window tree host. - fix the positioning logic in UIControlsOzone -- it creates the location in root_window's coordinate, which is actually intended to be display's coordinate. BUG=883523 TEST=no breakage on existing tests Change-Id: I62b1aea1a28deee4dd1d6da377574af8fddef5ed Reviewed-on: https://chromium-review.googlesource.com/1228942 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#592252}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0191ed8e87dc..774b566c1308 git log 0191ed8e87dc..774b566c1308 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 bungeman@google.com Revert "Reland "implement SkPixmap::erase() with draws"" 2018-09-18 kjlubick@google.com [CanvasKit] Add docs 2018-09-18 nigeltao@google.com Remove duplicate BUILD.gn configuration 2018-09-18 bungeman@google.com Work around FreeType issue with bitmap font and autohinter. 2018-09-18 caryclark@skia.org fix conic fuzz 2018-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 95277a300f52..0fdb956d9c24 (1 commits) 2018-09-18 mtklein@google.com Reland "implement SkPixmap::erase() with draws" 2018-09-18 robertphillips@google.com Fix DDL reattachment of uniquely keyed proxies 2018-09-18 robertphillips@google.com Revert "Suppress addition of changeListeners during DDL recording" Created with: gclient setdep -r src/third_party/skia@774b566c1308 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: Ieb70d1226c9ef538b001afc134a69598efda9c31 Reviewed-on: https://chromium-review.googlesource.com/1232023Reviewed-by:
-
Amos Lim authored
As per updated naming conventions, rename interfaces to mojom Bug: 799479, 806965 Change-Id: Ie539ca95b7e221d4568f0b03b736f354a882d2e6 Reviewed-on: https://chromium-review.googlesource.com/1229726Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#592250}
-
Ryan Cui authored
Seeing flaky failures for the test on the MSan bot. Bug: 884118 Change-Id: Id2773b731b054bbecb02fd9bca8f7c00d2f5f447 Reviewed-on: https://chromium-review.googlesource.com/1232193Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
-
Khushal authored
Temporarily make sure we always fallback to using ES2 for all android versions to understand whether a particular crash spike associated with the oopr experiment is a result of oopr enabling ES3 for skia. R=ericrk@chromium.org Bug: 884659 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If5668a65d967294d07687f8d09a114153aa0d09f Reviewed-on: https://chromium-review.googlesource.com/1232198Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#592248}
-
Sam McNally authored
Bug: 883628 Change-Id: I5f4d81dd1a1d269a33091748def79d20941f1eca Reviewed-on: https://chromium-review.googlesource.com/1229638Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#592247}
-
David Tseng authored
Test: navigate within editable text. Hit the 'end' key. Verify the cursor lands on the extra cell padding after this change. Before this change, the cursor "disappears". Change-Id: I370bb2ae2bc458e4d94a1cd364c381fec3e976da Reviewed-on: https://chromium-review.googlesource.com/1231982Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592246}
-
Yuly Novikov authored
ANGLE's support for these formats has been available for a while, so remove the workaround converting sized formats to unsized. Bug: angleproject:556,angleproject:2567 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie5bddbe78a7231c9b90966573812f118abca379f Reviewed-on: https://chromium-review.googlesource.com/1231981 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592245}
-
bsheedy authored
Adds MacOS-only logic to run_gpu_integration_test.py that immediately aborts if the lockscreen is detected. The device should be automatically unlocked prior to the test starting, so a failure to do so needs to be easily identified for investigation. Bug: 884913 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I684a73ace61fd34484af815c7d55517613de16b3 Reviewed-on: https://chromium-review.googlesource.com/1229366Reviewed-by:
-
Tommy Li authored
This reverts commit 29028a2d. Reason for revert: Breaks Linux Msan tests. See https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests/builds/11648 Original change's description: > [css-tables] Force layout when colgroups are removed or added > > When colgroups are modified via Javascript, Blink uses a stale computed > logical width, resulting in incorrect sizing of auto columns if layout > was previously done. This patch forces a fresh layout of the affected > cells, which corrects this behaviour. > > Bug: 870296 > Change-Id: I4a12d5a8db689ba1457c6c9960ae8ea9c1dd40d9 > Reviewed-on: https://chromium-review.googlesource.com/1162224 > Commit-Queue: David Grogan <dgrogan@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Reviewed-by: David Grogan <dgrogan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592115} TBR=dgrogan@chromium.org,eae@chromium.org,richard.townsend@arm.com,mstensho@chromium.org Change-Id: If7507718dddd3b84ceffdae3df5e35b8402f27ea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870296 Reviewed-on: https://chromium-review.googlesource.com/1232480Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#592243}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I77c7dbeb1f412305091a49f239b1a5c9826a691a Reviewed-on: https://chromium-review.googlesource.com/1232207 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592242}
-
kylechar authored
VizProcessContextProvider relies on GLInProcessContext to own/initialize some classes necessary to support a command buffer. We'll need to access even more internal state from GLInProcessContext for memory reporting which means adding another accessor. Instead of adding another accessors, move initialization logic into VizProcessContextProvider. This removes a step of indirection and makes the code a bit easier to understand. Bug: 876508 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib66ad5596e6c349695a25279b65792260ea89105 Reviewed-on: https://chromium-review.googlesource.com/1231829Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#592241}
-
Joel Einbinder authored
Change-Id: I52f28ee062a9f651dbb0e95f6abeb762b6afab35 Reviewed-on: https://chromium-review.googlesource.com/1229673Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#592240}
-
Mark Pearson authored
Change-Id: Id2084ba5bf5e91f007417febdfa817f757fe6eb7 Reviewed-on: https://chromium-review.googlesource.com/940861Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#592239}
-
Xiyuan Xia authored
- Add testonly to service_manifest and grit GN template - Make test_ws service manifest testonly and update dependent targets; Bug: 874089 Change-Id: If9b46baf09e1b4457bdc05b252825d46b610d8ab Reviewed-on: https://chromium-review.googlesource.com/1231895 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c623fabe..604c50c8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I434ce8edd5f44a20d7583187c68634be859bafbe Reviewed-on: https://chromium-review.googlesource.com/1231979Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592237}
-
Muyuan Li authored
Label seems to use heuristics to figure out number of lines of text when width is not specified, which causes problem when DPI changes. We add an explicit width to the greeting label to avoid this issue. Bug: b/112843496 Test: manual Change-Id: I12122de165a8c1071cf29c2970c97595820b7263 Reviewed-on: https://chromium-review.googlesource.com/1228892Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Muyuan Li <muyuanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#592236}
-
Xida Chen authored
WidgetInputHandlerManager::DispatchEvent is the function where we run the callback that sets the touch action. There are some corner cases where the touch action is set to base::nullopt. This is fine previously when the TouchActionFilter::allowed_touch_action_ has a default value of kTouchActionAuto. However, now that we changed the |allowed_touch_action_| to Optional instead of having a default value (Auto), and rely on the fact that it will be set by the renderer when ack from the main thread, we have to set |allowed_touch_action_| to Auto for these corner cases. This CL sets it at receiver end, which is in InputRouterImpl::OnTouchEventAck. When receiving the ack for touch sequence start, if the |allowed_touch_action_| is not set, then we maybe hitting these corner cases. Bug: 851644 Change-Id: If1bb393580619eb7b7ba60ac2b01099c83c71f26 Reviewed-on: https://chromium-review.googlesource.com/1228295 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592235}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1904775ac35b..0c858b7a312a Created with: gclient setdep -r src-internal@0c858b7a312a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I45ea1d7289359703cfb57a333aec2b98735c123d Reviewed-on: https://chromium-review.googlesource.com/1232026Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592234}
-
Krishna Govind authored
R=benmason@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I795438ae4b19230303b07ce45df0e1e4724bb081 Reviewed-on: https://chromium-review.googlesource.com/1232476Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#592233}
-
khmel@chromium.org authored
TEST=locally BUG=879628 Change-Id: I69574cab1012efea5d87d786373b20eba543d616 Reviewed-on: https://chromium-review.googlesource.com/1232337Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#592232}
-
Patricia Hongo authored
Bug: 884872 Change-Id: Ic6dd2b2ba1e28400d2585aab5751763592a7ad86 Reviewed-on: https://chromium-review.googlesource.com/1228440Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Patricia Hongo <phongo@google.com> Cr-Commit-Position: refs/heads/master@{#592231}
-
Nico Weber authored
After this, for all targets where the warning is enabled on non-Win, it's now enabled on Windows too. Bug: 404525 Change-Id: I2518fe482e04ba3c4b9964c49ee3fc3c4217d170 Reviewed-on: https://chromium-review.googlesource.com/1231838Reviewed-by:
-
Sam McNally authored
Fallback to native copy when a file is unavailable (e.g. not yet synced to the server) or when offline. Bug: 870009 Change-Id: I974da5d56187812d2376d7ea97bda9d9e6c68f29 Reviewed-on: https://chromium-review.googlesource.com/1229714 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#592229}
-
Peter Kvitek authored
TaskDuration metric used different TimeTickNow sources when calculating the final task duration. This resulted in incorrect TaskDuration values when running headless Chrome in Virtual Time mode. Change-Id: I1c862cb783e768b4128ef6d55510c1a5151c2e40 Reviewed-on: https://chromium-review.googlesource.com/1231315Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#592228}
-
Manas Verma authored
Adding browser tests for the sign-in after local save flow. This includes user-action sign-in metrics, the sign-in promo, and the manage cards prompt. Bug: 855186 Change-Id: I8c1d15f79e6915230860d7f0f2529a10c01559b7 Reviewed-on: https://chromium-review.googlesource.com/1196918 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#592227}
-
