- 08 Jul, 2016 40 commits
-
-
slan authored
Add OnStatisticsUpdate and OnWaitingForDecryptionKey to mojom::RendererClient, and call these callbacks from MojoRendererService. These are needed for Cast Apps like Netflix that depend on decoding statistics from the media pipeline. BUG=585287 BUG= internal b/29390639 Review-Url: https://codereview.chromium.org/2101043003 Cr-Commit-Position: refs/heads/master@{#404486}
-
sky authored
The resize lock completely throws off tests that generate events. These tests aren't meant to exercise the resize lock, so disabling seems reasonable. This is just the plumbing for the disable, will start enabling tests separately. BUG=331924 TEST=none R=piman@chromium.org Review-Url: https://codereview.chromium.org/2135743002 Cr-Commit-Position: refs/heads/master@{#404485}
-
cwallez authored
TBR=zmo@chromium.org BUG=626524 BUG=626742 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2134643004 Cr-Commit-Position: refs/heads/master@{#404484}
-
pdr authored
This patch fixes a crash on https://codepen.io where the paint offset in PaintPropertyTreeBuilder::updateSvgLocalToBorderBoxTransform would not be reset if transformToPixelSnappedBorderBox was identity. The new testcase, SvgPixelSnappingShouldResetPaintOffset, both ensures the DCHECK in PaintPropertyTreeBuilder::updateTransform is not hit, and verifies the transform property tree is correct in this case. BUG=600618 Review-Url: https://codereview.chromium.org/2131803002 Cr-Commit-Position: refs/heads/master@{#404483}
-
sammiequon authored
Bug was caused by having transitions for the image and sign in indicator for the user pod, while the image pane stays 100%. So when we are in the public account user pod the image will be centered. BUG=626157 Review-Url: https://codereview.chromium.org/2130143002 Cr-Commit-Position: refs/heads/master@{#404482}
-
yinjie authored
* Introduce lazy allocation of Storage. This in particular allows moved-from SpdyHeaderBlock instances to be valid without having to allocate Storage for them. * Use swap in move constructor and move assignment operator to make sure moved-from instance is valid. * Add SpdyHeaderBlockTest.MovedFromIsValid test. * s/block1/block/ in SpdyHeaderBlockTest.AddHeaders. This CL lands server change 125821596 by bnc. BUG=488484 Review-Url: https://codereview.chromium.org/2125403003 Cr-Commit-Position: refs/heads/master@{#404481}
-
thestig authored
TBR=brettw@chromium.org Review-Url: https://codereview.chromium.org/2133083002 Cr-Commit-Position: refs/heads/master@{#404480}
-
majidvp authored
BUG=624651 Review-Url: https://codereview.chromium.org/2124143004 Cr-Commit-Position: refs/heads/master@{#404479}
-
nektar authored
The children of non-editable combo boxes, search boxes and text fields specified via e.g. aria-owns should not be hidden from platform trees. Children of combo boxes, search boxes and text fields might not always be part of the shadow DOM, especially when no <input> or contentEditable . tags have been usedThey might be a list of combo box items specified via aria-owns. data:text/html,<div role="combobox" aria-owns="list" onKeyDown="this.setAttribute('aria-activedescendant', 'item');">content</div><ul id="list"><li id="item">item</li></ul> BUG=620432 R=dmazzoni@chromium.org TESTED=manually with Jaws NVDA and Voiceover Review-Url: https://codereview.chromium.org/2120523002 Cr-Commit-Position: refs/heads/master@{#404478}
-
lushnikov authored
BUG=616044 R=kozyatinskiy Review-Url: https://codereview.chromium.org/2135703003 Cr-Commit-Position: refs/heads/master@{#404477}
-
smaier authored
BUG=625704 Review-Url: https://codereview.chromium.org/2126353002 Cr-Commit-Position: refs/heads/master@{#404476}
-
hush authored
BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2124063002 Cr-Commit-Position: refs/heads/master@{#404475}
-
rajendrant authored
When any user initiated traffic is seen during the precache fetches, precache should be cancelled. BUG=619221 Review-Url: https://codereview.chromium.org/2061303003 Cr-Commit-Position: refs/heads/master@{#404474}
-
erg authored
BUG=622900,622575 Review-Url: https://codereview.chromium.org/2099513003 Cr-Commit-Position: refs/heads/master@{#404473}
-
ortuno authored
Moving BluetoothAdapterFactoryWrapper avoids the need to access a member from RenderProcessHostImpl, which avoids casting from RenderProcessHost to RenderProcessHostImpl. The scan duration is a web bluetooth concept and therefore should not be part of the FactoryWrapper in device. To that extent we expose a static function in BluetoothDeviceChooserController that allows tests to set a scan duration of 0. BUG=621528 Review-Url: https://codereview.chromium.org/2059543002 Cr-Commit-Position: refs/heads/master@{#404472}
-
mark authored
For each new major OS version, we need to poke at the internals of CFAllocator to enable the out-of-memory killer for the default CFAllocator implementations. This update is for macOS 10.12 ("Sierra"), whose CFAllocator internals are unchanged from 10.11 (and from 10.9, and in fact from 10.7). It also updates the base::mac::IsOS*() family of functions for this new OS version. BUG=626536,45650 TEST=base_unittests OutOfMemoryDeathTest.CFAllocator*,MacUtilTest.IsOSEllipsis Review-Url: https://codereview.chromium.org/2129273002 Cr-Commit-Position: refs/heads/master@{#404471}
-
mathp authored
A follow-up change will split the slightly long promo over 2-lines for Views, Mac, Android. Also, Android and iOS will need bridges into Java and ObjC, so this is deferred to another change. BUG=626442 Review-Url: https://codereview.chromium.org/2124343002 Cr-Commit-Position: refs/heads/master@{#404470}
-
ccameron authored
Trying to fix this has been a source of hung frames. This makes the DelegatedFrameHostClient's IsVisible callback return the variable that tracks whether or not the DelegatedFrameHost's owner has set it to be visible. BUG=623716 Review-Url: https://codereview.chromium.org/2125143004 Cr-Commit-Position: refs/heads/master@{#404469}
-
ortuno authored
Before we updated the map two times: 1. When constructing the device object *iff* the services had been resolved. 2. When a new service was added. This meant that if there was a cached service before services resolved, the service would never be added to the map. There are a couple of changes: 1. No longer add BluetoothDeviceBluez as an observer of BluetoothDeviceClient. This follows the previous pattern of exposing a function that BluetoothAdapterClient will use to update the device. 2. When services are resolved we add all previously unknown services. 3. Modified 2 tests and added two extra ones to test all the following cases: 1. Cached services exist and discovery hasn't completed. 2. Cached services exist and discovery has completed. 3. New service is exposed with no previous cached services. 4. New service is exposed with previous cached service. Case 1 should cover this bug. BUG=624400 Review-Url: https://codereview.chromium.org/2105423003 Cr-Commit-Position: refs/heads/master@{#404468}
-
mathp authored
Supports 2-digit years, and various combinations of mm/yyyy and single digit month combinations (e.g. m/yy). BUG=626537 TEST=CreditCardTest,PersonalDataManagerTest Review-Url: https://codereview.chromium.org/2136453003 Cr-Commit-Position: refs/heads/master@{#404467}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a5d8806e..252926e7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2131203003 Cr-Commit-Position: refs/heads/master@{#404466}
-
halliwell authored
Now that we have fixed physical display resolution, we can set the initial display size correctly, and there is no need for the resize logic. BUG=internal b/29391986 Review-Url: https://codereview.chromium.org/2119583002 Cr-Commit-Position: refs/heads/master@{#404465}
-
malaykeshav authored
- Checks the age of device by comparing the Oobe flag file creation date. Design Doc=go/cros-hats-eng BUG=611781 COMPONENT=Chrome OS, HaTS Review-Url: https://codereview.chromium.org/2103293003 Cr-Commit-Position: refs/heads/master@{#404464}
-
jbauman authored
This will help us track down the causes of video decoding errors in about:gpu and on the GPU bots. Logging only the line number should help prevent code bloat due to logging strings (and code) in release builds, and should make it easy to identify exactly what code failed. BUG=626524 Review-Url: https://codereview.chromium.org/2133553002 Cr-Commit-Position: refs/heads/master@{#404463}
-
mcasas authored
* No new code introduced whatsoever * Like it says in the title: s/MockClient/MockVideoCaptureClient/ and s/client_/video_capture_client_/ because there's a new client coming in https://crrev.com/2129733004, (namely MockImageCaptureClient), now we have to specify. TEST=capture_unittests passing merrily as before. TBR=emircan@chromium.org (since this CL is trivial) Review-Url: https://codereview.chromium.org/2133233003 Cr-Commit-Position: refs/heads/master@{#404462}
-
sunnyps authored
Resources which do not belong to a particular ResourceProvider should not require a WaitSyncToken. This is a speculative fix for the increased idle wakeups seen on Mac non-overlay. R=piman@chromium.org BUG=621198 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2130213002 Cr-Commit-Position: refs/heads/master@{#404461}
-
msw authored
Flaked 7/16 of the last runs on Linux ChromiumOS Tests (1): http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=ash_unittests&tests=ShelfTooltipManagerTest.ShowTooltipWithDelay BUG=NONE TEST=No/fewer flakes in this test fixture. R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2130133003 Cr-Commit-Position: refs/heads/master@{#404460}
-
mariakhomenko authored
Upstream most of the implementation. Add unit tests. BUG=626159 Review-Url: https://codereview.chromium.org/2123393002 Cr-Commit-Position: refs/heads/master@{#404459}
-
jbroman authored
WebGL demos now work with --enable-slimming-paint-v2 --enable-layer-lists. BUG=587970 Review-Url: https://codereview.chromium.org/2121933003 Cr-Commit-Position: refs/heads/master@{#404458}
-
asvitkine authored
Keeps its default state as enabled, as before, but this lets us experiment with turning it off experimentally to see whether it may be causing a suspected startup regression. BUG=626676 Review-Url: https://codereview.chromium.org/2131233002 Cr-Commit-Position: refs/heads/master@{#404457}
-
rob authored
std::set's count() method is expected to return 0 or 1. But due to the fact that EventListener::operator< conditionally ignored |embedder_process_id|, the count method could return more than 1 (e.g. 2) in release builds on Windows (VC++), and fail an assertion. This assertion failure shows that the assumption about the uniqueness of EventListeners (while ignoring the |embedder_process_id| value) does not hold, i.e. there may be more than one non-webview EventListeners with the same |extension_id| and |sub_event_name|, but different |embedder_process_id|. To fix this, this patch removes the conditional exclusion of |embedder_process_id| from operator< and looks up |embedder_process_id| before searching through the set. BUG=589735 TEST=./unit_tests --gtest_filter=ExtensionWebRequestTest.AddAndRemoveListeners Review-Url: https://codereview.chromium.org/2121873002 Cr-Commit-Position: refs/heads/master@{#404456}
-
iclelland authored
Many origin trial features can be installed on interfaces and prototype objects without requiring an existing interface object. This creates an alternate method signature for installing such features, and simplifies the bindings installation code. BUG=626435 R=yukishiino@chromium.org Review-Url: https://codereview.chromium.org/2130883002 Cr-Commit-Position: refs/heads/master@{#404455}
-
konsto authored
Almost the same string is repeated in the title of the dialog. BUG=618140 Review-Url: https://codereview.chromium.org/2123653007 Cr-Commit-Position: refs/heads/master@{#404454}
-
pkotwicz authored
Non-WebAPK web apps rely on a property in site preferences to determine whether the web app has been installed. If a user clears Chrome's data via Settings->Apps->Chrome->Storage->"Clear Data" site preferences are cleared. This CL adds a way for determining whether a WebAPK is installed which works even after a user clears Chrome's data. BUG=622135 Review-Url: https://codereview.chromium.org/2124703003 Cr-Commit-Position: refs/heads/master@{#404453}
-
thestig authored
Also convert !container.size() to container.empty(). Review-Url: https://codereview.chromium.org/2119283002 Cr-Commit-Position: refs/heads/master@{#404452}
-
fdoray authored
The PrefService argument was optional because it wasn't available in components/html_viewer. Now that components/html_viewer is gone, a PrefService should always be provided when calling startup_metric_utils::RecordBrowserMainMessageLoopStart. BUG=580211 Review-Url: https://codereview.chromium.org/2131663002 Cr-Commit-Position: refs/heads/master@{#404451}
-
sky authored
Prior to this change if you registered an accelerator for a key event then only the accelerator got the event. After this change the tree that registered the accelerator (wm) need not consume the event. If the wm doesn't consume the event it'll be processed normally. BUG=612331 TEST=covered by tests R=sadrul@chromium.org, dcheng@chromium.org Review-Url: https://codereview.chromium.org/2125883003 Cr-Commit-Position: refs/heads/master@{#404450}
-
sanjoy.pal authored
The spec requires using the last selected shipping option. Instead of going through the whole list of shipping options from front to back, iterate from back to front and early return on the first selected shipping option. BUG=587995 TEST=None (No behavior change) Review-Url: https://codereview.chromium.org/2131963002 Cr-Commit-Position: refs/heads/master@{#404449}
-
jennyz authored
Do not notify Volume change event to CrasAudioHandler::Observer when CrasAudioHandler change volume during initialization. BUG=625222 Review-Url: https://codereview.chromium.org/2127033004 Cr-Commit-Position: refs/heads/master@{#404448}
-
lushnikov authored
DevTools "hosted mode" is broken in a multiple ways: - it uses sync XHR from inside the microtask (this was recentrly forbidden) - as the protocol was split and moved around, the InspectorBackendHostedMode.js is not able to generate proper inspector backend commands The patch fixes both problems. Here we: - manually copy browser_protocol.json and js_protocol.json to the front-end folder so that hosted mode can rely on it - preload protocol files into Runtime.cachedResources in hosted mode for future use of InspectorBackendHostedMode.js BUG=623602 R=dgozman, pfeldman Review-Url: https://codereview.chromium.org/2124203002 Cr-Commit-Position: refs/heads/master@{#404447}
-