- 20 Jun, 2018 40 commits
-
-
rbpotter authored
Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie05684e0aacb7606b107e879f7da0defaf449793 Reviewed-on: https://chromium-review.googlesource.com/1086239Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#568964}
-
Boris Sazonov authored
This CL reimplements ExpandablePreferenceGroup to make it usable in other contexts by decoupling it from SingleCategoryPreferences. It also reimplements expand/collapse arrow and adds transition animations to it. Bug: 814728 Change-Id: I126bd08c1841d282f889dfde1ff71b35fe0a2262 Reviewed-on: https://chromium-review.googlesource.com/1106144 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#568963}
-
Yoichi Osato authored
This patch is a follow-up of previous patch: [LayoutNG] Paint LayoutReplaced selection considering line height: crrev.com/c/1102287 The test is styled "writing-mode:vertical-lr" and the 1px diff is accepted. Bug: 708452 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I253917127951a4139ece4191df37a9b68b9a4da3 Reviewed-on: https://chromium-review.googlesource.com/1107526Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#568962}
-
Ben Pastene authored
And add two mojo libs that were added to the list of required runtime deps in: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1066085 Change-Id: I0e2d90ba922508f2f22802780944100e8c17b17e Reviewed-on: https://chromium-review.googlesource.com/1072490 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#568961}
-
Christopher Cameron authored
BrowserAccessibilityManagerMac::GetParentView is used to get the NSView for a RenderWidgetHostViewMac (via a delegate interface -- it doesn't know it's talking to a RenderWidgetHostViewMac). It does this by calling AccessibilityGetAcceleratedWidget, and then converting to an NSView via ui::AcceleratedWidgetMac::GetNSView. Two problems with this approach: 1. This is roundabout -- the RenderWidgetHostViewMac knows its NSView directly. 2. When the RenderWidgetHostViewMac doesn't do its own compositing, this ends up being incorrect. The gfx::AcceleratedWidget used by compositing is the same as the main window. There exists no gfx::AcceleratedWidget mapped to the RenderWidgetHostViewCocoa. Change BrowserAccessibilityManagerMac::GetParentView to call the delegate method AccessibilityGetNativeViewAccessible, which returns an NSView directly. Remove the implementation of AccessibilityGetAcceleratedWidget, since it will lead to trouble. Bug: 852781 Change-Id: I74985d678f3cb10128a0e2caeb17fb3f22aa1752 Reviewed-on: https://chromium-review.googlesource.com/1105502Reviewed-by:Leonard Grey <lgrey@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#568960}
-
Justin Novosad authored
BUG=854068 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie19b1595538a6dad8d8c095233fe16d9383cfd00 Reviewed-on: https://chromium-review.googlesource.com/1108347Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#568959}
-
Esmael El-Moslimany authored
Bug: 849857 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia153c02e3f88c27a430c50cc85b2f3906f1b9c32 Reviewed-on: https://chromium-review.googlesource.com/1102189 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568958}
-
Xiangjun Zhang authored
When audio/video capturing stops, the capturing count is not decremented before stopping observing the WebContents due to some thread racing on Mac. This CL ensures the correct order of these two operation. Bug: 704797 Change-Id: Ia6168facbb5241321bf5a193da3f67811969f314 Reviewed-on: https://chromium-review.googlesource.com/1101920 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#568957}
-
Jun Mukai authored
It turned out that some X11 events arrive to the surfaces when the tests run with Xvfb (without -noreset flag), and that causes additional events which causes mismatches on mock expectations (especially on OnPointerFrame). RunAllPendingInMessageLoop() will consume such events, so those failure won't happen again. BUG=854674 TEST=exo_unittests with Xvfb :9 -nolisten tcp -screen 0 1280x800x24 Change-Id: I2c40aa29708362bd8eb4d05dd6448948622cfd81 Reviewed-on: https://chromium-review.googlesource.com/1105492Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#568956}
-
Fabrice de Gans-Riberi authored
All the remaining tests have been manually disabled. Bug: 706592 Change-Id: I043163517817794891f8a31d6f09913ca74b500c Reviewed-on: https://chromium-review.googlesource.com/1105020Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
-
Ryan Daum authored
Provide VLOGging of system gesture event timing metrics. Bug: internal b/110376393 Test: manual Change-Id: I5fa2c1ac52b02d3b81653bab485cd5379dc07944 Reviewed-on: https://chromium-review.googlesource.com/1108157Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#568954}
-
Justin Cohen authored
This bug is fixed in beta 2. Bug: 852431 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I799dffa75f0de39c4593de6f8f6cf67252df082c Reviewed-on: https://chromium-review.googlesource.com/1107777Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568953}
-
Jialiu Lin authored
This CL further propagates the ReusedPasswordType to warning UIs in order to display correct warning text, and to UMA tracking. To achieve this, 3 page info related enum values are introduced: SB_THREAT_TYPE_ENTERPRISE_PASSWORD_REUSE, SITE_IDENTITY_STATUS_ENTERPRISE_PASSWORD_REUSE MALICIOUS_CONTENT_STATUS_ENTERPRISE_PASSWORD_REUSE And 3 enums are renamed: SB_THREAT_TYPE_PASSWORD_REUSE -> SB_THREAT_TYPE_SIGN_IN_PASSWORD_REUSE SITE_IDENTITY_STATUS_PASSWORD_REUSE -> SITE_IDENTITY_STATUS_SIGN_IN_PASSWORD_REUSE MALICIOUS_CONTENT_STATUS_PASSWORD_REUSE -> MALICIOUS_CONTENT_STATUS_SIGN_IN_PASSWORD_REUSE 2 UMA histogram suffixes are added to cover 2 different enterprise cases: "GSuiteSyncPasswordEntry" Reuse of sync password for GSuite enterprise users "NonGaiaEnterprisePasswordEntry" Reuses of non-Gaia enterprise password (captured on enterprise login page) Bug: 852138 Change-Id: I234791c498a3679a9e5cfbfa371d931b16338408 Reviewed-on: https://chromium-review.googlesource.com/1100104Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#568952}
-
Reid Kleckner authored
This test causes a use-after-free when network services are enabled. Disable the test when network services are enabled until the bug is fixed. NOTRY=True TBR=tbansal@chromium.org, thakis@chromium.org BUG=850945 Change-Id: I73526165107c7ecc03c87febbcd772c910177092 Reviewed-on: https://chromium-review.googlesource.com/1108487Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#568951}
-
Allen Bauer authored
There are issues here that manifested differently. They where all caused by the same core issue. Since the tabs overlap visually, two tabs can report as being hovered so make sure the |hovered_tab| variable isn't blindly overwritten without first making sure it's painted. Bug: 853240 Bug: 854371 Change-Id: I62643659c6416cb23637613d0c3da83c6f4605f2 Reviewed-on: https://chromium-review.googlesource.com/1108338 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#568950}
-
Scott Little authored
The current description of the preview type histogram suffix "LoFi" says that it only refers to server-side LoFi previews, but in reality it actually refers to both server-side and client-side LoFi previews, so this CL updates that description. Change-Id: I4f933186c39adcbb6bc68805ad64f1da2e934904 Reviewed-on: https://chromium-review.googlesource.com/1107200Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#568949}
-
Ryan Tseng authored
Most of these have been migrated. Bug: 840631 TBR: tikuta Change-Id: I3a4846c42c401da337f48b60e278c7f7bba52cae Reviewed-on: https://chromium-review.googlesource.com/1108481Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#568948}
-
Xiaocheng Hu authored
When an inline child has margin, its parent's rect is no longer a simple union of the descendant rects. Currently, LayoutNG fails to handle this, and produces wrong rects for inline elements. This patch forces box fragment creation if any of its children has inline margin to ensure that LayoutNG returns the correct rects for it. Tests: - fast/forms/form-element-geometry-expected.txt: LayoutNG computes wrong rects for two FONT elements, which is corrected - Three related hit test failures are fixed Bug: 851075 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I08bd749620ed108930f832fb518d062268fbae89 Reviewed-on: https://chromium-review.googlesource.com/1107157Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#568947}
-
Ned Nguyen authored
Change-Id: I4c7be0b4e3124799c91c45399e063e68d71d480a NOTRY=true # test by PRESUBMIT Change-Id: I4c7be0b4e3124799c91c45399e063e68d71d480a Reviewed-on: https://chromium-review.googlesource.com/1108359 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#568946}
-
Orin Jaworski authored
Tab hover opacity is boosted using a linear function ranging from minimum boost on max-width tabs to maximum boost on min-width tabs. The idea here is that wide tabs need less boost than narrow tabs, and the single constant boost of 0.33 was not enough to make tabs stand out. The new range intends to help tabs stand out more on various themes. Bug: 848415 Change-Id: I335035c2cc1760c314eeff71a59a727c321dcc57 Reviewed-on: https://chromium-review.googlesource.com/1097744 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
-
Kush Sinha authored
Revoke an account's old token when it is updated with a new token. Currently only supported for GAIA accounts. Bug: 820046 Change-Id: Ic12f905a8fe16d55d720d4808c237b9d57621533 Reviewed-on: https://chromium-review.googlesource.com/1105981 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#568944}
-
edchin authored
Previously, opening a new tab search from today view or 3d touch would put the tab grid in an invalid state, if the context menu was showing. The new tab would not show, and the UI was no longer interactable. The cause was that the context menu was not being dismissed. This CL properly dismisses the recent tabs context menu on top of the tab grid. Bug: 852263 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2607f3ba4012d397f5ffc2faa4bb190c1fc980ba Reviewed-on: https://chromium-review.googlesource.com/1102193Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568943}
-
Michael Thiessen authored
Standalones need 2D Chrome support for things like privacy policy links from Settings, etc., where entering VR would wreck the task stack and take the user out of the proper context, etc. Basically, when Chrome is asked to launch into 2D, we need to respect that and launch into 2D even if we're on a VR device, or in a VR session. Bug: 854626 Change-Id: I90765e2b402a72a1adf6f23e80c39dc6f8ec0046 Reviewed-on: https://chromium-review.googlesource.com/1108138Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
-
Bo Liu authored
Add a UMA when a crashed subframe becomes visible whether it has received any post messages from non-descendant frames. For frames that did, they cannot be silently reloaded. Bug: 841572 Change-Id: Ib2d0b4f5fc30b0f7596a00253afa9a0cfbe24faa Reviewed-on: https://chromium-review.googlesource.com/1097695Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#568941}
-
David Black authored
Assistant controller should contain only top level APIs and own two subcontrollers: - AssistantBubbleController - AssistantInteractionController Still TODO: - There has been some confusion about the name AssistantBubbleController. To address and clarify, I will rename to AssistantUiController. - Currently an Assistant interaction is started and that causes UI to be shown. With the addition of Settings, we may want to open Assistant UI without starting an interaction. For this reason, I am going to invert the logic as follows: - Previously, we start an interaction and this causes UI to show. - After follow up CL, we will show UI and (depending on entry point) start an interaction if necessary. This should clean things up quite a bit as well as add more structure to the definition of an "interaction". Bug: b:80542452 Change-Id: I635dd1d473a5357f30ec72a3958d8e8863c91cf3 Reviewed-on: https://chromium-review.googlesource.com/1104990 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#568940}
-
Troy Hildebrandt authored
Clicking the "Tasty" link on buzzfeed.com brings you to buzzfeed.com/tasty which triggers the instant apps banner and then immediately redirects you to tasty.co. This makes |navigated_away_from_launch_url_| into |user_navigated_away_from_launch_url| which is only true if the navigation started with HasUserGesture() being true, meaning we won't hide the infobar if the user didn't start the navigation. Change-Id: I39dddd4bd7e0d814afd2f3b8218b280d6fd012ec Reviewed-on: https://chromium-review.googlesource.com/1106541 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#568939}
-
Min Qin authored
When download reaches 100%, this method is called to complete the download. We need to return true for InProgressDownloadManager, as auto-open doesn't apply when Chrome is not running fully BUG=842245 Change-Id: I4891d1dca8c9af0aaa1b4f0da9ae3d862ddff5f0 Reviewed-on: https://chromium-review.googlesource.com/1107171Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568938}
-
Xiaohan Wang authored
TBR=jrummell@chromium.org Bug: 403462 Change-Id: Ie28f42905b01be16e1e5070ef467562fccecf489 Reviewed-on: https://chromium-review.googlesource.com/1106963Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#568937}
-
Dave Schuyler authored
This CL adds PNG icons for translation answers. Most answer icons are vector icons, but this one is a bit too complex. We should either simplify it or use a PNG. Bug: 838733 Change-Id: Ia8fbba3400dd4bb27d183e5422e4f2d08e4d973d Reviewed-on: https://chromium-review.googlesource.com/1107162Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
-
Fabio Tirelo authored
Source: https://docs.google.com/presentation/d/1EO7TOpIMJ7QHjaTVw9St-q6naKwtXX2TwzMirG5EsKY/edit#slide=id.g399d5e0d81_22_0 This is a partial reland of https://crrev.com/c/1099560, reverted because it broke contrast ratio for links on the bookmarks bar. Bug: 852094 Change-Id: I968fc12dd5101993ac7473a246b9f73b8a39b1d8 Reviewed-on: https://chromium-review.googlesource.com/1108196Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#568935}
-
Cheng-Yu Lee authored
BUG=852906 Change-Id: I9c0ee9211e815edc58ef2d6ba58bf0d467d4e82a Reviewed-on: https://chromium-review.googlesource.com/1101597Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Reviewed-by:
-
Thomas Tangl authored
Turning on the unified consent master toggle on the syncSetup page now does the following: - enable all sync data types - enable all non-personalized service (still things to do in a follow up CL) This is implemented by adding an observing changes in the newly added kUnifiedConsentGiven pref. TBR = rockot@chromium.org Bug: 800974 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ib3fc46c089e63db9507d105fdd215f0eb1507364 Reviewed-on: https://chromium-review.googlesource.com/1098666 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
Mike Dougherty authored
This reverts commit dda02200. Reason for revert: Based on experiment results, we will push back the full rollout of this feature. Original change's description: > Enable kContextMenuElementPostMessage feature by default. > > Bug: 228355 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I9177b7841982999299f31084ce3b042aefd59fdc > Reviewed-on: https://chromium-review.googlesource.com/942027 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Mike Dougherty <michaeldo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561943} TBR=eugenebut@chromium.org,michaeldo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 817517 Change-Id: Ibe6862a71ba844326c3aec927667c8be0d43d7fa Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1108417Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#568932}
-
Koji Ishii authored
This patch fixes inline box positions and sizes when they have margins and nested. ComputeInlinePositions() was made to 2 passes to make this. In the 1st pass, it computes the position of leaf (text and atomic inline) nodes, but it will not know their final positions until it processes all boxes. Box positioning and sizing was split into the 2nd pass so that it can compute after all leaf nodes are finalized. It turned out that fast/forms/suggestion-picker/ time-suggestion-picker-appearance-locale-hebrew.html was an incorrect rebaseline. Removed in this patch. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Icea86c309c5f4d51cb91946d7182e526cbbc3881 Reviewed-on: https://chromium-review.googlesource.com/1107525 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Ahmed Fakhry authored
call preventDefault() on auxclick events to avoid opening an invalid URL since those links are href="#". Also increase line height of the privacy note text per UX feedback. BUG=853662,852387 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ib1dd1d5c9cfe03d03de263b5b02c03052756a9ab Reviewed-on: https://chromium-review.googlesource.com/1106638 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
erikchen authored
-[NSMenu performKeyEquivalent:] uses private APIs to highlight the menu for 100ms when the keyEquivalent: is activated. Rather than attempting to use the private APIs, we simply let the NSMainMenu handle the event by returning NO from -[NSWindow performKeyEquivalent:]. Bug: 851317 Change-Id: I7f71023a4e37e0f89cb4f5e2f34fb1d95149629f Reviewed-on: https://chromium-review.googlesource.com/1105067 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#568929}
-
jonross authored
HitTestRegionObserver was created to replace WaitForChildFrameSurfaceReady. However until the new hit testing api is on by default, it is needed for testing the legacy path. By now all callsites to it have been changed to HitTestRegionObserver. So this change removes it from browser_test_utils, and hides it inside of HitTestRegionObserver to prevent new callsites from being added. I'll delete it once and for all once the new hit testing api is on by default. TBR=piman@chromium.org TEST=content_browsertests, browser_tests, interactive_ui_tests Bug: 787945 Change-Id: I9db70ef06bd327f95db39ab5174df49db538eea4 Reviewed-on: https://chromium-review.googlesource.com/1106048 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#568928}
-
Joel Hockey authored
Initially I planned to make the error message in getElement_ consistent for the case where contentWindow.document does not exist and contentWindow.document.querySelector(targetQuery) returns null. In the end it made more sense to inline this into the 2 callers that exist. Bug: 852324 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia5741cbb9628ada0839faca8d9d108f5535ba9f1 Reviewed-on: https://chromium-review.googlesource.com/1108238Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#568927}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I09806dff16570bd6ba7d06855b5da4c12548090c Reviewed-on: https://chromium-review.googlesource.com/1108377Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568926}
-
Kurt Horimoto authored
Bug: 805209 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ida292ceb4968059c945edd3bbeb5ed5a0510a55f Reviewed-on: https://chromium-review.googlesource.com/1104887Reviewed-by:
-
