- 05 Jan, 2021 40 commits
-
-
evliu authored
This CL reorders the functions in chrome_speech_recognition_client.cc to match the order of the declarations in the .h file, removes an obsolete TODO, and adds evliu@google.com as an owner for the files. Change-Id: I96755a9c8c04e328ca2dd0e9c312cb8aab78aa75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607744Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#840256}
-
David Bertoni authored
The Service Worker versions of these tests were disabled for being flaky. The failures were due to the tests' restarting when the extension was reloaded to disable file access. If the test got to the point of adding a dynamic rule, that state would be persist and the test would fail trying to add that rule again. The test infrastructure has been fixed and it no longer reloads extensions to modify file access. Testing shows these tests are not flaky now that they're not restarting. I also added a ScopedCurrentChannel to a test that uses a feature that's only available on the TRUNK channel. Without that, this test will fail in other channels. Bug: 1111240 Change-Id: I429fab8581d9d503211fd4a385f1f1c69a99736f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500441 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#840255}
-
Becca Hughes authored
Kaleidoscope has been turned down. Change-Id: I030fce11f17591b9f02cc9352f53431f5eaaafdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596020 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#840254}
-
Mustafa Emre Acer authored
Presently, when a user types a domain name in the omnibox such as "example.com", Chrome navigations to the HTTP version of the site (http://example.com). However, the web is increasingly moving towards HTTPS, and we now want to optimize omnibox navigations and first-load performance for HTTPS, rather than HTTP. This CL implements an initial version of defaulting typed omnibox navigations to HTTPS. In particular, the CL: - Modifies omnibox and autocomplete code to use HTTPS as the default scheme for navigations. We call these "upgraded HTTPS navigations". - Observes upgraded HTTPS navigations until completion and falls back to the HTTP version of the URL if the HTTPS load fails. It does this by introducing a new navigation throttle called TypedNavigationUpgradeThrottle. - Ignores SSL errrs in SSLErrorNavigationThrottle if the navigation was an HTTPS upgrade in order to prevent displaying spurious SSL interstitials. Most of the files touched by the CL have plumbing changes: The navigation throttle needs to know whether the navigation was upgraded, so this information is provided by the omnibox via is_using_https_as_default_scheme bit and stored inside the UIData of the navigation handle. This is a minimal implementation and is not ready for general usage. Future CLs are going to observe upgraded HTTPS navigations for several seconds instead and cancel the load when necessary, instead of indefinitely waiting for HTTPS loads to succeed. This CL also lacks many quality of life improvements such as remembering which URLs fell back to HTTP. These will also be added in future CLs. Bug: 1141691 Change-Id: Ie78a34bfa51fc995e9834d491ea43b7cac17598c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568448 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#840253}
-
Benjamin Beaudry authored
In some specific cases, the offset of the innermost abspos was off by exactly one fragmentainer block size. This CL fixes the issue. Bug: 1157086 Change-Id: I9ee621e11d7e411de56a8d8c3da1561d2eb1f7e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602442 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#840252}
-
Jérôme Lebel authored
Following test is flaky on ios14-sdk-simulator: + AddressViewControllerTestCase/testKeyboardIconDismissAddressController Bug: 1163133 Change-Id: Ia9bea2909296b0cea6764d1d379e731238c9c39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610904Reviewed-by:
Javier Flores <javierrobles@chromium.org> Commit-Queue: Javier Flores <javierrobles@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#840251}
-
Eric Orth authored
Flakiness is expected to be resolved now that captive portal tests do not make assumptions regarding GetLastActive() window. Fixed: 11139282 Change-Id: Ic24aa19bfb6985188d8674763badcf8857bf1a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611464Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#840250}
-
Lin XInan authored
Still in POC stage, make chromeos-amd64-generic-lacros-chrome run an existing tast(tast.critical-chrome) on CrOS device via Skylab. BUG=1139516 TEST=./generate_buildbot_json.py Change-Id: I29b9df8610f587d067c3aba831679f16bb0a4f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586073 Commit-Queue: Xinan Lin <linxinan@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#840249}
-
Bruce Dawson authored
Partition Alloc has a few different out-of-memory error reporting paths with different meanings for the "size" parameter. These different paths are supposed to be distinguishable by looking at the call stack but a combination of code folding and tail-call optimizations means that this is not actually guaranteed. In one (most?) crash dumps a call to PartitionOutOfMemoryWithLargeVirtualSize shows up on the stack as a call to PartitionExcessiveAllocationSize. This change disables code folding for the relevant functions, and disables tail calls as well. This should make understanding OOM failures easier. Bug: 1159694 Change-Id: I0faf577fa0e82e88f7a06940c97a570e778e5ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607585 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#840248}
-
Evan Stade authored
It's been unused since eff032d4 Bug: none Change-Id: I8bff98f5f75dbc87593097904f225a5ee936ff6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599884Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#840247}
-
Carlos Caballero authored
Bug: 1146622 Change-Id: I241126dabeadad6e51ed541372ef7c8952d49a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611265 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#840246}
-
Greg Thompson authored
With this change, Chrome's installer now includes the --from-installer switch when launching Chrome. When this switch is present during Chrome startup and a browser window is active following the StartupBrowserCreator's job, the text "Welcome to Chrome; new browser window opened" is announced. This lets users relying on assistive technologies know that installation has finished and Chrome is ready for action. conclusion of installation. Bug: 1072735 Skip-Translation-Screenshots-Check: true AX-Relnotes: Chrome will issue a spoken alert when launched at the Change-Id: I4a493052abe7a0ce30553388ed9801418a86fb17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587050 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#840245}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/75eced6da617..92311b48d43d 2021-01-05 michael.liao@microsoft.com [Sources]: Remove _resetPlaceholderState from sources placeholder view If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1161471 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic9d095e27159a65861a0797562ceab8fa79783fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611016Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840244}
-
spdonghao authored
Screenshots: MV tiles & carousel tab switcher: https://drive.google.com/file/d/1Gnk9tYwa-2zREw7EZaw6E9iTZrxtXe7D/view?usp=sharing&resourcekey=0-uByWJIp7_VoTlTcR1XOk7A Carousel tab switcher & Feed articles: https://drive.google.com/file/d/1-Ge1bYU2bp6cwDGTy3UDhONs6VBz2l66/view?usp=sharing&resourcekey=0-vZH4AqM_9w94cwqQtzirfQ Bug: 1156256 Change-Id: I25c14d962395a4ff44b6d2b3eb38ff6e190a6279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595633Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#840243}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ff29e249d317..b9e179f1f239 2021-01-05 capn@google.com Clarify 3-level caching of sampling routines If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic410a17df68a97a0add562f19c8f1aa38140a4a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611070Reviewed-by:
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 21 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2021-04-05. TBR=chromium-metrics-reviews@google.com Change-Id: I11e1f8ba0d308fd6a68b83bb323142beefb33734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611345Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#840241}
-
Evan Stade authored
For the user action of explicitly choosing not to clear a site in the clear browsing data dialog, "exclude" is more appropriate. For the list that tracks the number of times a site was ignored, some variation of "ignore" is more appropriate. For the action of removing a site from the importants list when it's been ignored too many times, "suppress" is more appropriate. TBR=dullweber@chromium.org Bug: 1161340 Change-Id: I14094e6d3e50a10ab6fef96953831705d2cb14fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599918Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1609847937-cf5cc478b4222d5ab5a9c5d5ace2908da8c23e42.profdata to chrome-win32-master-1609858728-3e92b62c0c1af42b6c3d7f7431a7286c240b0146.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ifa4f17534f72d48ba7eeccc836cf802d247b022a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611072Reviewed-by:
-
David Black authored
When holding space is enabled and the holding space has content, file thumbnails will show in the shelf. The user can enable/disable this behavior via context menu. Bug: 1155387 Change-Id: Ie7e6a56d677473ca19b70b98bb383db082ace2b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605397Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#840238}
-
Min Qin authored
BUG=1157743 Change-Id: Ib6d78ada4e84935873b8968ba560ed9653bf6294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595526Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#840237}
-
Jordan Bayles authored
This patch adds jophba@chromium.org as an owner to several cast directories, especially mirroring and remoting related code. Change-Id: I29a35b5ba7f957faf04bb6b5e6acc44ccfc95396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605389Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#840236}
-
Ryan Sturm authored
I hit a DCHECK using the frame tree node code path in the devtools code. I audited the uses of frame tree node, and the two cases that could possibly DCHECK or AV are these two. It makes sense that there is no way to access the dev tools code when the fetch is not tied to a frame. Change-Id: I571b77a4b4934e94ab5f6cf72b7aacdb0a71c67d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606289Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#840235}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 174 histograms that show frequent access in the past 90 days. These are the 95% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2021-04-05. TBR=chromium-metrics-reviews@google.com Change-Id: I011a2481967313e6d2e340a32bd1657850cd90e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611306Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#840234}
-
Sahel Sharify authored
This reverts commit 46d850ca. Reason for revert: The newly added TestsForceEphemeralProfilesPolicy times out on Windows. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=AllGuestProfileTypes%2FEphemeralGuestProfilePolicyTest.TestsForceEphemeralProfilesPolicy%2F1&testType=browser_tests Original change's description: > Update ephemeral Guest Profile handling when policy is set. > > When |ForceEphemeralProfiles| is set to false, ProfileManager cannot > overwrite the pref for ephemeral Guest profiles. > To overcome the issue, a new |IsEphemeral| function is added to the > ProfileManager which not only checks for the pref value, but also > consider profile type. > > Bug: 1125474 > Change-Id: Ieb22c22d4ed5ac63abe0c01096e10397eb0b6531 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584025 > Reviewed-by: Dominic Battré <battre@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Commit-Queue: Ramin Halavati <rhalavati@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840017} TBR=battre@chromium.org,msarda@chromium.org,rhalavati@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1125474 Change-Id: Ifcd0bfe22022db12e0d042ec734573256a59de1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605358Reviewed-by:
K. Moon <kmoon@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#840233}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4a9c1b46..b5675ec0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia533fce1cce4ed211adce8052e579b96d90b8c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611204Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840232}
-
Evan Stade authored
This was recently marked as RepeatingCallback, but should actually be OnceCallback, as it's fired at most once. MTPDeviceDelegateImplLinux does at times try to pass this callback off to more than one owner, however this is an implementation detail that should not make it into the public API. To circumvent this hurdle, a wrapper is introduced in MTPDeviceDelegateImplLinux. Bug: 1152278 Change-Id: Ie00927fad8f8fa95961380fcd391e6b463263a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598010Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#840231}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/472239462122..f9a1b53d2809 2021-01-05 treehugger-gerrit@google.com Merge "Add log for invalid API use." 2021-01-05 treehugger-gerrit@google.com Merge "GN: Add enable_perfetto_traced_probes variable" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9ef1782a28953eba3db0e421706f1207fdaf08a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611069Reviewed-by:
-
Bo Liu authored
The shell unsets the FullscreenCallback when the activity is destroyed, to avoid leaks, and also to avoid callbacks hitting null because the activity no longer exists. However unsetting FullscreenCallback has the side effect of exiting fullscreen, which is not desired. Instead, create a static FullscreenCallbackImpl that can unset its reference to the Activity when it's destroyed. Bug: 1159529 Change-Id: Ide0d440ada7d32c806b0c715538624e310e4fd8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601667Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840229}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.75. R=kbr@chromium.org, rmhasan@google.com Bug: 1041619 Change-Id: I892ccfc4178b117af1b98430dd21de9bc278a8c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606136 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#840228}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 87.0.4280.140. R=machenbach@chromium.org, rmhasan@google.com Bug: 1041619 Change-Id: I0a0a7520bf18a4658e5e2b52b7b6ad4c414ba2a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606135 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
-
Regan Hsu authored
Bug: 1146224 Change-Id: I780690c7b17ad109dd0291fa3f2bec1dade64775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610946Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#840226}
-
chromium-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/d0adb7e24551..393f02dd00ba 2021-01-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from f426f652299d to 9325cc013e3d (1 revision) 2021-01-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from e50f7d1ce8e1 to 7b7a21c4058c (3 revisions) 2021-01-05 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 17ffa89097b2 to 1bb80d2778a3 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com Change-Id: I7d669e00961f806ed59abd23cb4be50771a7b472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611006Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840225}
-
Sergey Ulanov authored
Previously FuchsiaAudioRenderer was stopping at EOS without updating buffering state to HAVE_ENOUGH. This means that when stream is seeked to the end of file playback never resumes. Fixed it to update buffering state as soon as EOS is reached. Bug: 1162503 Change-Id: I57d6a08469830c069a13252c4767f3b7f57ed24a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606034 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840224}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Icb72de6d168cde6195662ee906cd8fd28d4836c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610926Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840223}
-
Stephen McGruer authored
Bug: 1163175, 1163176, 1163178 Change-Id: I1e11bb23cd9212a7da2439d65e6acfec7865b2d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611285 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#840222}
-
Dominique Fauteux-Chapleau authored
This relands crrev.com/c/2590429 with the exact same changes, except with some changes to avoid the CFI error that caused a revert (crrev.com/c/2597715). Those differences with the original CL can be seen by looking at the patchset 1-3 diff. This is a reland of 4ee6e77f Original change's description: > Add profile DM token reading code to ConnectorsService > > This adds the main code to read the DM token from the profile instead of > CBCM. The PerProfileConnectorsEnabled feature guards these changes from > affecting working Connector policies. This change is insufficient to > test per-profile Connectors since the authentication and reporting code > still assume the DM token is from the browser. > > This adds a tweak to Connector policy test setters to ensure existing > tests don't break and still use the browser DM token. > > Bug: 1148789, 1155585 > Change-Id: I64bb1714667b0b61fdfdbadffbc153328e22f741 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590429 > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Daniel Rubery <drubery@chromium.org> > Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838139} Bug: 1148789 Bug: 1155585 Change-Id: Ic69ae3760171932f1f7dde8674a90b860ce22b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603586Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#840221}
-
Tanmoy Mollik authored
Replace IdentityManager.Observer.(onPrimaryAccountSet/Cleared) calls with onPrimaryAccountChanged call. This cl also fixes an issue where the IdentityDisc is not shown until first refresh when the user signs in without sync consent. Bug: 1132291, 1158855 Change-Id: Iefec79c38f39af8927ac5a30648e19f398e16401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598915 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840220}
-
Ryan Sturm authored
BF and restore navigations are allowed to use cache even when the cache-control headers would otherwise require revalidation. When this occurs on a previously served Search Prefetch URL, Chrome should attempt to serve the prefetch response from cache, and then fallback to the navigation URL on the network. Bug: 1162121 Change-Id: I5ec8c82fe772e57acce812987efed2baa3301ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605414Reviewed-by:
-
Gil Dekel authored
Most internal panels expose a single native mode, and for those internal displays with additional modes, Chrome does not have use-cases which require those extra modes. This CL restrict internal displays to expose only their preferred mode to Chrome. Test: ozone_unittests && display_unittests Change-Id: I0f9480846dc7876992110aca0f28e81384a33cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595621Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Gil Dekel <gildekel@chromium.org> Cr-Commit-Position: refs/heads/master@{#840218}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dc435fa60df6..7d63f91e4a43 2021-01-05 jcgregorio@google.com Add optional --yes argument to tools/install_dependencies.sh. 2021-01-05 johnstiles@google.com Add unit test for casting between float, int and bool. 2021-01-05 mtklein@google.com remove 32-bit iOS builders 2021-01-05 reed@google.com Move to sampling for async-rescale routines 2021-01-05 johnstiles@google.com Implement `roundEven` intrinsic in Metal (as `rint`). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: Ifbd981e791d5a73afbcd0e7f38a104c7ce07e34a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611008Reviewed-by:
-
