GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287938 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179632:179654&mode=html
TBR=jbroman@chromium.org
BUG=

Review URL: https://codereview.chromium.org/447913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287937 0039d316-1c4b-4281-b951-d872f2087c98

For the time being I have to duplicate these. Separately I'm going to
investigate centralizing these exclusions.

BUG=401201
TEST=none
TBR=sbc@chromium.org

Review URL: https://codereview.chromium.org/445133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287936 0039d316-1c4b-4281-b951-d872f2087c98

When running from outside chrome (e.g. in athena), 'app' and 'webstore' api
implementations are not available. So check to see if the API is available
before registering the corresponding bindings.

BUG=391478
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/443723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287935 0039d316-1c4b-4281-b951-d872f2087c98

If MD is enabled, add a value to the config dictionary passed to the page.

BUG=400332
TEST=manual

Review URL: https://codereview.chromium.org/447033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287934 0039d316-1c4b-4281-b951-d872f2087c98

This CL merges navigation list (the very left pane) and directory tree (middle pane).
In the conbined tree, the first-level children are VolumeItem or ShortcutItem, which correspond to NavigationModelItem.
Only Drive volume has children and the Drive volume. They are DirectoryItem and the behavior is similar to previous directory tree.

BUG=390848,397222
TEST=run browser_tests

Review URL: https://codereview.chromium.org/441233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287933 0039d316-1c4b-4281-b951-d872f2087c98

These were missed by the big renaming CL
https://codereview.chromium.org/356713005/.

R=rch@chromium.org,asargent@chromium.org,lcwu@chromium.org
TBR=twilson@chromium.org
BUG=

Review URL: https://codereview.chromium.org/430673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287932 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rkc@chromium.org
BUG=None.

Review URL: https://codereview.chromium.org/448943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287931 0039d316-1c4b-4281-b951-d872f2087c98

(due to direct_dependent include_dirs)

R=brettw@chromium.org
TBR=thestig@chromium.org
BUG=354261

Review URL: https://codereview.chromium.org/448743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287930 0039d316-1c4b-4281-b951-d872f2087c98

The first version of the Safe Browsing interstitial used a SBInterstitial counter. It was subsequently replaced by two histograms: SB2.InterstitialAction and SB2.InterstitialActionDetails. This deprecates the SBInterstitial counter.

BUG=346120

Review URL: https://codereview.chromium.org/439683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287921 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379148

Review URL: https://codereview.chromium.org/441013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287920 0039d316-1c4b-4281-b951-d872f2087c98

* Renaming AccountInfo to AccountMapping.
* Adding status and timestamp of it's last change
* Removing last message timestamp, as with introduction of
  message ack event, it is no longer needed

BUG=374969
R=zea@chromium.org

Review URL: https://codereview.chromium.org/443573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287919 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rkc@chromium.org
BUG=None.

Review URL: https://codereview.chromium.org/445243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287918 0039d316-1c4b-4281-b951-d872f2087c98

These histograms are derived from OmniboxEvent log entries.

Some new types are appearing in some new logs nowadays.

TBR=vadimb

BUG=

Review URL: https://codereview.chromium.org/443873007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287916 0039d316-1c4b-4281-b951-d872f2087c98

This will make setAcceleratedCompositingForCanvasEnabled always be
true. There are separate settings to turning canvas on/off entirely.

R=piman@chromium.org
BUG=364908

Review URL: https://codereview.chromium.org/445123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287913 0039d316-1c4b-4281-b951-d872f2087c98

A refactor of FileDownloader (r284961) broke the caching behavior for nexes
that were translated from pexes; the cache would always end up with entries of
length 0, breaking future loads of the pexe. This is the translated nexe was
written to the wrong file handle, preventing caching of the result.

This change causes the translated nexe to be written to the correct file
handle, fixing the caching behavior.

I manually tested this change on the "game of life" demo at
https://gonativeclient.appspot.com/demo/life, verifying that a cached
translated nexe for the pexe was successfully loaded.

BUG=401121

Review URL: https://codereview.chromium.org/447013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287912 0039d316-1c4b-4281-b951-d872f2087c98

The Java DistilledPagePrefs observers are wrapped in a
native observer, which is only deleted when the observer is
removed again. Since the reference to this native observer
wrapper is kept in a Java map with the real Java observer as
the key, the second time addObserver(foo) is called with the
same observer, the first reference is lost, and the native
object is leaked. 

For example, the following would leak a native object:
addObserver(foo);
addObserver(foo);
removeObserver(foo);
removeObserver(foo);

It is already safe to remove an observer if it is not
currently an observer, and this CL ensures that an observer
can only be added once, so the second calls to
addObserver(foo) and removeObserver(foo) will be no-ops.

addObserver and removeObserver will return a boolean based
on whether they have successfully completed the operation.

BUG=383630

Review URL: https://codereview.chromium.org/426153006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287911 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391071

Review URL: https://codereview.chromium.org/442173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287910 0039d316-1c4b-4281-b951-d872f2087c98

BUG=223859

Review URL: https://codereview.chromium.org/447923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287906 0039d316-1c4b-4281-b951-d872f2087c98

Ports most of the sync GYP targets to GN.  Adds comments in the original
GYP files pointing to the new GN targets.  Fixes some TODOs in other
files that were blocked on sync GN support.

Adds several new linkable targets to the GN build.

The android-specific parts of sync have not been converted yet.

TBR=nyquist,rogerta
BUG=

Review URL: https://codereview.chromium.org/439533004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287905 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/443703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287904 0039d316-1c4b-4281-b951-d872f2087c98

If the star in the Location Bar is already in the correct state, then there's
no need to perform a complete redraw.

This was responsible for ~50% of extraneous location bar redraws, which was
consuming ~5% of cpu cycles on start up.

BUG=393819

Review URL: https://codereview.chromium.org/442343006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287902 0039d316-1c4b-4281-b951-d872f2087c98

Plugin logic expects redirects to have headers, and gets very confused
when they're missing.

BUG=345160

Review URL: https://codereview.chromium.org/422233006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287901 0039d316-1c4b-4281-b951-d872f2087c98

API which enables the exchange short messages with nearby devices.

This is the audio handling code of the copresence core component. We'll be
open sourcing this code in phases, this is the first part. This CL includes
the code for the directive handler for copresence, and all related classes.
Including blundell@ for the OWNERs review to add this component.

R=dalecurtis@chromium.org, derat@chromium.org, jochen@chromium.org, xiyuan@chromium.org, blundell@chromium.org
BUG=365493

Review URL: https://codereview.chromium.org/419073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287900 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394532
TEST=unit_tests

Review URL: https://codereview.chromium.org/444543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287899 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287897 0039d316-1c4b-4281-b951-d872f2087c98

This patch rolls trace-viewer to r1445.

TBR=nduca
NOTRY=true

Review URL: https://codereview.chromium.org/444103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287896 0039d316-1c4b-4281-b951-d872f2087c98

to track server config expiration from 1 minute to 30 days.

Minor cleanup of names and description of server config expiry
and use of inchoate ClientHello.

Fixed wtc's comments for CL:
  https://codereview.chromium.org/413363005/

R=jar@chromium.org

Review URL: https://codereview.chromium.org/443763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287895 0039d316-1c4b-4281-b951-d872f2087c98

Each application <> shell connection is represented by a ShellImpl instance
on the shell side. This CL makes the Application watch its ShellPtr for pipe
errors so it can Quit() itself if the shell goes away (shell loop destroyed).

mojo_shell_tests starts using a new method to terminate all shell connections
in this CL, and waits afterward until KeepAlive quits the loop signifying that
all apps are gone. This is done prior to destroying the shell MessageLoop so
that the test ensures apps have all died before the next test. In the future
it would be a test failure if this wasn't a no-op, but we have things in the
shell that don't quit themselves right now.

The shell itself won't wait around for apps to die (as of this CL), but
~MessageLoop will still send the message to Application sides that will quit.

** NOTE ** This does not require an app build target to explicitly add magic
*.cc files to their sources.  It requires selecting an appropriate
mojo_application_{chromium, standalone} library akin to mojo_environment_*.
We can possibly combine these two in the future.

BUG=394477

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287680

Review URL: https://codereview.chromium.org/394903005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287894 0039d316-1c4b-4281-b951-d872f2087c98

Instead of passing the sync server URL as a string, int, and bool, just
pass the GURL.  In a future CL SyncManager will make use of this GURL to
initialize an AttachmentUploader.

clang-format was used to format the modified lines.

BUG=

Review URL: https://codereview.chromium.org/442403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287893 0039d316-1c4b-4281-b951-d872f2087c98

Calling pushState when the search page is shown causes history entries after
the current one to be lost.

This mimics the pre-r271538 behavior where it set location.hash. Setting
location.hash is a no-op (rather than pushing a duplicate history entry) if the
hash has not changed.

BUG=401004

Review URL: https://codereview.chromium.org/446093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287892 0039d316-1c4b-4281-b951-d872f2087c98

NSS would use "" as the password while OpenSSL would use "\0\0" (UCS-2 encoding
of a NUL-terminated string) because of how PKCS#12 recommended encoding
passwords. Make the OpenSSL code use the same format so that we can freely switch
back and forth between NSS and OpenSSL.

(This is in case we need to roll back an OpenSSL cutover and the release has
hit some early release channel already.)

BUG=399121

Review URL: https://codereview.chromium.org/435593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287890 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/449603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287889 0039d316-1c4b-4281-b951-d872f2087c98

* Give it its own copy of its test data, instead of sharing with other
unrelated tests that live in src/chrome.
* Introduce ChromeComponentExtensionResourceManagerTest to address a TODO
and eliminate the src/chrome dependency.

BUG=397164
TEST=unit_tests, extensions_unittests

Review URL: https://codereview.chromium.org/439023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287885 0039d316-1c4b-4281-b951-d872f2087c98

This doesn't seem to be a problem for release builds, but in debug builds the invalid array access causes STL errors:

    error: attempt to subscript container with out-of-bounds index 0, but
    container only holds 0 elements.

BUG=401161

Review URL: https://codereview.chromium.org/446853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287884 0039d316-1c4b-4281-b951-d872f2087c98

If new assertions fire or crashes occur, these PDBs are needed in
order to generate reasonable stack traces. Remove the comment about
their presence being temporary.

BUG=383963,385976

Review URL: https://codereview.chromium.org/448773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287882 0039d316-1c4b-4281-b951-d872f2087c98

This method is taking a non-trivial amount of time during a typical scroll
sequence, so convert the instant trace into a proper scoped trace.

BUG=401204
NOTRY=true

Review URL: https://codereview.chromium.org/446063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287881 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385992
TEST=MultiUserWindowManagerChromeOSTest.TestBlackBarCover & visual inspection

Review URL: https://codereview.chromium.org/448493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287880 0039d316-1c4b-4281-b951-d872f2087c98

Put the .d file in the same directory as the output from grit. Currently it
uses the default location for the .d file all the time, even in cases where the
output directory is overridden and the rest of the files go somewhere else.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/450483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287877 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
Test=None, internal comment only change.

Review URL: https://codereview.chromium.org/427183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287876 0039d316-1c4b-4281-b951-d872f2087c98