GitLab

This is a reland of f3f5b838

I think I've finally fixed the root issue and this is ready
to land again.

Original change's description:
> Reland "[ar] Do not refer to ARCore shim in APK merger"
>
> This is a reland of 58e4a081
>
> Original change's description:
> > [ar] Do not refer to ARCore shim in APK merger
> >
> > This hard-coding should no longer be required.
> >
> > Bug: 839191
> > Change-Id: Id44f0f19da6efcee90ef79ea3e241eb2a7ea5843
> > Reviewed-on: https://chromium-review.googlesource.com/1147706
> > Commit-Queue: Ian Vollick <vollick@chromium.org>
> > Reviewed-by: Richard Coles <torne@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#577662}
>
> Bug: 839191
> Change-Id: I42c3d31c0cbe49c1fe2d68c55d0db18dcdc3381d
> Reviewed-on: https://chromium-review.googlesource.com/1151567
> Reviewed-by: Richard Coles <torne@chromium.org>
> Commit-Queue: Ian Vollick <vollick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578347}

Bug: 839191
Change-Id: I2618d967b214fb8f21264d6303837b08729222c4
Reviewed-on: https://chromium-review.googlesource.com/1152275Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579391}

In this CL, we use the flag that is added in CL:1150026 to test whether telemetry
is in compatibility mode, if so, we will not add the field trials configuration
to bypass earlier Chromes' configuration file size limit in order to run benchmark on them.

Corresponding test case is added as well.

Some style change is also included to keep gpylint happy.

Bug: chromium:866881
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I97bd81ce14b45afb5995f0c3d925aa3ef4d0810b
Reviewed-on: https://chromium-review.googlesource.com/1150032
Commit-Queue: Leonard Ge <wangge@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579390}

https://android.googlesource.com/platform/external/perfetto.git/+log/3f1566f6317f..37a1543bfe3a


git log 3f1566f6317f..37a1543bfe3a --date=short --no-merges --format='%ad %ae %s'
2018-07-31 treehugger-gerrit@google.com Merge "Fix Zoom Duration on Tap"
2018-07-30 michaschwab@google.com Fix Zoom Duration on Tap


Created with:
  gclient setdep -r src/third_party/perfetto@37a1543bfe3a

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I120a93297c0c7c50a9319840a4167c826648dc2e
Reviewed-on: https://chromium-review.googlesource.com/1156484
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579389}

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie5ad888db854272c8be30413697d85b816ce0639
Reviewed-on: https://chromium-review.googlesource.com/1155797Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579388}

The CL also updates the actual Autofill Home icons with the required size.

Bug: 856662
Change-Id: I3b8df3dec255cb703bd856183de30490640638a1
Reviewed-on: https://chromium-review.googlesource.com/1152983Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579387}

- Move FilterModel to FilterProperties.
- Incorporate showing/hiding the tabs as a new property on the model.

Change-Id: I0711ab244aada2ee27d8693408551261911df41e
Reviewed-on: https://chromium-review.googlesource.com/1149268
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579386}

The pages chip in downloads home was showing up even though the pages
were prefetched and did not show up in "My Files".  This was because we
were considering the suggested pages as PAGES for filter purposes and
keeping the chip visible.  We now consider all suggested content as
PREFETCHED for the purpose of the chips.

This is NOT baked into the base
Filters.fromOfflineItem(OfflineItemFilter) logic because we do not want
to restrict the suggested tag to only pages.

Change-Id: Iad2c74b7efd2f55cab06a15e6883d3e8cc0df73e
Reviewed-on: https://chromium-review.googlesource.com/1152234Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579385}

This CL fixes a crush bug in Relocate().
It is caused when we relocate backings that were dereferenced in EagerSweep/PreFinalizer/WeapProcessing.
The slots are no longer referenced so we can early return and fix the bug.

Bug: 869301
Change-Id: Id46854267065744f38f9be567b7d286f2175b99f
Reviewed-on: https://chromium-review.googlesource.com/1155329
Commit-Queue: Haruka Matsumura <harukamt@google.com>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579384}

So Reflector doesn't work with VizDisplayCompositor yet at all. See
https://crbug.com/601869 for tracking getting this working again.

This updates the ReflectorImplTest to exit early when VizDisplayCompositor is
enabled. This is so that we can remove the filter files used for
content_unittests with Viz.

This change then also removes the filter file, and updates the bots.

TEST=ReflectorImplTest

Bug: 762512
Change-Id: I5fa02925cbe3d961fbfa46f646b68b25da5671ed
Reviewed-on: https://chromium-review.googlesource.com/1153300Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579383}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: Iea523564b620467df5c70aeecfe169a6981b5496
Reviewed-on: https://chromium-review.googlesource.com/1156471
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579382}

PendingConnectsMap already owns WebSocketTransportConnectJob,
and the raw pointer type is not idiomatic for this case.
Using release() for taking over ownership and naked deletes
when erasing are screaming for unique_ptr<>.

Change-Id: Ibdd2a219392bdd332c6c2e477687e8dbdf6e600c
Reviewed-on: https://chromium-review.googlesource.com/1155310Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579381}

When building using jumbo, files get merged and
the usage of "using namespace..." results in the
error:
using namespace directive in global context in header

This commit solves the issue by removing
"using namespace" and instead write the complete
name when it is used.

Bug: 867350
Change-Id: Iba570fbb737819ed515dc686ba65f9e7f9b47653
Reviewed-on: https://chromium-review.googlesource.com/1154538
Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org>
Reviewed-by: Chrome Cunningham (In Paris) <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579380}

Previously it would CHECK, which would be fine since this is
non-production code, but clusterfuzz strenuously objected.

Bug: 868657
Change-Id: I9744b8e36be7d4645a1901656453608d7068671f
Reviewed-on: https://chromium-review.googlesource.com/1154978
Commit-Queue: Dan Elphick <delphick@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579379}

Ensure to wait until the login manager UI is loaded/available before
continuing with the actual test.

When UserAffiliationBrowserTest was passing "--login-manager" and
"--force-login-manager-in-test" and the test function did not do any
substantial work, the test crashed on shutdown.

      browser_tests --gtest_filter=*UserAffiliationBrowserTest*

Bug: 869272
Test: compile browser tests with is_debug=true and run \
Change-Id: I44c35e5df6850d908a694a64b2bd648b008ec5a6
Reviewed-on: https://chromium-review.googlesource.com/1155592Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579378}

Bug: 807724
Change-Id: I510e6b677606c30265956a1f290ae0b1ef9b0214
Reviewed-on: https://chromium-review.googlesource.com/1155089Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579377}

Was currently just checked when trying to create the pseudo element.
This change should have no effect, but is done in preparation for [1].

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1155591

Bug: 847218
Change-Id: I99fa06bed1256cb6405e6f24a5f116def366acf9
Reviewed-on: https://chromium-review.googlesource.com/1156389Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579376}

1. Set |stencil_size| to 0 except on Chrome OS. This is copying what
   happens in GpuProcessTransportFactory.
2. Set |lose_context_when_out_of_memory| to true. We can handle lost
   contexts in VizProcessContextProvider now.

Bug: 866486
Change-Id: I5f3b1332616883df9cb7b78b8e46c71fc85dfa70
Reviewed-on: https://chromium-review.googlesource.com/1155651Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579375}

https://webrtc.googlesource.com/src.git/+log/df9e9ae9ee66..304da796abc6


git log df9e9ae9ee66..304da796abc6 --date=short --no-merges --format='%ad %ae %s'
2018-07-31 nisse@webrtc.org Revert "Delete root header file typedefs.h. Part 2."
2018-07-31 nisse@webrtc.org Delete root header file typedefs.h. Part 2.


Created with:
  gclient setdep -r src/third_party/webrtc@304da796abc6

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Iad9a4bed4b40294f554ee431bac87e333b2132f1
Reviewed-on: https://chromium-review.googlesource.com/1156253Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579374}

Commit 7732d4d0 ("Fix many android layout test bugs") marked some layout
tests as failing on Android. It turns out some of them are actually crashing
on android_blink_rel, and preventing new WPT imports because rebaseline-cl
tries to add duplicate expectations to TestExpectations.

Use the results from
https://ci.chromium.org/buildbot/tryserver.chromium.android/android_blink_rel/7107
to update the list.

TBR=jbudorick@chromium.org
NOTRY=True

Bug: 824539
Change-Id: I4bd46d9fdc0b3c7e75b6c91ac10792fadef1eab7
Reviewed-on: https://chromium-review.googlesource.com/1156505Reviewed-by: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#579373}

Before this CL, the renderer emitted a large amount of redundant
messages to the browser: Whenever a focused node changes, there would
be a message to the PasswordManagerDriver.

With this CL, only relevant requests (when a fillable input field is
focused) are always sent to the driver.
For multiple focus changes to unfillable fields, only the first change
results in a message to the driver.

This should fix a performance regression (see linked bug).
Running the third_party/blink/perf_tests/css/FocusUpdate.html 20 times
resulted in the times below which amount to ~10% difference.

Without this CL:
median 3359.5858379950205 runs/s
ranging from 2484 runs/s to 3464 runs/s

With this CL:
median 3008 runs/s
ranging from 2600 runs/s to 3639 runs/s

Bug: 866527
Change-Id: Ief36dea9a7a3f30e83ab9c7454124374b95ed52b
Reviewed-on: https://chromium-review.googlesource.com/1154541
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579372}

Change-Id: I0a9f90bcbb69cc6dd512ba6cb728ae285878e3b2
Reviewed-on: https://chromium-review.googlesource.com/1156336Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579371}

This CL migrates our Background Fetch layout tests to our WPT suite, and
adds coverage in various new areas, together with a few minor bug fixes.

Tests related to initializing the Service Worker events haven't been
included as the event model has just been updated. New tests will be
added based on that soon.

One file which was removed without being migrated was
"credentials-in-url.https.window.js". This was testing the Fetch API as
opposed to Background Fetch. Instead, the requirement to propagate
exceptions thrown by the Fetch API is tested in fetch.https.window.js.

Bug: 864561
Change-Id: I077be6c5bf8c379e3108f4ec3207011582028477
Reviewed-on: https://chromium-review.googlesource.com/1155118
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579370}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/eb15bd6c..27f30125

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: If4f9cc515a6a0870b6072a15dc87b996a8c614ae
Reviewed-on: https://chromium-review.googlesource.com/1156251Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579369}

https://android.googlesource.com/platform/external/perfetto.git/+log/296b43d7e177..3f1566f6317f


git log 296b43d7e177..3f1566f6317f --date=short --no-merges --format='%ad %ae %s'
2018-07-31 hjd@google.com Merge "perfetto-ui: Remove unused file all_tracks.ts"
2018-07-31 hjd@google.com Merge "perfetto-ui: Make UI grid based"
2018-07-30 hjd@google.com perfetto-ui: Make UI grid based
2018-07-30 hjd@google.com perfetto-ui: Remove unused file all_tracks.ts


Created with:
  gclient setdep -r src/third_party/perfetto@3f1566f6317f

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Ib8367de8022f742d2b2a2b970bb4e42e7da62186
Reviewed-on: https://chromium-review.googlesource.com/1156254
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579368}

This CL applies a refactoring tool at //tools/clang/base_bind_rewriters
to //components, that updates base::Bind to base::BindOnce where the
resulting Callback is immediately converted to OnceCallback.

This reduces the number of base::Bind in //components by 921 (from 2749 to 1828).

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia07c5b2987e113efcdeccab8f5b4ec290779d128
Reviewed-on: https://chromium-review.googlesource.com/1151035
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579367}

This is a reland of a3ec8289

Original change's description:
> Re-enable webrtc audio quality browsertests on windows.
>
> Tests were previously disabled when they started failing (more context in linked bug). Re-enabling because tests pass locally on win7 machine.
>
> Bug: 850936
> Change-Id: Ie1ab4e82daf2c0265e932237d3edf6b3399ee803
> Reviewed-on: https://chromium-review.googlesource.com/1139066
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575638}

NOTRY=True

Bug: 850936
Change-Id: I53579cd78304a845c6ec45500980c1a5cc6f96eb
Reviewed-on: https://chromium-review.googlesource.com/1156444
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579366}

Adding list of commands for each switch to toggle from the Google
services settings (see the screenshot). To associate those commands to
each UISwitch, SyncSwitchItem.commandID is added.

GoogleServicesSettingsViewController calls the right command on its
|commandHandler| when a switched is toggled.

GoogleServicesSettingsMediator implements
GoogleServicesSettingsCommandHandler to modify the model when the user
toggles the switches. The coordinator sets the mediator to be the
command handler for the view controller.

Screenshot: https://drive.google.com/open?id=1hvi5LyGjBDODkRQymvC5sbUjSN9tafFz

This patch is to replace: crrev.com/c/1146730

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ica05f255bc2af154033a53cd1a1365c43775f9c7
Reviewed-on: https://chromium-review.googlesource.com/1155587
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579365}

https://chromium.googlesource.com/catapult.git/+log/65f883bb7739..8786c7f1de1c


git log 65f883bb7739..8786c7f1de1c --date=short --no-merges --format='%ad %ae %s'
2018-07-31 wangge@google.com Add attribute `compatibility_mode` to `BrowserOptions` Class.


Created with:
  gclient setdep -r src/third_party/catapult@8786c7f1de1c

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:866881
TBR=sullivan@chromium.org

Change-Id: Ia68a25335236898b764a3af2905032d8a2716f11
Reviewed-on: https://chromium-review.googlesource.com/1156249Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579364}

Preferences related to Password Manager are removed from the persistent
storage list for incognito mode.
After this CL, if these preferences are changed from incognito mode,
they are only stored in memory and won't affect user profile.

Bug: 861722
Change-Id: I298e226c93a990473158e8eb455fa70370aa6751
Reviewed-on: https://chromium-review.googlesource.com/1155601Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579363}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5e5144a5..eb15bd6c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ic921a287d002c7076a6d0b8afaa3d3464170b336
Reviewed-on: https://chromium-review.googlesource.com/1156247Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579362}

This CL make sure Picture-in-Picture tests don't enable
switches that are already enabled by default.

Change-Id: I288cd11a41b3eddb8a455a36f0165d6b0ec5ecb6
Reviewed-on: https://chromium-review.googlesource.com/1152818
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579361}

When we decide to switch over to legacy layout for a block formatting
context (and the entire subtree) because there's something editable, we
used to only set ForceLegacyLayout on those nodes that create layout
objects, but that isn't enough. There may be descendants of box-less
nodes that may create layout objects later on, and, since
ForceLegacyLayout is an inherited "property", we need to set it on all
potential parent nodes. Otherwise we risk inserting NG objects that
participate in a legacy block formatting context, which isn't allowed
[1].

This matters when we have display:contents (which is very common
situation for shadow DOM slot elements, for instance).

Checking with the layout parent's style whether to force legacy layout
or not fixes the problem.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1127027
enforces this.

Bug: 863040
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I6133c20493017b4648b153f2c7558c76589c3d89
Reviewed-on: https://chromium-review.googlesource.com/1136445Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579360}

ScopedFileOpener::Runner is a ref counted object, and its first reference
used to be made in its constructor through base::Bind.
The reference is passed to ProvidedFileSystem::OpenFile, and released
when the callback object is destroyed.

However, if OpenFile failed, the reference is released before the
Runner construction has done. Then `new Runner` returns a stale pointer,
instead of newly created object.

This CL adds a static consntructor and moves the implicit ref count
manipulation out of the real constructor.

Bug: 866456
Change-Id: I92d68b3383d8fecd900be080cc23551cddb5f12b
Reviewed-on: https://chromium-review.googlesource.com/1156325Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579359}

https://webrtc.googlesource.com/src.git/+log/168b4977f3c2..df9e9ae9ee66


git log 168b4977f3c2..df9e9ae9ee66 --date=short --no-merges --format='%ad %ae %s'
2018-07-31 nisse@webrtc.org Delete RtpVideoStreamReceiver methods GetRtpReceiver and rtp_rtcp


Created with:
  gclient setdep -r src/third_party/webrtc@df9e9ae9ee66

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ie53eed13d23d29acec30a87b30cbb984129b3698
Reviewed-on: https://chromium-review.googlesource.com/1156244Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579358}

This CL corrects the unified search box on J devices as described in the
linked bugs.

To be more precise, the failure on J devices was coincidental: on those
devices, export was not available and therefore no overflow menu and
instead of hiding the overflow menu, the search box would be hidden.

The main changes are ensuring, that we only ever affect the overflow
menu, in case it exists and unifying the way action bar buttons change
appearance.

Bug: 868279, 868316
Change-Id: I969f5085262f4452327e445b2bb2e9286e20a956
Reviewed-on: https://chromium-review.googlesource.com/1154972Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579357}

This CL adds a unit test for the force touch gesture recognizer added
to the toolbar buttons, triggering the popup menu.

TBR=marq@chromium.org

Bug: 864430
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia87d675b460922eb1991de4022438e0ed0b1ce4d
Reviewed-on: https://chromium-review.googlesource.com/1156304Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579356}

Ephemeral provider is added to the list of content settings sources that
are counted in site settings change counter.

Bug: 762560
Change-Id: I526f7280b61b4f777560c58a99cf5148bd9b9ff9
Reviewed-on: https://chromium-review.googlesource.com/1155603Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579355}

Replace Identification arguments of CryptohomeClient and SessionManagerClient with AccountIdentifier.
Add and use conversion functions to create AccountIdentifier from other
types.
Change the key type of SessionManagerClient::ActiveSessionMap to
std::string.

BUG=741274
TEST=build

TBR=msramek@chromium.org for changes under chrome/browser/browsing_data/

Change-Id: Iaa4518f5a6f37f6ac3b89e965ffa59412ffde5cc
Reviewed-on: https://chromium-review.googlesource.com/1144814
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579354}

This will allow us to share this code with the Aura Linux implementation
in a future change. We also create a new abstract class to collect these
attributes while maintaining performance between the different
platforms. Currently there is only an implementation of this class for
Windows.

Bug: 866612
Change-Id: I5cb84b9f226e976ac2b199149ea897831a48d175
Reviewed-on: https://chromium-review.googlesource.com/1152977
Commit-Queue: Martin Robinson <mrobinson@igalia.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579353}

I just discovered that FakeProfileOAuth2TokenService never cancels
access token requests:
- OAuth2TokenService::FetchOAuth2Token() is virtual and overridden by
  FakePO2TS. This is the method that creates pending fetchers for
  access token requests. FakePO2TS' override results in O2TS not
  creating any pending fetchers for access token requests.
- OAuth2TokenService::CancelRequests{ForAccount}(), however, are *not*
  virtual. O2TS simply looks in its set of pending fetchers to cancel
  the relevant ones.

The combination of these facts means that requests are not cancelled
in response to CancelRequests{ForAccount}() when FakePO2TS is used.
This in turn means that production flows are not accurately reflected,
and blocks creating a unittest for a just-discovered production bug
(that itself would perhaps have not landed if this situation was not
as it is).

This CL remedies the problem by having FakePO2TS override the
now-virtual methods for cancelling access token requests to respond
appropriately. It also updates a few unittests that had previously
(either intentionally or unintentionally) worked around the lack of
cancellation by cancelling requests manually after token revocation.

Change-Id: Id935831294849a191e6034f3fe1360bea1dddc9e
Reviewed-on: https://chromium-review.googlesource.com/1154925
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579352}