- 12 Apr, 2018 40 commits
-
-
Wei Guan authored
This is because changes to use the Chrome OS Audio Service (CrAS) are not backwards compatible. BUG=831250 Change-Id: If7eb2ff01224fc16c76574e53e29ff6eacc41ec0 Reviewed-on: https://chromium-review.googlesource.com/1004922 Commit-Queue: Wei Guan <weigua@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#550236}
-
agrieve authored
This reverts commit 0c15ca3a. Reason for revert: Supersize now deals with thin archives as of 6a15a6c4 Original change's description: > Disable thin archive builds on Android. > > Temporary fix while support is added to supersize. > > Bug: 830843 > Change-Id: I677782d52c9927ed08d2a07c5272c18a0901e3d6 > Reviewed-on: https://chromium-review.googlesource.com/1003999 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549397} TBR=thakis@chromium.org,estevenson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 830843 Change-Id: I10a8c141be3808b7095f686c44127f7a102abb7d Reviewed-on: https://chromium-review.googlesource.com/1010322Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#550235}
-
Michael van Ouwerkerk authored
Bug: 800421 Change-Id: Ia33bdfadc93c39c92a6b7ce33c0bf3fbc82a52a6 Reviewed-on: https://chromium-review.googlesource.com/1007722Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#550234}
-
Rohit Rao authored
This file will be shared by the popup_menu, tools_menu, and history_popup code. BUG=818742 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3b62df2300d49faa0f08124b083044b25d62ad37 Reviewed-on: https://chromium-review.googlesource.com/1010522Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#550233}
-
Kayce Basques authored
Bug: 831833 Change-Id: If7df48f525538b0590f0c1529d4d6f8d4d317c48 Reviewed-on: https://chromium-review.googlesource.com/1008637Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Kayce Basques <kayce@chromium.org> Cr-Commit-Position: refs/heads/master@{#550232}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icb2af862ae1ed5d6f41b17cfc710cfbdfede76db Reviewed-on: https://chromium-review.googlesource.com/1010502 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#550231}
-
erikchen authored
This CL is a refactor and has no intended behavior change. This CL creates a new class ClientConnectionManager in components/heap_profiling. This class connects HeapProfilingClients to the HeapProfilingService by observing process creation events. This CL creates a tiny subclass ChromeClientConnectionManager in chrome/ which prevents incognito renderers from being profiled. This refactor is necessary in order to expose this shared logic [previously located in chrome/] to Android WebView. Furthermore, this is a necessary first step in bringing end-to-end tests to Android WebView. In addition to moving the logic, this CL makes several improvements: * The threading model is now sane. ClientConnectionManager must only be accessed from the UI thread. Previously the logic was scattered between the UI and IO threads. * ClientConnectionManager always attempts to hook up existing processes at start. The changes in this CL are tested by the end to end tests in ProfilingTestDriver. Bug: 827545 Change-Id: I0a0fdf6a2f3984188aee54c10041822b412e6815 Reviewed-on: https://chromium-review.googlesource.com/1006096Reviewed-by:Nico Weber <thakis@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#550230}
-
Ethan Kuefner authored
Bug: 744736 Change-Id: Ia1b895010fbb174476a29799b2151c4bc1e0265a Reviewed-on: https://chromium-review.googlesource.com/1010284Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Ethan Kuefner <eakuefner@chromium.org> Cr-Commit-Position: refs/heads/master@{#550229}
-
Steven Bennetts authored
Also added to BUILD.gn for CrOS changes. Bug: none Change-Id: I9cdc4a06246aecbb8b36546cc6c12b4c152f57dc Reviewed-on: https://chromium-review.googlesource.com/1005501Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#550228}
-
Xianzhu Wang authored
This reverts commit 2d526f29. Reason for revert: crbug.com/832020 Bug: 832020 Original change's description: > [PE] Let visual rect cover sub-pixel visual effect outsets > > If an overflowing visual effect has sub-pixel geometry and is painted > with anti-aliasing along pixel-snapped border box, the pixel-snapping > may cause the anti-aliased edge overflow the calculated visual rect. > > Let LayoutBox::VisualRectOutsetForRasterEffects() return 1 if there are > any sub-pixel visual effect outsets to ensure the visual rect covers > all pixels. > > Bug: 827516 > Change-Id: I48f8350fb2124d002333a4cc76486c63ca55f8c9 > Reviewed-on: https://chromium-review.googlesource.com/1003492 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Florin Malita <fmalita@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550014} TBR=wangxianzhu@chromium.org,fmalita@chromium.org,chrishtr@chromium.org Change-Id: Iea3cfeb8e661dac43f27f85ab1eb2e7f00da8b73 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 827516 Reviewed-on: https://chromium-review.googlesource.com/1010582Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#550227}
-
Sarah Hu authored
Bug: 817599 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I833c44fac8347974c4ec173ed83902ec09b7e15a Reviewed-on: https://chromium-review.googlesource.com/1004414 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#550226}
-
Hannes Payer authored
The V8-side landed in: https://chromium-review.googlesource.com/c/v8/v8/+/981146 Bug: chromium:814144 Change-Id: I3ef9523b4a0f371ce0f22400ef3c70bb521117ee Reviewed-on: https://chromium-review.googlesource.com/999472 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#550225}
-
arthursonzogni authored
The hard timeout of services_unittests on chromium.android/KitKat Phone Tester (dbg) was 120s. However, it often runs close to 120s, which results in task timeout. This CL increase the timeout to 240s. Bug: 832021 Change-Id: Ibc6a6984de8915a7c7a33349041d15c6cb13e1db Reviewed-on: https://chromium-review.googlesource.com/1009949 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#550224}
-
Sammie Quon authored
Back button visibility was normally handled on shelf animation finish. When switching from vertical shelf to tablet mode (force bottom shelf), there is no animation, so the back button does not show up. This cl handles that case. Test: ash_unittests BackButtonTest.* Bug: 831469 Change-Id: Ia95e791d30deb5a5c91599039c39094ffa29003b Reviewed-on: https://chromium-review.googlesource.com/1008163 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#550223}
-
Emily Hanley authored
Bug: 757933 Change-Id: I6d5ec84f38f9ae07e223900476b7198691c43d87 Reviewed-on: https://chromium-review.googlesource.com/1010262Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#550222}
-
Rob Buis authored
Fix regression allowing text value for -webkit-background-origin that was caused by r514365. Code change implemented by Bugs Nash, testcase by Rob Buis. Bug: 802256 Change-Id: I11e2b1b19a374e9f6b9c1091d82882ef526bc63c Reviewed-on: https://chromium-review.googlesource.com/1008102 Commit-Queue: Rob Buis <rob.buis@samsung.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#550221}
-
Jun Choi authored
User verification requirement is an optional paramter for MakeCredential and GetAssertion requests. However, while CTAP spec defines the parameter as a boolean, the WebAuthN spec defines the paramter as a enum with 3 values : Required, Preferred, and Discouraged. Implement logic to convert WebAuthN style user verification requirement parameter to CTAP style parameter. Bug: 780078 Change-Id: If7ebe92a2d5fa4d623348ee52bbd6958c30e1a9e Reviewed-on: https://chromium-review.googlesource.com/1002532 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#550220}
-
Troy Hildebrandt authored
Every use of LocationBarButton aside from the omnibox incognito icon were setting their layout_gravity explicitly, so having LocationBarButton have a gravity of end wasn't an issue elsewhere. This brings back the original LocationBarButton and creates the LocationBarActionButton for action buttons instead. TBR=yusufo@chromium.org Bug: 831535 Change-Id: If78e27c32c09d0a462a15503ab73f89788d603bd Reviewed-on: https://chromium-review.googlesource.com/1008169 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#550219}
-
Nico Weber authored
TBR=miu,kbr Bug: 831999,832011 Change-Id: I22bf82f84e0ae874811b1ba3cbac03d8b5f1d49e Reviewed-on: https://chromium-review.googlesource.com/1010382Reviewed-by:
-
Gustav Sennton authored
Add code to support the Support Library version of WebResourceRequest.isRedirect(). Also add a feature flag to guard that API. Bug: 831315 Change-Id: I528c02cfabdd1a83f66231ed7dd1b78b972b3843 Reviewed-on: https://chromium-review.googlesource.com/1005755 Commit-Queue: Gustav Sennton <gsennton@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#550217}
-
Francois Doray authored
Previously, tasks posted to a shared SingleThreadTaskRunner with the same traits were scheduled on the same thread. If single-threaded task A (BACKGROUND, CONTINUE_ON_SHUTDOWN) was scheduled on the thread and single-threaded task B (BACKGROUND, BLOCK_SHUTDOWN) was posted afterwards, shutdown could not complete until task A finished and allowed task B to run on the thread. This CL fixes the issue by scheduling shared single-threaded tasks that are CONTINUE_ON_SHUTDOWN/non-CONTINUE_ON_SHUTDOWN on different threads. Bug: 829786 Change-Id: Ia0b556971895c2a5799157f8dcf1a1ee6ce650c9 Reviewed-on: https://chromium-review.googlesource.com/1005422 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#550216}
-
Yash Malik authored
The gvr keyboard API requires that gvr_keyboard_advance_frame is called every time after the keyboard is initialized. This regressed in the optimization that doesn't call UiElement::OnBeginFrame for invisible elements. We add a special hook to do certain thing every frame. Bug: 831749 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I877299165dde517fab90451788de9680700666d9 Reviewed-on: https://chromium-review.googlesource.com/1009042 Commit-Queue: Yash Malik <ymalik@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#550215}
-
Krishna Govind authored
R=cmasso@chromium.org Change-Id: I92933136860899b7cdd3e8c3f209febd1c88d9df Reviewed-on: https://chromium-review.googlesource.com/1010471Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#550214}
-
Matt Falkenhagen authored
This makes more sense as SharedWorkerHost's destructor calls WorkerDestroyed to balance it out. It also simplifies the params to Start(). Not strictly needed for the linked bug. Refactoring that will make it easier to fix. Bug: 830288 Change-Id: I3be38ad7cc58c35bef301cd21074987ea9e5c64d Reviewed-on: https://chromium-review.googlesource.com/1004887 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#550213}
-
Alexey Kozyatinskiy authored
Nicer arrow is always better. R=pfeldman@chromium.org Bug: none Change-Id: I38f58ca5adbdaa55516bc215928e99ac0c1f1c2d Reviewed-on: https://chromium-review.googlesource.com/1008630Reviewed-by:
-
Jonathan Backer authored
On certain CrOS device, we --enable-native-gpu-memory-buffers. This causes the target for texture to become GL_TEXTURE_EXTERNAL_OES in a RasterDecoder::CreateTexture call. OnceCopyRasterProvider calls TexParameteri(...), which binds gpu::Texture and sets it immutable service side via a call to TextureManager::SetTarget(...). A subsequent call to BindTexImage2DCHROMIUM then fails on the IsImmutable check. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ibde88dd449a246573343ac435116e529ce4e88cf Reviewed-on: https://chromium-review.googlesource.com/1008130Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#550211}
-
Helen Li authored
This is a reland of 53553a99 Original change's description: > Add a net::TransportClientSocket class > > This CL adds a net::TransportClientSocket so that we can have an interface > to expose socket Bind() method. > > This CL changes the following: > - socket_test_util.cc > Changes MockClientSocket to subclass this new net::TransportClientSocket > class instead of net::SSLClientSocket. This new class hierarchy is more > intuitive because not all client sockets are ssl socket. > - client_socket_factory.cc > Makes CreateTransportClientSocket() returns a net::TransportClientSocket > instead of a StreamSocket. > - services/network/* > Makes network::SocketFactory take in a net::ClientSocketFactory. > - cast_socket.cc/h and cast_socket_unittest.cc. > > > Bug: 721401 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: Ie258114565e76529555e244364be421e66637960 > Reviewed-on: https://chromium-review.googlesource.com/995554 > Commit-Queue: Helen Li <xunjieli@chromium.org> > Reviewed-by: Derek Cheng <imcheng@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549731} TBR=imcheng@chromium.org Bug: 721401 Change-Id: I93fb736881be6554bdaf17359b881370be1d7fea Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1007034Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#550210}
-
Peter Boström authored
Rounded omnibox results apply to touchable and Material refresh. This is not in spec for refresh and touchable doesn't need to diverge here. Bug: chromium:826606 Change-Id: If9ea12ae3912b50fce92c9368452bf342b395e6c Reviewed-on: https://chromium-review.googlesource.com/1007898Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#550209}
-
Jun Choi authored
Currenly FakeFidoTask used in unit test for FidoRequestHandler categorizes response types depending on whether the response received from the mock device is base::nullopt, empty vector, or a non-empty vector. Change this categorization to use clearly readable enums instead. Bug: 827677 Change-Id: I6817808a6ace85e88bba48039c9cbe054cfbfb81 Reviewed-on: https://chromium-review.googlesource.com/1006233 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#550208}
-
Daniel Bratell authored
When building chrome_app_unittests chrome/common/crash_keys.cc are compiled both as a dependency and locally. Enough to compile it as a dependency. (Noticed in jumbo build experiments where the duplicate symbols met in the linker) Change-Id: I517436d21ae17c2ff664afeed43ad8e1b7e529e9 Reviewed-on: https://chromium-review.googlesource.com/1005341Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#550207}
-
chrome://inspectKen Rockot authored
Bug: 829412 Change-Id: Ia42efe7c749e0eaa44ea9c45a1a4be1a7d43580f Reviewed-on: https://chromium-review.googlesource.com/1007980 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
-
Ashley Enstad authored
Bug: 816458 Change-Id: Iba29c656f02789baa8d0f9153bfaabe0fc1121e8 Reviewed-on: https://chromium-review.googlesource.com/1005032 Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Reviewed-by:
-
Biao She authored
This CL also did the following three things: 1. refactored the code for checking if we should suppress 2D UI. 2. add kOsStoragePermission enum to represent suppress native storage UI request(currently only Android). 3. add kMediaRouterPresentationRequest enum to represent suppress media router presentation. Bug: 817148 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id8e0bdc961ffcbcd1f0bc7145be2998ca949602e Reviewed-on: https://chromium-review.googlesource.com/1005842 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#550204}
-
Emily Hanley authored
Bug: 779634 Change-Id: I613fed97d31045ed7d15bbe17e0d3153fd19812e Reviewed-on: https://chromium-review.googlesource.com/1002922 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#550203}
-
Bence Béky authored
WebSocketEndpointLockManager being a singleton is causing a number of issues, including test flakiness. This CL makes HttpNetworkSession create and own an WebSocketEndpointLockManager instance instead, as suggested in https://crbug.com/450518#c8. I have verified locally that the following test invokation fails on trunk but passes with this CL: out/gn/net_unittests --gtest_filter=\ HttpStreamFactoryTest.RequestWebSocketBasicHandshakeStreamOverSSL:\ WebSocketEndpointLockManagerTest.LockEndpointReturnsOkOnce This is like the one reported in https://crbug.com/814985, but using LockEndpointReturnsOkOnce instead of GetInstanceWorks, because GetInstanceWorks is removed in this CL. Bug: 450518 Change-Id: Ie882dd7584c8cd3917844e0583370e453e316964 Reviewed-on: https://chromium-review.googlesource.com/1009962Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#550202}
-
Yuqian Li authored
Bug: chromium:821353 Change-Id: I69a86f539e5e7d3b038fd085abfbba0826eb04bc Reviewed-on: https://chromium-review.googlesource.com/1008043Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Yuqian Li <liyuqian@chromium.org> Cr-Commit-Position: refs/heads/master@{#550201}
-
yiyix authored
In the current implementation, if the new RenderFrameMetadata is same as the initial value, then Browser will not receive the RenderFrameMetadata until it changes. After this patch, Browser will always receive the initial RenderFrameMetadata. Bug:830540 Change-Id: Ic0723d03aff1e4e7fa9eaabe80c27d5dd9bb31d0 Reviewed-on: https://chromium-review.googlesource.com/1006374Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
-
Katie D authored
This uses window.speechSynthesis, which should be using the TTS engine and voice prefs selected by the user. Bug: 823359 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2b8cd29a2b1fd1da2a5cb002aeb877ed2e615196 Reviewed-on: https://chromium-review.googlesource.com/996764 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#550199}
-
Andrew Grieve authored
Change-Id: If11054d64db33bef5f32561950604706d8a55b52 Reviewed-on: https://chromium-review.googlesource.com/1006043Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#550198}
-
jdoerrie authored
This change promotes the DCHECKs in base::Optional::value() to CHECKs in order to match std::optional more closely. Furthermore, it also CHECKs when dereferencing a base::Optional via operator* or operator->. Bug: 817982 Change-Id: Ib2bfdd3a863e8bade21fa1b6b1c10c7c4d2ca135 Reviewed-on: https://chromium-review.googlesource.com/997335 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
