- 26 Jan, 2018 40 commits
-
-
Jay Civelli authored
Moving the manifest parsing and extension validation from the Unpacker class to SandboxedUnpacker. As a result, all the extension unpacking is done from the browser process and the Unpacker class is removed. The 2 remaining methods in unpacker.cc still used for unzipping the extension have been moved to utility_handler.cc and the associated tests renamed from unpacker_unittest.cc to utility_handler_unittest.cc. The unzipping will also eventually be moved to the browser process at which point utility_handler files will be removed as well. Tbr: rockot@chromium.org Bug: 800540 Change-Id: Ib286fa88edc96e4c186aba6e2ee1d9c2317efe84 Reviewed-on: https://chromium-review.googlesource.com/883967Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#532064}
-
Ovidio Henriquez authored
This change migrates the server/getPrimaryService(s) tests to wpt/. BUG=509038 Change-Id: I9f3adb19f0b6edec2ba45eec7e331b75b3aae57c Reviewed-on: https://chromium-review.googlesource.com/834201Reviewed-by:
Conley Owens <cco3@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#532063}
-
Yoland Yan authored
Add +aluo to related third_party repo and WebView sub directory as OWNER Change-Id: Ieae996d2725893adf593e40c3f4950bd3e3e2d24 Reviewed-on: https://chromium-review.googlesource.com/887824Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yoland Yan <yolandyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#532062}
-
Tom Sepez authored
There aren't any lifetime issues as far as I can tell, but the code will be a lot safer given move-only semantics. Remove always-empty fds_to_close_post_fork array usage. Change-Id: I20638a01c30193275212c72f056b8da613c7072e Reviewed-on: https://chromium-review.googlesource.com/887356 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#532061}
-
Ovidio Henriquez authored
This change updates a couple of characteristic same object tests to use the new test API. This will allow the tests to be migrated into the wpt/ directory. BUG=509038 Change-Id: I483a623c8f58848fb0a7e3cea7cb65b27c79eccc Reviewed-on: https://chromium-review.googlesource.com/823072 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
-
Robert Ogden authored
M65 changed some of the clicking/playing behavior so update the test to use a backward-compatible fix. Bug: 799585 Change-Id: If13867d2a56d0de8b374505f8c780385143f9aa2 Reviewed-on: https://chromium-review.googlesource.com/887425 Commit-Queue: Robert Ogden <robertogden@google.com> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#532059}
-
Yuwei Huang authored
* Make text on host setup instruction view darker so that the contrast ratio is higher than 4.5:1. * Use Google Blue palette for the settings menu. Make primary text bold. Bug: 806091 Change-Id: I7c6b02d502a24261e022eca329eb6766007563ea Reviewed-on: https://chromium-review.googlesource.com/887720Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#532058}
-
Xianzhu Wang authored
For SPv175 (but not SPv2) a chunk may have paint properties escaping its containing composited layer. A layer may have no painting changed but needs raster invalidation for changed paint properties (caused by ancestors) of such chunks. An example is a fixed-positioned object under a composited layer other than the LayoutView. When the viewport scrolls, nothing will change in in paint artifacts, but the fixed-positioned object's paint chunk will change its chunk_to_layer_transform thus needs raster invalidation. Bug: 805049 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I72c672657215aa4543783eed9cb2362411939a01 Reviewed-on: https://chromium-review.googlesource.com/885092Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#532057}
-
Tarun Bansal authored
Bug: 806068 Change-Id: I013b1396f3c56edb5b7dd349d9ad31616b1a5803 Reviewed-on: https://chromium-review.googlesource.com/887780Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#532056}
-
Jian Li authored
OfflinePageRequestJob does not derive from URLRequestFileJob any more. Instead, the file reading logic in URLRequestFileJob is integrated into OfflinePageRequestJob such that the file can be opened and held for both validation and reading. Bug: 758690 Change-Id: Id33533316b79a919a365991aa0173bc8c71b5e4f Reviewed-on: https://chromium-review.googlesource.com/865757Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#532055}
-
Xida Chen authored
TBR=junov@chromium.org Bug: None Change-Id: Ib34c35f73778b71cea041b81dcf94ca413f0e13a Reviewed-on: https://chromium-review.googlesource.com/887962Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#532054}
-
Qiang Xu authored
Disabling as this test is failing on linux-chromeos-rel builder. See: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/4627 TBR=yamaguchi@chromium.org TBR=yoshiki@chromium.org Bug: 804413 Change-Id: I9591ee8652fc7965b1261a8cf2f1666b6ae7d3ea Reviewed-on: https://chromium-review.googlesource.com/887618Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Qiang(Joe) Xu <warx@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#532053}
-
Jiaquan He authored
This commit fixes a regression of crrev.com/c/874526. Bug: 804517 Change-Id: Ib1150d51a35251bb9fcaa9853b41db55a50633f1 Reviewed-on: https://chromium-review.googlesource.com/887825Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#532052}
-
Christian Biesinger authored
UKM review: https://docs.google.com/document/d/1Cpe5kLi3tVshH3evoJVUVDjOw7le-f8jFwBjEk2uadY/edit Bug: 783383 Change-Id: Ib684e9e07322e27633b33576c688fa699fada81e Reviewed-on: https://chromium-review.googlesource.com/812154Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Evan Stade authored
For the changes to FileManagerBrowserTestBase, you can run affected tests with --gtest_filter=DriveSpecific* This is identical to 2a3c7c84 but should work now after the fix which landed as 7a379f73 Bug: 783018 Change-Id: Ie77f44e2e7a5af15e24e630c412bebe5788cb5a0 Reviewed-on: https://chromium-review.googlesource.com/881681Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#532050}
-
Albert Chaulk authored
Currently there is an implicit assumption that certain dbus files are built if is_linux=true which causes link errors if they aren't. This changes the ifdef condition to also build stubs in this case. Bug: b/72507234 Test: Local build Change-Id: Ie1857a0400eb2bfbd4420a1c2402fa2d95089b8e Reviewed-on: https://chromium-review.googlesource.com/871259Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#532049}
-
Steve Kobes authored
TESTED=RenderViewImplTest.PreferredSizeZoomed passes with RLS Bug: 785088 Change-Id: Ibce3e168a7b777b7ee4a51593177d6cbc162ec87 Reviewed-on: https://chromium-review.googlesource.com/886837Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#532048}
-
Peng Huang authored
Bug: 805437,802379 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I574359746c207e0e1078758d1908f0c98450333c Reviewed-on: https://chromium-review.googlesource.com/886832Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#532047}
-
Michael Thiessen authored
Wait until we get the actual WebContents size before we resize the Webcontents/surfaces to avoid an extra unnecessary resize when entering VR. Change-Id: Ice3c74830ce8c395b3909b719e3c5956facbba77 Reviewed-on: https://chromium-review.googlesource.com/887266Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#532046}
-
Yuwei Huang authored
By default WebRTC will try to use all networks available to establish a connection to the host. Sometimes cellular network will be use even when WiFi network is available. Generally app will never use cellular network if WiFi is available. This CL enables the PORTALLOCATOR_DISABLE_COSTLY_NETWORKS flag on the port allocator, which removes costly network when a less costly network exists. Bug: 488760 Change-Id: I2eec64807c246dc11b1022f75eb3e9bf16935946 Reviewed-on: https://chromium-review.googlesource.com/862844Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#532045}
-
Sidney San Martín authored
Change-Id: I00799bf180fc94b3a8b30e0a77bdc7473cf58ca4 Bug: 589943 Reviewed-on: https://chromium-review.googlesource.com/887385Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#532044}
-
Adithya Srinivasan authored
This reverts commit e76e0e99. Reason for revert: I suspect it caused recent Windows MSVC build failures (https://luci-milo.appspot.com/buildbot/chromium.win/WinMSVC64%20%28dbg%29/2260. The problematic file is chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc. Original change's description: > Add timestamp to requests for experimental contextual suggestions. > > The experimental contextual suggestions service provides 0-suggest > autocomplete suggestions based on the URL that is visited in the active > tab, at the time the address bar is focused. This CL adds to the request > a timestamp corresponding to the time the user started navigating the > URL for which the suggestions are requested. > > This change is a requirement for the process of enabling server-side > logging of the contextual suggestions that are sent to Chrome clients. > If logged, contextual suggestions are to be removed as soon as a > synced user removes from their history the page that was visited at the > time the suggestions were displayed. The timestamp is necessary for > matching suggestions with the corresponding navigation. > > TBR=rohitrao > for mechanical changes to ios/c/b/a/* > > Bug: 692471 > Change-Id: I6939d108cfab91b69640acdbb3b8307687999320 > Reviewed-on: https://chromium-review.googlesource.com/879167 > Commit-Queue: Gheorghe Comanici <gcomanici@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531999} TBR=rohitrao@chromium.org,mpearson@chromium.org,jdonnelly@chromium.org,gcomanici@chromium.org Change-Id: Ie588cd5849a59c845b51c9ca334b32bef4a61037 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 692471 Reviewed-on: https://chromium-review.googlesource.com/889142Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#532043}
-
Marijn Kruisselbrink authored
Bug: 604800, 769024, 740744 Change-Id: I2267b1015e3c9ad0d3dfe019572ff328557e0112 Reviewed-on: https://chromium-review.googlesource.com/882483Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#532042}
-
Steve Anton authored
https://webrtc-review.googlesource.com/c/src/+/41042 will change an error message in CreateAnswer which would break this WPT. Once the WebRTC CL has rolled in the test expectation will be updated and the test re-enabled. Bug: 806005 Change-Id: I53855be0dcc23bb76a6a6087761198beb82262dc Reviewed-on: https://chromium-review.googlesource.com/887371Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#532041}
-
Réda Housni Alaoui authored
Fixes for reland number 6: - "Win10 Tester" capture_unittests failure - "Win8 Tester" capture_unittests failure Fixes for reland number 5: - "Win10 Tester" browser_tests_functional failure - "Win8 Tester" browser_tests_functional failure Fixes for reland number 4: - "Win10 Tester" browser_tests_functional failure - "Win8 Tester" browser_tests_functional failure - "Win8 Tester" capture_unittests failure Fixes for reland number 3: - "Win10 Tester" browser_tests_functional failure - "Win10 Tester" capture_unittests failure - "Win8 Tester" browser_tests_functional failure - "Win8 Tester" capture_unittests failure Fixes for reland number 2: - "Win10 Tester" browser_tests_functional failure - "Win10 Tester" capture_unittests failure - "Win8 Tester" browser_tests_functional failure - "Win8 Tester" capture_unittests failure Fixes for reland number 1: - "Win8 Tester" browser_tests_functional failure - "Win8 Tester" capture_unittests failure Original description: - Full rewrite of the MediaFoundation implementation video part to use IMFCaptureEngine - Implementation of takePhoto, setPhotoOptions and getPhotoCapabilities - takePhoto triggers a still image capture with the highest available resolution without stopping the video stream thanks to IMFCaptureEngine TEST=adapted video_capture_device_unittest.cc and webrtc_image_capture_browsertest.cc; launch Chrome with --force-mediafoundation on Win8+ and capture video using e.g. https://webrtc.github.io/samples/src/content/getusermedia/gum/ R=mcasas@chromium.org Bug: 730068 Change-Id: I7b7ff88f2db8d71f46428a2ecbb733e18a25a334 Reviewed-on: https://chromium-review.googlesource.com/734042 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Original-Original-Original-Original-Original-Commit-Position: refs/heads/master@{#521435} Reviewed-on: https://chromium-review.googlesource.com/810766 Cr-Original-Original-Original-Original-Commit-Position: refs/heads/master@{#524417} Reviewed-on: https://chromium-review.googlesource.com/843974 Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#527139} Reviewed-on: https://chromium-review.googlesource.com/852455 Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#528005} Reviewed-on: https://chromium-review.googlesource.com/858138 Cr-Original-Commit-Position: refs/heads/master@{#531109} Reviewed-on: https://chromium-review.googlesource.com/885815 Cr-Commit-Position: refs/heads/master@{#532040}
-
Miriam Gershenson authored
The async resolver has some Android-version-specific problems. This will allow enabling it via Finch for newer Android before the problems with older Android are worked out. Bug: 768874, 805020 Change-Id: Iec9aeaa255dbb110103ae7ca7ffe8b19dbded235 Reviewed-on: https://chromium-review.googlesource.com/887601Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#532039}
-
Zhongyi Shi authored
No Flag update. Some changes to quic_connection_test, including: 1) fix stream offset to make it increases monotonically. 2) Refactor out SendRstStream. Merge internal change: 182410984 https://chromium-review.googlesource.com/c/chromium/src/+/879753/ relnote: Stores SpdyHeaderBlocks directly in QuicClientPromisedInfo, rather than holding them via unique_ptr. No functional change. Merge internal change: 182114281 https://chromium-review.googlesource.com/c/chromium/src/+/879841/ relnote: Add two new QUIC connection options to experiment with different max ack delay behaviors, one that ignores ack delay and one that sets the default to 25ms instead of 0ms. Protected by quic_reloadable_flag_quic_max_ack_delay. Merge internal change: 182103603 https://chromium-review.googlesource.com/c/chromium/src/+/879435 Change-Id: If84cf1ae1eb3609380e95a24aefd9d87b555f40e Reviewed-on: https://chromium-review.googlesource.com/883778 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#532038}
-
Brian White authored
Bug: 806050 Change-Id: Id1606fa8739937ff0dcdaec36f3a532a8a18155c Reviewed-on: https://chromium-review.googlesource.com/887641Reviewed-by:
-
Marijn Kruisselbrink authored
BlobEntryRegistry will DCHECK when presented with invalid blob URLs, so both make sure the renderer doesn't send such URLs, and kill the renderer if it does happen to do so. Bug: 756743 Change-Id: Ife653cc4d8687fc30c8a03336caa66905951556b Reviewed-on: https://chromium-review.googlesource.com/884522Reviewed-by:
-
Fady Samuel authored
This CL introduces the notion of a default lower bound deadline. Prior to this CL, if any SurfaceLayer specified a deadline lower than the default deadline then the whole CompositorFrame would get a deadline of that SurfaceLayer which could break synchronization expectations of other SurfaceLayers. Instead, now base::nullopt for the deadline parameter of SetPrimarySurfaceId indicates to use the default deadline as specified by the Viz service. The deadline of a CompositorFrame is effectively the max of all the deadlines of the SurfaceLayer without the non-specified deadline indicating use the default. Thus, if any SurfaceLayer has a lower deadline, that deadline will not be used unless it is the only activation dependency in the next produced CompositorFrame. If the CompositorFrame contains other changing surfaces, then the maximum of the deadlines (including default if base::nullopt) will be used. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Iad6dd5a4d797705fcf02b9f02e45ee0994a6ee15 Bug: 672962 Reviewed-on: https://chromium-review.googlesource.com/884261 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#532035}
-
WC Leung authored
The captioned test is now fixed, so we enable the test again. This is a revert of https://chromium-review.googlesource.com/827006. Bug: 794821 Change-Id: Icabf8e2fed02d0b2c3220af7e1a1001afbaadbfd Reviewed-on: https://chromium-review.googlesource.com/883821Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#532034}
-
Tommy C. Li authored
This CL enables showing the elided permanent URLs when the flag is on. It also restores the full URL on focus and puts back the elided one on blur (assuming it hasn't been edited). No selection adjustment logic exists in this CL. Bug: 797354 Change-Id: I1fc6a8aa37aaf4582db2b6895a1292006da3114b Reviewed-on: https://chromium-review.googlesource.com/882617 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#532033}
-
Chris Nardi authored
CSS Color 4 states that all numbers should be parsed inside of the RGB and RGBA functions, instead of only integers as previously defined. This change updates our behavior to match this, with non-integers rounded to the nearest value. This additionally changes the behavior of percentage values, multiplying by 255 and rounding to match the spec instead of multiplying by 256 and flooring. The new spec is located at https://drafts.csswg.org/css-color-4/#rgb-functions. Bug: 703898 Change-Id: I826e92e7f81576240ad9b06f866df3300140b12c Reviewed-on: https://chromium-review.googlesource.com/885004Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#532032}
-
Chris Harrelson authored
Bug: 798378 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic3c0b29430b06e76a3c81e654bc780e4a969592d Reviewed-on: https://chromium-review.googlesource.com/880403 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#532031}
-
Mike Wasserman authored
This refines my earlier work done in: http://crrev.com/c/842467 Move event target nulling and root location use to WindowTreeClient, to ensure events reach MusUnifiedEventTargeter. Otherwise, WindowEventDispatcher::GetInitialEventTarget will use the touch gesture recognizer's target (returned by GetPriorityTargetInRootWindow) before performing the mirror display transformation on the event's location. Inline DispatchEventToTarget for additional clarity. Bug: 805714 Test: Mus touch events work in Chrome OS's unified desktop mode. Change-Id: Ic4844c85cc24a9f9885e7705ff27cb57b305d245 Reviewed-on: https://chromium-review.googlesource.com/887250 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#532030}
-
Sammie Quon authored
Sometimes windows can be very long or very tall outside of overview mode. These windows will either become super wide or super skinny after entering overvie wmode. This is not ideal as too wide -> takes up too much space and too skinny -> users cannot see the title. Clamps the width to be within 0.5 and 2 times the height. Windows will still keep their aspect ratio, so the resulting window is centered in the window selector item. https://screenshot.googleplex.com/dSfEciJ5CPd The above screenshot shows the effect of this CL (minus the blue and red borders which help visualize). The extreme windows will look they are floating since the backdrop is not implemented yet. But this cl is all behind a switch. Test: ash_unittests WindowSelectorTest.ExtremeWindowBounds Bug: 782320 Change-Id: Id337eb091fcc4f1297ae8f864175c7f06b10b71c Reviewed-on: https://chromium-review.googlesource.com/869051 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#532029}
-
Alexei Filippov authored
Do not create Sample object ahead. Moved all the hooks into the SamplingNativeHeapProfiler class to improve code readability. BUG=803276 Change-Id: I88a920c338d19fc89689c3f797d2c002a3d976cb Reviewed-on: https://chromium-review.googlesource.com/879595 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#532028}
-
Ilya Sherman authored
When the safe seed and the latest seed have identical contents, use a sentinel value to avoid storing a duplicate value for the two seeds. This is purely a storage space optimization; no difference in observed functionality is expected. R=asvitkine@chromium.org Bug: 727984 Change-Id: Ica641a479228b0cdfcc4af2ec04ddfc54c36c5eb Reviewed-on: https://chromium-review.googlesource.com/880482 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Wenzhao Zang authored
The criteria of opening wallpaper picker should be consistent between the settings page [1] and the shelf context menu [2]. Another pending CL [3] will combine these two places to avoid duplicate logic. The criteria of whether to show the 'shelf position' option remains unchanged and it should be separate from the logic of wallpaper picker. [1] https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/settings/appearance_handler.cc?q=appearance_handler&sq=package:chromium&dr=C&l=76 [2] https://cs.chromium.org/chromium/src/chrome/browser/chromeos/background/ash_wallpaper_delegate.cc?dr=C&q=ash_wallpaper&sq=package:chromium&l=73 [3] https://chromium-review.googlesource.com/c/chromium/src/+/848193 Bug: 806051 Change-Id: I99da5e9bfef4dc02a2cdc53b33862d6310d88e14 Reviewed-on: https://chromium-review.googlesource.com/887251 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
-
Elliot Glaysher authored
This resolves the problem where the hardware cursor is shown in one window when unified mode is turned on. We might not have an active pref service yet, so move the checks that don't depend on preferences before checking the pref service. Bug: 805719 Change-Id: I92c1ea1a47a0cd63f695fc792e1fe025ee715962 Reviewed-on: https://chromium-review.googlesource.com/887288 Commit-Queue: Elliot Glaysher <erg@chromium.org> Reviewed-by:
-
