GitLab

Speculative rollout of r170564 to see if unit_tests and content_unittests start working again.

TBR=haraken
BUG=340522

Review URL: https://codereview.chromium.org/219243014

git-svn-id: svn://svn.chromium.org/blink/trunk@170602 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The pad-gesture-fling layout tests assumes the fling curve will generate a
minimum number of events.  This may not always hold, depending on the
fling curve parameters, the fling curve update frequency and whether the main
thread is slow.  Instead, impose a maximum limit on the number of fling updates
it takes to reach the minimum offset target, and use preventDefault() on the
mousewheel event to prevent the fling from terminating early.

Review URL: https://codereview.chromium.org/219243010

git-svn-id: svn://svn.chromium.org/blink/trunk@170597 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=353309

Review URL: https://codereview.chromium.org/209413002

git-svn-id: svn://svn.chromium.org/blink/trunk@170596 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/221253002

git-svn-id: svn://svn.chromium.org/blink/trunk@170595 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=170448

TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/219963010

git-svn-id: svn://svn.chromium.org/blink/trunk@170593 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move HTMLCollection's id / name cache to a new class. HTML's collection
m_hasValidIdNameCache, m_idCache and m_nameCache members were replaced by a
single OwnPtr that holds an instance of NamedItemCache when populated.

Most HTMLCollections do not have a valid namedItemCache so we end up saving
some memory. This also makes the code a bit clearer.

This patch is based on the following WebKit revision by rniwa@webkit.org:
http://trac.webkit.org/changeset/164772

R=

Review URL: https://codereview.chromium.org/215073003

git-svn-id: svn://svn.chromium.org/blink/trunk@170592 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The code to generate an invalidation for StyleDifferenceRepaint and outline
decrease in RenderLayerModelObject::styleWillChange is duplicated with the
one in RenderObject::styleWillChange. This meant that we would generate 2
identical invalidations for each repaint-cue or outline decrease.

Review URL: https://codereview.chromium.org/217973002

git-svn-id: svn://svn.chromium.org/blink/trunk@170591 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes shape-padding support, since it can be used only with shape-inside. Shape-inside support has been removed in r170260.

BUG=356778

Review URL: https://codereview.chromium.org/216793009

git-svn-id: svn://svn.chromium.org/blink/trunk@170590 bbb929c8-8fbe-4397-9dbb-9b2b20218538

previousRegionLogicalHeight() was not getting updated in RenderFlowThread::validateRegions() and 
previousRegionLogicalWidth() was updated but not used.

Review URL: https://codereview.chromium.org/147653002

git-svn-id: svn://svn.chromium.org/blink/trunk@170589 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=327641

Review URL: https://codereview.chromium.org/212103004

git-svn-id: svn://svn.chromium.org/blink/trunk@170587 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=aandrey, pfeldman

Review URL: https://codereview.chromium.org/213423010

git-svn-id: svn://svn.chromium.org/blink/trunk@170585 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=acolwell@chromium.org
BUG=353373

Review URL: https://codereview.chromium.org/220183002

git-svn-id: svn://svn.chromium.org/blink/trunk@170583 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=358679

Review URL: https://codereview.chromium.org/221093002

git-svn-id: svn://svn.chromium.org/blink/trunk@170582 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also, highlight record on hover.

BUG=

Review URL: https://codereview.chromium.org/213673005

git-svn-id: svn://svn.chromium.org/blink/trunk@170581 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It's time to expose only ShadowRoot constructor.
The chromium side patch is here: https://codereview.chromium.org/217013005/.

BUG=242153

Review URL: https://codereview.chromium.org/216123005

git-svn-id: svn://svn.chromium.org/blink/trunk@170580 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=sergeyv@chromium.org

Review URL: https://codereview.chromium.org/220903002

git-svn-id: svn://svn.chromium.org/blink/trunk@170579 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes live location from header stylesheet on dispose
action.

Review URL: https://codereview.chromium.org/217423015

git-svn-id: svn://svn.chromium.org/blink/trunk@170578 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=358534
R=apavlov@chromium.org

Review URL: https://codereview.chromium.org/221033003

git-svn-id: svn://svn.chromium.org/blink/trunk@170577 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As r170438, WebViewImpl has owned m_m_speechInputClient member variable. However, it is also only used for
passing a pointer of SpeechInputClient. It is useless. To remove it, we need to change parameter
type to OwnPtr|PassOwnPtr in SpeechInput class. Besides OwnPtr|PassOwnPtr help to manage the client pointer more safely.

BUG=N/A

Review URL: https://codereview.chromium.org/219273002

git-svn-id: svn://svn.chromium.org/blink/trunk@170576 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch hides autocomplete suggestion box in editor whenever
autocopmletion prefix length is zero.

BUG=358255

Review URL: https://codereview.chromium.org/219773004

git-svn-id: svn://svn.chromium.org/blink/trunk@170573 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change adds the APIs specified in the feature proposal found here:
http://wiki.whatwg.org/wiki/Canvas_Context_Loss_and_Restoration
The API changes are hidden behind the experimental canvas features flag.

This change does not implement any elective canvas evictions. Those will
be added in a future change. Only pre-existing context loss use cases
are handled, such as failure to allocate a backing store, and gpu
failures.

The strategy for recovering from a GPU context lost was modified
substantially in order to accomodate synchronization issues with the
context restored event. Context restoration is now attempted proactively
through a scheduled event. Prior to this change, restoration happened
lazily when trying to use the canvas.

BUG=322335
R=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/211503006

git-svn-id: svn://svn.chromium.org/blink/trunk@170572 bbb929c8-8fbe-4397-9dbb-9b2b20218538

more standards compliance work: Track.stop should not any more stop the
source until all tracks using the same source is stopped.

BUG=357503

Review URL: https://codereview.chromium.org/219453002

git-svn-id: svn://svn.chromium.org/blink/trunk@170571 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=haraken@chromium.org, zerny@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/220233007

git-svn-id: svn://svn.chromium.org/blink/trunk@170569 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We're incrementally replacing RefPtr<DOMWrapperWorld> with RefPtr<NewScriptState>. See the bug description for more details.

BUG=357144

Review URL: https://codereview.chromium.org/218493013

git-svn-id: svn://svn.chromium.org/blink/trunk@170567 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Do not skip method invocations inside requestAnimationFrame
when it has entered a new batch sequence. Otherwise the scheduled
method invocations get lost.

Review URL: https://codereview.chromium.org/213833016

git-svn-id: svn://svn.chromium.org/blink/trunk@170566 bbb929c8-8fbe-4397-9dbb-9b2b20218538

StorageQuotaClient can be null in some contexts.


BUG=346577
TEST=run the failed test locally (see the issue)

Review URL: https://codereview.chromium.org/212123005

git-svn-id: svn://svn.chromium.org/blink/trunk@170565 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After r170314, the HTML parser thread allocates on-heap objects such as CSSValues. So this CL supports the HTML parser thread in oilpan. Also this CL marks the CSSValue hierarchy with ThreadAffinity=AnyThread because CSSValue can be allocated by both main thread and parser threads.

BUG=340522

Review URL: https://codereview.chromium.org/216203006

git-svn-id: svn://svn.chromium.org/blink/trunk@170564 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/aLpDg8pviU0/dUbUt7jsvT4J

javascriptURL-execution-context-frame-location-htmldom.html was
identical to javascriptURL-execution-context-frame-src-htmldom.html
apart from the attribute set, so remove it.

javascriptURL-execution-context-frame-location-htmldom-uncaught.html
tests code that was removed in V8HTMLFrameElementCustom.cpp and does not
have a counterpart for the src attribute, so remove it too.

BUG=358505

Review URL: https://codereview.chromium.org/220563002

git-svn-id: svn://svn.chromium.org/blink/trunk@170563 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=eustas, lushnikov, pfeldman
BUG=358098
NOTRY=true

Review URL: https://codereview.chromium.org/220763004

git-svn-id: svn://svn.chromium.org/blink/trunk@170562 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There have been discussions about removing foreignObject and instead
allow an html element with position and dimensions inside svg. Knowing
how popular foreignObject is may be useful in such discussions.

Review URL: https://codereview.chromium.org/220713003

git-svn-id: svn://svn.chromium.org/blink/trunk@170561 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These calls were for non-Chromium port of WebKit to get/set cookies on
WebSocket opening handshake. In Blink, they're no longer necessary.
Chromium intercepts handshakes in the browser process and add/remove
cookies. Any cookie header added by Blink is ignored. Set-cookies are
stripped before forwarded to Blink.

BUG=none

Review URL: https://codereview.chromium.org/209823002

git-svn-id: svn://svn.chromium.org/blink/trunk@170560 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=vsevik@chromium.org, vsevik
BUG=357614

Review URL: https://codereview.chromium.org/216183003

git-svn-id: svn://svn.chromium.org/blink/trunk@170559 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357520

Review URL: https://codereview.chromium.org/219333007

git-svn-id: svn://svn.chromium.org/blink/trunk@170558 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds a Ctrl-D shortcut to the devtools editor which selects
the next occurrence of word or selection. Implementation is based
on CodeMirror v4 multiple cursor capabilities.

BUG=356878

Review URL: https://codereview.chromium.org/219583002

git-svn-id: svn://svn.chromium.org/blink/trunk@170557 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=haraken@chromium.org, oilpan-reviews@chromium.org, wibling@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/220763005

git-svn-id: svn://svn.chromium.org/blink/trunk@170556 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch allows the validator checks to handle types declared as
/** @constructor */ var MyType = function() {}

R=pfeldman, sergeyv

Review URL: https://codereview.chromium.org/218993012

git-svn-id: svn://svn.chromium.org/blink/trunk@170555 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=341815

Review URL: https://codereview.chromium.org/220893002

git-svn-id: svn://svn.chromium.org/blink/trunk@170554 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make ImageFrame store an SkBitmap directly instead of indirectly via
NativeImageSkia.
The direct effect is less indirections in ImageFrame, but this allows
making NativeImageSkia more immutable-looking since the SkBitmap&
accessor and setDataComplete() method can be removed.

Review URL: https://codereview.chromium.org/170463002

git-svn-id: svn://svn.chromium.org/blink/trunk@170553 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This shorthand sets the values for the grid-template-columns, 
grid-template-rows and grid-template-areas, so the 
implementation tries to reuse as much available parsing 
functions as possible.

The "parsingGridTrackList" was refactored to return a 
CSSValue and let the "parseValue" function to assign the 
property value. The "forwardSlash" operator is now valid 
when the track-list clause is part of a shorthand. The  
"parseValue" function checkouts that only additional 
clauses are allowed when processing shorthands; the 
grid-columns-rows-get-set.html tests was modified to verify 
this.

The "parseGridTemplateAreas" was refactored too, in order 
to process single areas's rows. This is very useful for the 
gris-template secondary syntax, which mixes areas and rows 
values.


Finally, the "parseGirdLineNames" function was modified as 
well by defining an new argument to concatenate head/tail 
custom-ident elements and ensure the identList is at the 
heading index, since it's now possible the parseList was 
rewound.

The implementation of the grid-template shorthand tries 
first to match the <grid-template-columns> / <grid-template-rows> 
syntax, failing back to the secondary syntax if needed. 
This approach requires to rewind the parseList but it 
produces a clearer code.
 
TEST=fast/css-grid-layout/grid-template-shorthand-get-set.html

BUG=79180

Review URL: https://codereview.chromium.org/149373004

git-svn-id: svn://svn.chromium.org/blink/trunk@170552 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This matches Firefox's behavior (see [1]). Hooray for interoperation!

Intent to Ship thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/rCiwMvGG8IY/MgRtHrkQfgMJ

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=979580

Review URL: https://codereview.chromium.org/220343005

git-svn-id: svn://svn.chromium.org/blink/trunk@170551 bbb929c8-8fbe-4397-9dbb-9b2b20218538