- 29 Jun, 2020 40 commits
-
-
Mustafa Emre Acer authored
This CL displays the lookalike interstitial for remaining IDN spoof check results with a few exceptions, as described in the comments. Bug: 1095120 Change-Id: I13c2fb2517b8c5104ef7902b15d11c9531b2c672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271166 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#783728}
-
Taylor Bergquist authored
This is also partial progress towards https://crbug.com/1093972 Bug: 1096645 Change-Id: I78cc212f224bdc6d7ba6bd2bd180e779e8d62ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261874Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#783727}
-
Daniel Cheng authored
Bug: 1099945 Change-Id: If0e381bbaf57687b37b89796d76ddaeb2771a74d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271257 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#783726}
-
Dale Curtis authored
TBR=nasko Bug: 1055282 Change-Id: I1cd244fe06d6494f1ca7282ad05e37f7d0322e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273622Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#783725}
-
Scott Little authored
These histograms seem to have been removed from the code, and the latest milestone that I can find any data for them is M60, so I'm marking them as obsolete. Fixed: 1089123 Change-Id: I15d1e6c9442f00e2a081ef89f938d5878051d568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268201 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#783724}
-
arthursonzogni authored
There have been temporarily removed by: https://chromium-review.googlesource.com/c/chromium/src/+/2217553 One possible caused for this being reached was solved in: https://chromium-review.googlesource.com/c/chromium/src/+/2216255 Now, after M85 branch cut, I would like to add the checks back. This will confirm whether it exists other issues or not. Bug: chromium:1041376 Change-Id: I4d4e8c0575881aa0fbaba9a4eeacd4bd4119d8f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270080 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Ella Ge authored
Bug: 1007635 Change-Id: I4103199e0d39efc49202cc620dd0538c1bba5239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272869Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#783722}
-
Scott Little authored
It looks like the OfflineIndicator.CTR histogram is still in use, so this CL extends the expiry of this histogram. Fixed: 1016415 Change-Id: I09cc1d39f36a55fc7caa2607671286f036662ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268197Reviewed-by:
-
Jonathan Ross authored
FrameTokenMessageQueue was used as a way to diagnose incorrect frame submission ordering bug within the Renderer and Viz. The root cause behind that (crbug.com/1051625) was fixed. We never got around to removing the DumpWithoutCrashing. These have popped back up as side-effects of other crashes, but were not needed to identify nor debug those. There is also a race condition which can lead to this being a false signal. Where FrameTokenMessageQueue::Reset can be called before Viz has submitted an ACK. A proper fix for this would be to change from raw ints, to an expansion of LocalSurfaceId. So that the source of the frame can be attributed. However that's a larger effort. Instead this change removes some of the previous debugging, as it is no longer needed. While also updating the check in DidProcessFrame to only be ran when the are queued items, and it isn't the ack from the Reset. This should hopefully reduce the noise. TEST=FrameTokenMessageQueueTest Bug: 1058439 Change-Id: I6854b1e5e71cdc77c72f898adc81541047592c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270837 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#783720}
-
Alan Cutter authored
This CL makes it more clear than Windows 10 SDK version 10.0.19041.0 is needed generally. Bug: 1089996 Change-Id: Ifbb1ecb5abf5d494123a2b773dea4dafc8d61d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265896 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#783719}
-
Scott Little authored
This CL extends the expiry of several OfflinePages.Background.* histograms that are still in use: OfflinePages.Background.FinalSavePageResult.* OfflinePages.Background.ImmediateStart.AvailableRequestCount OfflinePages.Background.ImmediateStart.AvailableRequestCount.Svelte OfflinePages.Background.ImmediateStartStatus OfflinePages.Background.ImmediateStart.UnavailableRequestCount OfflinePages.Background.ImmediateStart.UnavailableRequestCount.Svelte OfflinePages.Background.LoadingErrorStatusCode.* OfflinePages.Background.OffliningPreviewStatus.* OfflinePages.Background.RequestFailure.StartedAttemptCount OfflinePages.Background.RequestSuccess.StartedAttemptCount OfflinePages.Background.SavePageFromCCT.* OfflinePages.Background.ScheduledStart.AvailableRequestCount OfflinePages.Background.ScheduledStart.AvailableRequestCount.Svelte OfflinePages.Background.ScheduledStart.UnavailableRequestCount OfflinePages.Background.ScheduledStart.UnavailableRequestCount.Svelte Fixed: 1089126, 1089127, 975098, 1089128, 984298, 1089129, 1089131, 975907, 975982, 1089132, 984243, 975894 Change-Id: I7ebe829b304b31ee8df044e67ee9f4d4b73e835b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268273 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8eb3c3c47410d0424481d2140e8b4ffa6b3b902d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274660Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783717}
-
evliu authored
This CL removes the unnecessary BindToCurrentLoop from the EnableSpeechRecognition callback. Bug: 1099651 Change-Id: Ic2d497c17c255726acfd8b2657933027966a0f9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270350 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
-
Scott Little authored
The histogram OfflinePages.Wakeup.NetworkAvailable seems to have been removed from the code a while ago, and the latest milestone I can find data for is M77. This CL marks this histogram as obsolete. Fixed: 1089165 Change-Id: I063dd2ac16fa0a55b57e84f01ef56bb9036f5ef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269501 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
Andrew Xu authored
When SetTranslucentBackground() is called, hotseat background may have the running bounds animation. Then it is not meaningful to compare |background_bounds|, the parameter of SetTranslucentBackground(), with the layer's current bounds. The layer's target bounds should be compared with instead. In this particular bug, AppWindow::Init() adds the app icon to shelf via AppWindowRegistry::AddAppWindow() then may remove the app icon from shelf through AppWindow::Hide(). Due to the problem showed above, when the shelf item is removed, the hotseat bounds animation triggered by shelf item addition is still running so the hotseat background's bounds do not update yet. As a result, the target bounds for shelf item removal are identical with the current layer bounds. So it fails to update bounds. Bug: 1097645 Change-Id: I4046792060797faedb9f358ba3e4706338e5b7f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274144Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#783714}
-
Leonard Grey authored
Bug: 1095050 Change-Id: I910f02b1dd0a61580786680dc420061f0d2ae8de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264508Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a935c65a0488..58ff77a83502 2020-06-29 m.maiya@samsung.com Vulkan: Set new layout based on VkImageUsageFlags 2020-06-29 courtneygo@google.com Vulkan: Implement invalidate for color buffers 2020-06-29 syoussefi@chromium.org Vulkan: Remove superseded updates when flushing to image 2020-06-29 ianelliott@google.com Vulkan: Skip *functional.attribute_location.bind* tests 2020-06-29 syoussefi@chromium.org Vulkan: Remove suppression of fixed dEQP tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I7cb8ee07c76e9cebc57f1e69fecebd4723248022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274138Reviewed-by:
-
Nico Weber authored
Bug: 1098899 Change-Id: Iaf6c591a7ae4591d09bedc75d4bd83c64b7e28df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269512Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#783711}
-
Kai Ninomiya authored
Correctly generates filenames for test names like wpt_internal/webgpu/cts.html?q=webgpu:api,validation,fences:* Fixes an issue where on Windows, such filenames cause (1) traces to not be written to disk and (2) the driver process to hang during shutdown and get terminated by timeout. Bug: 953991 Change-Id: Ia4389ccd7843c343bc0e2bc5338a974aa5b072b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268181 Auto-Submit: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#783710}
-
Abhijeet Singh authored
The announcements and alerts for the Quick-Answers related views are updated to be able to better assist the feature users and guide them through the widget when the screen-reader is turned on. Bug: b:152059023 Test: Tested on Atlas test device. Change-Id: I243993a560ed0499ec44a87181ba0e1dd7f859cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271164 Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c7eed83f9616..f64be08132ec 2020-06-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-06-29 dpranke@google.com Revert "Add a Str() function to gclient for use in DEPS files." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1099242 Tbr: agable@chromium.org Change-Id: Ice45ad5c8aabf5a7741de6fc7b157772bf65a02c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274150Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c1e0cf3933c5..77e0c895b247 2020-06-29 tvanderlippe@chromium.org Remove RelaxedJSONParser If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1098730 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5bcb7a621f0eb94c29382e3434af7c2f9b22510f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274162Reviewed-by:
-
James Cook authored
Construct LacrosChromeServiceImpl as soon as threads are ready. This allows the mojo::Remotes for ash-side APIs to be bound immediately. Thus they are safe to use any time LacrosChromeServiceImpl exists. Outgoing calls will be queued until connection to ash-chrome. pipe to ash-chrome. Hit Ctrl-O/Ctrl-S. No crash. Test: Launch lacros-chrome from cmd line so it doesn't have a mojo Bug: 1090587 Change-Id: Iace0a9a2b26ba7e7fd3dbb2132b9454b3e86c1f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271065 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:Darin Fisher <darin@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#783706}
-
James Hawkins authored
R=hansberry@chromium.org Bug: none Test: none Change-Id: Ie6a1cbfe2af5a92bdbecd5c15f6eccc6c3bdcf1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270857Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#783705}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9ca21df4f833..eef73d8cd3f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dalecurtis@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1045256,chromium:1090082 Tbr: dalecurtis@google.com Change-Id: I09ddd251a008b17e40b5caf735e7f3e7676b00f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274142Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783704}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/096c0b0921ee..a1163749fd80 2020-06-29 tommi@webrtc.org Move BWE_TEST_LOGGING_COMPILE_TIME_ENABLE code to the worker thread. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I672df86eb003c231ec08b4bfd385e4c6589b272e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274537Reviewed-by:
-
Etienne Pierre-doray authored
A unique id that's < worker count. This will be used by several v8/blink use cases to index into worklist by worker. Change-Id: I3fce2f3f885d507e5b4f1f4425b9065dd642a6fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230760 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#783702}
-
Mikel Astiz authored
Implementations of SyncManager no longer exercise any Directory-related logic, which also means many Directory-centric concepts like purging datatypes or applying changes are obsolete and can be deleted. This surfaces another set of tests that were obsolete and must be deleted, in particular in SyncEngineImplTest and SyncManagerImplTest. Change-Id: Ice96d72aef3c94a5cf558a97721965e8ec832c2a Bug: 923287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266717 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#783701}
-
Rakib Hasan authored
This reverts commit ede59cfc. Reason for revert: Change is causing failures like https://chromium-swarm.appspot.com/task?id=4d1acfb5e4200410 Original change's description: > gpu_tests: Remove use of run_gpu_integration_tests.main in presubmit > > This CL is a follow up to crrev.com/c/2268883. It removes further > spawning of subprocesses by removing calls to > run_gpu_integration_tests.main. > > Bug: chromium:960606 > Bug: chromium:952105 > Change-Id: I2120da203b5048c7fe6007a16769058e8e551db3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273620 > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: Rakib Hasan <rmhasan@google.com> > Cr-Commit-Position: refs/heads/master@{#783661} TBR=bsheedy@chromium.org,rmhasan@google.com Change-Id: Icae220a32fb889c08d5be3eecc3332333029a62e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:960606, chromium:952105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274171Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#783700}
-
Charlene Yan authored
Bug: 1018230 Change-Id: I5bcbc750e801e583f8d86128710f3cadeecec9f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274153Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic5bd44aff96a37e078a4bbc85fb0869895a15eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274181Reviewed-by:
-
Lei Zhang authored
The 1-parameter version is simpler, and the 2-parameter version is deprecated. Bug: 1009837 Change-Id: Ib3801fdace1fc660956a6a5a2f5e5c0c92fe69a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269761Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#783697}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/dbc68791f80c..bc4525604b66 2020-06-29 bpastene@chromium.org cros_test: Remove rootfs verification when flashing. 2020-06-29 shaochuan@chromium.org command_vm_test: add board param to cros_vm call If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com,bpastene@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com,bpastene@google.com Change-Id: I288d52977fe202beec9137bd5020c85ed7db426d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274158Reviewed-by:
-
Aleks Totic authored
Also added unit tests. The coverage is not very broad, but it is a start. We can add more tests to illuminate questions as they come up. Bug: 958381 Change-Id: Id4c1a563f7f76c664c74bf6bc1a9a3464a19e30e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269729 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#783695}
-
Charlie Hu authored
This reverts commit 9a47d288. Original change's description: > Revert "Implement permissions policy parser" > > This reverts commit a96776d4. > > Reason for revert: Broke Linux bots: > https://ci.chromium.org/p/chromium/builders/ci/linux-blink-cors-rel/6631 > https://ci.chromium.org/p/chromium/builders/ci/Cast%20Linux/95081 > > Original change's description: > > Implement permissions policy parser > > > > Implement permissions policy parser based on this proposal: > > https://github.com/w3c/webappsec-feature-policy/issues/376 > > > > Change-Id: I50e160afa0f2e3039b67388c71bf5879957ad784 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240900 > > Commit-Queue: Charlie Hu <chenleihu@google.com> > > Reviewed-by: Ian Clelland <iclelland@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#783581} > > TBR=iclelland@chromium.org,chenleihu@google.com > > Change-Id: Iee0cbaa33aff49f2473c374d5c0af5d0e04e6985 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273604 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#783606} TBR=dalecurtis@chromium.org,iclelland@chromium.org,chenleihu@google.com Change-Id: I852afc10dee493b15f02c083762b9f2dae4d0f2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273082Reviewed-by:
Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#783694}
-
Nate Chapin authored
Bug: 1100176 Test: html/semantics/scripting-1/the-template-element/template-element/template-set-inner-html-in-inactive-document-crash.html Change-Id: I1d2ad61aead0d8f14952ae9b8e49d855d773e86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273798 Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#783693}
-
Varun Khaneja authored
Fixed: 1084103,1084104,1084105,1084106 Change-Id: I34ff65e2d09262e6720382e6e44bf190b76b5d1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273685 Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I94d002a560a1d12d7ea16e3cf40534e04f47824f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274357Reviewed-by:
-
Wei Li authored
As part of a larger effort to increase ui/views code coverage, this CL added unit tests and fixed an condition. Bug: none Change-Id: I2791a05f07c0a3ec8c85d80b8400178c726bd4b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271243Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#783690}
-
Mike Wittman authored
Reuses the ModuleCache POSIX module implementation for Android ELF modules, which fixes the incorrect start and end addresses previously generated by AndroidModule. Renames AndroidModule to NonElfModule. Removes tests specific to the previous implementation. Also includes a latent 64-bit bug fix where the register copy would only copy half the registers. Bug: 1004855 Change-Id: I3b26fac427043b2022b1d35b5c985e468ce35692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253221Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#783689}
-
