- 20 Apr, 2020 27 commits
-
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org Bug: 1071928 Change-Id: I369d9bfd4024cea36397c7b9546b72903bf15302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155759Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#760394}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0c9327e48e9c..2657867e1fcb git log 0c9327e48e9c..2657867e1fcb --date=short --first-parent --format='%ad %ae %s' 2020-04-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/dawn 53f694b34a8d..99655bcf85ca (11 commits) Created with: gclient setdep -r src/third_party/skia@2657867e1fcb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jcgregorio@google.com Change-Id: If08c3c9f859b24843f3eb5d838bf311197d3ba0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156112Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760393}
-
Hirokazu Honda authored
When application requests simulcast, libwebrtc configures temporal layers on each stream. If VaapiVEA and V4L2VEA refuses the temporal layer encoding, then we cannot make use of HW encoders on ChromeOS in simulcast case. Ignoring temporal layers and producing a simple stream causes a little less flexibility on a video call background, but not so critical. So V4L2VEA and VaapiVEA ignores the request as intended. Bug: 1030199, 1071089 Test: webrtc.RTCPeerConnection.* Change-Id: Iff153d76c05a1a994a609b97956dbb1fe041c627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154359 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#760392}
-
Yutaka Hirano authored
https://crrev.com/c/2132902 introduced case-sensitivity unintentionally. Fix it. Having a test for COEP header parsing for responses coming from service workers in reporting.https.html is not good. Create a separate test file and remove the corresponding test case from reporting.https.html. Bug: 887967 Change-Id: I50da8ee5e38162fbb81699fc1c55f5b4cb9cd903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154364 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#760391}
-
Ramin Halavati authored
IndependentOTRProfileManager is deprecated. Usage of it in HatsWebDialog is replaced by profile API functions. Bug: 1033903 Change-Id: Ie531e0c319351c20ea69d9faa2065803a2e08573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153073 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#760390}
-
Peter Kotwicz authored
This CL adds two new tests for the lightweight first run experience. The motivation for the new tests is because the purpose of removing the WebApkConstants.EXTRA_WEBAPK_PACKAGE_NAME in WebappLauncherActivity#tryCreateWebappInfo() is to make the lightweight FRE logic work correctly but the logic was not tested in the FRE context. BUG=None Change-Id: I5958a7333722f10de1e3599b07d82be9e9e39446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147042 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#760389}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/30b6825fa7b1..b4af53b2ac23 git log 30b6825fa7b1..b4af53b2ac23 --date=short --first-parent --format='%ad %ae %s' 2020-04-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@b4af53b2ac23 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I978a69c56d54a05c386d6cd929231348675838fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156111Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760388}
-
Yoichi Osato authored
Stop saving the request if OutOfBlinkCors is enabled. This is because |fallback_request_for_service_worker_| is needed only when OutOfBlinkCors is disabled. Bug: 787704 Change-Id: Idae728e80f4b229b236790494b61c28687fdbb6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128004 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#760387}
-
Yutaka Hirano authored
The special treatment was added as https://crrev.com/c/1220257. That was needed because at that time blob URLs are handled in CorsURLLoader. Now it is handled in storage::BlobURLLoader, so we don't need the logic here. Bug: None Change-Id: I2ba642cee12304b4f8cd4e4eca4f8afaab3ff4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129379Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#760386}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9f46e3dd5e11..3f4e5c456306 git log 9f46e3dd5e11..3f4e5c456306 --date=short --first-parent --format='%ad %ae %s' 2020-04-20 63069047+pmistryNV@users.noreply.github.com Add support for extension GL_ARB_shader_image_size (#2185) Created with: gclient setdep -r src/third_party/glslang/src@3f4e5c456306 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,timvp@google.com Change-Id: Idef2ee34f567f2db9bd87c5eebd3c60e688140c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156110Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760385}
-
Matt Giuca authored
Adds cmp and dmurph as general owners; oyiptong as file handler owner. Change-Id: I0d2e92704610f4d5f915f31768a77b22fb9ba4dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153530 Auto-Submit: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#760384}
-
Keishi Hattori authored
This reverts commit 1e7636e6. Reason for revert: It didn't unblock a problem that I was expecting this to. Original change's description: > Remove CooperativeScheduling code > > Remove CooperativeScheduling code as it is not actively developed. > > Change-Id: I74f8bee019652b04dd8e9fc2cf54e9bf83b6a4e3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154637 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760368} TBR=haraken@chromium.org,keishi@chromium.org Change-Id: I9803d69a71eb1c25f94e40124850413c3e3c37e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155752Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#760383}
-
Antonio Gomes authored
BUG=767015, 1063749 R=rego@igalia.com Change-Id: I665a0ab0d51e42284bade8979b8563245def8877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153732Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#760382}
-
Patrick Meiring authored
As recommended by the app service team, to avoid Plugin VM app code polluting the built-in app publisher. TEST=unit_tests --gtest_filter=*PluginVm* TEST=cros_sdk -- tast run -buildbundle=pita $DUT_IP pita.* Bug: 1069426 Change-Id: I63bfe5f2c1040a0add937b7ddef4693a3e709fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151767 Commit-Queue: Patrick Meiring <meiring@google.com> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#760381}
-
Wanming Lin authored
WPT test directories should named after the shortname of the spec, this CL renames wpt/wake-lock to wpt/screen-wake-lock and moves system wake lock related tests to web_tests/wake-lock since there's no w3c spec for system wake lock at present. This CL also moves the idlharness tests for system wake lock to wpt_internal/system-wake-lock to use wptserve. Relevant spec issue: https://github.com/w3c/screen-wake-lock/issues/257 Bug: 1064685 Change-Id: I77939065ca82257fc261dcdfd07c9e7608fc9c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147352 Commit-Queue: Wanming Lin <wanming.lin@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#760380}
-
Anand K. Mistry authored
The updated credential needs to be remembered so that the share can be restored on suspend/resume. Bug: 1065271 Change-Id: Id47aaa5dd40ec61c979749760bf229f4dc661145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151498Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#760379}
-
Hiroki Sato authored
There is an invisible list in PlayStore app, and when the loading completed, a selection event is dispatched from the list. This made ChromeVox move the focus to the list when opening PlayStore. Before http://crrev/c/2129381, this was not observed because selection event handling was incomplete, but now observable. This CL prevents the behavior by dropping selection and focus events from invisible nodes. Bug: b:154293371 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: manual. Open PlayStore, focus no longer moves to the invisible node. Change-Id: Icfe4c931bef53b573878c3a55223e9e553b47307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154358 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#760378}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: If9b4b0fdefd987a471c1a1a1ef52a6c2aaf8aed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155819Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760377}
-
Yue Zhang authored
http://crrev.com/c/2123991 exposes a problem in TabGridDialog by skipping a call which was used to setup the basic fade-in/fade-out animation. Instead of having it setup in a unrelevant call, this CL fixes this issue by adding a specific handle in TabGridDialogMediator# onReset to make sure that the basic animation is setup if needed. Some other things happened in this CL: * Add a e2e regression test for this bug. * Simplify the logic controlling the alpha of dummy views used for dialog zoom-in/zoom-out animation so that 1) the alpha is only set by animators related to zoom-in/zoom-out animation but not fade-in/fade-out animation. 2) The dummy views will always have alpha as 0 when animation ends. Bug: 1068928 Change-Id: I66ae49925727c65ceedc365a5ea27cc6d378d15f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143671 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#760376}
-
Jing Wang authored
keep-typing feature: when the suggestion pops up and the user keeps typing, if what they type is a prefix of the suggestion, the popup will not disappear, and in the suggestion text the typed prefix will be displayed in black and bold. The popup will disappear anyway if the user has typed more than 10 characters. Test: tested with Linux emulator Bug: 1042084 Change-Id: I157cd92cf29bb308e09764109d2eb0333183af7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153181 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#760375}
-
Josh Simmons authored
Bug 1067499 requires the addition of individual browser tests to validate the MIME type detected and reported by Quick View for all file extensions known to Files.app. This CL adds a new test for files with extension 'jpeg' and more clearly names the existing test for files with extension 'jpg'. Bug: 1067499 Test: browser_tests --gtest_filter="*FilesApp*openQuickView*" Change-Id: I03d72d6d7daeffb2f14f5bf0083b07ca328b685d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153461 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#760374}
-
Jie Jiang authored
Cleanup discovery sessions after the ARC Bluetooth service in Android shutdown. BUG=b:145257789 TEST=manually test: LE scan stops immediately after called BluetoothAdapter.disable() in an Android app, as expected. Change-Id: I9f1f7814eb935ceca3099c0d8124e313a9c2c065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051863 Commit-Queue: Jie Jiang <jiejiang@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#760373}
-
Sergei Datsenko authored
BUG=chromium:1037058,chromium:1037059,chromium:1037060 Change-Id: Ie0e9a26d0739f83502a422fc2ffb2d45cde43093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147519 Commit-Queue: Sergei Datsenko <dats@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#760372}
-
Jie Jiang authored
Uses a separate discovery session for LE scan requested by ARC. Avoids triggering the DiscoveryStateChanged event for LE scan since Android doesn't use it for LE scan. Note that We still use a timer for LE scan since we cannot set scan parameters and filters now, while this is not expected by Android. BUG=b:145257789 BUG=b:152463320 TEST=Automatic cts tests passed; TEST=Manually test with the app mentioned in the bug thread, the behavior becomes normal. Change-Id: I9b9d24827896678b24592260eefd48e7aa2b89c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010606Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Commit-Queue: Jie Jiang <jiejiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#760371}
-
Jing Wang authored
Test: tested with Linux emulator. Bug: 1068044 Change-Id: I27899234572f483e2be1322bab5f3e4e18902d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153173Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#760370}
-
Kuo Jen Wei authored
Set CCA window can consume volume button. Add new mojo API monitoring tablet mode state. Trigger camera shutter when CCA window receive volume button event in tablet mode. Design doc: go/cros-camera:dd:cca-volume-button-shutter Bug: 1024118 Test: Manually test shutter triggered after clicking volume button in tablet/non-tablet mode Change-Id: I8b6730773abae7741e90e676abc1a196f6289668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089111Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#760369}
-
Keishi Hattori authored
Remove CooperativeScheduling code as it is not actively developed. Change-Id: I74f8bee019652b04dd8e9fc2cf54e9bf83b6a4e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154637Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#760368}
-
- 19 Apr, 2020 13 commits
-
-
Daniel Libby authored
This reverts commit 0de4d371. Reason for revert: Need to sort through memory regressions on the perfbots - see crbug.com/1071564 Original change's description: > Reland "Add support for drawImageRect-based directly composited images" > > Reland now that M83 has forked. Also adjust DCHECK in > picture_layer_impl.cc. crbug.com/1063358 points out that even if the > aspect ratio matches, we can still end up with a scaled tile that does not > exactly match the layer's bounds because of the raster scale adjustments > that kick in inside RecalculateRasterScales when the desired scale is > adjusted based on the ideal scale. > > > Original change's description: > > > Add support for drawImageRect-based directly composited images > > > > > > Directly composited images is a feature that rasterizes images at their > > > intrinsic size, when an image is the only thing drawn into a layer. > > > However, this determination is today made prior to painting the image > > > in blink, which can't be done with CompositeAfterPaint enabled. > > > > > > This CL adds support for detecting PictureLayers that qualify as directly > > > composited images, by analyzing the paint ops of the display item list. > > > If a single drawImageRect paint op is detected (with some facilities for > > > detecting images for which orientation is respected), then we'll > > > propagate the image's intrinsic size over to PictureLayerImpl on commit. > > > PictureLayerImpl then uses that information to calculate a raster scale > > > that results in the image being rasterized at its intrinsic size. > > > > > > There are a few additional changes needed outside that core calculation. > > > If the aspect ratio of the layer bounds does not match the image's > > > aspect ratio, we won't raster the image at the intrinsic size, but > > > instead will choose the scale from one dimension. In these cases, we will > > > choose to re-raster when the layer is resized until the layer bounds > > > aspect ratio matches that of the image. > > > If we do adjust the raster scale and add tilings to the active tree > > > (as is seen in the default configuration for web_tests), we should drop > > > the previous tilings (which are now non-ideal) since the max raster scale > > > tile will be chosen when the SharedQuadState is created during > > > AppendQuads. > > > We also need to tell the LayerImpl if nearest neighbor should be used > > > when the TileDrawQuad is scaled in the display compositor to preserve > > > the same output of the original drawImageRect. > > > > > > Bug: 875110 > > > > > > Change-Id: I2cda143f483c2aa30a6ae1fb850e1c7ef1227882 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036542 > > > Reviewed-by: vmpstr <vmpstr@chromium.org> > > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > > Commit-Queue: Daniel Libby <dlibby@microsoft.com> > > > Cr-Commit-Position: refs/heads/master@{#751891} > > TBR=vmpstr@chromium.org,pdr@chromium.org,dlibby@microsoft.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 875110 > Change-Id: I485e939ba08575a3e2af5a821558e54ce6132cc2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144398 > Reviewed-by: Daniel Libby <dlibby@microsoft.com> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Reviewed-by: vmpstr <vmpstr@chromium.org> > Commit-Queue: Daniel Libby <dlibby@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#758935} TBR=vmpstr@chromium.org,pdr@chromium.org,dlibby@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 875110, 1071564 Change-Id: Id418d813962bd56145361f26b4e42552815fb033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156071Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#760367}
-
John Chen authored
The release script was recently modified to change to a temp dir as its working directory, and that caused it to look for notes.txt in the wrong location. This CL fixes it. Change-Id: Ib0d0abe2689a5bc80c4e6079e5cde2588f5b7a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155202Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#760366}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 879e9aa2. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Icdc5be30cb668bba3daeba13d3d3e0e5618fa03d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156012Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760365}
-
Wez authored
Enabling |toolkit_views| in all Fuchsia builds ensures that Views can be built under Fuchsia, which will be required when we start wanting to add UX e.g. to mitigate use of web permissions. Enabling Views to be compiled in advance of that requirement is a trade- off between overhead maintaining the Views/Fuchsia configuration while it is unused, and cost of making it work on Fuchsia in future. Since the vast majority of Views is cross-platform, the maintenance overhead should be relatively small. Also remove unused //build/args/fuchsia.gn. Change-Id: I24b534e2bf8f005db76a0a612fa4fa57ac1b1e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056951Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#760364}
-
David Tseng authored
This fixes an issue where on user accounts with other tts extensions installed, we always get back a reply by waiting for Googletts voices, and targeting Googletts with our warmup utterance. Without this change, it's possible chromeVoxDeferredLoader waits forever if the engine never sends an event. TBR=dmazzoni@chromium.org Test: all flows including login, guest, regular sessions. In each case, with ChromeVox previously loaded, and without ChromeVox previously loaded (i.e. automatically started on session start). Change-Id: I7abe9556bbd00a432a969f38343e0e8c1f24e94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156065Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#760363}
-
Yuzu Saijo authored
This CL adds a browsertest to make sure that when printing feature is used on a page, the page is not cached in BackForwardCache. This is because we currently do not close the popup caused by printing properly for bfcache. Blocklisting the feature is the first step, and supporting it is the next step. Bug: 106849 Change-Id: Ie8195ae88f94d967aed915422099c6e208b67c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148706 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#760362}
-
Javier Ernesto Flores Robles authored
Sometimes an exception is thrown by the system when trying to execute one of the input form accessory actions. This catches the exception to avoid the crash and continue. Bug: 942445 Change-Id: Ia3a127cf3ce6e41eba63c62034d574aa296ea952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144159Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#760361}
-
Pavol Marko authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/14a2fb015f12..bde2e0883d12 $ git log 14a2fb015..bde2e0883 --date=short --no-merges --format='%ad %ae %s' 2020-04-07 pmarko system_api: Add cryptohome TpmAttestationDeleteKey 2020-04-14 akhouderchah system_api: shill: Organize function names based on object type 2020-04-14 akhouderchah system_api: shill: Remove unused Network interface 2020-04-14 akhouderchah shill: l2tp: Remove unused properties Created with: roll-dep src/third_party/cros_system_api Change-Id: Ibdc2f4269e18154178cbac4dc67f3ced4e9dd6b0 Bug: 1045895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153159Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Askar Aitzhan <askaraitzhan@google.com> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#760360}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I1634409c39819127c2dd83343175dc7f1e2ba2dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155998Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760359}
-
Mohsen Izadi authored
Currently, we do not report end-to-end EventLatency metrics for WebInputEvent's of type kRawKeyDown and kChar. An example is when a user enters a text in an input field. The reason is that the function that converts WebInputEvent::Type to ui::EventType return ET_UNKNOWN for these two specific event types. It should return ET_KEY_PRESSED. Bug: 1054007 Change-Id: I701a71c43dc2f2b13ee20607b0950858155398e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085597 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#760358}
-
Wez authored
When pre-caching packages onto the Target, run 'pkgctl get-hash' to verify that the newly-cached package variants are active, i.e. that they will be returned by the package resolver when launched. Bug: 1070595 Change-Id: I2c64f2ca75946cfe0ccf893a25036ab37dffdfe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148317 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#760357}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3ce055109dd8..bf3571fa2a27 Created with: gclient setdep -r src-internal@bf3571fa2a27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com Change-Id: If7733c870f1ce5fecec2a2529ae8bc229c790f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155533Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760356}
-
Roman Aleksandrov authored
Remove Skip related methods and tests because there is no more Skip button on the ArcToS screen. Bug: 1069792 Change-Id: I35362c0c6598ce2b68334ecc1bb06c6d50532632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144960 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#760355}
-