GitLab

https://webrtc.googlesource.com/src.git/+log/fc8279d66c81..c9f42ad909c0

git log fc8279d66c81..c9f42ad909c0 --date=short --first-parent --format='%ad %ae %s'
2020-01-17 srte@webrtc.org Simplifies transport overhead mechanism in Scenario test framework.
2020-01-17 saza@webrtc.org Remove unused AEC delay offset API
2020-01-17 hbos@webrtc.org ResourceAdaptationModule HasInputVideo+DegradationPreference setters.
2020-01-17 peah@webrtc.org Reland "Replace the ExperimentalAgc config with the new config format"

Created with:
  gclient setdep -r src/third_party/webrtc@c9f42ad909c0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I5157cea9673dd5979c29787204e5678963040bc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007591Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732852}

Using wpt-import in Chromium 8b49e5d8.
With Chromium commits locally applied on WPT:
62f8d5f0 "Enable Scroll To Text by default"
363313c0 "Sort the registrations returned by getRegistrations() by registration ID."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Ifff3aaace72b7afbaa5430e3d6495ef52f911f55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007609Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732851}

https://chromium.googlesource.com/catapult.git/+log/d4405431bad0..c6d670ac06ee

git log d4405431bad0..c6d670ac06ee --date=short --first-parent --format='%ad %ae %s'
2020-01-17 khokhlov@google.com [Telemetry] Set a clock snapshot on Android

Created with:
  gclient setdep -r src/third_party/catapult@c6d670ac06ee

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC rmhasan@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:990304
Tbr: rmhasan@google.com
Change-Id: I590f9426897f503ff42cb28223df035304c6d926
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007593Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732850}

Currently, |login_screen_ui::UiHandler| only closes the login screen UI
window when the extension is uninstalled, and not when it is unloaded.
When an extension is updated, the old instance is unloaded and not
uninstalled. This means when an update occurs when the old instance has
a window open, this window will not be closed, and the new instance
will not be able to open another window.

This CL updates |UiHandler| to also close the window when the extension
is unloaded.

Bug: 957573
Change-Id: If586fa5cc83fca20d971e85080389d013b854e66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002610
Commit-Queue: Jit Yao Yap <jityao@google.com>
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732849}

This CL separates 'require-trusted-types-for' from 'trusted-typs'
Content Security Policy directive, which currently has only one injection
sink 'script'.
https://w3c.github.io/webappsec-trusted-types/dist/spec/#require-trusted-types-for-csp-directive

Bug: 1030257
Change-Id: I1c241c5b6be318aa195323178cf974df138d5788
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993351
Commit-Queue: Yifan Luo <lyf@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732848}

This CHECK was added to investigate the dirty layout found at
crbug.com/965976 <crrev.com/c/1626349>. This patch turns this
to NOTREACHED to mitigate users.

Bug: 1038735
Change-Id: Id544874fd5ec3c0805bd28fb615b8378351fd276
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006832Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732847}

Improve variables naming and comments.

Bug: 1012892
Change-Id: I72aa8b832711041bc71f0aff3742306beaeb7ad2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003177Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732846}

There is a device policy for setting the Chrome OS release channel. The update daemon reads and honors this policy. Chrome does not need to get involved. It still tries though, calling GetUpdateEngineClient::SetChannel, which produces a spurious error message as the method is no longer meant to be used in an enterprise context.

Bug: 991109
Change-Id: Ia5007581b91846eaecb9f270de09a790f41cc9db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007630Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Commit-Queue: Anina Koehler <aninak@google.com>
Cr-Commit-Position: refs/heads/master@{#732845}

https://chromium.googlesource.com/angle/angle.git/+log/ce9f521465e1..b46e6c2fa626

git log ce9f521465e1..b46e6c2fa626 --date=short --first-parent --format='%ad %ae %s'
2020-01-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 5fc197dc7669..2cb1db08e5f1 (2 commits)
2020-01-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src ab883b9d257e..41a96d15fd99 (5 commits)
2020-01-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 4792a6854238..b6ac1e60cd3a (3 commits)

Created with:
  gclient setdep -r src/third_party/angle@b46e6c2fa626

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jonahr@google.com
Change-Id: Ifbd397d33f9bf08a6f652c0c93b03db1a3c7fcaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007589Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732844}

This is a reland of 19619799

Original change's description:
> [iOS] Roll MDC to dc9529ad1077730cb7a57b05b77c9260d027b6d4
> 
> Bug: 1034144
> Change-Id: I8f69bae933c264839a60f4ce7c9cb6ac04249895
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003391
> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#732628}

Bug: 1034144
Change-Id: I5d8888ab30a9ae60018f547808575588d0ccb6bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007628Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732843}

Do this by changing the default implementation to true for OS_ANDROID.
This also allows removing the android webview override.

Bug: 1038894
Change-Id: I1be3c680a32116bc8867958d85f89ad5302a525d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006208
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Auto-Submit: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732842}

Following bot results are included.
990 991 992 994 995 996 997 1000 1002 1003 1004 1005 1006
1007 1008 1009 1011

91 lines were removed and 16 lines were deflaked by consecutive
results since 991.

TBR=yosin@chromium.org
NOTRY=true

Bug: 982194
Change-Id: Id5ed79b5a9ca348c5113f1d1caa9311538cb2446
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002553Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732841}

This fix part 1/2 for the bug with the bad spinner being displayed after
the end of the SAML login.

This fixes a race between multiple pieces of code changing
screen-gaia-signin's |isLoadingUiShown_|. These races led to the "please
wait" spinner not being shown in some cases.

In particular, one race condition was between (a) setting this flag to
true after the successful authentication (done by onAuthCompleted_())
and (b) setting it to false when the authenticator completely loads a
third-party page (done by onAuthReady_()). Before this. CL, the flag
could stay "false" after the SAML authentication, due to "(b)" happening
after "(a)" (after fully loading the Gaia's /programmatic_auth_chromeos
page).

The fix is to get rid of direct overwrites of the |isLoadingUiShown_|
property from different places, and instead make it computed from a few
variables that track independent states.

Bug: 1024253
Test: perform SAML login on a slow device, verify that after less than a second the "Please wait" spinner is shown
Change-Id: I8a9d3dbb859ca4c4bf87e0f9b595ae9410d7937b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000627Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732840}

This reverts commit bc295819.

Reason for revert: Breaks browser_tests on Mac10.13 Tests (dbg): https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/16788

Original change's description:
> [SyncSteup]: Change Sync everything to a radio behaviour.
> 
> As part of friendly settings, this CL implements changing |sync
> everything| from check box to radio button. The motivation behind this
> work is to clarify to users the difference between |Sync everything|
> checked and |Sync everything| unchecked but all single data types
> checked.
> 
> Screenshot:
> http://screen/TuwQcMx3dmk
> 
> Bug: 1035421
> Change-Id: I4f9db188a6b324d18c5d17a5dfca6b9d70e0b1ae
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995328
> Commit-Queue: Monica Basta <msalama@chromium.org>
> Reviewed-by: Dan Beam <dbeam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#732804}

TBR=dbeam@chromium.org,msalama@chromium.org

Change-Id: Ifddfa0873d756f23059b90b5ce95743091c0d048
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1035421
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007213Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732839}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/07335b60..9da16439

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ifb59252fe95c6717d58ae45ba115c250139bf2c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007608Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732838}

The HRTF response size can some times be smaller than the FFT size.
This can happen if the FFT size has a lower limit, such as for PFFFT
which clamps the size to the lower bound.  To account for this, create
a new HRTF response that is zero-padded to the FFT size.

Manually tested against repro cases from the bugs; ASAN issue no
longer reproduces.

Bug: 1032000, 1041411
Change-Id: Ic2136a92a6e1bf4f2f78f434b065c21dc1b72b5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003571Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732837}

Update some title descriptions and provide a proper stylesheet
resource for link-dnsprefetch-in-css.html.

Bug: 456173
Change-Id: I06d2982ded73d6be1e1c9a829c764e3e4a4dfc90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002871Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#732836}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b39daad9ba0c..d8628858c150

git log b39daad9ba0c..d8628858c150 --date=short --first-parent --format='%ad %ae %s'
2020-01-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@d8628858c150

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I1fa6de85ff6d26faf48ca050ab970915a7d18464
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007588Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732835}

Moved the strings used both in the new tab page and desktop site
settings page to NTP string file, in order to be able to add more
3P cookie controls consistency between desktop and android.

Bug: 1040091
Change-Id: I3953c6003e57db53b7459662534f6a9e77af0d6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005068Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732834}

This change makes above classes independent of SelectPopup, which will
allow reuse of those widgets in other parts of Chrome.

Specifically, they will be used in autofill_assistant for the selection
of time slots and similar information.

This is a refactoring only; there are no user-facing changes.

Bug: b/147577012
Change-Id: Id2d981345640ecf3b201ad4b64e0b5e2c3145426
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002620
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732833}

Chrome status:
https://chromestatus.com/feature/5709702556024832

Intent to remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/5gxzhdS1KNs/Fs-Bvz4iAQAJ

This patch also cleans up the card type (i.e., prepaid, debit, credit,
unknown) from Chrome, because it was only ever used for "supportedTypes"
parameter of "basic-card" payment method name.

Bug: 981907
Change-Id: Ib0e89a0b68217565cc5e4a97310d0055d74d08c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980751
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Tim Schumann <tschumann@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732832}

Merge:
 - content::CSPDisposition
 - blink::ContentSecurityPolicyDisposition
 - blink::WebContentSecurityPolicyDisposition

Along the way, mojoifying it into network::mojom::CSPDisposition.

deleted files:
 - content/common/content_security_policy/csp_disposition_enum.h
 - third_party/blink/public/platform/web_content_security_policy.h

See UnifyCSP:
https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao

Bug: 1021462
Change-Id: Ic7a018978ae525d66172e70aa88accb878621b46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002570
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732831}

This will allow tests built with is_official_build=true to produce symbolized
stack traces during failures by explicitly setting exclude_unwind_tables
to false. This will be used by the chrome-branded + is_official testers that
have been spun up on https://ci.chromium.org/p/chrome/g/chrome/console

Note that any official build that doesn't touch exclude_unwind_tables will still
have unsymbolized stack traces since exclude_unwind_tables defaults to true
for official builds:
https://source.chromium.org/chromium/chromium/src/+/master:build/config/compiler/compiler.gni;l=96

Consequently, every other official builder will still have this symbolizing
code excluded from the build products.

Bug: 1041069
Change-Id: I937dbe01c38a29b1aff01d471807a9a492109645
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001749Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732830}

dsymutil (which runs as part of the link in official builds by default)
needs a lot of memory. Account for that.

Bug: 1028112
Change-Id: I555c265c1e6313327cecb5ab292063f04e4ff30b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007648Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732829}

Spec:
https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnectioniceerrorevent

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/fs-Y4awdYj0/1UOKRxzmBQAJ

Bug: chromium:1013564
Change-Id: I32c7d731a08dc75adcfe640357e8636f7c4325be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944346
Commit-Queue: Eldar Rello <elrello@microsoft.com>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732828}

This CL removes the BlinkFeatureUsageReport API on the WebLocalFrame
and converts FrameMsg_BlinkFeatureUsageReport to mojo.

The API mojom.LocalFrame API is named ReportBlinkFeatureUsage().

BUG=1041070
R=avi@chromium.org, dcheng@chromium.org, dtapuska@chromium.org, haraken@chromium.org

Change-Id: Ie25f1cd2dc1d39ef571f39b1c94fe67b5c9bf872
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005290
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#732827}

Bug: 999145
Change-Id: Id01bfa3a34201bbfdae7a1de1f2ba035b0469aec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003798Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732826}

There was a flaky failure in vulkan_native_blink_web_tests which would lead to
the test runner itself crashing.

Somehow when parsing input the results from re.match() the first result is a
NoneType, leading to a failure when adding group(1) + group(2)

I can't reproduce locally, so I want to add logging for this case.

TEST=vulkan_native_blink_web_tests

Bug: 1021563
Change-Id: I1cdec431ebc08df4a891c1062c3f1c64c80bc826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003029Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732825}

This is a reland of 382570ad

Original change's description:
> Add DCHECKs for correct thread usage of KeyedService code
> 
> Bug: 701326
> Change-Id: If652eb76fabc09cabdd61865cdb409f72c140392
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748083
> Reviewed-by: Lutz Justen <ljusten@chromium.org>
> Reviewed-by: Cait Phillips <caitkp@chromium.org>
> Commit-Queue: Derek Schuff <dschuff@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#686622}

Bug: 701326
Change-Id: I0a7dd9863175243181251f1f461c2100c17f09a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003129
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732824}

The metrics is collected. No follow-up is planned.

Bug: 1037179,791541
Change-Id: I4db51f2595761fcff3a68abf7d912950112c42c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004993
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732823}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8dd28cd4db8d..1918d6d30029


Created with:
  gclient setdep -r src-internal@1918d6d30029

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: If9033ade40986b98d6af0f8d81df6060aab2b16b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007428Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732822}

This more closely matches the button size for the close-x at the end of
the downloads shelf. The focus ring and ink-drop highlight was
significantly larger than intended, likely after r619533.

This change also adds padding left of the drop-down button so that the
"Discard" button doesn't get laid out edge-to-edge next to it with
overlapping focus rings.

Bug: chromium:1042633
Change-Id: I3aac0b77846020e0fe3eb612d35f67bf307dbd6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006136
Auto-Submit: Peter Boström <pbos@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732821}

This reverts commit 4184bbb0.

Reason for revert: Likely culprit for a number of new flakes on Mac: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNDE4NGJiYjBmM2ZlZjIzNzNlZGZjMTlkN2EzOGMxYTQ1NDBkZjBiOAw

Original change's description:
> Convert browser side's legacy IPCs of BlinkTest message to Mojo
> 
> As a step to convert legacy IPCs to the Mojo, this CL
> converts browser side's BlinkTest IPCs to Mojo. This
> CL introduces WebTestClient interface to replace the
> IPC messages to Mojo methods in web_test.mojom file.
> The interface starts to support the original messages
> as below,
> 
>  - InitiateLayoutDump()
>  - PrintMessageToStderr()
>  - SetPopupBlockingEnabled()
>  - NavigateSecondaryWindow()
>  - GoToOffset
>  - Reload()
>  - LoadURLForFrame()
>  - CloseRemainingWindows()
>  - ResetDone()
>  - SendBluetoothManualChooserEvent()
>  - GetBluetoothManualChooserEvents()
>  - SetBluetoothManualChooser()
> 
> This CL should not change any behavior.
> 
> Bug: 1039247
> Change-Id: Ic30f8cc0cb19ec8a306b577f3c10567d91bdccf1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002047
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#732388}

TBR=dtapuska@chromium.org,mkwst@chromium.org,gyuyoung@igalia.com

Change-Id: Iab211ed8d34d4fbc4781ec02e107f7deb3dbde72
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1039247
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007389Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732820}

There is a scenario causing crash in old implementation:
1. Client receives NigoriSpecifics with non-decryptable
|keystore_decryptor_token| in backward-compatible keystore mode.
2. User provides implicit passphrase.
3. Client decrypts |pending_keys| with implicit passphrase, but
continues to ask for new keystore keys.
4. Client receives keystore keys and crashes when trying to dereference
|pending_keys|.

Current fix is to not do anything if there is no |pending_keys|.

Bug: 1042203
Change-Id: I20d607cbe349bbb6eda5ed9b85f1e91d213fbc9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002615
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732819}

This API is analogous to IsPassphraseRequired() and different from
IsTrustedVaultKeyRequiredForPreferredDataTypes() in the sense that it's
not influenced by the currently-selected sync datatypes.

The rationale for introducing is that, when pending keys exist, certain
operations such as setting up a custom passphrase should be disallowed
by the UI, to prevent data loss. This is because having pending keys
means the locally accessible keybag does not contain all keys, so e.g.
setting up a custom passphrase would produce a new keybag where such
keys may be missing. As a consequence, worst-case, this can effectively
lead to user data loss, since there could be synced passwords encrypted
with the keys that have just been lost.

In this patch, setting pages on various platforms are updated to consume
use the new function instead of
IsTrustedVaultKeyRequiredForPreferredDataTypes().

Bug: 1019687
Change-Id: I6b5c69aac12b05ea34b4edc7dc149c84bd23d5c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972140
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#732818}

All these histograms but one (NonGaia) were no longer recorded.
The NonGaia histograms only had one bucket recorded:
PROFILE_DESKTOP_MENU_OPEN_USER_MANAGER

This information can be found in Profile.Menu.ClickedActionableItem and
is thus redundant.

This CL also obsoletes the histogram
Profile.AndroidAccountManagementMenu.GAIAIncognito
which is never recorded in the code.

Fixed: 1041533, 1041470
Change-Id: Ic5f6e05156d323f49ebe3a5b9daf7d64f319b7d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002626
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732817}

This reverts commit e03c42ac.

Reason for revert: browser_tests failures on CrOS (https://crbug.com/1043074)

Original change's description:
> Add Quick Answers context menu observer.
> 
> The feature is guarded by a feature flag that is currently disabled by default.
> 
> This CL implements a temporarily UI for getting early feedback on product and
> data quality while we are figuring out the final UI.
> 
> More detail at: go/quick-answers-cros and go/quick-answers
> 
> Bug: 1020004
> Test: Unit tests
> Change-Id: I17dac669c230f5fbd2052cd5683344fa30c41b85
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961210
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Commit-Queue: Li Lin <llin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#732713}

TBR=avi@chromium.org,xiyuan@chromium.org,thakis@chromium.org,estade@chromium.org,llin@chromium.org

Change-Id: I5d0a1ca1a22301e1c79b8f6187df8c18ead14120
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1020004
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007568Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732816}

https://chromium.googlesource.com/catapult.git/+log/fada3b97d140..d4405431bad0

git log fada3b97d140..d4405431bad0 --date=short --first-parent --format='%ad %ae %s'
2020-01-17 phoglund@google.com Add support for diagnostics and unit conversion.

Created with:
  gclient setdep -r src/third_party/catapult@d4405431bad0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC rmhasan@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1029452
Tbr: rmhasan@google.com
Change-Id: If60017872120fa5803e22b3baac2d4bc8c3b9116
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005803Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732815}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/47cbd1fb..07335b60

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: If44db73d830df8f73ed9a67e8b1a388e6fe3e5ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006171Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732814}

MANIFEST_FETCH_FAILED.

This is to get a better idea for failure of Force installed extensions
through UMA statistics by reporting error codes in case of
MANIFEST_FETCH_FAILED.

We report Network Error codes, Http error codes, and the number of fetch
retries made in case of MANIFEST_FETCH_FAILED error.
Following histograms are added:
Extensions.ForceInstalledManifestFetchFailedNetworkErrorCode -> Reports
the number of fetch retries made in case of MANIFEST_FETCH_FAILED.
Extensions.ForceInstalledManifestFetchFailedHttpErrorCode -> Reports
the Http Error Code in case of MANIFEST_FETCH_FAILED.
Extensions.ForceInstalledManifestFetchFailedNetworkErrorCode -> Reports
the Network error codes in case of MANIFEST_FETCH_FAILED.

Error codes are received in the ExtensionDownloader.

Bug: 981891
Change-Id: Icf5310d0f9422f77a4751c36ae8d6eaa5e772052
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993976Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Oleg Davydov <burunduk@chromium.org>
Commit-Queue: Swapnil Gupta <swapnilgupta@google.com>
Cr-Commit-Position: refs/heads/master@{#732813}