GitLab

Revert of Roll Clang 214024:216630 (+216684) and switch to CMake (patchset #20 id:380001 of https://codereview.chromium.org/453513004/)

Reason for revert:
Builds failing with:

../../third_party/skia/include/core/SkRect.h:280:25: error: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Werror,-Wundefined-bool-conversion]
        SkASSERT(&a && &b);
                    ~~  ^
../../third_party/skia/include/core/SkTypes.h:96:56: note: expanded from macro 'SkASSERT'
    #define SkASSERT(cond)              SK_ALWAYSBREAK(cond)
                                                       ^
../../third_party/skia/include/core/SkPostConfig.h:173:19: note: expanded from macro 'SK_ALWAYSBREAK'
              if (cond) break; \
                  ^

(From http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/12335/steps/compile/logs/stdio)

Original issue's description:
> Roll Clang 214024:216630 (+216684) and switch to CMake
>
> This updates Chromium's clang version to r216630 with
> r216684 cherry-picked to fix an ASan issue.
>
> It also changes the build script for Clang to use CMake
> instead of Autoconf. The ASan team say this configuration
> is better tested, and it also makes us consistent with
> the Windows Clang build which already uses CMake.
>
> BUG=400849
> R=thakis@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/ff31c1ba254ca37f7a8b45549e1b7b1c978b3390

TBR=thakis@chromium.org,samsonov@google.com,eugenis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=400849

Review URL: https://codereview.chromium.org/567443003

Cr-Commit-Position: refs/heads/master@{#294960}

Revert of mojo: Starting serialization for python bindings. (patchset #3 id:40001 of https://codereview.chromium.org/570563002/)

Reason for revert:
This patch appears to be causing failures on the Linux Tests bot.

http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/13627

Original issue's description:
> mojo: Starting serialization for python bindings.
>
> R=sdefresne@chromium.org,cmasone@chromium.org
>
> Committed: https://crrev.com/4e395c5e4c9025f187c98fb38730858b5cfdcc65
> Cr-Commit-Position: refs/heads/master@{#294846}

TBR=cmasone@chromium.org,sdefresne@chromium.org,qsr@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/576603002

Cr-Commit-Position: refs/heads/master@{#294959}

- Change the default kiosk test app to not auto close itself;
- Add test case for zooming support;

BUG=413854

Review URL: https://codereview.chromium.org/571973006

Cr-Commit-Position: refs/heads/master@{#294958}

If a surface has a copy output request pending, then the aggregator should avoid merging its root pass into its parent pass, and should instead place the copy request on it.

BUG=397730

Review URL: https://codereview.chromium.org/565313003

Cr-Commit-Position: refs/heads/master@{#294957}

gles2_interface.h defines a pure virtual interface; targets which use it should
depend on it, but not necessarily on an implementation target. Consequently,
a //gpu/command_buffer/client:gles2_interface target was created to reflect the
dependency on this interface without linking a particular implementation.

This resolves an issue with //cc trying to use this header without having a
dependency on a target which includes it.

Review URL: https://codereview.chromium.org/464153002

Cr-Commit-Position: refs/heads/master@{#294956}

Create LazyInstances for the default LabelButton FontLists.
Avoid creating/deriving default fonts for each new button.
(the bookmark bar can create unbounded button instances)
(repeated derivation is slow and exhausts GDI handles)

BUG=411716
TEST=Profiles with tons of bookmarks do not crash.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/544173007

Cr-Commit-Position: refs/heads/master@{#294955}

* arg names in GenerateEcP256KeyPairCallback typedef were reversed
* Make CreateSecureMEssage and UnwrapSecureMessage take structs (instead
of having long list of arguments)

BUG=None
TEST=existing unittests

Review URL: https://codereview.chromium.org/569813002

Cr-Commit-Position: refs/heads/master@{#294954}

This updates Chromium's clang version to r216630 with
r216684 cherry-picked to fix an ASan issue.

It also changes the build script for Clang to use CMake
instead of Autoconf. The ASan team say this configuration
is better tested, and it also makes us consistent with
the Windows Clang build which already uses CMake.

BUG=400849
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/453513004

Cr-Commit-Position: refs/heads/master@{#294953}

The GN on trunk requires this.

Review URL: https://codereview.chromium.org/571043003

Cr-Commit-Position: refs/heads/master@{#294952}

Also, cleanup internet_options_handler.cc 'showViewAccountButton' code.

BUG=279351

Review URL: https://codereview.chromium.org/561073002

Cr-Commit-Position: refs/heads/master@{#294951}

The multiple_proguards_test_apk target used guava as an example for
something that needed to be proguarded out to ensure no proguard
warnings.

Since guava is going away, this CL moves the bad code into chromium
directly so there is no need for guava.

It does bad things which produce warnings, so they are silenced by
telling GYP that it is not chromium code.

BUG=412673

Review URL: https://codereview.chromium.org/571203003

Cr-Commit-Position: refs/heads/master@{#294950}

BUG=409192
R=rkc, xiaowenx

Review URL: https://codereview.chromium.org/536213003

Cr-Commit-Position: refs/heads/master@{#294949}

NOTRY=true

Review URL: https://codereview.chromium.org/576563002

Cr-Commit-Position: refs/heads/master@{#294948}

BUG=

Review URL: https://codereview.chromium.org/575603002

Cr-Commit-Position: refs/heads/master@{#294947}

The CancelIo() operation does not synchronously cancel IO operations,
we must wait for them to return before returning to avoid writes to
resources which may have already been destructed.

See this blog post for more information:

http://blogs.msdn.com/b/oldnewthing/archive/2011/02/02/10123392.aspx

BUG=413494
TEST=manual inspect of cancellation states.

Review URL: https://codereview.chromium.org/570713003

Cr-Commit-Position: refs/heads/master@{#294946}

https://chromium.googlesource.com/chromium/blink/+log/1d4eb25ceba65e3e78786bce1251dc248d20af19..fbd4f37d728e462a9cbc3482156ad7e8c2c1d0b5
TBR=loislo@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/564663004

Cr-Commit-Position: refs/heads/master@{#294945}

Determine how many extension icons to show on each row of the overflow menu based on the width of other menu items.

Screenshot: http://imgur.com/mPQAbxs
BUG=412503

Review URL: https://codereview.chromium.org/553233002

Cr-Commit-Position: refs/heads/master@{#294944}

When in the component build multiple threads (apps) will use the same
view manager client lib and could fight over the current GL context, so
always make our context current in BitmapUploader.

When shutting down abrubtly (i.e. when losing a connection to an app),
the client will not necessarily properly unref all resources it uses.
DCHECKing here isn't helpful, so just skip over resources that are not
fully unreffed.

R=ben@chromium.org

Review URL: https://codereview.chromium.org/569173007

Cr-Commit-Position: refs/heads/master@{#294943}

BUG=352293

Review URL: https://codereview.chromium.org/566413002

Cr-Commit-Position: refs/heads/master@{#294942}

This means Chrome will no longer register itself as the handler for the
bogus "chromehtml" URL protocol. (Regular file associations should not
register the class name as a URL protocol.)

BUG=413051

Review URL: https://codereview.chromium.org/559253002

Cr-Commit-Position: refs/heads/master@{#294941}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG=110610

Review URL: https://codereview.chromium.org/556293004

Cr-Commit-Position: refs/heads/master@{#294940}

BUG=412882
TEST=components_unittests
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/562763004

Cr-Commit-Position: refs/heads/master@{#294939}

Metrics already exist but were never added to the inputs.

R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/571233002

Cr-Commit-Position: refs/heads/master@{#294938}

We figured out which part caused the problom, so these logs are no longer needed.

BUG=393331
TEST=bots
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/551803006

Cr-Commit-Position: refs/heads/master@{#294937}

Program the NIC to wake-on-packet for packets arriving from
the GCM server.  Chrome notifies the connection manager (shill)
by calling D-Bus methods.  The return status indicates if the
operation succeeded or not (depending on hardware support and
the type of connection).

Keywords: wowlan, wake-on-lan, wake-on-wlan

BUG=360295
TEST=verified dbus methods are called, and packets are sent on the
TEST=connection passed to the methods.  Also verified that shill
TEST=programs the NIC correctly, and packets wake up the device.

Review URL: https://codereview.chromium.org/409883006

Cr-Commit-Position: refs/heads/master@{#294936}

R=asvitkine@chromium.org,isherman@chromium.org
BUG=404791

Review URL: https://codereview.chromium.org/523273003

Cr-Commit-Position: refs/heads/master@{#294935}

Revert of ash: Add checks for supervised users. (patchset #5 id:80001 of https://codereview.chromium.org/561713002/)

Reason for revert:
This is breaking NotificationApiTest.TestUserGesture, which assumes it starts with an empty notification list.

Somehow this is causing the browser test to be in a state where there is already a notification in the list regarding a supervised user.

Original issue's description:
> ash: Add checks for supervised users.
>
> Propagate the user's supervised state to the ash system
> so that it becomes available for views
>
> https://chromereviews.googleplex.com/79527013/
>
> BUG=394417
>
> Committed: https://crrev.com/8616ac4cf7bd77f53dc001eb9d8d61c6c975eaaa
> Cr-Commit-Position: refs/heads/master@{#294821}

TBR=antrim@chromium.org,derat@chromium.org,jennyz@chromium.org,bauerb@chromium.org,treib@chromium.org,merkulova@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=394417

Review URL: https://codereview.chromium.org/575653002

Cr-Commit-Position: refs/heads/master@{#294934}

This reverts commit f51d7453.

The UI is breaking with certain extensions and users have no
ability to work around this. Putting back behind a flag and
trunk-only restriction.

BUG=414497,474476
CC=jleichtling@chromium.org,amineer@chromium.org
TBR=kalman@chromium.org,fsamuel@chromium.org

Review URL: https://codereview.chromium.org/571213003

Cr-Commit-Position: refs/heads/master@{#294933}

* Changes the include order of YASM
Default includes need to be put to the end for YASM.

In particular there are several versions of x86inc.asm in the tree and
libvpx requires its own version. This change in order allows libvpx to
include its own version.

* Roll libvpx to include BUILD.gn.

libvpx now builds on x86 posix.

R=brettw@chromium.org, scherkus@chromium.org, tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/535613002

Cr-Commit-Position: refs/heads/master@{#294932}

Otherwise keyed services see different profiles in unit_tests at
different times since the incognito->GetOriginalProfile() changes. This
is causing release code to pick up unnecessary workarounds to keep
unit_tests green in try runs.

The fix is achieved by adding `TestingProfile::Builder::BuildIncognito`,
which differs from `Build` by requiring an |original_profile| argument,
which will own the incognito profile (so no need to return scoped_ptr).
This simplifies a lot of call sites, since they no longer need to do a
scoped_ptr dance of their own.

BUG=277296

Review URL: https://codereview.chromium.org/556173002

Cr-Commit-Position: refs/heads/master@{#294931}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG=110610

Review URL: https://codereview.chromium.org/568413004

Cr-Commit-Position: refs/heads/master@{#294930}

This patch adds a bit more information into traces in the activation
path.

BUG=414292
R=reveman@chromium.org

Review URL: https://codereview.chromium.org/569413002

Cr-Commit-Position: refs/heads/master@{#294929}

Removes the spammy warning message, and replaces it with a sanity-
check that the queue has not grown past 10 seconds' worth of
packets.  If the sanity-check trips, a process crash dump will be
sent to make us aware, via crash reports, that this is a problem
in-the-wild.

Review URL: https://codereview.chromium.org/539323002

Cr-Commit-Position: refs/heads/master@{#294928}

Currently, when a scroll starts touch selection handles are hidden and
then re-shown after scroll ends. But, if scroll ends in a fling, handles
are not re-shown, because there hadn't been a way to determine end of
the fling. Now that there is an IPC message notifying end of flings, we
can re-show handles after a fling.

BUG=413927

Review URL: https://codereview.chromium.org/569863003

Cr-Commit-Position: refs/heads/master@{#294927}

Related changes:
 - Created a DriWindowManager to keep track of the platform windows.
   These are then used to perform the bounds clipping for the cursor.
 - Moved delegate manager to DriWindowDelegateManager. In a follow-up CL
   the delegate manager in the browser process will be removed in favor
   of holing on to the DriWindowDelegates on the DriWindow.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/556073003

Cr-Commit-Position: refs/heads/master@{#294926}

BUG=414162
TBR=dsinclair

Review URL: https://codereview.chromium.org/577493002

Cr-Commit-Position: refs/heads/master@{#294925}

Replaced the test for validation of requests and responses
with one that relies on the Connection et al classes to set
up the validators and deliver messages.

BUG=413303

Review URL: https://codereview.chromium.org/551293004

Cr-Commit-Position: refs/heads/master@{#294924}

Review URL: https://codereview.chromium.org/566863005

Cr-Commit-Position: refs/heads/master@{#294923}

Modifications from upstream:
- renamed class as it doesn't make much sense to test an "abstract" class.
- made this into an E2E test so we can test against the real ChromeVox message strings and not have to fake out a lot of objects.

Review URL: https://codereview.chromium.org/571643004

Cr-Commit-Position: refs/heads/master@{#294922}

Also catch 401 errors.

BUG=None.
TEST=None.

Review URL: https://codereview.chromium.org/556003002

Cr-Commit-Position: refs/heads/master@{#294921}