- 16 Jan, 2020 40 commits
-
-
Dan Beam authored
CL generated with: $ git ls-files 'content/browser/resources/*.js' | xargs grep -l -P ' [!=]= (?!null)' | xargs perl -p -i -e 's/ ([!=])= (?!null)/ \1== /g' Bug: 720034 Change-Id: Ib22149854033d71daf6c3041b4f3f747e9113ffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003793Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#732280}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f7d73bb52028..e5b0598dee84 git log f7d73bb52028..e5b0598dee84 --date=short --first-parent --format='%ad %ae %s' 2020-01-16 fancl@chromium.org Switch default to sheriff-config Created with: gclient setdep -r src/third_party/catapult@e5b0598dee84 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:953181 Tbr: wenbinzhang@google.com Change-Id: Id01e057ea564c3552684ab194d215ddf14df9b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003644Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732279}
-
Natalie Chouinard authored
TextAndButtonPreference is unlikely to be a useful reusable component for future settings screens (over ButtonPreference or HyperlinkPreference), so make its specificity explicit and move it alongside other Autofill Settings code. Change-Id: I7b76e30024f433c74188d2e0c4e1561033d4e5c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003688Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#732278}
-
Alexey Baskakov authored
Delete OS shortcuts in OnWebAppWillBeUninstalled observation. The bookmark app uninstallation case is currently handled in ::AppShortcutManager::OnExtensionUninstalled() located in chrome/browser/apps/platform_apps/shortcut_manager.h|cc. Bug: 860581 Change-Id: Id501151011998b49d971cf09a5ebab7f985de8e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000448Reviewed-by:
Jay Harris <harrisjay@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#732277}
-
Trent Apted authored
This reverts commit 4e23e8e8. Reason for revert: Causing flaky failures on inux-chromeos-rel since https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/33779 got deterministic in https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/33781 e.g. LoadingPredictorBrowserTestWithProxy.PrepareForPageLoadWithoutPrediction errors like ../../chrome/browser/predictors/loading_predictor_browsertest.cc:164: Failure Expected: (num_connections) >= (sockets_.size()), actual: 2 vs 4 Stack trace: #0 0x5578dc920ba5 predictors::ConnectionTracker::WaitForAcceptedConnections() Original change's description: > Adding a FTT config for PreconnectSameOriginDesktop > > This experiment is in canary/dev and should be moved to Beta. > > Bug: 1038774 > Change-Id: I4fc9c44e2b68aa58f9eee7210a625103f45edb01 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992684 > Commit-Queue: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732219} TBR=isherman@chromium.org,tbansal@chromium.org,ryansturm@chromium.org,alexilin@chromium.org Change-Id: I6ccc34cb80ca6da3b1b3b40d29d6c4e5dd8e65f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1038774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004181Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#732276}
-
Kramer Ge authored
We use one X visual and thus all GLContexts are compatible with each other and this method is not needed. Bug: 902943 Change-Id: I51d8f7527b52117c0b1535cc7f3d706030c3ffda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001397 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#732275}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/de6595c71442..c86e356c31a9 git log de6595c71442..c86e356c31a9 --date=short --first-parent --format='%ad %ae %s' 2020-01-16 thestig@chromium.org Roll tools/clang/ 57e481c48..42fbdfef1 (13 commits) 2020-01-16 thestig@chromium.org Roll build/ 4f02786ee..1bee638a8 (246 commits) 2020-01-16 thestig@chromium.org Roll v8/ 724fd9f1e..cd3414532 (360 commits) 2020-01-16 thestig@chromium.org Roll buildtools/ 6b3e658d6..1f38b432e (4 commits) 2020-01-16 thestig@chromium.org Roll third_party/depot_tools/ 603782044..e9730d75a (43 commits; 11 trivial rolls) 2020-01-16 tsepez@chromium.org Remove unused CXFA_GEColor no-arg ctor. 2020-01-16 thestig@chromium.org Roll third_party/catapult/ 32775164b..f7d73bb52 (148 commits) 2020-01-15 thestig@chromium.org Roll third_party/icu/ 88ea42af7..dbd3825b3 (1 commit) 2020-01-15 tsepez@chromium.org Remove unused CFFL_FormFiller::GetSystemHandler(). 2020-01-15 thestig@chromium.org Roll third_party/zlib/ f262c1b3c..814da1f38 (3 commits) 2020-01-15 thestig@chromium.org Roll base/trace_event/common/ 5e4fce17a..81c050f85 (1 commit) 2020-01-15 thestig@chromium.org Roll third_party/android_ndk/ 89e8db0cd..27c0a8d09 (1 commit) 2020-01-15 tsepez@chromium.org Move PDFSDK_XFAAActionType from cpdfsdk_fieldaction.h to cpdfsdk_widget.h 2020-01-15 thestig@chromium.org Refactor CFX_ImageTransformer::Continue(). 2020-01-15 tsepez@chromium.org Unify PWL right click handling under xfa/non-xfa. 2020-01-15 thestig@chromium.org Add a pixel test that uses type 3 font. 2020-01-15 dhoss@chromium.org Update pdfium_diff printf messages to use the current binary name Created with: gclient setdep -r src/third_party/pdfium@c86e356c31a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I5c9d4fc6b4738ced8b4d3ea694ac6ef72cd7da82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003643Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732274}
-
Yue Zhang authored
Bug: 1035869 Change-Id: If0af6b3bc0f9730f3962e06e21df00b837d6a784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003908 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#732273}
-
Leon Han authored
DOMString data source is always encoded as utf-8. The spec change: https://github.com/w3c/web-nfc/pull/522 BUG=520391 Change-Id: Iec3d923d169f7a61937eda5249a57c6803598678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991972 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#732272}
-
nancy authored
This CL is used to integrate Crostini's context menus for app list to AppService: https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/crostini/crostini_app_context_menu.cc?l=57 https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/crostini/crostini_app_context_menu.cc?l=34 BUG=1038487 Change-Id: Icde50aaf93cd961476f46a6652112005fe4a3ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002554Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#732271}
-
Will Cassella authored
This implements the API outlined in the explainer here: https://github.com/immersive-web/lighting-estimation Initial components of this implementation were done by bialpio@. Bug: 1034135 Change-Id: I98ba7d3e7c166c6ac2254efae4f5b79e4bb95f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965850Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#732270}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4cf1874981c3..7edb0eb8a458 git log 4cf1874981c3..7edb0eb8a458 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 jvanverth@google.com Revert "Reland "Add new method for storing DrawOpAtlas texture index."" 2020-01-15 jlavrova@google.com RTL Paragraph + all it causes 2020-01-15 herb@google.com Redo glyph quad regeneration 2020-01-15 mtklein@google.com fix SkMatrixConvolutionImageFilter unpremul 2020-01-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-01-15 csmartdalton@google.com Add a temporary job to test GrGpuTessellationPathRenderer 2020-01-15 reed@google.com experimental: saveCamera() 2020-01-15 halcanary@google.com docs/examples: REG_FIDDLE_ANIMATED Created with: gclient setdep -r src/third_party/skia@7edb0eb8a458 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: I88382145ebaf55ecd4405fafa9894a9d905fa201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003755Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732269}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=emaxx@chromium.org Bug: 1041419 Change-Id: I1bc4cdc82b44fbc1da1cedc429708e0aa58717ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998264 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732268}
-
Rob Schonberger authored
By default, we mark any touch that has a ABS_MT_TOUCH_MAJOR == major_max (as given in device info) to be a palm. For some experimental situations, we often receive a genuine TOUCH_MAJOR of this magnitude. We want to be able to treat that as normal. Adds a Feature, and set it at construction time - this avoids looking through features on every single touch. Adds a unit test appropriately to test for this change in behavior (and that current behavior is maintained). Bug: 1009290 Change-Id: I4f1c3b2d4733ff00cb13814db4dad834baeb8977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003166Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#732267}
-
Meredith Lane authored
This reverts commit b1af29a5. Reason for revert: Crashes ash_unittests on linux-chromeos-dbg First failure: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/16451 Original change's description: > tablet: Fix double shelf when entering guest mode. > > The issue was the window was created on startup, then OnGetSwitchStates > triggers TabletMode to start and create the screenshot since it detects > a window animating. But the window doesn't destroy the screenshot because > a |fps_counter_| is not detected on animation end because it is created > in on animation schedules which happened before entering tablet mode. > > This CL aims to prevent this and similar bugs by not taking the screenshot > if a window is already animating, so the only observed animation is the > one triggered by entering tablet mode. This may have missed data or > performance in some cases, but will prevent similar bugs. > > Test: ash_unittests TabletModeControllerScreenshotTest.EnterTabletModeWhileAnimating > Bug: 1035356 > Change-Id: I601d08ef50f214dbd262e5eea6baed40e5596270 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999241 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732159} TBR=xdai@chromium.org,sammiequon@chromium.org Change-Id: I738e9d46e2a9c7aa00305ba5ecf3c203ac872ecb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1035356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004177Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#732266}
-
Thomas Guilbert authored
Callbacks passed to video.requestAnimationFrame are never called when using webRTC. This is because webRTC uses WebMediaPlayerMS instead of WebMediaPlayerImpl, and it does not override the RequestAnimationFrame() method. This CL implements the method and fixes the issue. Bug: 1035028, 1012063 Change-Id: I1792dfd6f6077e6e49c39f23e607e7868611293e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987069 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732265}
-
Tao Bai authored
This - reduces unnecessary calls from native to java. - makes it possible to add observer in native side. Bug: 1042048 Change-Id: I0e5c32b98adfb56ac408556f9a0fcbd209b5813c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001747Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#732264}
-
Rachel Sugrono authored
Add a test that tab-index key focus works correctly (the tab-indexable elements are cycled through in order) when Quick View is displaying a video file in its content panel. Tab past the content panel to skip over checking the focus on the content webview/video: these can have multiple internal elements that can take the focus and our test should be independent of that. Bug: 907380 Change-Id: Ie7f6de4a4ab5487ed62fc30361674ac1d55de057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004172 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#732263}
-
Dan Beam authored
CL generated with: $ git ls-files 'components/*.js' | xargs grep -l -P ' [!=]= (?!null)' | xargs perl -p -i -e 's/ ([!=])= (?!null)/ \1== /g' Bug: 720034 Change-Id: Ie01258dadf0dea819405a03d064c6767d8da96e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003638 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#732262}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/cb3f04f584a53844546aaa32e949534c453185aa..98b4cdba1e4ede26d845bcae8185ddb5b2feea93 The following commits have update notes: 0df6edff4 Split BN_prime_checks into two constants for generation and validation. Bug: none Change-Id: Ia16ddb85756277144fc0ea410fb2b31840bf9332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998162 Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#732261}
-
Rachel Sugrono authored
Add a test that tab-index key focus works correctly (the tab-indexable elements are cycled through in order) when Quick View is displaying a audio file in its content panel. Tab past the content panel to skip over checking the focus on the content webview/audio: these can have multiple internal elements that can take the focus and our test should be independent of that. Bug: 907380 Change-Id: Ifd8b298865c05cbfcc318e63b0d701fb6ca8f7d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004171Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Rachel Sugrono <rsugrono@google.com> Cr-Commit-Position: refs/heads/master@{#732260}
-
Alexandre Courbot authored
When the resolution changes, we recreate the image processor device entirely. However we used to do so while reusing the same V4L2Device instance, which is not supported and triggers a DCHECK() with Debug builds. This behavior is wrong anyway since we might want to use another image processor device with the new resolution. This also seems to be effective in fixing bug 1029396. BUG=chromium:1029396 TEST=video.DecodeAccel.h264_resolution_switch passes 100 times in a row on Hana. TEST=video.DecodeAccel.h264_resolution_switch passes on Hana without triggering DCHECK(). Change-Id: Ib506d9f038810a0683b806f8385746dce16ecd56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002250 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#732259}
-
Peter Boström authored
Fixes regression in r728281. The code started assuming that a BrowserActionsContainer always existed, this is not true for windows without a tab strip. Bug: chromium:1042419 Change-Id: Ia69257972ebe08d58a878722a42821730ebcc7b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003220 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#732258}
-
Dan Beam authored
CL generated with: $ git ls-files 'chrome/renderer/*.js' | xargs grep -l -P ' [!=]= (?!null)' | xargs perl -p -i -e 's/ ([!=])= (?!null)/ \1== /g' Bug: 720034 Change-Id: I64e170031fdd2087dd3adf50276228fbfaf6fd57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003917 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#732257}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I6de271cd0349c33500203d3d4d87d2600932bbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003084Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732256}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=boliu@chromium.org Bug: 1041419 Change-Id: Ied9d082ee57276d5b82983e6b42ee7914dea9eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998672 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732255}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=ntfschr@chromium.org Bug: 1041419 Change-Id: I24f1a8ce0a32854fad3be2f645dd801f20e583ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998381 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732254}
-
Tom Anderson authored
The test should hopefully no longer be flaky after 0896c15f. R=atwilson Change-Id: I643298557d70d3b48163f7ba232ae5c31f0cb039 Bug: 701023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003613 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#732253}
-
Meredith Lane authored
This reverts commit 143d21fd. Reason for revert: Deterministically fails gfx_unittests on Mac 10.12 First failure: https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/31106 Original change's description: > Remove ignorable codepoints for FontFallback > > Default ignorable codepoints should not be considered for > choosing a fallback font. > > see: > http://www.unicode.org/L2/L2002/02368-default-ignorable.pdf > """ > Default-ignorable codepoints are those that should be ignored > by default in rendering (unless explicitly supported). They have > no visible glyph or advance width in and of themselves, although > they may affect the display, positioning, or adornment of > adjacent or surrounding characters. > """ > > The API used to determine fallback fonts on Mac is > CTFontCreateForString(...) > 1) This API can returns .LastResort for an unknown text. > We observed this behavior with Emoji (e.g. regional flags). > see: > https://unicode.org/policies/lastresortfont_eula.html > > 2) The API is not able to match default ignorable codepoints > like ZWJ and NZWJ. GetFallbackFont(...) was failing when > an ignorable codepoints is present and the expensive > GetFallbackFonts(...) is used instead. > > > Bug: 1036652 > Change-Id: I12a81a0130b072f662547abd0d82f73c24a7b20d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995501 > Commit-Queue: Etienne Bergeron <etienneb@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732133} TBR=robliao@chromium.org,drott@chromium.org,etienneb@chromium.org Change-Id: I5c9fa4078a1519fc044536befd5d8a6ed0ea2604 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1036652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004168Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#732252}
-
Matt Jones authored
Bug: 1041090 Change-Id: I7eb2c11717bfff33c98db123d511f8b867fc8961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003572 Auto-Submit: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#732251}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=rbyers@chromium.org Bug: 1041419 Change-Id: Ibabc077d7f35f4e25d9c0c30964bc5cf9cf5be0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998790 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732250}
-
Kyle Horimoto authored
Now contains cr_components/chromeos and cr_elements/chromeos. Change-Id: I99b40bf8d81e7cb3a48c8f73ac06aca570dfc904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003148 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#732249}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/737bab4e36f5..c885431d04db Created with: gclient setdep -r src-internal@c885431d04db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1010717,chromium:1034098,chromium:1041468 Tbr: jbudorick@google.com Change-Id: I93a35f1c090388c87f86048cfafe89ac2b11c963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003927Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732248}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0c66bcd13a54..0ecc48ecb7a1 git log 0c66bcd13a54..0ecc48ecb7a1 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 natlee@microsoft.com Handle DeviceLost error Created with: gclient setdep -r src/third_party/dawn@0ecc48ecb7a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I76c2586baaf2abb36f44191679328e89d3516189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003549Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732247}
-
Dan Harrington authored
Change-Id: I61465c05b77282e229bf472a57f044c092fe4079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001121 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#732246}
-
Sara Kato authored
Currently arc_a11y_helper_bridge converts mojom actions to android actions, however it's cleaner if this handling is done in arc_a11y_util. Bug: b/145316954 Test: refactoring Test: ArcAccessibilityHelperBridgeTest.* passes Change-Id: I48e1367a479bfc2d44664c2c4de6ce96eda44daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975478 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#732245}
-
Hiroki Sato authored
This change adds an extension API to set touch mode in ARC, which will be used in tast test. Bug: b:147116837 Test: tast run DUT arc.Accessibility* (crrev/c/1999865) Change-Id: I4bfdc11c5fec41e45207ceeffa0be0c985b172c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997436 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#732244}
-
Alex Newcomer authored
Increase for a few more milestones, this is soon to be deprecated. Bug: 1037252 Change-Id: I06d316ebd227a2938fff54196c3d86ce5e7ad6d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998459 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#732243}
-
Alexandre Courbot authored
This member is only used in one method, and its initialization is very simple: image processor if present, otherwise decoder. So perform this choice in the method where it is actually used instead of carrying this member for the whole life of the decoder and making sure it is updated properly, at the risk of introducing bugs. BUG=None TEST=Video playback working on Hana. Change-Id: I52e23fae9edb057ed618c2da0834f60ae88fccf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002249 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#732242}
-
Kent Tamura authored
This CL should have no behavior changes. Bug: 1040826 Change-Id: Iac5efeac96ddf437e3aa389c0669b0e19b131894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002268 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#732241}
-