- 31 Jan, 2020 40 commits
-
-
Eric Karl authored
Change-Id: Ib2b07973169a5cddf614b0a00f97a1edd15e67df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033590Reviewed-by:
vikas soni <vikassoni@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#737469}
-
sczs authored
If an there's an existent modal it means one is currently presented, or in the process of being presented. Configuring a new one would only cause InfobarCoordinator to hold pointers to a Modal that won't be presented. This CL prevents that by stopping any new configuration if a Modal already exists. It also removes modalNavigationController since we can get the NavigationController from the modal. Bug: 1040066 Change-Id: Ia2da22d67804e39780b19b78af2dcba58fa8a580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032565Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#737468}
-
Maksim Ivanov authored
Mark the DeviceSamlLoginAuthenticationType policy as "future", in order to hide it from the policy documentation. This policy is unused. It was originally intended for configuring the Chrome OS smart card user login feature for all users on the given device, but the design was later changed to support users of both types (smart card and non smart card) on the same device, by determining the case dynamically. BYPASS_POLICY_COMPATIBILITY_CHECK=policy was never used Bug: 826417 Change-Id: If76b55076d09d5c09e985a3730bf954c72a9f963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030898Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#737467}
-
Dominik Röttsches authored
This reland fixes the sequenced task runner initialisation. Set the task runner in the constructor and reset it for each unit test execution. Since there may be multiple instance of DWriteFontProxyImpl instantiated for multiple RenderProcessHosts, and DWriteFontProxyImpl::GetUniqueNameLookupTable may access DWriteFontLookupTableBuilder::QueueShareMemoryRegionWhenReady from separate threads, there may be race conditions around the pending_callbacks_ member of DWriteFontLookupTableBuilder. Sequentialise and guard access to pending_callbacks_ with a separate sequenced task runner. Remove explicit configuration of the FontUniqueNameBrowserTest cache directory as [1] introduced a callback function in ShellContentBrowserClient which sets this correctly. This avoids instantiating DWriteFontLookupTableBuilder too early when the ThreadPool is not yet available in a BrowserTest. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1776358/9/content/shell/browser/shell_content_browser_client.cc#422 Fixed: 1047054 Change-Id: I38cf8b84a48315980624b68bbf55d3727be457b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032119Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#737466}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 27802b89. With Chromium commits locally applied on WPT: d455934d "Clamp the presentation time to a usable range" 4a9e20a2 "[ElementTiming and LargestContentfulPaint]Fix background img sizes" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I836d46d366b37cf2e71f57ca653dc70f3ed8453f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032306Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737465}
-
Maksim Ivanov authored
This fixes the following warning that was printed almost unconditionally: "Ignoring untrusted value of the extensions.install.login_screen_extensions pref" Also the CL removes unnecessary handling of the nullptr pref value, as this case should never occur. Bug: 1012892 Test: verify that no "Ignoring untrusted value" log appears in browser_tests --gtest_filter="SigninProfileExtensionsAutoUpdatePolicyTest.Test" Change-Id: I41a18ae371b3b9a01fe9a6926731e5550fd0987f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029507Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#737464}
-
Pete Williamson authored
Change-Id: I8ef8ec496ab0fb8857db60d1d8aeb55212b23bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033542 Commit-Queue: Peter Williamson <petewil@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Auto-Submit: Peter Williamson <petewil@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#737463}
-
OlivierLi authored
Bug: 1047269 Change-Id: Idc9e1547a2be65ff638429ecffcdd6c5149c1b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031753Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#737462}
-
Xida Chen authored
The crashes caused by this DCHECK happens when a begin-impl-frame reports no damage, and then presented without frame end. This CL fixes it. Bug: 1043091 Change-Id: Idaef2477f7f2904fec87b202c47a3a9be6b95c42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018084Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#737461}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/62c4aa446733..7b8eb884cfd6 git log 62c4aa446733..7b8eb884cfd6 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 tsepez@chromium.org Make all CXFA_FFWidget observe their CXFA_FFPageview. 2020-01-31 thestig@chromium.org Fix various build/include_order lint errors. 2020-01-31 thestig@chromium.org Give some .in test files better formatting. 2020-01-31 tsepez@chromium.org Remove dwCoordinatesType arg from GetPageMatrix(). 2020-01-31 thestig@chromium.org Reduce the number of calls to HasPermissions(). 2020-01-31 thestig@chromium.org Move permission constants to constants/access_permissions.h. 2020-01-31 dhoss@chromium.org Run tests with --disable-xfa in coverage_report.py Created with: gclient setdep -r src/third_party/pdfium@7b8eb884cfd6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1010844,chromium:1042915 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I6415f31dfba3a5156486c3f53cb14e64d455c30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033586Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737460}
-
Hidehiko Abe authored
cros_supported_configs_ is defined iff OS_CHROMEOS is defined. However, it is used iff USE_CHROMEOS_MEDIA_ACCELERATION regardless of OS_CHROMEOS. This CL aligns the conditions. BUG=1047719 TEST=Build locally. Change-Id: I08fe8532c1778ff8c77c7a9d9cdd96ff2a83272f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030924Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#737459}
-
Kyle Horimoto authored
This CL introduces Mojo enums for settings section names and page visibility as well as a SettingsUserAction class and several derived classes which encapsulate user actions in settings. Bug: 1047062 Change-Id: I04d1648ade1f8b25dc83c2f32805a22bd4c23458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030000Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#737458}
-
Elly Fong-Jones authored
One of these retains a callback method on the object; the other uses the lambda-captures-&controller pattern. Bug: 1011446 Change-Id: Ic5ea4f6231a94e3e6d14d646bb78f00220e90ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032231Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#737457}
-
Ben Joyce authored
Bug: 1021634 Change-Id: I7ac7a2ea5a9bdcc5a244057f74bc8305773546ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026150 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#737456}
-
Nick Diego Yamane authored
This is a reland of 97332534 Original change's description: > x11: Ensure XEvent translation is equivalent to ui::Event ctors > > This is part of the patch series migrating PlatformEvent to ui::Event > (formerly using XEvent) in Aura/X11 in order to eliminate this > fundamental difference/incompatibility between Ozone and non-Ozone X11 > ports. Design doc [1] describes in details such effort. > > This CL, particularly, is meant to ensure XEvent => ui::Event > translation code (x11_event_translation.{h,cc}) is equivalent to > constructing ui::*Event using the PlatformEvent ctors, the mechanism > used so far to do such "translation". > > To achieve it, events_unittests have been modified to use the brand new > X11 event translation code as well as fixing discrepancies found along > the way. Most of them are trivial and this change does not bring any > behavioral change. > > [1] https://docs.google.com/document/d/1Neh2p6f8pew9SPuEAtnJMafozAY7uhAIfhwd43CLETc > > Bug: 965991 > Change-Id: I1b738fd20c21233a611a0661b76da7fcdf176613 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022322 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736213} Bug: 965991, 1047005 Change-Id: I07d7ced6460845faa36d91b7e38bae10ff4697c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028408 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#737455}
-
Chong Gu authored
Disable skia_gl renderer for Fuchsia since it's not supported Bug: 1043399 Change-Id: I44a25bb3745282b701ba86ad44c19b8a466f39b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008235Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#737454}
-
Yusuke Sato authored
The plan is to stop using the platform2 functions sometime soon. BUG=b:144199481 TEST=try Change-Id: Iad53b4818459b31bd43d6065191ccd0c6403bbda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032721 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#737453}
-
Frank Liberato authored
This CL causes dxva video decoder to send the output metadata for the display, even if the stream doesn't provide metadata of its own. For AMD cards, this CL also causes it to send empty stream metadata, rather than omit sending it. Otherwise, it crashes intermittently. Bug: 1045586 Change-Id: If0a478bade4453c235f9f6d77c453e6ea3c179e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020744Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#737452}
-
Orin Jaworski authored
This CL updates pedal logic to work with and without the button row feature enabled. Pedals may attach to matches that also have tab-switch and keyword buttons. ExecutePedal is used instead of OpenMatch when the intent is to perform the pedal action. Bug: 1046523 Change-Id: I5a46383ca716df2f41f21eec3ffcf2969e7ab593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032189Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#737451}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb93f7b380bc..f18fddd279d2 Created with: gclient setdep -r src-internal@f18fddd279d2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ib4900706c7f5527bd273a64020e0935cc0f3bc8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033420Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737450}
-
Daniel Rubery authored
download_stats.cc has removed the histograms that needed to be kept in sync with download_file_types.asciipb, so we no longer need to edit it when updating download file types. Change-Id: Ica4fb0027f1d1f029c6ac5ef1eedeb1c26e8fb7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033434 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#737449}
-
Patrick Monette authored
The ModuleDatabase was moved to its own sequence but both the IncompatibleApplicationsBrowserTest and ThirdPartyBlockingBrowserTest test fixtures were not updated. This CL moves the accesses to the ModuleDatabase instance to the right sequence. Also added an override for the OutOfProcessQuarantine feature to allow local testing. This was not an issue on the bots because they respect the fieldtrial_testing_config.json file. Bug: 850517 Change-Id: I2e8955b33cd7ffc75f74dd56b01df9dec96fc604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031742 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#737448}
-
Robin Lewis authored
This would otherwise be created once a user logs in. This reduces friction if the admin wants to set registry entries before anyone has signed in. Bug: 1047460 Change-Id: I035717a3c46513a23540f9b19274841b5eff3667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031872Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Robin Lewis <wrlewis@google.com> Cr-Commit-Position: refs/heads/master@{#737447}
-
Eric Orth authored
Fix a missing nullptr initialization. Original change: https://chromium-review.googlesource.com/c/chromium/src/+/2003256 Change-Id: I5aa663c8273449c0e77f526c55097eb288edb72d Bug: 1047641, 1022059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032787 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#737446}
-
Alex Ilin authored
This CL adds an implementation of a dummy Reauth dialog to SigninViewController. This dialog is needed only for developer needs and should never be shown in production. The dialog is hidden behind "SigninReauthPrompt" feature flag. This CL also adds minor details to the comment of SigninViewController::ShowReauthPrompt() method. Bug: 1045515 Change-Id: I74b066157ddfa3d697f12e45511c9cbdceaf1c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030766Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#737445}
-
Sigurdur Asgeirsson authored
It's been a couple of years since this code was used, and the oncoming refactoring will be easier without this in the way. Bug: 1044707 Change-Id: Ic6e07b8f3ce61312d2c5a89d8af9850ea7510a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032230Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#737444}
-
Josh Simmons authored
Bug: 1030813 Change-Id: Ic368d70f3d78a49ea280f70cc795935e11cdc264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031428 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#737443}
-
Mugdha Lakhani authored
Create the UrlBarController interface and a simple version of the method createUrlBarView() without UrlOptions. Use it in WebLayerShellActivity to show a URL bar. UrlBarController updates url text whenever the visible URL changes. This means that the embedder doesn't have to listen to onVisibleUriChanged and create a new URL Bar view. Bug: 1025607, 1044571 Change-Id: I83bff6f82354ab970dbd84d3d24e5fac2cf66db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017408 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#737442}
-
David Tseng authored
Bug: 1046430 Change-Id: I583b0ac6928a1c209368507f427c0c40dbd22c04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026110 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#737441}
-
Patrick Monette authored
This will allow the WorkerTaskProvider to do accurate bookkeeping on running shared workers, even though it dynamically subscribe and unsubscribe to the SharedWorkerService while some workers are already running. Bug: 1041093 Change-Id: I4480eff07b9735d7b0b2132caaed75a7e78311d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015565 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#737440}
-
Kevin Schoedel authored
Occasionally a WebContentController is destructed before we have received RenderViewDeleted notifications for all observed RenderWidgetHosts. Therefore, it is not safe to call RemoveInputEventObserver on every RenderWidgetHost that we started observing; we need to remove only from currently live RenderWidgetHosts. Bug: b/148227677 Change-Id: Ic9a7a4f187eb154665fc2ad093dd9464f7520e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020246 Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Albert Chaulk <achaulk@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#737439}
-
Ryan Hamilton authored
https://quiche.googlesource.com/quiche.git/+log/278efaec3531..4c93e8d76db8 $ git log 278efaec3..4c93e8d76 --date=short --no-merges --format='%ad %ae %s' 2020-01-30 wub gfe-relnote: Enhance the error_details of QUIC_NETWORK_IDLE_TIMEOUT and QUIC_HANDSHAKE_TIMEOUT errors. No behavior change except the error message. 2020-01-30 fayang Instead of checking handshake done frame received, just check both endpoints' handshake state is HANDSHAKE_CONFIRMED. There is a possibility where HANDSHAKE_DONE frame is received before observer gets set. 2020-01-30 bnc Do not send PRIORITY_UPDATE frame if it does not change priority. 2020-01-30 bnc Refactor MaybeSendPriorityUpdateFrame(). 2020-01-30 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_enable_lifo_write_scheduler. 2020-01-30 bnc Do not send PRIORITY_UPDATE from server. 2020-01-30 bnc Add HTTP2_CODE_COUNT_N API and decompress_failure_3 counters to debug source of DECOMPRESS_FAILURE errors. 2020-01-29 renjietang Grease HTTP/3 settings. 2020-01-29 dschinazi Improve QuicFramer testing of retry 2020-01-29 ianswett gfe-relnote: Inline QuicConnection::MaybeSetAckAlarmTo because it's only used in one place. No functional change, not flag protected. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I77d441e23cc6750a7b872613a046326340f7bb27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032011Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#737438}
-
Andrew Xu authored
Due to the side effect from https://crrev.com/c/1988855, auto-hide shelf is hidden after opening the system tray. Update on the shelf's visibility state is triggered by the visibility change of system tray. However, calculation on the auto-hide state depends on the state of tray bubbles which are created/destructed after the visibility change. This CL delays the update on the shelf's state when the visibility of system tray changes. In addition, a test case is added for this scenario. Bug: 1046464 Change-Id: I72d48b5872ca9efc8160c9fd6bba6bd55addfa43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028766Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737437}
-
Ken Rockot authored
This is a fairly thorough rewrite of the StorageArea mojom interface and the related StorageAreaObserver interface. A very brief summary of the changes is: - StorageAreaObserver is no longer associated with StorageArea - The Blink DOM Storage implementation no longer relies on StorageArea replies being ordered against StorageAreaObserver events - CachedStorageArea no longer resets its StorageAreaObserver connection once established - All storage mutations (or failed mutations) now result in a StorageAreaObserver event. Follow-up changes should be able to simplify IPC further by removing StorageArea message replies, removing some redundant messages, and possibly reducing the complexity of the different caching modes. Rough preliminary proposal: https://docs.google.com/document/d/1N27aEvjJa-3t_kunyyGATlmTyuTU8HNkv0sLDgZCLGM/edit Bug: 1000959 Change-Id: I810626eda9e5f409b8f08439ab66801dd7376a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025873 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#737436}
-
Vincent Boisselle authored
Change-Id: I87319ac1548bde596dedeb65fa8f02c762590734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032229Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#737435}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/55890e1afe33..41a7302e9c62 git log 55890e1afe33..41a7302e9c62 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 capn@google.com Split JIT creation from LLVMReactor.cpp into LLVMJIT.cpp Created with: gclient setdep -r src/third_party/swiftshader@41a7302e9c62 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Iaa474736e15f998f73640603ab90c6cf464fce0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033417Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737434}
-
sczs authored
The modal will be presented from an Infobar banner (which might change in subsequent CL's). Adds a forward GURL declaration on InfobarSaveCardModalDelegate Bug: 1029067 Change-Id: I6d4f69aa69ced0b93b46b36809b229cdf6b6fd05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028743Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#737433}
-
Robert Ogden authored
Adds mainframe to the name to clarify its purpose. No behavioral changes. Bug: 1023483 Change-Id: I88fb202f350d088cc5b0a5b41873bc6e40b457de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032715 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#737432}
-
Jeffrey Kardatzke authored
This code appeared wrong because it was locally allocating buffers for the planes and then wrapping them in a VideoFrame which marked them as unowned memory. The memory would be deallocated after the call to Encode completes, and that posts a task so when the memory is actually accessed later it would be invalid. The V4L2 VEA also expects to receive owned memory on input buffers as well. other patches for buffer allocation unrelated to this) Bug: None Test: CacheLineUnalignedInputTest/** passes for I420 on trogdor (w/ Change-Id: I4552d803e5572f3f155dd984a273a1c0ffbc4b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032050Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#737431}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4ada8ab49f7b..4d67872733ec git log 4ada8ab49f7b..4d67872733ec --date=short --first-parent --format='%ad %ae %s' 2020-01-31 agable@chromium.org Enable recipe-roller autosubmit Created with: gclient setdep -r src/third_party/depot_tools@4d67872733ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:773529 Tbr: agable@chromium.org Change-Id: I1ca7a01095efc36f6517e6b35221a12d641f5da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033415Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737430}
-