- 26 Sep, 2014 40 commits
-
-
isherman authored
BUG=none TEST=none R=tengs@chromium.org Review URL: https://codereview.chromium.org/604213002 Cr-Commit-Position: refs/heads/master@{#296988}
-
dzhioev authored
List of added resources: * PNG illustation (1x and 2x). * Three styles of Roboto font. * SVG icon. optimize-png-files.sh was applied to added PNG files. Icon was not added to 'chrome_unscaled_resources.grd' because it will be inlined to HTML. BUG=375191 Review URL: https://codereview.chromium.org/607473004 Cr-Commit-Position: refs/heads/master@{#296987}
-
nyquist authored
For every successfully distilled article a word count is submitted to UMA. The histogram ranges from 1->4000 words with 50 buckets. Changes rolled in from the DOM Distiller repo: bbf7c01 Add StatisticsInfo to DomDistillerResult proto for number of words. fc1a5c1 treat non-breaking space as whitespace de38c78 Expand usage of SimilarSiblingContentExpansion 444a55e reorder table tests 5ff895b add and fix missing tests to suite 970a419 Add SimilarSiblingContentExpansion da76b1e add new table classification heuristic BUG=417049 Review URL: https://codereview.chromium.org/608583003 Cr-Commit-Position: refs/heads/master@{#296986}
-
sunil.ratnu authored
This CL changes the return value of PasswordManagerClient::PromptUserToSavePassword to bool, indicating if the prompt was indeed displayed, and logs that appropriately through |logger| BUG=393138 Review URL: https://codereview.chromium.org/604293002 Cr-Commit-Position: refs/heads/master@{#296985}
-
Ben Smith authored
This is the same issue as in 8d01729a. MSVC 2013 now requires including <algorithm> to use std::{min, max}. BUG=none R=sbc@chromium.org Review URL: https://codereview.chromium.org/607923002 Cr-Commit-Position: refs/heads/master@{#296984}
-
xiyuan authored
BUG=412006 Review URL: https://codereview.chromium.org/599263002 Cr-Commit-Position: refs/heads/master@{#296983}
-
rijubrata.bhaumik authored
Review URL: https://codereview.chromium.org/591383002 Cr-Commit-Position: refs/heads/master@{#296982}
-
jmadill authored
This missing dependency could cause intermittent broken builds. BUG=417583 Review URL: https://codereview.chromium.org/605243002 Cr-Commit-Position: refs/heads/master@{#296981}
-
sandersd authored
BUG=133828 Review URL: https://codereview.chromium.org/491163002 Cr-Commit-Position: refs/heads/master@{#296980}
-
zmo authored
BUG=418019 TEST=linux bots, content_browsertests TBR=viettrungluu@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/612483002 Cr-Commit-Position: refs/heads/master@{#296979}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/e48d3d4..6254fdf TBR=ager@chromium.org,zmo@chromium.org Review URL: https://codereview.chromium.org/607133002 Cr-Commit-Position: refs/heads/master@{#296978}
-
igsolla authored
AwContents are deleted asynchronously, so to stop receiving callbacks we unregister delegates / observers / listeners from AwContents.destroy() and ContentViewCore.destroy(). Receiving callbacks after AwContents.destroy() is called is problematic because Java refs have already been set to null. BUG=415666 Review URL: https://codereview.chromium.org/594103002 Cr-Commit-Position: refs/heads/master@{#296977}
-
aurimas authored
BUG=None Review URL: https://codereview.chromium.org/607953002 Cr-Commit-Position: refs/heads/master@{#296976}
-
jackhou authored
Previously, setShape({'rects': []}) or setShape({'rects': [{left:0, width:0, top:0, height:1}]}) would make the window completely transparent, but still capture input. This was because ShapedAppWindowTargeter::GetHitTestMask returned false if the shape was empty. It now returns false only if the shape is NULL. BUG=417014 Review URL: https://codereview.chromium.org/602013002 Cr-Commit-Position: refs/heads/master@{#296975}
-
nyquist authored
Currently the DOM Distiller does not work in incognito, since the source for the chrome-distiller:// scheme has not been registered. This CL moves the functionality for registering the scheme to a generic place and it is now used by both ProfileImpl and by OffTheRecordProfile during profile creation. It also makes both the normal profile and the incognito profile use the same instance of the DomDistillerService. BUG=380036 Review URL: https://codereview.chromium.org/608653002 Cr-Commit-Position: refs/heads/master@{#296974}
-
bcwhite authored
BUG=413744 Review URL: https://codereview.chromium.org/611543002 Cr-Commit-Position: refs/heads/master@{#296973}
-
gavinp authored
After we're sure we have fixed 317138, let's drop these CHECKs. Also, celebrate! R=ttuttle@chromium.org BUG=317138 Review URL: https://codereview.chromium.org/509993002 Cr-Commit-Position: refs/heads/master@{#296972}
-
gunsch authored
R=lcwu@chromium.org,byungchul@chromium.org BUG=None Review URL: https://codereview.chromium.org/603243003 Cr-Commit-Position: refs/heads/master@{#296971}
-
dmazzoni authored
Previously a focus ring was only drawn around web elements; this uses a new API to draw the focus ring around native views, too, by adding a new field to the existing private accessibility API with the bounding rect of the focused view. BUG=314889 Review URL: https://codereview.chromium.org/600063002 Cr-Commit-Position: refs/heads/master@{#296970}
-
stevenjb authored
We were passing a 'parent_window' parameter to the network_connect::ConnectToNetwork() in an effort to open network configuration dialogs from the desktop they were triggered from. This was never a good idea since gfx::NativeWindow is actually a pointer which may become invalid before the callback is triggered. In practice this is unnecessary since we decided that all network configuration applies to the primary user, so we should always use the currently active desktop to host the dialog (which is what GetNativeWindow() does in ash_system_tray_delegate.cc). BUG=413925 Review URL: https://codereview.chromium.org/607613002 Cr-Commit-Position: refs/heads/master@{#296969}
-
zea authored
sync_initialized() does not account for backup/rollback modes. For now we just manually check the backend mode. In the future the PSS will expose a better method for denoting when its safe to reconfigure. BUG=417400 Review URL: https://codereview.chromium.org/605483002 Cr-Commit-Position: refs/heads/master@{#296968}
-
gunsch authored
R=byungchul@chromium.org,lcwu@chromium.org BUG=332744 Review URL: https://codereview.chromium.org/605033003 Cr-Commit-Position: refs/heads/master@{#296967}
-
shuchen authored
BUG=367631 TEST=Verified with IME extensions on linux_chromeos. NOTRY=true Review URL: https://codereview.chromium.org/606553002 Cr-Commit-Position: refs/heads/master@{#296966}
-
guoweis authored
Counter will be accumulated for each OnIceCandidate callback and report once the IceGathering is completed. BUG=411086 Review URL: https://codereview.chromium.org/600163004 Cr-Commit-Position: refs/heads/master@{#296965}
-
qsr authored
Due to the following bug: https://code.google.com/p/android/issues/detail?id=76644, it is not possible in art to create an empty buffer for address NULL. This solve the issue by creating an empty buffer on a random address. This is not an issue as the memory will never be accessed. BUG=406848 R=ppi@chromium.org,yfriedman@chromium.org Review URL: https://codereview.chromium.org/601163002 Cr-Commit-Position: refs/heads/master@{#296964}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/2a007a0..e48d3d4 TBR=ager@chromium.org,zmo@chromium.org Review URL: https://codereview.chromium.org/608463005 Cr-Commit-Position: refs/heads/master@{#296963}
-
jrummell authored
BUG= Review URL: https://codereview.chromium.org/607693002 Cr-Commit-Position: refs/heads/master@{#296962}
-
earthdok authored
A recent security update changed the file, so the patch had to be rebased. BUG=313751 TBR=glider@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/610643002 Cr-Commit-Position: refs/heads/master@{#296961}
-
dmazzoni authored
BUG=408809 Review URL: https://codereview.chromium.org/541903002 Cr-Commit-Position: refs/heads/master@{#296960}
-
noms authored
Screenshots: https://drive.google.com/open?id=0B1B1Up4p2NRMc28yXzJuRFRZbWs&authuser=1 TL; DR: - never show a drop down arrow in the button. This means we can do s/MenuButton/LabelButton - if there is one local, non-signed in profile, show a tiny button with a generic avatar - in all other cases, show the avatar button with the profile name - updated the button insets so that the icons are centered correctly in the button - the new tab button should completely slide under the avatar button - because of this, I made public the new tab button width (and height, to be consistent) BUG=410946 Review URL: https://codereview.chromium.org/598163002 Cr-Commit-Position: refs/heads/master@{#296959}
-
qsr authored
This is a reland of https://codereview.chromium.org/607513003 with the fix for the failing test. BUG=417707 TBR=sdefresne@chromium.org Review URL: https://codereview.chromium.org/612443002 Cr-Commit-Position: refs/heads/master@{#296958}
-
timvolodine authored
Fix the number of buckets in Tabs.ScrubDistance. Currently the value 19 falls in the bucket with value 18 which is confusing. Results can be checked on uma.googleplex.com. BUG= Review URL: https://codereview.chromium.org/551893002 Cr-Commit-Position: refs/heads/master@{#296957}
-
damienv authored
BUG=376450 Review URL: https://codereview.chromium.org/599123002 Cr-Commit-Position: refs/heads/master@{#296956}
-
plundblad authored
BUG=394284 Review URL: https://codereview.chromium.org/598003002 Cr-Commit-Position: refs/heads/master@{#296955}
-
treib authored
Update the AvatarMenu (and the ProfileChooserView, which listens for changes to the AvatarMenu) when a supervised user's custodian info changes. BUG=372381 Review URL: https://codereview.chromium.org/597783003 Cr-Commit-Position: refs/heads/master@{#296954}
-
rmcilroy authored
BUG=418029 Review URL: https://codereview.chromium.org/605073003 Cr-Commit-Position: refs/heads/master@{#296953}
-
penghuang authored
BUG=417408 Review URL: https://codereview.chromium.org/601293003 Cr-Commit-Position: refs/heads/master@{#296952}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/0f037ba..2a007a0 TBR=ager@chromium.org,zmo@chromium.org Review URL: https://codereview.chromium.org/602043005 Cr-Commit-Position: refs/heads/master@{#296951}
-
timvolodine authored
Fix number of buckets in AsyncDNS.ServerCount and SyncDNS.ServerFailureIndex UMA histograms. Currently the value 9 falls in the bucket with value 8 which is confusing. Results can be checked on uma.googleplex.com. BUG= Review URL: https://codereview.chromium.org/551873002 Cr-Commit-Position: refs/heads/master@{#296950}
-
asanka authored
If the cause of a rename failure is suspected of being transient (sharing violations, suspected race conditions in the file system), then retry the rename with an exponential backoff. BUG=368455 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278483 Reverted (Win XP issues): https://chromium.googlesource.com/chromium/src.git/+/d31e3689a5f5a0ae6eba1f15ea299bf84fd6d381 Review URL: https://codereview.chromium.org/319603003 Cr-Commit-Position: refs/heads/master@{#296949}
-