- 05 Aug, 2020 40 commits
-
-
Rakina Zata Amni authored
Currently if a page has beforeunload/unload handlers, it will block sudden terminations (e.g. tab closing) from happening before it has a chance to run the handlers. This CL makes it so that pagehide & visibilitychange handlers have that power too, to make sure they cover all the cases where unload handlers are fired. Bug: 987409 Change-Id: I685245b863c2976caaea9198665f941ecdedee3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288711 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#794892}
-
Wenbin Zhang authored
As part of the progress of removing reference build from perf waterfall, this CL disabled the reference builds on system_health.common on all platforms, i.e., system_health.common_mobile.reference is no longer running on: Android Nexus5 Perf, Android Nexus5X WebView Perf, android-go_webview-perf, android-go-perf, android-pixel2_weblayer-perf, android-pixel2_webview-perf, android-pixel2-perf system_health.common_desktop.reference is no longer running on: linux-perf, mac-10_12_laptop_low_end-perf, mac-10_13_laptop_high_end-perf, win-10_laptop_low_end-perf, win-10-perf More details can be found in: go/ref-builds-prd go/chromeperf-refless Bug: chromium:1108663 Change-Id: I9b0bee9818b74f2a26fb0ed5fbc0286526dfac56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337380Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#794891}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f8ccdc63a188..23c5b63d1c68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie92fc10db9bca3cf0aea107cbee1a6f92821349c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338033Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794890}
-
Kent Tamura authored
According to the legacy layout behavior, WebKit behavior, and Firefox behavior, margins of a LEGEND should not affect block-direction position of the LEGEND. The border-box of the LEGEND should be centered vertically in the top border of the FIELDSET. - We should compare the block-start border width of the FIELDSET and the block size of the LEGEND border-box. - Even if the block size of LEGEND border-box is smaller than the block-start border of the FIELDSET, block-end margin of the LEGEND can affect the position of the FIELDSET content box. This fixes legend-after-margin-with-before-border-horizontal-mode.html and legend-small-after-margin-before-border-horizontal-mode.html, and the major part of legend-block-margins-2.html. Test changes: * NGFieldsetLayoutAlgorithmTest.LegendBreakBeforeAvoid The test assumed a break happened in the block-start margin of a LEGEND. We ignore the block-start margin, and the test broke inside the LEGEND. Add 'break-inside:avoid' to avoid breaking inside the LEGEND. * NGFieldsetLayoutAlgorithmTest.MarginTopPastEndOfFragmentainer Removed. The test made sure that if a break happens inside the block-start margin of a LEGEND, the reaiming block-start margin was ignored. We ignore the block-start margin, so we can't test the behavior. Bug: 875235 Change-Id: I78db12c42d5d1d5a928b7871838a5330f4b6943a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331995 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#794889}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ic58153b84d825e50f7f73ec5432ac104fa03a86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337720Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794888}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d24a19d42924..8076f2289388 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC horo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: horo@google.com Change-Id: I44fe9f02f33e84079313e9915d8d0be021156b65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337934Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794887}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596571199-429c5d3274b1adcffd4054f095f3cc2a5ada36c8.profdata to chrome-win32-master-1596585596-89744fc48a5c31a4a09c1357a13855640c06c65a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I018fe3e1466f2f8a31090456903b6c7efe594454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336872Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1596562698-892fa89488e0e796ec09ee348ea5782de7379276.profdata to chrome-win64-master-1596585596-c75cdf8296e7e3f8b1db14498223f15cea6443e5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I9c50bb60e3756070a9123544648fd58b033f393e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337937Reviewed-by:
-
chrome://flagsTsuyoshi Horo authored
This reverts commit 5da77d64. Reason for revert: Caused compile error. https://ci.chromium.org/p/chrome/builders/ci/win64-chrome/5437 [9650/14917] CXX obj/chrome/browser/browser/about_flags.obj FAILED: obj/chrome/browser/browser/about_flags.obj c:\b\s\w\ir\cache\goma\client\gomacc.exe ..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.e...(too long) ../../chrome/browser/about_flags.cc(6186,46): error: no member named 'kEnableTabSearchName' in namespace 'flag_descriptions'; did you mean 'kEnableSaveDataName'? {"enable-tab-search", flag_descriptions::kEnableTabSearchName, ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~ kEnableSaveDataName ../..\chrome/browser/flag_descriptions.h(358,19): note: 'kEnableSaveDataName' declared here extern const char kEnableSaveDataName[]; ^ Bug: 1113076 Original change's description: > Tab Search: Add chrome://flags entry for Tab Search > > This addition is necessary to allow users to disable the feature once > the experiment is enabled. > > Bug: 1099917 > Change-Id: I4e537a1fe92d1329c75ff8c190f92ce7f1cde8b7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336020 > Reviewed-by: Robert Liao <robliao@chromium.org> > Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794867} TBR=robliao@chromium.org,tluk@chromium.org Change-Id: I9e4778e201b2e61e1966ebb887930571e670dbdb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337049 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#794884}
-
Prakhar Asthana authored
This reverts commit 2940de50. Reason for revert: The reverted build failed: https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests/2902 The original CL doesn't seem to be the reason behind https://crbug.com/1112710. Original change's description: > Revert "Bring parity between mac coverage and non-coverage build" > > This reverts commit 25c59fc5. > > Reason for revert: Speculative revert for https://crbug.com/1112710 > > Original change's description: > > Bring parity between mac coverage and non-coverage build > > > > They have diverged since coverage build was first created. > > > > > > Bug: 1024915 > > Change-Id: Iec853bce25916efe7aea644c1a6ddcef4339a849 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335573 > > Commit-Queue: Prakhar Asthana <pasthana@google.com> > > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > > Auto-Submit: Prakhar Asthana <pasthana@google.com> > > Cr-Commit-Position: refs/heads/master@{#794288} > > TBR=liaoyuke@chromium.org,pasthana@google.com > > Change-Id: Ifd50ef6445af397abd08a953e9229d86809d25d7 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1024915, 1112710 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333841 > Reviewed-by: Kush Sinha <sinhak@chromium.org> > Commit-Queue: Kush Sinha <sinhak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794487} TBR=liaoyuke@chromium.org,sinhak@chromium.org,pasthana@google.com # Not skipping CQ checks because this is a reland. Bug: 1024915 Bug: 1112710 Change-Id: Ia75ff3b1ef2494274e38eebb3a0ded893a3a2ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336340Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Prakhar Asthana <pasthana@google.com> Cr-Commit-Position: refs/heads/master@{#794883}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/580a4b1d52b6..5ea3e861cd37 2020-08-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9852fd2d969dcad3887ebc15a49d9cfbb4450e4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337936Reviewed-by:
-
chrome-release-bot authored
This is a reland of d67d7452 Original change's description: > Updating trunk VERSION from 4223.0 to 4224.0 > > # This is an automated release commit. > # Do not revert without consulting chrome-pmo@google.com. > NOAUTOREVERT=true > TBR=pbommana@chromium.org > > Change-Id: If634e36bccdaf23712ecf376a6ff315c346875e7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332868 > Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#794839} Change-Id: I619563d769b591e301419355874f3249515e5ad7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337768Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#794881}
-
Noah Rose Ledesma authored
The MediaWebContentsObserver will notify the MediaSessionControllersManager of a device switch. In turn the appropriate MeiaSessionController will receive this message. Bug: 1110368 Change-Id: I1ceefdd6a0502384dfffba3ad6dedff21ba8b94e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323589 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#794880}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/10f019c5068f..bfcf8c4832c7 2020-08-05 herb@google.com simplify next allocation size If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: If1c42fd819f838bf18117e53271f2d4ebd977a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337451Reviewed-by:
-
Sven Zheng authored
This cl should not change any logic. Lucicfg tool had an update and caused 'lucicfg fmt' changed. This cl enabled lint, fixed some lint issues, and generated changes after running 'lucicfg fmt' inside infra/config. Change-Id: Id6b8cbde334075c2b549337eb12ee819f3ece211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316795 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#794878}
-
Maksim Sisov authored
There are some USE_X11 guards that I needed to fix. ----- PS: Please note that this is a temp solution that will help to choose between ozone and non-ozone X11 build. The switch that will be used to choose the path is --enable-features=UseOzonePlatform. Once non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how the finch trial goes), the wrapper will be removed. Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: I5562751867d876b0cbf6a4bde7e71daf2395d541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333842Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#794877}
-
Maksim Sisov authored
Enabling use_x11 && use_ozone results in running X11-only tests that cannot succeed for Wayland config. Thus, disable them (as it was before we started to work on use_x11 && use_ozone config) via checking for the feature flag instead of relaying on GN. I acknowledge that this is wrong to do, but I'm going to fix that as soon as use_x11 && use_ozone config is upstreamed. ----- PS: Please note that this is a temp solution that will help to choose between ozone and non-ozone X11 build. The switch that will be used to choose the path is --enable-features=UseOzonePlatform. Once non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how the finch trial goes), the wrapper will be removed. Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: I77b943fe8e54982b97c40a4f34bbbca66ab3f726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336597Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#794876}
-
Maksim Sisov authored
These should be as close to platform level as possible. Thus, avoid having them outside platform. Bug: 789065 Change-Id: Ie61150ae6c9b56c167475c3798464b4f4290b950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332610 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
-
Maksim Sisov authored
These parts are not used in Ozone/Linux for the use_x11 && !use_ozone config. However, we are going towards have a single Linux config where OzonePlatform is enabled by --enable-features=UseOzonePlatform. Thus, the parts that are guarded by \#ifdef(USE_X11) start to be executed. This is not desired for Ozone/Linux as it can run Wayland instead. Thus, temporarily add check for the OzonePlatform feature flag and a TODO to properly fix that. ----- PS: Please note that this is a temp solution that will help to choose between ozone and non-ozone X11 build. The switch that will be used to choose the path is --enable-features=UseOzonePlatform. Once non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how the finch trial goes), the wrapper will be removed. Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: I45cb0c9d36a7e45e72b8ff52cbfbdfcb37bc4ee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333199 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
-
Michael Moss authored
This reverts commit d67d7452. Reason for revert: Branch run failed, so trying again. Original change's description: > Updating trunk VERSION from 4223.0 to 4224.0 > > # This is an automated release commit. > # Do not revert without consulting chrome-pmo@google.com. > NOAUTOREVERT=true > TBR=pbommana@chromium.org > > Change-Id: If634e36bccdaf23712ecf376a6ff315c346875e7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332868 > Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#794839} TBR=pbommana@chromium.org,chrome-release-bot@chromium.org,chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com Change-Id: I0fb52240afb0e4f0405fb77fcdd7cef35263560a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337765Reviewed-by:
-
Marijn Kruisselbrink authored
The file_type_index passed to SelectFileDialog::SelectFile can't be 1 (the first accepted type) if no explicitly accepted types are provided. Bug: 1112122 Change-Id: If72b971be087c3b9b7142b6754f887e70f122fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333036 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#794872}
-
Timothy Loh authored
Flaky on linux, chromeos, android TBR=qinmin@chromium.org Bug: 1106059 Change-Id: Id1bb19c7aba4be458315f3510c2dcaea1a394bb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336379Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#794871}
-
Minoru Chikamune authored
We are going to remove ipc_task_queue and ipc_task_runner. The scheduling policy of ipc_task_queue is the same as the default task queue. Nowadays, we are using per-frame task queues as much as possible. And if there are no relevant per-frame task queues, then we can use the (per-isolate) default task queues. [related design doc section] https://docs.google.com/document/d/1y-vHkrD1z2RtyWYwT6rJkSLHClYNjDDpUbTtBU7l95A/edit#bookmark=id.eeuir8g768ou Bug: 1105403 Change-Id: I5da4bd5434f92f714d49f0beb9bec4e6b7588cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332106Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#794870}
-
Ernesto García authored
Many websites rely on same doc navigation to render different views using pushState/replaceState API, which was originally not considered to unelide URL. This CL enables uneliding for same document navigations with the following considerations: - If the same doc navigation is just a fragment navigation (e.g.) from /foo to /foo#bar, URL should remain in its initial state. - If the same doc navigation is not a fragment navigation (e.g.) from /foo to /foo/bar, URL should be unelided. Also, added tests to check both scenarios, including GetPreviousURL mock in the mock_navigation_handle. Bug: 1096160 Change-Id: Ic051699c9fdb34eaa16e0c586672aae6d8d98b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335675Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Ernesto García <ernestognw@google.com> Cr-Commit-Position: refs/heads/master@{#794869}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b156b016f22b..f8ccdc63a188 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I48ce2b361b27e5f1a8d3b3deaa4d62ed62dfa873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337580Reviewed-by:
-
chrome://flagsThomas Lukaszewicz authored
This addition is necessary to allow users to disable the feature once the experiment is enabled. Bug: 1099917 Change-Id: I4e537a1fe92d1329c75ff8c190f92ce7f1cde8b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336020Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#794867}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib0b9d0f5bb5f747a54e62eecef25332a93d52924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337935Reviewed-by:
-
Hiroshige Hayashizaki authored
This CL checks base URL used in resolving relative URL-like specifiers in dynamic imports() from - `<script>`s, - worker top-level scripts, and - worker scripts imported by `importScripts()`. This is for https://github.com/whatwg/html/issues/5751. This CL relands https://chromium-review.googlesource.com/c/chromium/src/+/2198835/ with a fix: `base-url-worker.sub.html` was flaky due to race between two `fetch_tests_from_worker()`s. In this reland, a `fetch_tests_from_worker()` is moved to a new file `base-url-worker-importScripts.html`, having at most one `fetch_tests_from_worker()` per file. Bug: 1082086, 1112844 Change-Id: I59c9817a7829e950f40878d376ccb5216207b7e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337194Reviewed-by:
Domenic Denicola <domenic@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#794865}
-
Takuto Ikuta authored
Change-Id: I3e516d56adcb020db1c76956b6b72a9a26e01062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336320Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#794864}
-
Steven authored
Add support for WebGL2ComputeRenderingContext to XRWebGLLayer. Extend the IDL union type XRWebGLRenderingContext to include WebGL2ComputeRenderingContext. Also create an alias for this type because the newly generated union type's name is very long. Bug: 1107256 Change-Id: I0db6c5a2281c7f44dd4a704d93a2b7b5ebc9c1d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306913Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Steven Cohen <peragwin@gmail.com> Cr-Commit-Position: refs/heads/master@{#794863}
-
Dominic Mazzoni authored
AXMenuList adds some "fake" accessible nodes for HTML select options; it'd be nice to migrate away from that and expose the actual underlying popup internals, on platforms where the select popup is implemented internally as a web page inside a popup. This patch provides a setting and switch to do this, and a test. In the future we hope to enable this by default on Chrome OS once both ChromeVox and Switch Access support it. Bug: 1110367 Tbr: kenrb@chromium.org Change-Id: I4128f924970c454c415a7d7895150caf16f3bd1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333303 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#794862}
-
Brian Malcolm authored
This is intended to replace the PerAppTimeLimitsWhitelist policy. The old policy will still be used in the absence of the new one for at least a few releases of Chrome. BUG=chromium:1103812 Change-Id: If45b3826493072774cec25e3171183fa899d3bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332980 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794861}
-
Steven authored
Extend modules_idl_files.gni to add support for typedefs_enums_only idl files to be defined in modules. R=peria@chromium.org, yukishiino@chromium.org Change-Id: I5c1464ab47985bd69594e8c3fddceafb3197a1c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336023Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f8ccdc63a188..23c5b63d1c68 2020-08-04 oksamyt@google.com Merge "[trace processor] Update webview power metric slice selection conditions" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia0ef75c6fc0baada002d53f7c39d7171f39b2079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336867Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7176f54720e6..f8ccdc63a188 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0837eeec5e39c4499cd8a98e7cb38bba823e34dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336289Reviewed-by:
-
Rachel Carpenter authored
This removes the feature that it was conditioned on and adds logic in extensions to remove the component and not add it again. We should be able to remove it completely in another milestone after clients have had a chance to remove it properly. Bug: b/159863346 Change-Id: Id6369e670f749b6cd532a25eac0d35c718a4f5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318889 Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#794857}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ac60992d41b7..d5eb7e06f156 2020-08-05 fancl@chromium.org Change Row parent to TestContainer for stats If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1112373 Tbr: skyostil@google.com Change-Id: I95698bb989148e850eae5d005b7c1c59129c3bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337452Reviewed-by:
-
Ben Pastene authored
This reverts commit 5365fbee. Reason for revert: Spec reverting for browser_test timeouts on mac eg: https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests/2891 See crbug.com/1112796 Original change's description: > Correctly prompt users for system level location permission > > This is part of the Core Location implementation in Chrome. This change > deals with the UI element. It checks the permission from the UI side > and prompts the user accordingly > > Bug: 1051591 > Change-Id: I69b9964690f5e9f114a1502a5cc45a38d6da558c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240029 > Commit-Queue: James Hollyer <jameshollyer@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794293} TBR=avi@chromium.org,engedy@chromium.org,reillyg@chromium.org,mattreynolds@chromium.org,jameshollyer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1051591, 1112796 Change-Id: Ia18a29213a2e02acd0ef57ec416e7973cfc51a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337579Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#794855}
-
Melissa Zhang authored
This CL adds proper margins for SharesheetTargetButton and updates bubble targets to have a fixed size and alignment. We also increase the size of the bubble to a fixed width. Bug: 1097623 Change-Id: I9f236a6dd73dbf1a9159d8e6a8ee38a4447c06aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336117Reviewed-by:
-
Devlin Cronin authored
We should be using last committed URL for security checks, not visible URL. This requires updating a number of the extension API tests in order to wait for the tab to commit before attaching the debugger; also take this as an opportunity to update a few with some async helpers (like await, etc). Bug: 237908 Change-Id: Ic9fcb010e4d029204d5d2e0b8e6bbbe76738bc1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327462Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794853}
-
