- 23 Sep, 2016 40 commits
-
-
wangxianzhu authored
This makes the current path and the slimmingPaintInvalidation path invalidate FrameView and layout tree in the same order, to avoid unnecessary layout test result differences. The slimmingPaintInvalidation path needs to handle invalidation of FrameView before traversing into the layout tree because the former initializes PaintInvalidatorContext which is needed by the latter. This will change the order of object paint invalidation of caret and frame scrollbars. In some cases, this will cause the caret to be invalidated twice (one in FrameView, another in BlockPaintInvalidator). Will optimize this when making partial rect invalidation work for spv2. BUG=646176 Review-Url: https://codereview.chromium.org/2366853002 Cr-Commit-Position: refs/heads/master@{#420749}
-
estade authored
rather than caring about the (deprecated) material design mode. Make IDR_INFOBAR_SAVE_PASSWORD android-only. BUG=648281 TBR=oshima@chromium.org Review-Url: https://codereview.chromium.org/2361843003 Cr-Commit-Position: refs/heads/master@{#420748}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/0569d009b4f8cb54109be9b898c4764945943957 gatekeeper: Use CBE for chromium.perf (martiniss@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=649093 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2371463002 Cr-Commit-Position: refs/heads/master@{#420747}
-
thakis authored
BUG= Review-Url: https://codereview.chromium.org/2368683002 Cr-Commit-Position: refs/heads/master@{#420746}
-
rajendrant authored
BUG=638420 Review-Url: https://codereview.chromium.org/2335913002 Cr-Commit-Position: refs/heads/master@{#420745}
-
shess authored
CL https://codereview.chromium.org/1753993002 landed changes to allow recover.c to compile outside of SQLite core. It also neglected to fully update the patches, so that patching according to README.chromium resulted in something different from trunk. Bring it back in line with trunk. Additionally update README.chromium with the current version, and tweak the patch instructions to work better. BUG=584407 TBR=michaeln@chromium.org Review-Url: https://codereview.chromium.org/2366013002 Cr-Commit-Position: refs/heads/master@{#420744}
-
qiangchen authored
The existing UMA counts "Screen Capturer Creation" and "System Audio Capturer Creation". But based on those two metrics, we have no idea how frequent a stream is created with Screen Share and Audio Share simultaneously. Thus in this CL we add finer metrics "Screen Capturer Created With/Without Audio". Similar situation for tab capture. BUG=649749 Review-Url: https://codereview.chromium.org/2363003003 Cr-Commit-Position: refs/heads/master@{#420743}
-
sievers authored
When ReleaseCompositorFrameSink() was called explicitly we delete |resource_provider_|, but we might still have a BeginMainFrame occur and processing UIResourceRequests will try deref it. BUG=643721 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2349143003 Cr-Commit-Position: refs/heads/master@{#420742}
-
ericrk authored
Revert of Idle cleanup for worker context (patchset #5 id:200001 of https://codereview.chromium.org/2353033003/ ) Reason for revert: This appears to be breaking some number of unittests - need to investigate further. Original issue's description: > Idle cleanup for worker context > > Currently, Skia flushes unused items out of its caches after ~1 second > of non-use (50 flushes). This works fine while Skia is in-use, but when > a worker context goes idle we stop calling into Skia altogether. This > means that Skia will never flush out unused cache items from the last > piece of work it did. This can lead to some rather large temporaries > being kept around (~20mb). > > This change adds an idle cleanup process which flushes Skia's caches > and cleans up worker context resources after a worker context is idle > for 1 second. > > BUG=624630 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/051ae83bf29b52cefd82235ebfb90f203912afbb > Cr-Commit-Position: refs/heads/master@{#420496} TBR=danakj@chromium.org,jbauman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624630 Review-Url: https://codereview.chromium.org/2366033002 Cr-Commit-Position: refs/heads/master@{#420741}
-
shess authored
No longer in use, 3.10.2 has worked out fine. This directory is not part of any build, so this should have no Chromium impact. BUG=579743 TBR=michaeln@chromium.org Review-Url: https://codereview.chromium.org/2363173002 Cr-Commit-Position: refs/heads/master@{#420740}
-
ekaramad authored
BUG=563285 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2369623002 Cr-Commit-Position: refs/heads/master@{#420739}
-
dpranke authored
manage.py lied to me, and the iOS builder broke as a result. TBR=dnj@chromium.org NOTRY=true BUG=649579 Review-Url: https://codereview.chromium.org/2362123003 Cr-Commit-Position: refs/heads/master@{#420738}
-
bnc authored
This CL lands server change 133740552 by agt. BUG=488484 Review-Url: https://codereview.chromium.org/2365683002 Cr-Commit-Position: refs/heads/master@{#420737}
-
twellington authored
We would like the aggregate suppression heuristic logging to determine the impact of signals we are collecting but not yet using to suppress. Also changes BarOverlapTapSuppression to only consider the y-position of the tap. BUG=642897,642962 Review-Url: https://codereview.chromium.org/2365653007 Cr-Commit-Position: refs/heads/master@{#420736}
-
guidou authored
This CL introduces MediaDevicesManager, which is now responsible for low-level device enumerations, including using device monitoring to maintain updated caches. This CL also removes the enumeration functionality from the MediaStreamProvider interface, as MediaDevicesManager is the new class resnposible for providing enumeration results to be used to handle renderer-generated enumeration requests and device-change notifications. Due to this, relatively minor changes are made to AudioInputDeviceManager and VideoCaptureManager. BUG=647660 Review-Url: https://codereview.chromium.org/2350693002 Cr-Commit-Position: refs/heads/master@{#420735}
-
mariakhomenko authored
BUG=646929 Review-Url: https://codereview.chromium.org/2365973002 Cr-Commit-Position: refs/heads/master@{#420734}
-
yiyix authored
"Learn more" link in accessibility detailed view is used to point to the how to turn on accessibility features page, it is now updated to point to the general help page of accessibility. BUG=638439 Review-Url: https://codereview.chromium.org/2366713003 Cr-Commit-Position: refs/heads/master@{#420733}
-
cwallez authored
https://chromium.googlesource.com/angle/angle.git/+log/c287ea6..28a97ee BUG=chromium:648031,chromium:648135,648063,607283,645532,chromium:648074 TBR=geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Merge branch 'master' of https://chromium.googlesource.com/chromium/src fuzzers: add a fuzzer for the ANGLE shader translator BUG=angleproject:1522 Review-Url: https://codereview.chromium.org/2364873003 Cr-Commit-Position: refs/heads/master@{#420732}
-
bnc authored
* Remove HttpNetworkSession::enabled_protocols_. * Spell out AlternateProtocol enum values in HttpNetworkSession::IsProtocolEnabled() and in HttpServerProperties::IsAlternateProtocolValid(). * Remove ALTERNATE_PROTOCOL_MAXIMUM_VALID_VERSION, ALTERNATE_PROTOCOL_MINIMUM_VALID_VERSION, enum AlternateProtocolSize. BUG=116575 Review-Url: https://codereview.chromium.org/2362233002 Cr-Commit-Position: refs/heads/master@{#420731}
-
ntfschr authored
If Webview is started in an application using defaultToDeviceProtectedStorage="true", it will first try to switch to a CE context. If it's unable to switch contexts, it throws an exception. BUG=645921 Review-Url: https://codereview.chromium.org/2339343002 Cr-Commit-Position: refs/heads/master@{#420730}
-
lazyboy authored
Specifically this CL moves files related to the following APIs/Natives: certificate_provider quick_unlock_private file_system_provider platform_keys_natives & enterprise.platformKeys and friends Locally, I also see linux (non-chromeos) binary size reducing by ~5.6k [1] BUG=376319 [1]: With patch: ls -al out/Release/chrome -rwxr-x--- 1 lazyboy eng 61426832 Sep 22 17:43 out/Release/chrome Without patch: ls -al out/Release/chrome -rwxr-x--- 1 lazyboy eng 61432496 Sep 22 17:44 out/Release/chrome Review-Url: https://codereview.chromium.org/2367653002 Cr-Commit-Position: refs/heads/master@{#420729}
-
falken authored
Original patch author: horo@ at https://codereview.chromium.org/2248583003/ bug 608049 is a top crasher on stable channel. The cause is that render process hosts are not reliably destructing on shutdown because shared workers keep them alive. Shared worker bookkeeping is expected to return the worker ref counts to zero when documents close, but I suspect it often doesn't finish in time for shutdown since it requires posting tasks between the IO thread and UI thread. https://crrev.com/798a8b94726d3c439e6302998f31bc487f521ec8 tried to solve the bug by removing waiting for an IPC from the renderer process, but the thread hopping means shutdown is still racy. This patch forcibly sets the ref counts to 0 on the UI thread when the browser context is shutting down, similar to what we do for service workers. BUG=636377,608049 Review-Url: https://codereview.chromium.org/2342523002 Cr-Commit-Position: refs/heads/master@{#420728}
-
dpranke authored
Since the builders are being removed. R=dnj@chromium.org BUG=649579 Review-Url: https://codereview.chromium.org/2358133005 Cr-Commit-Position: refs/heads/master@{#420727}
-
ryansturm authored
This introduces an in memory blacklist for previews. This also introduces an interface for retrieiving prior sessions information from a store. The blacklist is keyed on fully qualified domain name and will blacklist domains based on user history of opt-outs on those domains. This does not yet implement adding preview navigations to the blacklist or using the blacklist to determine site navigation eligibility. Nor does this CL implement the backing store. BUG=639087 Review-Url: https://codereview.chromium.org/2335023002 Cr-Commit-Position: refs/heads/master@{#420726}
-
bnc authored
* Remove all unnecessary IsSpdyAlternative() checks. IsSpdyAlternative() implies origin_url_.SchemeIs(url::kHttpsScheme), see DCHECK in constructor. * Inline now const |spdy_certificate_error_|. * Inline and remove SwitchToSpdyMode(). This method was only used twice out of four potential places. Removal makes sense as the method is trivial, and there are no corresponding methods for |using_spdy_ = false|, |using_quic_ = true|, and |using_quic_ = false| assignments. * Use url_constants instead of string literals for schemes (http, https, ftp, and wss). There has already been two uses of such constants. * Remove unused |destination| local variable. * Fix some comments. * git cl lint: Remove unnecessary semicolon, add includes. BUG=475060 Review-Url: https://codereview.chromium.org/2359153003 Cr-Commit-Position: refs/heads/master@{#420725}
-
apacible authored
Add strings from the UX mocks. Some strings are repeats in the file as this gives us full control over the strings we're using. The media layer doesn't access the resource bundle directly, but media/base/media_resources.cc/h and c/c/media/media_resource_provider.cc/h provides indirect access. The appropriate strings used in the media layer will be wired up in a later change. BUG=649575 Review-Url: https://codereview.chromium.org/2363033002 Cr-Commit-Position: refs/heads/master@{#420724}
-
maxbogue authored
BUG= Review-Url: https://codereview.chromium.org/2363853002 Cr-Commit-Position: refs/heads/master@{#420723}
-
rockot authored
ServiceManager is trying to use an out-of-process native runner in production, which is a big no-no. This adds some junk to help track that down. BUG=649673 TBR=ben@chromium.org Review-Url: https://codereview.chromium.org/2369543002 Cr-Commit-Position: refs/heads/master@{#420722}
-
open.hyperion authored
Updated and refactored URLIndexPrivateData::HistoryItemsForTerms to handle searching the history for both the original search string as well as the string with a break inserted. The goal is to support mid-word autocomplete in the Omnibox. Currently, if the user types "funtimes", inserts the cursor between the "n" and the "t" and begins typing the word "good" the Ominbox will search for URL results that match "fungood times" only. We want to also search for "fungoodtimes". BUG=591979 TEST=0. Clear browser history. 1. Visit the following link: https://twitter.com/fungoodtimes 2. Open a new browser tab. 3.Type into the Omnibox "funtimes". Note the lack of the suggestion for the above URL. 4. Insert the cursor between the "n" and "t" in "funtime" and type "good". 5. The above URL should show in the autocomplete list. Review-Url: https://codereview.chromium.org/2364553004 Cr-Commit-Position: refs/heads/master@{#420721}
-
yiyix authored
Introduced a new layout for accessibility detailed view. Each row now contains a vectorized icon which is shown on left, a description which is shown in the middle and a check mark is shown on the right. The row on the bottom which contains "setting" option and "learn more" option is removed and it will be included in the title row in the future cls. This CL also updates the description of ChromeVox from "ChromeVox (Spoken feedback)" to "ChromeVox (spoken feedback)" TEST=tray_accessibility_browsertest BUG=632102 Review-Url: https://codereview.chromium.org/2343603003 Cr-Commit-Position: refs/heads/master@{#420720}
-
melandory authored
BUG=647248 Review-Url: https://codereview.chromium.org/2344663003 Cr-Commit-Position: refs/heads/master@{#420719}
-
tedchoc authored
This change, http://crrev.com/2297193003, introduced a chrome specific InvalidationClientService, but it did not properly update all the appropriate references. This pulls the registered service from the AndroidManifest.xml if applicable. Does it through this indirection as components/ is unaware of chrome/. BUG=647774 Review-Url: https://codereview.chromium.org/2352943002 Cr-Commit-Position: refs/heads/master@{#420718}
-
rockot authored
It needs to be a public dependency as it's exposed by chrome/browser/ui/browser.h and uses generated code. BUG=649766 R=thakis@chromium.org TBR=ben@chromium.org Review-Url: https://codereview.chromium.org/2368633002 Cr-Commit-Position: refs/heads/master@{#420717}
-
clm authored
Review-Url: https://codereview.chromium.org/2361413002 Cr-Commit-Position: refs/heads/master@{#420716}
-
paulmeyer authored
This patch implements new find-in-page functionality that allows for frames that are either newly added or navigated during a find session to be automatically searched so that matches in their new content are automatically highlighted and included in the results shown in the find bar. Also, there is a fix included in this patch to prevent the find-in-page bar from closing when a subframe navigates (the find session should only end if the main frame navigates). Design doc: https://docs.google.com/document/d/1r4F19FIKg4zPJCaSyJ9-T0sgFbxlCGKL3FjqQEAKegg/view BUG=2220,621660 Review-Url: https://codereview.chromium.org/2236403004 Cr-Commit-Position: refs/heads/master@{#420715}
-
agrieve authored
This will give us an easy toggle for testing out obfuscation. BUG=620323 Review-Url: https://codereview.chromium.org/2369573002 Cr-Commit-Position: refs/heads/master@{#420714}
-
zmin authored
BUG=642059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2351173004 Cr-Commit-Position: refs/heads/master@{#420713}
-
ekaramad authored
Currently, with the flag --use-cross-process-frames-for-guests switched on, MimeHandlerView still creates a BrowserPlugin while on the browser side we expect an OOPIF based implementation. This causes PDF viewer to crash. On the other hand, GuestViews will soon use OOPIF. Hence, temporarily, we need to make MimeHandlerView an exception and force it to use BrowserPlugin's codepath even when the switch above is turned on. BUG=563285 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2165523004 Cr-Commit-Position: refs/heads/master@{#420712}
-
dmazzoni authored
It was using different time calls for the start time and current time. BUG=589632 Review-Url: https://codereview.chromium.org/2367693003 Cr-Commit-Position: refs/heads/master@{#420711}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/cc0937273030..aa840647fc7f $ git log cc0937273..aa840647f --date=short --no-merges --format='%ad %ae %s' 2016-09-23 bsalomon Don't compute path keys for volatile paths in GrShape. 2016-09-23 csmartdalton Add Pixel C knobs to skpbench 2016-09-23 jvanverth Some Vulkan memory fixes and cleanup 2016-09-23 reed change SkXfermodeImageFilter to carry no impl information BUG=649562 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=borenet@google.com Review-Url: https://codereview.chromium.org/2367933002 Cr-Commit-Position: refs/heads/master@{#420710}
-