- 21 Jul, 2020 40 commits
-
-
Mohsen Izadi authored
Based on the data gathered from running the experiment on canary/dev and beta, it seems that the disabling latency recovery for both main and impl threads is an overall performance win. So, we are going to re-enable the (now-expired) experiment on stable and move forward with its gradual rollout. Bug: 993895 Change-Id: I5c45c3cb469d14cf53193d0af6a560842ce02be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309188Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#790549}
-
Nnamdi Theodore Johnson-Kanu authored
Bug: 1106937 Change-Id: Idd4931433c8421187510df98b200b93e51da508c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309757 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#790548}
-
Greg Thompson authored
Resource extraction and file expansion in the mini_installer now use the MiniFile class to manage output files while they are open. It takes care of handle lifetime management and provides a robust way to delete an open file. This change also fixes two potential file leaks. Specifically, a destination file created by either PEResource::WriteToDisk or mini_installer::Expand is now deleted in case of error. BUG=516207 Change-Id: I2ee894d4e6f2d04fbb6cf3355638ee50e8bb1bf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303400Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#790547}
-
phillis authored
Bug: 1107962 Change-Id: Ibb57e754136237e906fff151cffae8a2d167901e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310836 Auto-Submit: Phillis Tang <phillis@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#790546}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595330901-a1487ea0e73c84091ecbf3f0440329cfe99905ef.profdata to chrome-mac-master-1595354395-0cec5727d5425707de0e31a54a23e974ac70998e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Iae85a615c155da7b771ac57520342aaeb49fb0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310796Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790545}
-
Xianzhu Wang authored
We are removing the function to remove obstacle to integrate paint with LayoutNGBlockFragments. Now always pass image border size to painting timing detectors. This is also more accurate than the visual rect used previously. Visual rect includes visual overflows, borders, etc. which are not part of the image. For the text in FileUploadControl, now report the bounds of the text instead of the control's visual rect which also covers the button and visual overflows. Bug: 1104064 Change-Id: I9974ee67c5f0a0bdc84e0d0530c12c4843b577ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309801 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#790544}
-
Livvie Lin authored
Bug: 1058898 Change-Id: I395d8e95992e2d741882f199fb80a5173db49d61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304310Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790543}
-
sczs authored
Bug: 1085419 Change-Id: I88648fb865e96a839b691c762518b2076b5fcd2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311051 Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#790542}
-
Matt Jones authored
The GESTURE_DETECTOR property for the scrim is currently unused and doesn't correctly pass motion events back to the mediator as it was originally intended to. This patch correctly delegates event handling to the mediator; there is no behavior change if the GESTURE_DETECTOR property is null or not set. A test has also been added to ensure events can be processed by the detector if set. Bug: 1062099 Change-Id: Ia67f8f6dfa7b16d9f74a71bbe1a73994fe8ed034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305921Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#790541}
-
Pavol Marko authored
Allow TpmChallengeKeySubtle to be instantiated with a nullptr Profile*. Such an instance can only be used to work with machine keys (device-wide keys). This is useful to decouple the device-wide CertProvisioningScheduler from the sign-in Profile. Bug: 1045895 Change-Id: I42382d3be03aa371d4ba31aaebb2891326e24599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189650 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#790540}
-
Josh Nohle authored
The //chrome/browser/nearby_sharing/ directory has subdirectories with their own BUILD files. Those directories cannot currently depend on the Nearby Share enum and pref files, which currently live in the //chrome/browser/nearby_sharing/ directory. Here, we create a //chrome/browser/nearby_sharing/common BUILD target that contains Nearby Share prefs and enums. Change-Id: I9e8daf5660ec4dc22ef002c3cc00a1d715bb5ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306372 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#790539}
-
Roger Tawa authored
With recent changes triggered DLP rule names are added to the reported events. This CL is mostly about make sure things are work as expected. Two changes are made: 1/ Remove extra fields from the reported rules. The server is quite strict and rejects reports if they contain bad or extra fields. This CL removes the fields 'id' and 'action' which are not handled. 2/ Rename the "result" field to "eventResult". This was an error I introduced in cl/2288811. With these changes I have verified that event reports are properly accepted by the backend. Bug: 1069109 Change-Id: Ia381da313488eee6f41d71b1ab3928c213003e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308991Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#790538}
-
adamta authored
Immediately shows or hides Discover feed from NTP when setting is toggled in the settings menu. Changes setting title from "Article Suggestions" to "Discover" (this may change eventually and the icon will change as well). Bug: 1085419, 1105624 Change-Id: I560b7af4aa41b18493f7853a5b44b504d9c1ad53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302809 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#790537}
-
Peng Huang authored
This CL doesn't reuse the external semaphores, it just adds a new class ExternalSemaphore which will be reused in follow-up CLs. Bug: 1004772,1004774 Change-Id: I28930c3accdd3e004db058e32ff688630c66a20c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308873Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#790536}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/09357ccfa85a..5933d7d54fb8 2020-07-21 johnstiles@google.com Update GrPaint APIs to reflect lack of multiple color processors. 2020-07-21 herb@google.com constify GrAtlasTextOp::Geometry 2020-07-21 johnstiles@google.com Remove support for multiple color processors from GrPaint. 2020-07-21 johnstiles@google.com Update VisualizeCoverageCountFP to accept an input FP. 2020-07-21 mtklein@google.com some small SkVM TODOs 2020-07-21 herb@google.com inline prepareGrGlyphs 2020-07-21 bsalomon@google.com Rename GrCaps fields and methods from MipMap to Mipmap 2020-07-21 csmartdalton@google.com Always return the full remaining buffer capacity from makeSpaceAtLeast 2020-07-21 egdaniel@google.com Add new GrContext::updateBackendTexture call that takes an SkColorType. 2020-07-21 bsalomon@google.com Rename GrBackendTexture::fMipMapped -> fMipmapped 2020-07-21 michaelludwig@google.com Revert "Support moving blocks from one allocator to another" 2020-07-21 bsalomon@google.com Rename GrMipMapsStatus GrMipmapStatus 2020-07-21 michaelludwig@google.com Support moving blocks from one allocator to another 2020-07-21 kjlubick@google.com [canvaskit] Update to 0.17.1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I570a9999ca312fee1f9f4612cabf99c3c91881c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309123Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790535}
-
Wenhan (Han) Zhang authored
Change-Id: I658ab21b20dbb35d539ee083533c2ec956e1c860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258194Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Wenhan (Han) Zhang <zwenhan@google.com> Cr-Commit-Position: refs/heads/master@{#790534}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0dd63428948f..232115851126 2020-07-21 jmadill@chromium.org Roll chromium_revision b0410bba..fb6cbaf6 (763000:790363) 2020-07-21 syoussefi@chromium.org Add test for deferred clear + attachment gaps 2020-07-21 geofflang@google.com Support EXT_shader_texture_lod on Vulkan. 2020-07-21 nguyenmh@google.com Apply multiprocessing to capture_replay_tests.py 2020-07-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 30aa06f22718 to 4b40207be32d (6 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I7b828a7dd1f81e49a839125e394e7740778dff0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309353Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790533}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9949ab7a4b1c..720e010ba1b2 2020-07-21 ehmaldonado@chromium.org Revert "bot_update: Refactor branch to detach and checkout." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1104182 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ia47ac5732faca80d1ed924ddc5447e0b07df014a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310321Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790532}
-
Dominique Fauteux-Chapleau authored
Bug: 1088124 Change-Id: I9d0e18023d0b81e8fe78cb1f80305b31e727e3c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298120Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#790531}
-
Erik Chen authored
The file does not provide the preprocessor defines for IN_PROC_BROWSER_TEST_ macros. This documentation update makes it clear to users that they need to manually include "content/public/test/browser_test.h". The header cannot be directly included by in_process_browser_test.h as it produces compile errors: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8874211071355292448/+/steps/compile__with_patch_/0/stdout Change-Id: Ie8091857d76e2408a6fdbc471bf97ca544f8c89d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308863Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#790530}
-
Joshua Peraza authored
498c36b82a03 mac arm64: Provide something more useful from SystemSnapshot::CPURevison e3c94b87f0ef [fuchsia] Move //zircon/system/ulib/fdio to //sdk/lib/fdio fd001f792eb7 build: Make crashpad_dependencies="external" work in the GN build ef8a063055c6 Fuchsia: Propagate failure to initialize exception snapshot 06a688ddc1bc linux: setup a signal stack 9f66d569fb87 linux: put test attachment in temp directory 070b18d326b6 linux: fix alt-stack tests with asan b71bde32e7f9 linux: fix tests with msan Change-Id: I509b8ba9053a71709f8ae24a81dc24d8da4e8fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309758 Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#790529}
-
Toby Huang authored
When the parent disables the "Permissions for sites, apps and extensions" toggle, supervised users can't install new extensions and can't approve permission updates on existing extensions by themselves. Otherwise, supervised users can install new extensions with parent/ custodian approval and approve permission updates on existing extensions by themselves. Therefore, this toggle is very important for controlling extensions behavior for supervised users. Since this toggle is enabled by default, we want to track how often the toggle is disabled for supervised users by adding a new UMA metric. Bug: 1096763 Change-Id: Ie1506fccc14e81a4fc2711335ede3457cb4813b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296823 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#790528}
-
Xing Liu authored
We're shipping offline prefetch notification with this feature. So extend the metrics expiration date. Bug: 1097841,1097840,1097839,1097838,1097837,1097836,1097835,1097834,1097833 Change-Id: I18464473d264428c746ba14aaa0f6d45fd3a4bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308992Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#790527}
-
Kevin Ellis authored
Change-Id: Icae6ce1abc3691bc00d8bd45e27963008b2bf7f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305511 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#790526}
-
Will Harris authored
This CL adds a gn flag "win_enable_cfg_guards" to allow CFG guard dispatch calls to be generated by the compiler. This also adds a test to verify that a guarded indirect call to an invalid location results in a 0xC0000409 fast fail. It also turns on the CFI linker for base_unittests and sbox_integration_tests. BUG=584575 Cq-Include-Trybots: luci.chromium.try:win7-rel Change-Id: I446d3a28733a46fa4d8f96f28cdfc7b132b10772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300634Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#790525}
-
cfredric authored
Add ukm::SourceIds to SharedWorkerHosts, and propagate the SourceId of the client when new connections are made. A followup cl will use these source IDs in UKM events. Bug: 1085645 Change-Id: I02853df540b734816cb48920f0254ad452336786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273483 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#790524}
-
Mikel Astiz authored
Overriding HistoryService and BookmarkModel after the profile has been created is problematic and known to cause hard-to-debug test flakiness. Instead, this patch adopts TestingProfile::Builder for tests in chrome/browser/extensions. Change-Id: Ifcf2999a5e12c0a2a3c2c23f06ae86711a54a982 Bug: 1106699,1106339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310490Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#790523}
-
Xianzhu Wang authored
Bug: 1104064 Change-Id: I943b1c59bcf9b3bbe60205387693c71e2b457284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306755 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#790522}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: Iabb83afa045a3e3f16a257f55c2a60ed16759222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308514Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#790521}
-
Lei Zhang authored
Replace existing code that does exactly the same thing. Bug: 1009837 Change-Id: I7f2612bbc03301bf1b43c42c153ab2f795a82616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285849Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#790520}
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I5dbc5ed6af51ce56dd24bb4427bb8f93db154dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303772 Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#790519}
-
Luis G Garcia authored
Enable grouping of the AR and Camera permission types in order to present both permissions within a single prompt to the user. This prompt will be displayed when a session is requested with camera access as a requested feature. UX Design Doc: https://docs.google.com/document/d/19iYmlZeyEIYwZFurDbYvwT0WEc1MfJ4TKS9V_JA2fF8/edit#heading=h.kffoh0tkafi0 Fixed: 1105590 Bug: 1106874 Change-Id: Ie6c1985f1dd717d3df88d0a856174ec1bdbc3b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303376 Commit-Queue: Luis Garcia <luisggarcia@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#790518}
-
John Z Wu authored
- Created SharedPasswordController to share ios specific code without being either ios/chrome or ios/web_view specific. - Move MakeSimpleFormData into test_helpers. - Make PasswordSuggestionHelper and PasswordFormHelper injected at initialization to aid with mocking in unit test. - Left some TODOs to continue cleanup of shared code in //components/password_manager/ios/... Change-Id: Ia877ecef4cb44d87f069500fbccb1d0f7320a598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254351 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#790517}
-
Becca Hughes authored
Change-Id: I14c9805056baa6c042d0c391ca3bc87504e59dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305119Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#790516}
-
George Steel authored
Update WPT tests to match spec. Spec: https://drafts.csswg.org/css-writing-modes-4/#text-combine-upright Bug: 1105144 Change-Id: Ia89fdf3f14bab8dfbce1a9e2315f64e9315423e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303353Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#790515}
-
Stefan Zager authored
Previously, <iframe> elements were always composited, and CompositingLayerAssigner specifically disallows squashing them. Due to a recent change (see bug), <iframe> elements are not always composited; but we cannot squash layers across an iframe with composited contents. With this change, an iframe with composited contents will end the current squashing context in the embedding document. BUG=1095935 Change-Id: Ie60becde8b99d204395a2c8f35bc1ce1076334a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309141 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#790514}
-
Pavel Feldman authored
This change introduces a binary post data field in the Network.Request type. New field contains entries that correspond to the http body data entries. New PostDataEntry type supports text/bytes data only, but allows progressive enhancement for other types such as files and blobs. Bug: 1107728 Change-Id: I205dd7fc93d627a14c111cc2a05a63ce962bc449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309660Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#790513}
-
Jan Wilken Dörrie authored
This change implements ranges overloads for the algorithms found in the alg.sort section. Bug: 1071094 Change-Id: I024bca1346ff67bbbb9bef7a6fd6aa8dbff2ebeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310349 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#790512}
-
Tibor Goldschwendt authored
Fixed: 1089106 Change-Id: I068dd5976b4c6798ad69653b53157fbd8a7edfaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310651 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#790511}
-
Ken Rockot authored
This is a mechnical translation of .typemap files into equivalent GN mojom target settings. Bug: 1059389 Change-Id: I128f2d16ad19617d4cdf7df33bc268823ad70abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304939Reviewed-by:
Mike Klein <mtklein@google.com> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#790510}
-