GitLab

We should not be sending a WM_MOUSELEAVE to the parent from the LegacyRenderWidgetHostHWND class when the parent has capture.

The LegacyRenderWidgetHostHWND class tracks WM_MOUSEMOVES to inform the parent when the mouse cursor moves outside the
bounds of the parent window. When the parent sets capture, Windows sends us a WM_MOUSELEAVE message. We should be ignoring this.

BUG=343844
R=sky@chromium.org
TBR=cpu

Review URL: https://codereview.chromium.org/166163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251370 0039d316-1c4b-4281-b951-d872f2087c98

Speculative revert to see if this resolves a spike in update failures on
canary.

> Add quotes around executable pathes in the mini installer
> 
> BUG=340387
> TEST=N/A
> 
> Review URL: https://codereview.chromium.org/154113004

TBR=cdn@chromium.org

Review URL: https://codereview.chromium.org/167333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251369 0039d316-1c4b-4281-b951-d872f2087c98

This feature is enabled for dev behind the
--enable-override-bookmarks-ui=1 feature flag, and for all releases for
internal bookmarks extensions.

Implements the shortcut key aspect of the
Remove Bookmark Shortcut Chrome API proposal:
https://docs.google.com/a/chromium.org/document/d/1C2Mle92O9uGlji5y5gGDM5tNJ_tVE1Vb-2xgsZPNDTk

BUG=335655
R=erg@chromium.org, finnur@chromium.org, shess@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/143493005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251368 0039d316-1c4b-4281-b951-d872f2087c98

Renamed all occurences of DataFetcherImplAndroid to SensorManagerAndroid
to better reflect current implementation of Device Motion/Orientation.
Also the relevant tests and files have been renamed in this patch.

BUG=334342

Review URL: https://codereview.chromium.org/137853006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251367 0039d316-1c4b-4281-b951-d872f2087c98

> Add wallpaper api tests
> 
> This CL add the following tests:
> 1. test chrome.setWallpaper can set ChromeOS wallpaper from jpg or png formatted arraybuffer.
> 2. test chrome.setWallpaper can set ChromeOS wallpaper from a valid url that point to a jpg or png image.
> 3. test an invalide URL wont set wallpaper
> 4. test a new wallpaper request will cancel previous unfinished request
> 
> 
> BUG=176183
> 
> Review URL: https://codereview.chromium.org/153093010

AFAICT this failed as soon as you landed it.

Here's output from one of the bots:

ExtensionApiTest.Wallpaper (run #1):
[ RUN      ] ExtensionApiTest.Wallpaper
[21364:21364:0213/150838:1514562885:ERROR:audio_manager_pulse.cc(248)]
Failed to connect to the context.  Error: Connection refused
Xlib:  extension "RANDR" missing on display ":9".
[7:7:0213/150839:WARNING:sandbox_linux.cc(55)] Activated seccomp-bpf
sandbox for process type: renderer.
[21409:21409:0213/230839:WARNING:sandbox_linux.cc(55)] Activated
seccomp-bpf sandbox for process type: gpu-process.
[15:15:0213/150840:WARNING:sandbox_linux.cc(55)] Activated seccomp-bpf
sandbox for process type: renderer.
[24:24:0213/150840:WARNING:sandbox_linux.cc(55)] Activated seccomp-bpf
sandbox for process type: utility.
Corrupt JPEG data: premature end of data segment
[21364:21364:0213/150841:1516721525:INFO:CONSOLE(0)] "[SUCCESS]
setJpgWallpaperFromAppLocalFile", source:
chrome-extension://neonnameailmmllmeicdbcndfninlogd/_generated_background_page.html
(0)
[31:31:0213/150841:WARNING:sandbox_linux.cc(55)] Activated seccomp-bpf
sandbox for process type: utility.
[21364:21364:0213/150841:1516803158:INFO:CONSOLE(0)] "[SUCCESS]
setPngWallpaperFromAppLocalFile", source:
chrome-extension://neonnameailmmllmeicdbcndfninlogd/_generated_background_page.html
(0)
[38:38:0213/150841:WARNING:sandbox_linux.cc(55)] Activated seccomp-bpf
sandbox for process type: utility.
Corrupt JPEG data: premature end of data segment
[21364:21364:0213/150841:1517187827:INFO:CONSOLE(0)] "[SUCCESS]
setJpgWallpaperFromURL", source:
chrome-extension://neonnameailmmllmeicdbcndfninlogd/_generated_background_page.html
(0)
[45:45:0213/150841:WARNING:sandbox_linux.cc(55)] Activated seccomp-bpf
sandbox for process type: utility.
[21364:21364:0213/150841:1517523379:INFO:CONSOLE(0)] "[SUCCESS]
setPngWallpaperFromURL", source:
chrome-extension://neonnameailmmllmeicdbcndfninlogd/_generated_background_page.html
(0)
[21364:21446:0213/150841:1517544840:WARNING:embedded_test_server.cc(231)]
Request not handled. Returning 404:
/extensions/api_test/wallpaper/test1.jpg
[52:52:0213/150841:WARNING:sandbox_linux.cc(55)] Activated seccomp-bpf
sandbox for process type: utility.
/usr/include/c++/4.6/debug/vector:320:error: attempt to subscript
container 
    with out-of-bounds index 0, but container only holds 0 elements.

Objects involved in the operation:
sequence "this" @ 0x0x7ffffdb6a470 {
}

at: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/10341/steps/browser_tests/logs/Wallpaper

TBR=bshe@chromium.org

Review URL: https://codereview.chromium.org/167243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251366 0039d316-1c4b-4281-b951-d872f2087c98

Temporary workaround for a goma bug.

BUG=337426
TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/167113004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251365 0039d316-1c4b-4281-b951-d872f2087c98

The session restore tests were timing out on Android. This was because
they were waiting for the background tabs to be loaded, which they
would not be in normal startup.

The only reason the test worked at all is that when devtools accessed
the background tabs this forced them to be loaded.

This changes the test to only wait for, and to only measure, the
foreground tab.

NOTRY=true
BUG=343168,343900

Review URL: https://codereview.chromium.org/161473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251364 0039d316-1c4b-4281-b951-d872f2087c98

Notes:
- The download feedback pref is an enum with a ternary (not binary) value. As a result, need to set up a special handler to toggle the checkbox appropriately.
- Moved DownloadReportingStatus enum from DownloadFeedbackDialogView into DownloadFeedbackService. This lets BrowserOptionsHandler use the enum.

-------
How to test (currently Win & CrOS only):

A
1. Go to chrome://settings on a clean build; search for 'Privacy'
2. Verify that "Send suspicious downloaded files to Google" is not checked

B
1. Visit http://testsafebrowsing.appspot.com/, click on #5
2. Click discard in the download item
3. Click 'No thanks' in the dialog
4. Go to chrome://settings; search for 'Privacy'
5. Verify that "Send suspicious downloaded files to Google" is not checked

C
1. Clear your user preferences (e.g., delete the Preferences file in your user data directory)
2. Visit http://testsafebrowsing.appspot.com/, click on #5
3. Click discard in the download item
4. Click 'OK' in the dialog
5. Go to chrome://settings; search for 'Privacy'
6. Verify that "Send suspicious downloaded files to Google" is checked
-----------

BUG=312533

Review URL: https://codereview.chromium.org/153353006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251363 0039d316-1c4b-4281-b951-d872f2087c98

The source of the webaudio audio track might not have any capturer and this will make |need_audio_processing| flag to be false.

BUG=343866

Review URL: https://codereview.chromium.org/166363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251362 0039d316-1c4b-4281-b951-d872f2087c98

In order to show the poster image while casting a video, we pass the poster image URL to Android. Like favicons, it will be downloaded and be shown in the relevant activity & view.

Relevant CLs:
Blink: https://codereview.chromium.org/131763011/
Chrome for Android: https://chrome-internal-review.googlesource.com/#/c/153405/

BUG=333260
NOTRY=true

Review URL: https://codereview.chromium.org/135863004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251361 0039d316-1c4b-4281-b951-d872f2087c98

BUG=341926
R=xiyuan@chromium.org
TEST=browser_tests

Review URL: https://codereview.chromium.org/159973004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251360 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds 6 user actions (prefixed by 'AppList_')
- AutoLaunchCanceled
- AutoLaunched
- HotwordRecognized
- SearchedBySpeech
- VoiceSearchCanceled
- VoiceSearchStartedManually

BUG=341239
R=xiyuan@chromium.org
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/151903007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251359 0039d316-1c4b-4281-b951-d872f2087c98

The following page always errors out inside rasterize_and_record.key_silk_cases
on some windows platforms:
  http://plus.google.com/app/basic/stream

This change disables this page so that the perf bots can pass this test for the
other pages.

BUG=338838
R=dominikg@chromium.org, tonyg@chromium.org

Review URL: https://codereview.chromium.org/167143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251358 0039d316-1c4b-4281-b951-d872f2087c98

> cros: Enable multiprofile for everyone.
>
> BUG=338941
> R=dpolukhin@chromium.org, nkostylev@chromium.org
>
> Review URL: https://codereview.chromium.org/146193005

TBR=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/167173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251357 0039d316-1c4b-4281-b951-d872f2087c98

The $included_files var contains a list of paths relative to the sysroot.
However calling `ls $included_files` gives us a list of paths relative to the host system root, which is obviously wrong. We need to do `ls $root$included_files` instead.

BUG=324207
R=thestig@chromium.org
CC=sl.ostapenko@samsung.com

Review URL: https://codereview.chromium.org/163103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251356 0039d316-1c4b-4281-b951-d872f2087c98

If someone wants to use a custom android sdk version, they now need to set
the android_sdk_version gyp define instead of this env var.

(Depends on one internal change to an internal bot that currently sets the
env var: https://chrome-internal-review.googlesource.com/154255)

BUG=330631

Review URL: https://codereview.chromium.org/159463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251354 0039d316-1c4b-4281-b951-d872f2087c98

Introduce the chroot_cmd flag that contains the command line prefix for running in a chrooted environment.

Right now when supplying a 32-bit sysroot via the 'sysroot' GYP flag on a 64-bit host arch,
pkg-config (and pkg-config-wrapper) fail to generate the correct 32-bit paths within that sysroot.
The solution is to chroot into that directory and run pkg-config from there.
This is intended to work with schroot scripts like 'precise32' generated when running build/install-chroot.sh

BUG=324207
R=piman@chromium.org

Review URL: https://codereview.chromium.org/163583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251353 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338941
R=dpolukhin@chromium.org, nkostylev@chromium.org

Review URL: https://codereview.chromium.org/146193005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251352 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=launch app_shell with flag "--remote-debugging-port=9222", then open
"localhost:9222" in browser and see the console.

Review URL: https://codereview.chromium.org/147993009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251351 0039d316-1c4b-4281-b951-d872f2087c98

any build (not just Chrome-branded builds).

BUG=343567

Review URL: https://codereview.chromium.org/163583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251350 0039d316-1c4b-4281-b951-d872f2087c98

BUG=341882

Review URL: https://codereview.chromium.org/155573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251349 0039d316-1c4b-4281-b951-d872f2087c98

DOM API calls and place them into argUrl field of an
Activity Log entry.

BUG=339882

Review URL: https://codereview.chromium.org/160753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251348 0039d316-1c4b-4281-b951-d872f2087c98

Fix compilation for arm64.

TBR=cpu@chromium.org
R=mark@chromium.org
BUG=314720

Review URL: https://codereview.chromium.org/163723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251345 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251344 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r12731: (jvoung) Turn on tests/callingconv_case_by_case for PNaCl --target=i686-nacl.
r12732: (bradnelson) Dropping remaining python_26 references.
r12734: (mcgrathr) Default to all trybot sets when pynacl/ code is touched
r12735: (kschimpf) Add pnacl-compress driver tool to compress pnacl bitcode files.
r12736: (halyavin) Fix more instances of use-after-free due to incorrect clean up.
r12737: (sbc) Update newlib revision used by toolchain builders.
r12738: (dyen) build_nexe.py can now apply tls_edit
r12739: (dyen) tls_edit only prints out verbose messages in scons
r12740: (mseaborn) Remove irt_ppapi.{c,h}, which have been moved to the Chromium repo
r12741: (jfb) Toolchain build: add sync-only option.
r12742: (noelallen) Add a bootstrap target for bionic LIBC to generate only the static libc components....
r12743: (mseaborn) Cleanup: Remove "ppapi" directory from IRT's #include search path
r12744: (noelallen) Roll to get missing files
r12745: (mseaborn) Cleanup: Remove PPAPI directories from include_rules, used by checkdeps
r12746: (dschuff) Run LLVM regression tests for toolchain_build_pnacl build
r12747: (noelallen) Roll Bionic in TOOL_REVISIONS
r12748: (jvoung) Show summary even w/out errors in *.sh bots, to be more like buildbot_lib.py.
r12749: (dschuff) once.py: Don't override fresh build if use-cached-results is disabled
r12750: (sbc) Roll newlib toolchain versions in TOOL_REVISIONS
r12751: (mcgrathr) toolchain_build: Build for x86_64-linux host too
r12752: (dyen) Fixed issue with applying tls_edit in windows
r12753: (dschuff) PNaCl translator: use multithreading for sandboxed translation
r12754: (sbc) Update hashes in TOOL_REVISIONS.
r12755: (jvoung) Revert "Show summary even w/out errors in *.sh bots, to be more like buildbot_lib.py."
r12756: (yyanagisawa) make goma to compile code for pnacl-clang.
r12757: (dschuff) pnacl-nativeld: Use RunWithSplit RPC instead of RunWithDefaultCmdLine

BUG=none
TEST=browser_tests and nacl_integration
R=bradnelson@google.com

Review URL: https://codereview.chromium.org/163993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251343 0039d316-1c4b-4281-b951-d872f2087c98

I'm going to nuke DockInfo soonish. This is a stup in that
direction.

BUG=none
TEST=none
R=erg@chromium.org

Review URL: https://codereview.chromium.org/165463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251342 0039d316-1c4b-4281-b951-d872f2087c98

The fake PO2TS does not actually use the request context. This CL overrides the
GetRequestContext() in PO2TS and returns NULL to avoid errors like the ones
explained at (that occur on iOS)
https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/HWdp5roPpF4/j7drB1WW01EJ

BUG=NONE

Review URL: https://codereview.chromium.org/166573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251341 0039d316-1c4b-4281-b951-d872f2087c98

The Geolocation API was launched a long time ago, and a mock is used in layout tests.
There are no unit tests so nothing needs to be set for them.

BUG=343592,36451

Review URL: https://codereview.chromium.org/164163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251340 0039d316-1c4b-4281-b951-d872f2087c98

The functionality is the same, just moving the code to a new place.

NOTRY=True
BUG=333995
R=bauerb@chromium.org, brettw@chromium.org, joaodasilva@chromium.org, nhiroki@chromium.org, noms@chromium.org, rlarocque@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251221

Review URL: https://codereview.chromium.org/150003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251339 0039d316-1c4b-4281-b951-d872f2087c98

String will be used at OOBE.

BUG=334576

Review URL: https://codereview.chromium.org/166663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251338 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343650
TEST=manually

Review URL: https://codereview.chromium.org/159903007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251337 0039d316-1c4b-4281-b951-d872f2087c98

BCKSFactory::SetTestingFactory() calls BCKSFactory::BrowserContextShutdown(),
which a BCKSFactory subclass may override to perform operations that result in
BrowserContextDependencyManager::AssertBrowserContextWasntDestroyed() being
called (e.g., BCKSFactory::GetServiceForContext()). When used with
TestingProfile::Builder, BCKSFactory::SetTestingFactory() is called *before*
the TestingProfile calls
BrowserContextDependencyManager::CreateBrowserContextServicesForTest(). These
facts set up the potential for a flaky crash: if the BrowserContext instance
being used is at the same address as one that had been used in a previous test,
then the call to AssertBrowserContextWasntDestroyed() will raise an error. This
CL eliminates the potential for that crash by explicitly informing
BrowserContextDependencyManager that the BrowserContext instance being used in
BCKSFactory::SetTestingFactory() is live.

NOTRY=true

Review URL: https://codereview.chromium.org/159763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251336 0039d316-1c4b-4281-b951-d872f2087c98

In this CL I introduce 2 classes (EmbeddedSharedWorkerDevToolsAgent, EmbeddedSharedWorkerStub).

EmbeddedSharedWorkerStub and EmbeddedSharedWorkerDevToolsAgent are almost same as WebSharedWorkerStub and SharedWorkerDevToolsAgent which are used in the worker process now.
These classes are not used yet.
EmbeddedSharedWorkerStub will be created when CreateWorker message is received by RenderThreadImpl.

In this CL I move shared_worker_devtools_agent.* from content/worker/ to content/child/ because I want use it from content/renderer/shared_worker.

BUG=327256

Review URL: https://codereview.chromium.org/158953008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251335 0039d316-1c4b-4281-b951-d872f2087c98

It will be used instead of WorkerMessageFilter when "enable-embedded-shared-worker" is set.

BUG=327256

Review URL: https://codereview.chromium.org/166273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251334 0039d316-1c4b-4281-b951-d872f2087c98

When crosscompiling for android on mac hosts, some machines don't have
the NLS header files available. Rather than insist on another build
dependency, just disable NLS when building yasm; we can live without
localisation in a build-time tool.

BUG=

Review URL: https://codereview.chromium.org/146833017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251333 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251332 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/165633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251331 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343024

Review URL: https://codereview.chromium.org/135013007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251330 0039d316-1c4b-4281-b951-d872f2087c98

On ES2 with OES_texture_float/OES_texture_half_float support, it is only possible to render to 16-bit half float textures using EXT_color_buffer_half_float. There's no support for rendering to 32-bit float textures in ES2 extensions. On ES3, rendering to some 32-bit float texture formats is exposed with EXT_color_buffer_float, but one must use the sized internal formats specified in ES3 core to do that. To expose this, a new command buffer extension is added which enables clients to directly use the sized internal format GL_RGBA32F.

A similar extension is also added to expose GL_RGB32F on desktop GL platforms for the sake of consistency.

These extensions are available whenever rendering to float textures is available. To support the current version of ANGLE, format conversions back to unsized internal formats are added to ui/gl.

Tests are added to cover this functionality. The new tests also add coverage for the handling of 32-bit float formats on ES2 and on desktop GL that existed before this patch.

BUG=329605
TEST=gpu_unittests, WebGL conformance tests

Review URL: https://codereview.chromium.org/139013008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251329 0039d316-1c4b-4281-b951-d872f2087c98

Apparently this type is not used by the unit tests and allow us to
remove another entry from the DEPS file.

BUG=140037
TEST=unit_tests
R=joi@chromium.org,blundell@chromium.org

Review URL: https://codereview.chromium.org/165453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251328 0039d316-1c4b-4281-b951-d872f2087c98