- 31 Jan, 2019 40 commits
-
-
Yue Li authored
- Wrap the sub-label of settings entry. - md-select items automatically shrink, adding a min-width to it. (not sure if this is intended?) Bug: b/123363474 Test: Manual Test Change-Id: Idd47e14a3b9d00dafe792f421660665d636e58b5 Reviewed-on: https://chromium-review.googlesource.com/c/1439460Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#627996}
-
Henrique Grandinetti authored
During the ActivityKeptInPref test case, the device status collector is reset, and the timezone retrieved on these two instantiations diverge which makes the test flaky. Originally, I tried to fix this by using UTCMidnight instead of LocalMidnight (crrev/r/1446471), however this broke other tests that are timezone dependent. The new solution stores the first baseline time used to instantiate the TestingDeviceStatusCollector and reuses it after the restart of this object. Bug: 891573 Change-Id: I1de2cd4f0140f496291652cc614d60b83b717608 Reviewed-on: https://chromium-review.googlesource.com/c/1448491 Commit-Queue: Sergey Poromov <poromov@chromium.org> Auto-Submit: Henrique Grandinetti <hgrandinetti@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#627995}
-
Joshua Pawlicki authored
changes. These tests flake one Mac 10.13 Tests (dbg). TBR=vasilii@chromium.org Bug: 922951 Change-Id: I3313766cec6460bd8c61e772d562eaed510499e5 Reviewed-on: https://chromium-review.googlesource.com/c/1447847Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#627994}
-
Xianzhu Wang authored
Background obscuration status is affected by many factors. Previously we cached the status, but invalidation of the cache was not complete, and it was difficult to keep it complete. Now we update background obscuration status during PrePaint, whenever the object is marked for any reason for PrePaintTreeWalk, which should cover all conditions that cause background obscuration change. Bug: 916050 Change-Id: Id044c9e724940f7a83c8dfc1aca8f3dde3526e96 Reviewed-on: https://chromium-review.googlesource.com/c/1444300 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#627993}
-
Julien Isorce authored
With a recent change, the webrtc::BasicDesktopFrame is created and initialized with 0. So it's not necessary to call memset() to the frame again any more. See https://webrtc-review.googlesource.com/c/src/+/97184/ Bug: webrtc:9703 Change-Id: Ic0f6d3f57bb2404825d8b72709509c1d7ba7a931 Reviewed-on: https://chromium-review.googlesource.com/c/1447021Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Cr-Commit-Position: refs/heads/master@{#627992}
-
Nick Diego Yamane authored
This patch makes CharacterComposer class reusable by other platforms, by moving character_composer{.h,.cc} files and its tests and auxiliary scripts out from ui/base/ime/chromeos into ui/base/ime so that it can be reused by other platforms. In particular, we intend to use it to properly handle dead keys in ozone/wayland configuration. The ozone/wayland integration will be done in a follow-up CL. In the future, ozone/x11 could also benefit from this. BUG=921947 Change-Id: Iff6cd82da9696279c0cd21afad7aba79a58baa8d Reviewed-on: https://chromium-review.googlesource.com/c/1446477 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#627991}
-
Vasilii Sukhanov authored
TBR=waffles@chromium.org Bug: 927334 Change-Id: Id15d137418ad267ed23dbcfb96c9a81747039dad Reviewed-on: https://chromium-review.googlesource.com/c/1448453Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#627990}
-
Clemens Arbesser authored
Immediately after starting the Chrome Custom Tab Activity, AA now automatically registers a synthetic trial with the 'Enabled' group. See also the related server CL: cr/231552009 Bug: 806868 Change-Id: I94db3e5a38700bf4f0d388bead52119f51602f40 Reviewed-on: https://chromium-review.googlesource.com/c/1445933Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#627989}
-
gambard authored
Several cells were very similar in settings. This CL is a first attempt to merge them. It removes the CardMultilineItem and EncryptionItem, using the TableViewTextItem instead. Bug: 925357 Change-Id: I53b787a3a362696eec3112981b90093e45f314ca Reviewed-on: https://chromium-review.googlesource.com/c/1443012 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#627988}
-
Kinuko Yasuda authored
Bug: n/a Change-Id: Ic5baa719de70bed2590e68a1c1f08f67e0124048 Reviewed-on: https://chromium-review.googlesource.com/c/1445672Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#627987}
-
Vladislav Kuzkokov authored
This eliminates some calls to |base::Value::Clone|. Change-Id: If142585263b1d8080385a063f2dae68263f29087 Reviewed-on: https://chromium-review.googlesource.com/c/1383051 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#627986}
-
Felipe Cerqueira authored
The designer (@johnpcassidy) proposed a new layout for the supervised users page: https://markup.googleplex.com/projects/1499 Due to urgency, we decided to apply first the changes related to accessibility (see b/72032640). Refactoring the layout was postponed to b/123570920, since it requires major changes in configuration for different devices (phone, tablet, etc.). Before this CL: https://screenshot.googleplex.com/yJoLNh5Mgq8 https://screenshot.googleplex.com/sxHTcQEf5Vz After this CL: https://screenshot.googleplex.com/LybxVLYWU69 https://screenshot.googleplex.com/n2mXDnWmweF Changes: 1) Updated font colors, size and line heights. 2) Changed the size of the avatar from 45px to 36px to make it more proportional. 3) Deleted some unused tags. Bug: 923026,b/72032640 Change-Id: If5c7e70c7253988728f6369efc9aa789256ce0da Reviewed-on: https://chromium-review.googlesource.com/c/1443691 Commit-Queue: Felipe Cerqueira <cerqueira@google.com> Reviewed-by:
Henrique Grandinetti <hgrandinetti@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#627985}
-
Vasilii Sukhanov authored
TBR=rockot@google.com Bug: 927234 Change-Id: Icae1de87586936063c3700054f9428ba48204826 Reviewed-on: https://chromium-review.googlesource.com/c/1448413Reviewed-by:
-
Clemens Arbesser authored
Recent changes to the onboarding terms & conditions have surfaced a problem where on small screens or when increasing the android font size, part of the onboarding content would be invisible because it did not fit. This can be seen in the following screenshot, where the buttons ('Cancel', 'I accept') are not visible: https://screenshot.googleplex.com/uKLQ1UV365h.png This CL wraps the onboarding inside a scrolling layout such that the buttons are always visible and the rest is inside the scrolling layout. Because the scrolling did interfere with the bottom bar swipe handle, swiping is now disabled for the onboarding screen. The new onboarding screen: https://screenshot.googleplex.com/J4zon1msk3R.png Scrolled down: https://screenshot.googleplex.com/2v9maEoPxzi.png Bug: 806868 Change-Id: I9b323133bcc735f71d2cee77a73cf7a085fe7b9b Reviewed-on: https://chromium-review.googlesource.com/c/1445591Reviewed-by:Theresa <twellington@chromium.org> Reviewed-by:
-
Jonathan Backer authored
SkiaOutputSurfaceOnGpuImpl::DestroySkImage may not be able to make the GL context current (e.g. tear down race or driver failure). In this case, we should not issue any GL calls. Most of these SkImages have an associated SharedImage. Eventually, all will. This notifies the SharedImage representation not to glDeleteTextures when the context is lost. Bug: 923473 Change-Id: I80f9777aa36278b021febc7b5492a0310deb0639 Reviewed-on: https://chromium-review.googlesource.com/c/1439622 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#627982}
-
gambard authored
This CL rolls MDC to 76.0.0, commit fa005e3a713d0a24c40b88916c53d36498c9256e. It moves the Shape and ShapeLibrary out of private. Bug: 927319 Change-Id: Ia9227999343d49348f519b3e0d2e53168dee2140 Reviewed-on: https://chromium-review.googlesource.com/c/1448166 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#627981}
-
Eric Roman authored
Assertion failures from DataPipe construction should now: (1) Include DataPipe::DataPipe() in the stack trace. (2) Include CrashMojoResourceExhausted() in the stacktrace if the failure was due to MOJO_RESULT_RESOURCE_EXHAUSTION. The goal is to make it easier to bucket incoming crash reports. Crashes due to resource exhaustion are often not actionable. Bug: 921799 Change-Id: I20fcc0a04e01ce7a829d2a1e4644b26c1f8c1139 Reviewed-on: https://chromium-review.googlesource.com/c/1444832Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#627980}
-
Sylvain Defresne authored
Convert client of the deprecated of PrefValueMap::SetValue taking a std::unique_ptr<base::Value> to the recommended override taking a base::Value directly. The conversion is done using the following rules: - If the value is built inline using std::make_unique<base::Value> then change to just construct a base::Value directly, - If the value is built use base::Value::CreateDeepCopy(), then change to use base::Clone() which returns a base::Value instead of a std::unique_ptr<base::Value>, - If the std::unique_ptr<base::Value> is just forwarded by the caller, dcheck it is not null (the check was present in the old method implementation) and use base::Value::FromUniquePtrValue to convert the std::unique_ptr<base::Value> to a base::Value. This CL fixes uses in src/chrome/browser/spellchecker. This CL was uploaded by git cl split. Bug: 646113 Change-Id: I0cc2c207c8e1fdf11710c29aa0ca78fb982758a8 Reviewed-on: https://chromium-review.googlesource.com/c/1446356Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#627979}
-
Arthur Hemery authored
In the model of the NavigationClient navigation interface, the renderer does not send a message notifying the browser that it committed. Instead, it runs the mojo callback that was passed to it at commit. In practice, this means that both SimulateCommitProcessed and DidCommitProvisionalLoad are part of the callback, instead of just the former. Because changing the callback means changing signatures, significant work has to be done to both be able to pass around the new callback and maintain a sane architecture that avoids code duplication. This patch only implements the callback change for SUCCESSFUL commits. CommitFailedNavigation will be handled in a second patch. The architecture should be the exact same, this is simply to keep test failures to a manageable level while debugging/landing. Note: This patch is fully behind the PerNavigationMojoInterface flag. Please see https://chromium-review.googlesource.com/c/chromium/src/+/1344107/ for the trybot runs with the PerNavigationMojoInterface flag on. Please see https://docs.google.com/document/d/1mXjxYJptb_bZ_EqGMF-c4LTSnhjt6Gn_WVvSrsinpq8/edit for the design doc. Bug: 784904 Change-Id: I9efdd25bfd289a2e76c5bf43e32e2dc0c589ad25 Reviewed-on: https://chromium-review.googlesource.com/c/1344091 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#627978}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1bd245b91801..d20cf3347241 git log 1bd245b91801..d20cf3347241 --date=short --no-merges --format='%ad %ae %s' 2019-01-31 michaelludwig@google.com Add new thin anti-aliasing demo Created with: gclient setdep -r src/third_party/skia@d20cf3347241 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: I505abc42193d1cd2deea82af600eaf221475ca98 Reviewed-on: https://chromium-review.googlesource.com/c/1448021Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#627977}
-
Michael Lippautz authored
Teardown garbage collections do not consider V8 wrappers as roots. Previously this was achieved by clearing out the internal wrapper fields of JS objects which caused a bailout during visitation. This is not necessary, as V8 ignores outgoing references once no more tracer is attached (see V8PerIsolateData::WillBeDestroyed). Blink can then just ignore DOM wrappers by not considering them in first place for termination garbage collections. Change-Id: I4b698b809e5eeb10a5a6f1fa9bdde9c133fec320 Reviewed-on: https://chromium-review.googlesource.com/c/1448216Reviewed-by:
-
Veranika Liaukevich authored
New exit codes will be used by the software reporting tool to signal whether the engine was scanning the registry or the file system at the moment when the watchdog terminated the process. Change-Id: Ied95c7a8451ccbc4fb474bddddc22c2f116b8d97 Reviewed-on: https://chromium-review.googlesource.com/c/1446862Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#627975}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/35f199648fe8..faa547c0731a git log 35f199648fe8..faa547c0731a --date=short --no-merges --format='%ad %ae %s' 2019-01-31 fmayer@google.com Merge "Increase timeouts for heapprofd integration tests." Created with: gclient setdep -r src/third_party/perfetto@faa547c0731a The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I212737454e2778d66de80c482b24e56b138f71bb Reviewed-on: https://chromium-review.googlesource.com/c/1448022Reviewed-by:
-
dsinclair authored
This reverts commit 65a33562. Reason for revert: Angle BUILD has been fixed, rolling this back in before re-starting the auto-roll bot. Original change's description: > Revert "Roll src/third_party/SPIRV-Tools/src 7f1a020abc82..464111eaef80 (1 commits)" > > This reverts commit 9912353f. > > Reason for revert: the roll breaks compare_build_artifacts crbug/926354 > > Original change's description: > > Roll src/third_party/SPIRV-Tools/src 7f1a020abc82..464111eaef80 (1 commits) > > > > https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7f1a020abc82..464111eaef80 > > > > > > git log 7f1a020abc82..464111eaef80 --date=short --no-merges --format='%ad %ae %s' > > 2019-01-29 stevenperron@google.com Remove use of deprecated googletest macro (#2286) > > > > > > Created with: > > gclient setdep -r src/third_party/SPIRV-Tools/src@464111eaef80 > > > > The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll > > > > Documentation for the AutoRoller is here: > > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > > > If the roll is causing failures, please contact the current sheriff, who should > > be CC'd on the roll, and stop the roller if necessary. > > > > > > TBR=dsinclair@chromium.org > > > > Change-Id: If37766e89c0fd21f4ddab20db4545feee1c0545d > > Reviewed-on: https://chromium-review.googlesource.com/c/1445791 > > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > > Cr-Commit-Position: refs/heads/master@{#627391} > > TBR=dsinclair@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com > > Change-Id: Iaa751145328372a9fb636f5a19d362eafca9dbe8 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/1446211 > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#627405} TBR=dsinclair@chromium.org,vasilii@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I853d24e9ef8fd470d628f724e76ac337e6317a7e Reviewed-on: https://chromium-review.googlesource.com/c/1447840Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#627973}
-
Julie Jeongeun Kim authored
This CL removes AccountTrackerService from authentication_service.mm and uses IdentityManager instead of it. It adds ReloadCredentials in AuthenticationServiceTest.MigrateAccountsStoredInPref to get refresh tokens for finding account info with IdentityManager. Bug: 922795 Change-Id: Ieac574b678aff04179f2bed4952af90d1ae6a126 Reviewed-on: https://chromium-review.googlesource.com/c/1433376Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#627972}
-
Chris Lu authored
Move the find_in_page/ directory into //ios/web/ and //ios/web/public/ Bug: 896867 Change-Id: Ifd73838af8a5f83f399a12fb277d2b7690977bf5 Reviewed-on: https://chromium-review.googlesource.com/c/1446865Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#627971}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0198e1a4756a..0ec02f9abd06 Created with: gclient setdep -r src-internal@0ec02f9abd06 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891734 TBR=mmoss@chromium.org Change-Id: I3a19d0dbef96fa60910dab6193f7851f15772181 Reviewed-on: https://chromium-review.googlesource.com/c/1448020Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#627970}
-
Dominic Battre authored
In PasswordManager.FillingAssistance we record whether the user was supported at logging into a site. One case is that this is not happening because the user has no saved credentials. This CL introduces an enum to indicate that there are no saved credentials and the user does not get offered to save them anymore. Bug: 918846 Change-Id: I2a041649e629ea38f859a4d88204db6b8fddfb2c Reviewed-on: https://chromium-review.googlesource.com/c/1448164 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#627969}
-
Dominik Röttsches authored
These tests were comparing offsetLeft, but there were pixel differences which made some of the tests fails. Using a less than 1 getClientBoundingRect().left difference instead, cleaning up the code and removing expectations file due to these robustly passing now. The pixel differences are not relevant to the intention of the test. Bug: 927287 Change-Id: I74fe8d64edb1a52de4fd0dbb3143843b305f8156 Reviewed-on: https://chromium-review.googlesource.com/c/1448215 Commit-Queue: Dominik Röttsches <drott@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#627968}
-
Lowell Manners authored
Tests which call GetIdentityTestEnvironmentFactories() don't set any fake cookie responses, so they don't need to create a FakeGCMS. This CL is part of eliminating FakeGCMS entirely: https://docs.google.com/document/d/1t0ZtuV7h-znzdItFgBW0aKPscAwWXIBuNZnNlEGgi7g/edit Bug: 907782 Change-Id: Ic42dcd215ecf9ca162e96cfa37d3424ead703ea7 Reviewed-on: https://chromium-review.googlesource.com/c/1445909 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#627967}
-
Henrique Ferreiro authored
Replace with IdentityManagerFactory. This matches what SigninManager is using. Bug: 927239 Change-Id: I8888e94e3032b323c78f65fbdeaf455a57cb27bc Reviewed-on: https://chromium-review.googlesource.com/c/1448155Reviewed-by:
-
Marek Haranczyk authored
Bug: 915659 Change-Id: Ib277ee462b14fbeba96b065149ea413461a51cda Reviewed-on: https://chromium-review.googlesource.com/c/1448154Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#627965}
-
Nikita Podguzov authored
Modify WallpaperController interface to support external data type policy. Remove WallpaperPolicyHandler as its functionality was replaced by DeviceCloudExternalDataPolicyObserver. Bug: 814364 Change-Id: I022989ae13464ef6f7e3653a216d052e37e7d37f Reviewed-on: https://chromium-review.googlesource.com/c/1406694 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#627964}
-
Henrique Ferreiro authored
This include is not used. Bug: 927240 Change-Id: Ie6035f1ed59db494cf875118e9dda114d9dbe65e Reviewed-on: https://chromium-review.googlesource.com/c/1448217Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#627963}
-
Daniel Bratell authored
A test() target with no deps (maybe only public_deps or no deps at all) would fail to compile on android because of a "deps += [...]" statement. Bug: 927257 Change-Id: I7fa3172a1f9cdca146800b8f81b965cfd46f81e9 Reviewed-on: https://chromium-review.googlesource.com/c/1443016Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#627962}
-
Vasilii Sukhanov authored
TBR=mmenke@chromium.org Bug: 922876 Change-Id: I82c925d0c3dc1279b3da8a2b7a0e9c772ca7da26 Reviewed-on: https://chromium-review.googlesource.com/c/1448232Reviewed-by:
-
Joshua Pawlicki authored
Bug: 922951 Change-Id: Ib089a473c1a99828726fa4c35e03646304aa752a Reviewed-on: https://chromium-review.googlesource.com/c/1447837 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
-
Christian Dullweber authored
LocalStorage deletion due to Clear-On-Exit is flaky on all plattforms. Disable this part of the test. TBR: jsbell@chromium.org Bug: 927312 Change-Id: I3833461f283704bc5db2c52816e42013672c531c Reviewed-on: https://chromium-review.googlesource.com/c/1448186Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#627959}
-
Nico Weber authored
Per discussion on bug. Bug: 877080 Change-Id: I7d5c8c4a5ab6887c1cc9885b8035c3bb83a2e9b3 Reviewed-on: https://chromium-review.googlesource.com/c/1443513Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#627958}
-
edchin authored
The bug referenced below was caused by a bad side-effect of a recent CL. The CL moved a |-closeAllTabs| call from BVC to BrowserViewWrangler. Previously, the |-closeAllTabs| call was essentially a NO-OP since |-browserStateDestroyed| was called a few lines earlier. Moving the call made it actually perform an action. TabModel's |-closeAllTabs| should not be called at shutdown because the method is only intended to be called when the user has taken action. It sets the CLOSE_USER_ACTION flag. Futhermore, at shutdown, |-closeAllTabs| does not need to be called. BrowserViewWrangler calls |-setMainBrowser:| which calls |-browserStateDestroyed| which calls WebStateList's |closeAllWebStates()| with the flag CLOSE_NO_FLAGS. This fixes the issue in the bug. The bug was that snapshots were being removed during shutdown. This was happening because snapshots are removed whenever a WebState is closed by user's action. There is no reason to revert the offending CL as this CL fixes the issue and the other parts of that CL are useful. Offending CL: https://chromium-review.googlesource.com/c/chromium/src/+/1388933 Bug: 927171 Change-Id: Ib9ccf125d93d28424fbf7d67ea72f8a06d9a7f2b Reviewed-on: https://chromium-review.googlesource.com/c/1446663 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#627957}
-
