- 01 Sep, 2018 23 commits
-
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4259762b3597..e323bd9d2263 git log 4259762b3597..e323bd9d2263 --date=short --no-merges --format='%ad %ae %s' 2018-08-31 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-31 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-31 nodir@google.com [bot_update] Untie revision and repository properties Created with: gclient setdep -r src/third_party/depot_tools@e323bd9d2263 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:877161,chromium:694348 TBR=agable@chromium.org Change-Id: I2435f620a6af4d970ed09912de690acbafa7523a Reviewed-on: https://chromium-review.googlesource.com/1199875Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588240}
-
Dominic Farolino authored
This follows up http://crrev.com/c/927701, mentioning that not all requests have their priority pushed down to the lowest, but that there is more granularity. R=kinuko@chromium.org, tbansal@chromium.org Bug: N/A Change-Id: I6112d8fdf8948552acc0a188c75b89aa2ef8f425 Reviewed-on: https://chromium-review.googlesource.com/1200583Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#588239}
-
Victor Miura authored
Appending entries to visible_rect_history was a hotspot in profiling. Changing to std::deque, and re-ordering the update code so the deque only grows to 2 entries rather than 3. BUG=879668 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I576ba0ae278a04a0e7336b3b1cd589fadd25b177 Reviewed-on: https://chromium-review.googlesource.com/1200466Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#588238}
-
Erik Luo authored
This makes Consoles messages focusable and navigable using: ArrowUp/Down/Left/Right, Home, End Screenshot: https://imgur.com/a/6JWY0iU Bug: 865674 Change-Id: I4166bf4d8d57856c6d1f7d51ef29e2dea0c088eb Reviewed-on: https://chromium-review.googlesource.com/1144453 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#588237}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b8e60f98418e..5167fb3f6694 git log b8e60f98418e..5167fb3f6694 --date=short --no-merges --format='%ad %ae %s' 2018-09-01 chiniforooshan@chromium.org Telemetry: latency metrics in TBMv2 Created with: gclient setdep -r src/third_party/catapult@5167fb3f6694 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:760553 TBR=sullivan@chromium.org Change-Id: Ifa1bc9ed82007576631a28271769ef7b3a667cf9 Reviewed-on: https://chromium-review.googlesource.com/1200169Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588236}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ca3a100e7dcf..a38996be8593 git log ca3a100e7dcf..a38996be8593 --date=short --no-merges --format='%ad %ae %s' 2018-08-31 tsepez@chromium.org Remove avail_buf out argument from GetAvailInput() methods. Created with: gclient setdep -r src/third_party/pdfium@a38996be8593 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ibf88905a34a202949c3c4035930e72224a308708 Reviewed-on: https://chromium-review.googlesource.com/1199874Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588235}
-
Weilun Shi authored
Changing the CSS setting and manually changing font family to Segoe UI on Windows instead of depending on the automatic fallback on CSS. Bug: 867778 Change-Id: I3c2fed3453639c6a8d1a4cb61cb88af3af33354b Reviewed-on: https://chromium-review.googlesource.com/1200310Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#588234}
-
yusukes authored
This allows chrome://settings/inputMethods to show up-to-date IME information without closing and reopening the settings window. For example, when the language X is enabled on the device and a new Chrome OS IME extension for the language X is installed, it'll instantly show up in chrome://settings/inputMethods. The same happens for Android IMEs installed via Play Store too. BUG=867795,845079 TEST=Add 'Japanese' to the language list, open chrome://settings/inputMethods, install 'SKK Japanese Input' (extension IME) from Chrome Web Store, verify the IME entry ('SKK') shows up in the settings page immediately. TEST=Go to extensions page, disable the SKK IME, verify 'SKK' disappears immediately. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I20f7586cd58e7d6c6f92f37c1f0b697d57d17d32 Reviewed-on: https://chromium-review.googlesource.com/1198106 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#588233}
-
Stephen Martinis authored
Bug: 846740 Change-Id: I391e6d3d9eb7999be5c35bfccec39e36ada9812f Reviewed-on: https://chromium-review.googlesource.com/1200317Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#588232}
-
Jian Li authored
1) Do not show offline indicator UI on offline page 2) If the page is still being loaded, wait until it is done and then decide whether to show offline indicator UI. Bug: 879705 Change-Id: I31f3df33ca19544b846e8cb60d2d1bc87c9b2439 Reviewed-on: https://chromium-review.googlesource.com/1138987 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#588231}
-
Dale Curtis authored
This can occur if an error occurs before FFmpegGlue has been created by the demuxer. BUG=879400 TEST=none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I35349e94ab7c8d164210f91073e05b50d3c58482 Reviewed-on: https://chromium-review.googlesource.com/1199772Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#588230}
-
Lei Zhang authored
base: :MappedReadOnlyRegion is simpler to use than base: :SharedMemoryHandle. Change-Id: I3d00fdc56dc796f0a20724133cad8ade78107edf Reviewed-on: https://chromium-review.googlesource.com/1186272Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#588229}
-
Matt Wolenetz authored
Changes MediaSource's |attached_element_| from WeakMember to Member, preventing collection of an element that is still attached by MSE when either of them are still reachable by GC Trace. This change also removes CloseMediaSource() from prefinalization of HTMLMediaElement, since any still-attached MediaSource during HTMLMediaElement's prefinalization is also not referenced by anything GC Trace can reach. BUG=856022 TBR=keishi@chromium.org,haraken@chromium.org Change-Id: I464b89d67323bc6527aa6b7b5b11ce5cdf774756 Reviewed-on: https://chromium-review.googlesource.com/1199780 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#588228}
-
Charlie Reis authored
There is no guarantee that the DocumentLoader is always attached [1], so let's introduce null checks in StateInternal and setScrollRestoration. [1] The DocumentLoader may be detached while FrameLoader::PrepareForCommit. BUG=879477, 872672 Change-Id: I048ad8ff3787fcead262c19fcdb485e9e5a5e3bf Reviewed-on: https://chromium-review.googlesource.com/1200075 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#588227}
-
Will Harris authored
Also remove legacy /WD4267 and replace with the compiler config. Warnings being suppressed are here: https://pastebin.com/raw/QkwwCZLb BUG=879657 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If145532f415cdcc4c52a48dc11f421171538b25d Reviewed-on: https://chromium-review.googlesource.com/1199869Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#588226}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/68de241167e0..ee3f5c44326d git log 68de241167e0..ee3f5c44326d --date=short --no-merges --format='%ad %ae %s' 2018-08-31 ayatane@chromium.org sysmon: Fix name for lucifer process metric 2018-08-31 chingcodes@google.com signing: add Shellball extract and repack operations Created with: gclient setdep -r src/third_party/chromite@ee3f5c44326d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I2f8405f4c7ffce97fc371de76598a68cf35b8751 Reviewed-on: https://chromium-review.googlesource.com/1200373Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588225}
-
braveyao authored
We suspect the problem in issue879672 is caused when ComThread callback for UWP device enumeration happens after VideoCaptureDeviceFactoryWin instance is destroyed. This cl is to try to stop running ComThread for UWP enumeration in the dtor. Bug: 879672 Change-Id: I622ff15815a0844833f87a5ba5390fc7c0e5ebd1 Reviewed-on: https://chromium-review.googlesource.com/1200465Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#588224}
-
Alan Cutter authored
This CL updates the opening animation for hosted app titlebars to match recent UI mocks by: - Removing the slide motion but retain the fade animation of the origin text. - Making the origin text bold. - Synchronising the fade durations of the origin text and app menu button highlight. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355048&signed_aid=mI6IiKwlkm5uzn4Cv6Asxg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355049&signed_aid=bfJDeHt7BMIqsW1SYf3DRg==&inline=1 This CL only includes the minimal changes needed to update the animation to be suitable for merging to M70. Further code clean ups have been moved to: https://chromium-review.googlesource.com/c/chromium/src/+/1198707/1 Bug: 878187 Change-Id: I0938f124e39ebf113843e62d63d6a0b9dc4417cc Reviewed-on: https://chromium-review.googlesource.com/1192463Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#588223}
-
braveyao authored
Form a recent crash report, it looks like the IAsyncOperation:GetResult may return a null pointer. So add a null check for the result. Bug: 879669 Change-Id: I9ab31df7b1ec165123a4f98683970f48f2bf3454 Reviewed-on: https://chromium-review.googlesource.com/1200318Reviewed-by:
-
Jeffrey Kardatzke authored
Bug: chromium:869747 Test: Unit tests pass Change-Id: I40512bee8b797d2861e6492876e75bd36668fd58 Reviewed-on: https://chromium-review.googlesource.com/1199777Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#588221}
-
Manu Cornet authored
Replace the logic in ShelfView's overridden OnPaint with a simpler view and rounded corners. You can see a screenshot in comment #17 of the linked bug. Bug: 874161 Change-Id: I416e670ca578e6fd5d4e7681c8c19acf2fa17c3a Reviewed-on: https://chromium-review.googlesource.com/1198525Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#588220}
-
John Budorick authored
This also rewrites some of the args logic in generate_buildbot_json.py and allows for callers to supply additional keys containing args they'd like to pull in (e.g. "gtest_args" for args that should apply only to gtests). Bug: 878321 Change-Id: I2314c90d5959f3cfdaa3898a2de1af2331d07002 Reviewed-on: https://chromium-review.googlesource.com/1197407Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#588219}
-
Carlos IL authored
Follow up to crrev.com/c/1189058, there were checks for IsUnifiedConsentFeatureEnabled that were redundant, they were now removed. Change-Id: I388b738d2ab65f12556fa4595f7a93266250205f Reviewed-on: https://chromium-review.googlesource.com/1199571Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#588218}
-
- 31 Aug, 2018 17 commits
-
-
Dan Sanders authored
This CL changes DecoderStream to maintain an instance of DecoderSelector continually. This enabled DecoderSelector to maintain DecryptingDemuxerStream state and the blacklist internally. An immediate consequence is that DecoderSelector can now always try the full list of potential decoders each time that selection is triggered. This fixes the GPU->GPU changeType() transition, and provides a foundation to build GPU fallforward on top of. Another consequence is that fallback can occur more than once for a stream. It is no longer possible to loop forever doing fallbacks, so this is a robustness improvement in addition to being a requirement for changeType(). Bug: 877673 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I030c9746c30e0339001ae1734d8c91d2b9bf2de0 Reviewed-on: https://chromium-review.googlesource.com/1200223Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#588217}
-
Simeon Anfinrud authored
This should make Observers.onEnter() more efficient, since it no longer allocates a new Scope every time it's opened. This can be used anywhere else you need a no-op Scope as well, which yields the benefit of not generating a new class for a no-op lambda in the dex file. Bug: None Test: cast_base_junit_tests Change-Id: I9e8130eee78d269e9cfb157ab10463a7d8473a06 Reviewed-on: https://chromium-review.googlesource.com/1197582Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#588216}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7bfe8438a94b..554ad9846a8b git log 7bfe8438a94b..554ad9846a8b --date=short --no-merges --format='%ad %ae %s' 2018-08-31 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-31 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 fd1621076a74..253038d8d13b (12 commits) 2018-08-31 brianosman@google.com Reland "Use skcms_PrimariesToXYZD50 to implement SkColorSpacePrimaries::toXYZD50" 2018-08-31 bsalomon@google.com Add script to pull svgs to svgs/ and add to .gitignore 2018-08-31 caryclark@skia.org add circles to stroked cubics with cusps Created with: gclient setdep -r src/third_party/skia@554ad9846a8b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I84a90413fa2ab82a0e68df8b9192c5ac54e7cce5 Reviewed-on: https://chromium-review.googlesource.com/1200374Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588215}
-
Oksana Zhuravlova authored
Bug: 879757 Change-Id: Ib8fbd95f086d95fc0f1ac00526059a7383e2ca24 TBR=boliu@chromium.org Change-Id: Ib8fbd95f086d95fc0f1ac00526059a7383e2ca24 Reviewed-on: https://chromium-review.googlesource.com/1200165Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#588214}
-
Daniel Zhang authored
1. Change behavior of AppList corners from animating from round to angular to no longer animating and disappearing offscreen at the top of the screen. 2. Fixed broken unit tests. Bug: 874200 Change-Id: I0983794bc58542a790b42bc3fcc17b64cc11e1b5 Reviewed-on: https://chromium-review.googlesource.com/1194862Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Michael Giuffrida authored
This reverts commit 9f818c41. Reason for revert: https://crbug.com/872786 Original change's description: > cros: move TapToClick prefs to ash > > changes: > * Move kTapToClickEnabled and kOwnerTapToClickEnabled handling to ash > * In this CL, above pref registrations are still in chrome side because > ash side doesn't have device owner info yet. > > TBR=stevenjb@chromium.org > > Bug: 817643 > Test: manual and test coverage > Change-Id: I6b11eb65a40968eada67ebf2e8b4fb3f1f0eaddc > Reviewed-on: https://chromium-review.googlesource.com/1116210 > Commit-Queue: Qiang Xu <warx@google.com> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570842} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 872786 Test: On another device, sign in with an account and disable touchpad tap-to-click. Then on the target device, complete OOBE with the same account. In the first user session, tapping should not cause clicks. After signing out, tapping should also not cause clicks. Change-Id: I67a67ba51b56bd14e656e332f8f64e219e3f80ef Reviewed-on: https://chromium-review.googlesource.com/1199873Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
Alexander Alekseev authored
This CL extracts PIN-setting element into separate Polymer object which could be used outside of Settings UI. Bug: 852553 Change-Id: I6da7b1dd0aaffde3b0c220bc2dd1650307904950 Reviewed-on: https://chromium-review.googlesource.com/1196763 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Becky Zhou authored
Bug: 879130 Change-Id: Ic7831023f25c77c9a7b6843563101a6808c7f753 Reviewed-on: https://chromium-review.googlesource.com/1200306Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#588210}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6fc719e87628..b8e60f98418e git log 6fc719e87628..b8e60f98418e --date=short --no-merges --format='%ad %ae %s' 2018-08-31 dtu@chromium.org [pinpoint] Tighten chart bounds. Created with: gclient setdep -r src/third_party/catapult@b8e60f98418e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I7b31f1a89a9c6b0e7423d53c3f17832aa0c91bcf Reviewed-on: https://chromium-review.googlesource.com/1199870Reviewed-by:
-
Kenneth Russell authored
Bug: 879704 No-Try: True Change-Id: I454192e7c0cde3883bfe43e76029727b4924bfc1 Reviewed-on: https://chromium-review.googlesource.com/1200312 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#588208}
-
Stephan Stross authored
The ScenicSession class underwent a breaking name change on the functions OnError, OnEvent -> OnScenicError, OnScenicEvent, and so this change modifies the names in the impl to get it building again. Change-Id: I5ebad87fa16c002344ecd232da05157c0871890f Bug: 707030 Reviewed-on: https://chromium-review.googlesource.com/1200406Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#588207}
-
Xianzhu Wang authored
especially on CQ bots (which has DCHECK enabled): https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests%20(with%20patch)&tests=inspector-protocol%2Fheap-profiler%2Fheap-snapshot-with-no-detached-iframe.js TBR=wangxianzhu@chromium.org Bug: 878650 Change-Id: Ibdcaa931c8820e9dfcf2f6c3e88922aa7345dc5b No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1199720Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#588206}
-
Chris Harrelson authored
r581008 added a call to SetNeedsCompositingInputsUpdate in LayoutView whenever overflow needed to be recomputed. It actually only needs to do that when overflow actually changes. This regresses any site which causes LayoutView overflow recomputation during animations. The call to SetNeedsCompositingInputsUpdate already exists in LayoutBlock::ComputeOverflow, and correctly only does it when overflow changes. An example is tools/perf/page_sets/key_silk_cases/pushState.html, which was one of the key silk sites that regressed in issue 872172. In that case, main frame times approximately doubled, because of the extra work to compute compositing inputs. crbug.com/872172 Change-Id: Iaf4780c0e3ed4d8df67d16d836486df6df0d2f43 Reviewed-on: https://chromium-review.googlesource.com/1200315Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#588205}
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/d636a4fae3c1..cb6ec4b1f91a git log d636a4fae3c1..cb6ec4b1f91a --date=short --no-merges --format='%ad %ae %s' 2018-08-31 hinoka@chromium.org Revert "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain""" Created with: gclient setdep -r src/native_client@cb6ec4b1f91a The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=mseaborn@chromium.org Change-Id: Ibb7a64bb3f5994bcb922a3175584c10485707eda Reviewed-on: https://chromium-review.googlesource.com/1200325Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588204}
-
Eric Foo authored
Bug: 731363 Change-Id: I9506337b62d6a98eba462520cdf545a6d58f62b5 Reviewed-on: https://chromium-review.googlesource.com/1199821Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#588203}
-
Carlos Knippschild authored
This adds translation screenshots for the regular dino page on Android/iOS and for one branch of the offline content experiment. This is based on the translation screenshot process described here: https://docs.google.com/document/d/1nwYWDny20icMSpLUuV_LgrlbWKrYpbXOERUIZNH636o Bug: 852872 Change-Id: I7363609fa8d53ef3ad28b9101a30d618455f084c Reviewed-on: https://chromium-review.googlesource.com/1199849Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Edward Jung <edwardjung@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#588202}
-
Xianzhu Wang authored
This CL tries to correct the box model when there are scrollbars, especially in vertical-rl mode. According to https://www.w3.org/TR/css-overflow-3/#scrollbar-layout, scrollbars "should be inserted between the inner border edge and the outer padding edge". Changes to the previous code: - Padding|client box now excludes scrollbars, with the help of (Top|Left|Bottom|Right)ScrollbarWidth methods which can get the scrollbar widths in physical directions in various writing modes. - Content box is now based on the new padding box by excluding the paddings. - Layout of contents is now based on the correct box model. In vertical-rl mode, layout of contents in blocks direction starts from the inner edge of the new content box which has been properly adjusted for the scrollbar. - Now LayoutBox::Location() and Location::PhysicalLocation() in the initial scroll state are correct in all writing-modes. Previously when they were incorrect in vertical-rl mode and some flex box directions, requiring an artificial scroll offset to paint the content at correct place. - With the correct padding box, content box, Location(), PhysicalLocation(), we no longer need the band-aid code to create the correct painted result. The changed code is mostly in LegacyLayout code. Some changed code is in LayoutNG that previously converted correct LayoutNG geometries into the problematic geometries that were previously expected by LegacyLayout. The correct box model is required by blink-gen-property-trees because we can't band-aid the incorrect results in paint properties after painting. Bug: 833167,853945,858843,878809,876266 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I41faf1ca0bfb95cb287c72703f08c8bd44e9e752 Reviewed-on: https://chromium-review.googlesource.com/1185901Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#588201}
-
