GitLab

dmprof has classified memory usage by pattern-matching with function names.
It adds another classification by pattern-matching with source file names.

BUG=225343
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/13514003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193022 0039d316-1c4b-4281-b951-d872f2087c98

cc is nearly spotless with cpplint warnings, so let's keep it that way.
The CommonChecks lint warning turns off a ton of errors that I would
prefer to keep on.  I turned it to level 1, since that's the default
when running cpplint.py.

This doesn't appear to be on by default.

R=jamesr@chromium.org
BUG=227196


Review URL: https://chromiumcodereview.appspot.com/13483022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193021 0039d316-1c4b-4281-b951-d872f2087c98

This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.

BUG=none

Review URL: https://codereview.chromium.org/13145003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98

* Catch exception in CheckKVM in case kvm-ok is not available.
* Add abi option for launching emulator.

This patch is contributed by Wu Hengzhi (hengzhix.wu@intel.com).

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/13300002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193019 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/13800005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193018 0039d316-1c4b-4281-b951-d872f2087c98

Here is first cut at adding the long-awaited browser tests for Drive in
Files.app. In this patch, only "TestFileDisplay" is ported to Drive.
Other tests will be ported in separate patches.

BUG=224534
TEST=none; just added a test.

Review URL: https://codereview.chromium.org/13602004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193016 0039d316-1c4b-4281-b951-d872f2087c98

Our Push Messaging test fails a fraction of the time (perhaps 10-20% of the
time).  The way that the push messaging test works is that it is a buildbot
which builds the source and then runs the test, so to test this I need to check
the source code in for the buildbot to run the test for me, even though the code
is not final.

The current theory is that the Push Messaging Canary Test is exiting immediately
after recieving the push message from the wire. The invalidation code (Push
Messaging relies on A sync invalidation service, which has a library that
reports reciept of the message back the server.  It seems that the reports back
to the server are not reliable, so the server thinks the client is flaky.

To investigate a fix to this, I'll add code which delays the time test by two
seconds to allow the ack to propagate back to the invalidation service.

BUG=229038

Review URL: https://chromiumcodereview.appspot.com/13483025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193015 0039d316-1c4b-4281-b951-d872f2087c98

BUG=180095
TEST=none


Review URL: https://chromiumcodereview.appspot.com/12851023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193014 0039d316-1c4b-4281-b951-d872f2087c98

This value is redundant.  We can use the root cliprect size or the
device_viewport_size divided by device_scale_factor instead.

This value was only used by PinchZoomScrollbars, I replaced it
with one that should be equivalent.

NOTRY=true
BUG=229098


Review URL: https://chromiumcodereview.appspot.com/13637017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193013 0039d316-1c4b-4281-b951-d872f2087c98

This will give us reasons for 6 of the top 7 most common failing methods. RenameFile doesn't have a histogram because base::ReplaceFile only returns a bool. Plumbing an error value is planned.

BUG=225051


Review URL: https://chromiumcodereview.appspot.com/13838003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193012 0039d316-1c4b-4281-b951-d872f2087c98

http://crrev.com/192706 broke top controls hiding because this situation
doesn't cause any damage, meaning no renderer frames are sent.  Fix it
by causing full root layer damage whenever one of the inputs to
VisibleViewportSize changes.

NOTRY=true
BUG=229138


Review URL: https://chromiumcodereview.appspot.com/13817003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193011 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds new scrollbars and restyles the preview images to match the recent specs.

TEST=Run chrome with --file-manager-new-ui, launch Files.app and verify.
BUG=226912


Review URL: https://chromiumcodereview.appspot.com/13783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193010 0039d316-1c4b-4281-b951-d872f2087c98

On the selected kiosk app runs in this mode, so we don't need any system UI including component extensions/apps.
 

BUG=227314
TEST=none


Review URL: https://chromiumcodereview.appspot.com/13610005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193009 0039d316-1c4b-4281-b951-d872f2087c98

 Moved EnsurePointerInDisplays to DisplayController as it needs to access RootWindow.


BUG=226300
TEST=covered by test.

Review URL: https://chromiumcodereview.appspot.com/13466022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193008 0039d316-1c4b-4281-b951-d872f2087c98

chromeos: Stop directly downloading files to the cache directory from DriveFileSystem::GetResolvedFile

Stop directly downloading files to cache directory, create temporary file instead.
Always free disk space from DriveCache::Store, regardless of the file operation type.

BUG=160487
TEST=unit_tests


Review URL: https://chromiumcodereview.appspot.com/13772005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193007 0039d316-1c4b-4281-b951-d872f2087c98

During tests that verify behaviour with checkerboarding, we need
preductable behaviour. Currently if the test takes too long and
the compositor thread ticks too many times, the checkerboarded
animation will time out and animate+draw. This is unpredictable
flaky behaviour for the tests. So add a setting to disable this
timeout-and-draw behaviour in the scheduler.

R=jamesr
BUG=228998

Review URL: https://chromiumcodereview.appspot.com/13577005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193006 0039d316-1c4b-4281-b951-d872f2087c98

This works by adding a new flag to the content layer:
kDisableHTMLNotifications, which causes Chrome not to expose the
webkitNotifications.createHTMLNotification function to JS contexts.
Chrome appends this switch to new renderer processes when appropriate
in ChromeContentBrowserClient.

BUG=225918


Review URL: https://chromiumcodereview.appspot.com/13533019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193005 0039d316-1c4b-4281-b951-d872f2087c98

In particular, split them into header / body format and
update their appearance a little, removing bold menu item
names.

BUG=174194

Review URL: https://chromiumcodereview.appspot.com/13471007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193004 0039d316-1c4b-4281-b951-d872f2087c98

Often this action is triggered and only actually needs to strip few/no
native libraries (i.e if only base.so changes there is no need to strip
all the other libraries). Add modified time checking to this action.

Since the input files are very large, using md5 checking is too slow
(i.e. it is not much, if any, faster than just doing the strip).

BUG=158821


Review URL: https://chromiumcodereview.appspot.com/13504003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193003 0039d316-1c4b-4281-b951-d872f2087c98

BUG=226755


Review URL: https://chromiumcodereview.appspot.com/13482012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193002 0039d316-1c4b-4281-b951-d872f2087c98

This script was added in http://crrev.com/192004 at first.

BUG=225343
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/13470029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193001 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=browser_tests --gtest_filter='TranslateManagerTest.*'

Review URL: https://codereview.chromium.org/13508007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193000 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds a fixed container size compensation matrix to fixed-position
layers, so fixed-position layers can be anchored to right / bottom edge during
a pinch gesture.

WebKit side: https://bugs.webkit.org/show_bug.cgi?id=111670

BUG=160223


Review URL: https://chromiumcodereview.appspot.com/12552004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192999 0039d316-1c4b-4281-b951-d872f2087c98

Create a directory at chrome/browser/chromeos/extensions/file_manager/
Move file_manager_* to the new directory.

BUG=224200
TEST=build

Review URL: https://codereview.chromium.org/13779002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192998 0039d316-1c4b-4281-b951-d872f2087c98

Also remove the flag "use-exynos-vda" from the test since 
it is not needed anymore.

BUG=223823


Review URL: https://chromiumcodereview.appspot.com/12844012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192996 0039d316-1c4b-4281-b951-d872f2087c98

This changelist was automatically generated using a clang tool.

BUG=171111

Review URL: https://codereview.chromium.org/13454036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192995 0039d316-1c4b-4281-b951-d872f2087c98

RemoveDirectoryChild is the only place where the entry must be removed.
For all other RemoveDirectoryChild users, just destroying parent-child relationship is enough.

BUG=None
TEST=unit_tests


Review URL: https://chromiumcodereview.appspot.com/13876003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192994 0039d316-1c4b-4281-b951-d872f2087c98

1) Being a ref counted class
Previously, FileBrowserEventRouter was a ref counted class, but the weak
pointer was also used, which doesn't make much sense. Being a ref counted
class was bad, as lifetime of FileBrowserEventRouter was unclear, and
FileBrowserEventRouter could outlive things like DBusThreadManager and
PrefService in rare cases, which caused crash at shutdown.

2) Use of a mutex lock
The lock was used to protect |file_watchers_|, which was accessed from FILE
and UI threads, which should be avoided. Interaction between FILE and UI
threads were also hard to read.

BUG=227477,227483
TEST=Open Downloads in Files.app. Download a file to Downloads. Confirm that the new file appears in Files.app immediatley.

Review URL: https://codereview.chromium.org/13776005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192993 0039d316-1c4b-4281-b951-d872f2087c98

This renames some "level" variables to "state" to make it
more clear that they don't directly map to the API's "level"
enum.  It also registers chrome.runtime.onStartup and
chrome.windows.onCreated (to work around onStartup apparently
not firing on Chrome OS) listeners and switches from
localStorage to chrome.storage.local.

BUG=none


Review URL: https://chromiumcodereview.appspot.com/13493019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192992 0039d316-1c4b-4281-b951-d872f2087c98

- better to focus on entries rather than the specific settings item
- scroll to the settings item when focus has moved out of the scroll view
- EntryView keeps the same margin both left and right
- resize the scroll contents when the window is resized

BUG=196804, 226678
R=dharcourt@chromium.org, dewittj@chromium.org


Review URL: https://chromiumcodereview.appspot.com/13544009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192991 0039d316-1c4b-4281-b951-d872f2087c98

Fixed memory leaks in ScreenshotTakerTest. Updated suppression files.
Ran valgrind and heapcheck on my desktop.

BUG=227271
TEST=manual
unit_tests --gtest_filter='ScreenshotTakerTest.*'

Review URL: https://chromiumcodereview.appspot.com/13801010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192987 0039d316-1c4b-4281-b951-d872f2087c98

This bug is caused by single trailing dot trimming from the input.
Fixed it by forbidding a pattern if canonicalization is not idempotent, i.e. the pattern canonicalized twice differs from the pattern canonicalized once.

BUG=180514


Review URL: https://chromiumcodereview.appspot.com/13251012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192984 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127135
TEST=None


Review URL: https://chromiumcodereview.appspot.com/13638032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192983 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70818

Review URL: https://codereview.chromium.org/13812005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192982 0039d316-1c4b-4281-b951-d872f2087c98

In preference to https://codereview.chromium.org/13699002/

As it's only the secondary widgets (not the Frame), it appears
relatively safe to use CloseNow to avoid the closing animation.

R=sky@chromium.org
BUG=226716

Review URL: https://chromiumcodereview.appspot.com/13770008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192981 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/13728003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192980 0039d316-1c4b-4281-b951-d872f2087c98

BUG=173944


Review URL: https://chromiumcodereview.appspot.com/13637009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192979 0039d316-1c4b-4281-b951-d872f2087c98

Use GetStorageInfoForPath to get volume size.

R=thestig@chromium.org
BUG=None


Review URL: https://chromiumcodereview.appspot.com/13524003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192978 0039d316-1c4b-4281-b951-d872f2087c98

The older interface assumes an implicit relationship between a URLRequestContext
and its delegate.  This interface has been deprecated in favor of making the
network delegate explicit.

BUG=146587


Review URL: https://chromiumcodereview.appspot.com/13079008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192977 0039d316-1c4b-4281-b951-d872f2087c98

Cryptohome now supports including a SignedPublicKeyAndChallenge embedded
in a challenge response.  The new options parameter allows a caller to
request that this be included.

BUG=chromium:219965
TEST=chromeos_unittests


Review URL: https://chromiumcodereview.appspot.com/13638022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192976 0039d316-1c4b-4281-b951-d872f2087c98