GitLab

Review URL: http://codereview.chromium.org/7739001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98153 0039d316-1c4b-4281-b951-d872f2087c98

BUG=76697
Review URL: http://codereview.chromium.org/7734005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98151 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98149 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90217
TEST=all


Review URL: http://codereview.chromium.org/7647014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98148 0039d316-1c4b-4281-b951-d872f2087c98

Get rid of link dependency from content to chrome. Make it get the SpeechInputManager through the embedder interface.

I've renamed Chrome's SpeechInputManagerImpl to ChromeSpeechInputManager, to match what we've been doing for other chrome implementations of content classes.

BUG=76697
Review URL: http://codereview.chromium.org/7729001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98147 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94103
TEST=none
Review URL: http://codereview.chromium.org/7740010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98146 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:19082
TEST=manual testing

Review URL: http://codereview.chromium.org/7714008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98144 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98143 0039d316-1c4b-4281-b951-d872f2087c98

Only contains Ninja changes; should have no effect on the build.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98142 0039d316-1c4b-4281-b951-d872f2087c98

invoke the corresponding delegate.

ExtensionHosts and TabContents which are RenderViewHost delegates no longer dispatch the 
ViewHostMsg_RunFileChooser message. Instead this message is handled by overriding the
RunFileChooser method in the RenderViewHostDelegate interface.

We eventually want to get rid of the pattern of sending IPC messages from content and handling
them in chrome and vice versa.

BUG=87335
Review URL: http://codereview.chromium.org/7729002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98141 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dennisjeffrey@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7740009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98140 0039d316-1c4b-4281-b951-d872f2087c98

BUG=93951
TEST=Client doesn't crash when disconnecting

Review URL: http://codereview.chromium.org/7730002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98139 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98138 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94006
TEST=Build Chromium with Make on Mac. It works.

Review URL: http://codereview.chromium.org/7731001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98137 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=podivilov
Review URL: http://codereview.chromium.org/7727006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98136 0039d316-1c4b-4281-b951-d872f2087c98

This code will be removed again once histograms have been collected (prior
to the M15 branchpoint).
R=cbentzel@chromium.org, dominich@chromium.org
Review URL: http://codereview.chromium.org/7728004

TBR=tburkard@chromium.org
Review URL: http://codereview.chromium.org/7748001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98135 0039d316-1c4b-4281-b951-d872f2087c98

R=jbates@chromium.org
Review URL: http://codereview.chromium.org/7746001

TBR=tburkard@chromium.org
Review URL: http://codereview.chromium.org/7745003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98134 0039d316-1c4b-4281-b951-d872f2087c98

Minor fix to idl_output: switch from None to '' to alow split to work
Add 'InReleases' member to verify node is valid within a list of releases.
Add 'releases' member to IDLVersionMap class for easier search.
Remove stale code and build ordered list of requested releases in AST
Remove release member from CGen object, and pass into functions
Move release tracking from C prototype to C header generator
Update generator tests.
Added golden files to verify the C generator is correct

NOTE:  This is work in progress.  The header emitted using
--release=X should be correct and has been tested to generate
exactly what we have today, however --range=X,Y does not yet
generate what we need.

BUG= http://code.google.com/p/chromium/issues/detail?id=89969
TEST= python generator.py
Review URL: http://codereview.chromium.org/7715036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98133 0039d316-1c4b-4281-b951-d872f2087c98

R=jbates@chromium.org
Review URL: http://codereview.chromium.org/7746001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98132 0039d316-1c4b-4281-b951-d872f2087c98

This code will be removed again once histograms have been collected (prior
to the M15 branchpoint).
R=cbentzel@chromium.org, dominich@chromium.org
Review URL: http://codereview.chromium.org/7728004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98131 0039d316-1c4b-4281-b951-d872f2087c98

This is used in code that will be moved for use in content_shell.

BUG=93804
TEST=none; code move

Review URL: http://codereview.chromium.org/7701012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98130 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/7259005 was supposed to have deleted
chrome/test/live_sync/live_preferences_sync_test.{h/cc}, but ended up
leaving behind the header file. There is no mention of the file in any
gyp file or #include directive.

This patch merely deletes the header file.

BUG=88510
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/7693033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98129 0039d316-1c4b-4281-b951-d872f2087c98

* Changed views test to use ViewsTestBase.
* Always calls ViewsTestBase::SetUp/TearDown. Added flags to check if this is enforced.
* Excluded tests that does not make sense on touch/pure views build.

BUG=none
TEST=views_unittets now passes on touch build, with a few exceptions below.

WidgetTest.GrabUngrab: assigned to sadrul
NativeTextfieldViewsTest.DragAndDrop_XXX: msw will look into it.

Review URL: http://codereview.chromium.org/7720020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98128 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:19260, chromium-os:15718

TEST= Manual on Cr48:
* Inserting, then removing and inserting removable device again. After both insertions, filebrowser tab pointing to device contents should be shown.
* Clicking ctrl+M with a file browser tab opened (the tab should not point to the root dir). New file browser tab pointing to the root dir should be opened.

Review URL: http://codereview.chromium.org/7701015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98127 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98126 0039d316-1c4b-4281-b951-d872f2087c98

BUG=51644
TEST=none


Review URL: http://codereview.chromium.org/7718019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98125 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/chromium-os/issues/detail?id=16082
TEST=Make sure you are signed out.  Open print preview. Choose sign in from the printer drop down.  Should be able to sign in with the resulting dialog.


Review URL: http://codereview.chromium.org/7518002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98124 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94121
TEST=Print preview is on by default again.
Review URL: http://codereview.chromium.org/7725006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98123 0039d316-1c4b-4281-b951-d872f2087c98

The operative portion of this change simply renames
chrome/app/chrome_exe_main_mac.mm to chrome/app/chrome_exe_main_mac.cc. The
main executables never used any Objective-C anyway. I named the files with .mm
a long time ago because at the time it meant that I didn't need to add a
separate GYP 'exclude' rule to keep other platforms from seeing the file. That
was before we added the rules to automatically exclude files based on platform
suffix like _mac.

This change also adds a "verify" step to the targets that build our main
executables. The verify step will cause a build failure if this ever
regresses.

This works around a bug in 10.5 CFBundlePreflightExecutable, which crashes
when called in a process whose main executable has slid due to PIE when the
main executable also contains an __OBJC,__image_info section. We enabled PIE
at r91243.

BUG=88697
TEST=No more crashes inside CFBundlePreflightExecutable (on our call from
     webkit::npapi::PluginLib::ReadWebPluginInfo) on 10.5
Review URL: http://codereview.chromium.org/7726007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98122 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70295
TEST=Run chrome in Arabic, Hebrew. View chrome://settings/syncSetup. Google should be the leftmost word in the title of the dialog.


Review URL: http://codereview.chromium.org/7709012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98120 0039d316-1c4b-4281-b951-d872f2087c98

NET_EXPORT_PRIVATE for the shared builds.

Do not call callback->Run() until we are about to return from this
object because callback->Run() may cause this object to be deleted.

Previously we were calling callback->Run() in DoWaitForDataReadyDone(),
which returns to the do-while loop in DoLoop().  The do-while loop
reads the state_ member. If the object was deleted in callback->Run(),
we would be reading state_ after free.

Miscellaneous cleanups: omit net::, and use the assign() method of
std::string to avoid constructing a temporary object.

R=agl@chromium.org,rvargas@chromium.org
BUG=84426
TEST=net_unittests --gtest_filter=DiskCacheBasedSSLHostInfo.DeleteInCallback

Review URL: http://codereview.chromium.org/7715007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98119 0039d316-1c4b-4281-b951-d872f2087c98

* Create inputmethod only when it's requested via Widget::GetInputMethod. This is what original code did.

BUG=none
TEST=added WidgetTest::ChangeActivation

Review URL: http://codereview.chromium.org/7729007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98118 0039d316-1c4b-4281-b951-d872f2087c98

dlopen is still the default for Google Chrome. This option
is intended for Linux distro packagers.

BUG=92689

Review URL: http://codereview.chromium.org/7655046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98116 0039d316-1c4b-4281-b951-d872f2087c98

reverts 97997 as it was only needed with this debugging code.

I'm TBRing this as it's just a revert (well, two reverts).

BUG=91396
TEST=none
R=brettw@chromium.org,mnissler@chromium.org,ben@chromium.org
TBR=brettw@chromium.org,mnissler@chromium.org,ben@chromium.org

Review URL: http://codereview.chromium.org/7714038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98115 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7728002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98114 0039d316-1c4b-4281-b951-d872f2087c98

Common code from browser_window_cocoa separated into cocoa/browser_window_utils.

Panel.xib changed to make the NSWindow for the PanelWindowControllerCocoa a ChromeEventProcessingWindow.

BUG=None
TEST=Manual testing with Panels and keyboard shortcuts to find/next/previous/close window/quit chrome.

Review URL: http://codereview.chromium.org/7719016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98112 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92689


Review URL: http://codereview.chromium.org/7720018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98111 0039d316-1c4b-4281-b951-d872f2087c98

The changes to chrome_web_ui_data_source allow for alternate message loops
and the absence of translated strings, which are cases I didn't think we'd
encounter.  But we did.
Review URL: http://codereview.chromium.org/7714007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98110 0039d316-1c4b-4281-b951-d872f2087c98

Currently it only tests the keyboard visibility. Eventually, it will have more
tests for the keyboard type, size, shape etc.

BUG=none
TEST=KeyboardManagerTest.*

Review URL: http://codereview.chromium.org/7212029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98109 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69934
TEST=Valgrind is happy.

Review URL: http://codereview.chromium.org/7718011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98108 0039d316-1c4b-4281-b951-d872f2087c98