- 01 Jul, 2020 40 commits
-
-
Shakti Sahu authored
This CL adds 1 - Vector icon for download later on the infobar (modified for dark mode as well) 2 - Correct formating for download later text which should say Download scheduled on Jun 25, 2020 or 3:30 PM (if same day) 3 - A color bug in download home which wasn't showing the progress circle for in-progress downloads. (It was making it same color as inner solid background) Bug: 1066379 Change-Id: Ibeb3cdb9102e7c5270d792637f4fb9b78747a885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276800Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#784343}
-
Sophey Dong authored
Also fix the issue where the QR Code was not being loaded after revoking permissions. Bug: 1079467, 1083351, 1099291 Change-Id: Ia5b61a461e0321e46631119c22a15ef851d8ddd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265248Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#784342}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/465b1021048a..ae6540492fcb 2020-07-01 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I25f64508f172452554565990681ea56a44d75d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277484Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784341}
-
Anupam Snigdha authored
This CL moves functions that fire events to JS from anonymous namespace to the |InputMethodController| so we can check if the ExecutionContext is still valid after firing the events or not and bail out if its not valid. Bug: 1088364 Change-Id: I2b98724bf305aed998222581a608dc16b0f64baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276666Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#784340}
-
Koji Ishii authored
When computing ink overflow against dirty tree, r784297 crrev.com/c/2275373 fixed to skip if corresponding |LayoutObject| was destroyed or moved. This patch adds another check of this, this time in |RecalcInkOverflowForCursor|, because without it, |HasSelfPaintingLayer| will crash. Bug: 1101079 Change-Id: Ia7abb284dd52b467b492e81da5523d0546d7a61b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275926Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#784339}
-
Matthew Denton authored
Right now the most complete set of OCSP tests is implemented in url_request_unittest.cc using HTTPSOCSPTest. This CL creates a parallel set of browsertests, so we can test that OCSP works with the CertVerifierService as well. The new tests are in ocsp_browsertest.cc, and existing OCSP browsertests were moved from ssl_browsertest.cc into ocsp_browsertest.cc to reduce the size of the ssl_browsertest.cc file. The new tests are nearly identical, structurally, to the original tests, but SystemSupportsOCSP() is no longer necessary as it was really checking support for EV certificates, and the checks for EV certificates are already guarded by SystemUsesChromiumEVMetadata(). Bug: 1015134, 1022561 Change-Id: I32e9355d276f75de3432c09f8e7309db1525f729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274581 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#784338}
-
Fergal Daly authored
It currently waits 500ms to allow time for RAFs. On some Mac builders this does not allow enough time, so increase the timeout to 1s. Bug: 1098715 Change-Id: I4e8cedb0706404f373ca381c9490395f42bd5886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269617Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/77d7d5ea92ca..5638f489af56 2020-07-01 mtklein@google.com add windows skvm bots 2020-07-01 mtklein@google.com save only xmm6-15 on windows 2020-07-01 johnstiles@google.com Update ImGui to latest stable version (1.77). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ethannicholas@google.com Change-Id: I1dd9fdf76821bc723d8f4ef6935309228d3e36b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276562Reviewed-by:
-
David Maunder authored
PersistedTabData stores tab metadata across restarts and FilePersistedTabDataStorage is the method of persisting the data in a file. Various use cases such as serialization, save, restore and delete now have metrics associated with them. Bug: 1059635 Change-Id: I3f7d267227819eefb30b23b95a85a637e22fef7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125229 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#784335}
-
Matt Giuca authored
Links to it from new README files in other related directories. Change-Id: I9dcca96de0e8e0b4fc885727efac800bdcc2abd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275976Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#784334}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fdd2cd6e5fc0..f0a1c32f21b8 2020-07-01 vadimsh@chromium.org [lucicfg] Update it to v1.17.1. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1096936 Tbr: agable@chromium.org Change-Id: Ia4a37c2efbe6a1abaa7f1bff374507053ff7fe60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276627Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c1b825219eae..4cb7be407fb7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rakina@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rakina@google.com Change-Id: I0efb231e69313e4a114954636ee595abf4cfc0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277483Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784332}
-
Dominic Farolino authored
This CL augments the existing iframe lazyload test for srcdoc lazyload support. Chrome currently does not implement this. The test accompanies the spec change made at: https://github.com/whatwg/html/pull/5579. R=sclittle@chromium.org Bug: 1101170 Change-Id: I5c5790c5d2eca3efbb01c5470e2267f2265858f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276624Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#784331}
-
Minggang Wang authored
For dedicated worker (PlzDedicatedWorker) and shared worker, the main script is pre-requested in browser process and passed to renderer process through WorkerMainScriptLoadParams, which is set into WebWorkerFetchContextImpl as NavigationResponseOverrideParameters. Finally, a faking request will be sent and gets hooked in ResourceDispatcher::ContinueForNavigation to receive the response. The downside is that we have to depend on content layer and construct an unnecessary WebURLRequest in renderer process to get the mian script. So, we are going to make changes: 1. This patch - Creates WorkerMainScriptLoadParameters to take over the WorkerMainScriptLoadParams passed from browser process. - Creates WorkerMainScriptLoader to load the main script in renderer process directly instead of sending a faking WebURLRequest to load the main script executed as classic or module for dedicated worker (PlzDedicatedWorker) and shared worker. - Adds the blink platform test for WorkerMainScriptLoader. - Creates a mojom interface ResourceLoadInfoNotifier to notify the loading info of the main script. 2. https://chromium-review.googlesource.com/c/chromium/src/+/2115554 - Enables WorkerClassicScriptLoader/WorkerModuleScriptFetcher to use WorkerMainScriptLoader to load the top-level scripts. 3. https://chromium-review.googlesource.com/c/chromium/src/+/2115459 - Removes NavigationResponseOverrideParameters. Change-Id: If36e7f2a0ba67967b160abe2231de31e332b2827 Bug: 860403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916682 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#784330}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ib61cf9be8fbc09fabd8765b8177c1b34d84494be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276565Reviewed-by:
-
Miyoung Shin authored
This CL fixes nullptr access in prerender::PrerenderObserverList::RemoveObserverForFrame since RenderFrame is destroyed first before ChromePluginPlaceholder dtor that removes an observer for RenderFrame is called. Fuzzer report: https://clusterfuzz.com/testcase-detail/4966404840816640 Bug: 1099851, 1100030, 1100780 Change-Id: Id0db5a3c6d3fc9018a120d7ad0b0d3125d875302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272179Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#784328}
-
Lei Zhang authored
Take the name suggestion from several reviewers while converting base::DeleteFile(path, true) calls. Tbr: blundell@chromium.org,jamiewalch@chromium.org,jkarlin@chromium.org,kinuko@chromium.org,reillyg@chromium.org,sdefresne@chromium.org,xdai@chromium.org Bug: 1009837 Change-Id: Ie0a3bbe7bae4844f4f29a4ffd63fd032128e599d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274676 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#784327}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/14453b7a67ac..2d6b37bbda59 2020-07-01 pcc@google.com Start reserving x18 by default on Android targets. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I895eb3d1f2fdd1771ca4cfb15c8aae7b07a7f677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276630Reviewed-by:
-
Jan Krcal authored
This CL is a refactoring before a minor update of the design of the profile menu. This CL brings no behavioral change. This change is needed because in the new design, the layout of the profile name heading and the layout of the identity info are more intertwined and thus it is opportune to set them in one function. Bug: 1099286 Change-Id: Iad6f03bd3ff7fa1e17cc1cb61b2d76c952c1394f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274626 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#784325}
-
Owen Rodley authored
Bug: 1094768 Change-Id: Ibcfa475f90241ab7d9da654b0b14d8f2c1bcd451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274379 Commit-Queue: Owen Rodley <orodley@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Owen Rodley <orodley@chromium.org> Cr-Commit-Position: refs/heads/master@{#784324}
-
Ian Kilpatrick authored
The logic introduced for CalculateChildAvailableSize was designed to have the correct value for an element with: "<div style="position: relative; left: 50%; top: 50%;></div>" E.g. the percentage based left/top would resolve against the available size. However this broke text alignment within anonymous-blocks which require the child-available-size to be based on the actual inline-size. This patch uses the actual inline-size in the inline direction, but keeps the logic for block direction. This will mean that for postiion:relative calculations we'll use the Percentage inline-size, and Available block-size for resolving percentages. Bug: 1100203 Change-Id: I83c5281c5de9f9fd40f1bfed54e627dff5bb0600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274359Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#784323}
-
Noel Gordon authored
Encapsulate the drag hover time in a helper dragTargetHoverTime_. Keep the 2000ms default. But make it shorter when window.IN_TEST, to reduce drag drop integration test times by the difference (1500ms) if they do check that drag hovering over a directory-tree tab makes the file-list navigate (change directory) after the hover time out. Covered by existing tests: transfer.{DragAndDrop,DragAndHover} Bug: 1002394 Change-Id: I6a1c3f61c43a602d362271acb5dd031d66058b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275569 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:Alex Danilo <adanilo@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#784322}
-
Kent Tamura authored
This CL reduce the estimated pre-processed size of parkable_string.h by 1.2MB. This CL moves DiskDataAllocator::Metadata out to its own header file, and removes mojo dependency from parkable_string.h. This CL has no behavior changes. Bug: 242216 Change-Id: I6f3278ef7cb3c9ceaf1776d14efb527fa34adfe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275566 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#784321}
-
Anand K Mistry authored
The function is unused. Bug: None Change-Id: Iacc20257e5636af4b38644ec7ab8c099d0310975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275925 Commit-Queue: Anand K Mistry <amistry@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#784320}
-
Joey Scarr authored
I've left the section about sheriffing philosophy, since that's also useful for non-sheriffs. Bug: 1095911 Change-Id: I9e97cc1951e5cc96fe9aa8ccc42e14c875f0f0b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274481 Commit-Queue: Joey Scarr <jsca@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#784319}
-
Giovanni Ortuño Urquidi authored
We do this by changing three things: 1. Set `composite` to `true`. From Typescript docs: ``` The composite option enforces certain constraints which make it possible for build tools to quickly determine if a project has been built yet. ``` This results in the TypeScript compiler generating two new files for each mojom target: - Declaration files (.d.ts) which in the Mojo case describes the exported Mojo interface. - tsBuildInfo files (.tsbuildinfo) which store incremental compilation information as a part of composite projects which enables faster building of larger TypeScript codebases. 2. Adding `references` to tsconfigs, to tell the compile that a target depends on other targets. 3. Adding `/// <reference>` to non-es-modules files, to tell the compiler which files that file references. Somewhat surprisingly adding `references` to the tsconfig was not enough. This results in: 1. Each mojom target getting compiled only once, independent of how many other targets depend on it. 2. The compiler complaining if we forget to add a mojom target to `references` and if we forget to add `/// <reference>`s for files in non-es-modules files. 3. When compiling a mojom target, the compiler only attempts to compile the specific target i.e. it doesn't try to compile its dependencies. It's up to ninja to trigger the compilation of dependencies. If a dependent target hasn't been compiled yet, the compiler will throw an error. This ensures that we don't accidentally forget dependencies in our generated bindings. The upside of this, is that compilation order is controlled by gn and ninja. The downside is that we need to run an instance of the compiler for each target and we don't get to take advantage of the --build flag, which changes the compiler to act more like an orchestrator than a simple compiler. Bug: 1002798 Change-Id: I831aaaa9a0f159d6e90b9ec698ba5cc1f7653c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274387Reviewed-by: -
Kent Tamura authored
This CL reduces the estimated pre-processed size of local_frame_view.h by 1.0MB. This CL has no behavior changes. Bug: 242216 Change-Id: I95bc2d99b955b922f28356789da4702d31128ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275977 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Noel Gordon authored
Use "directory" instead of "folder". Elaborate the Crostini comment re: it is actually a fake entry. However, the reason why we need to change immediately to its directory when it is a fake entry is not explained, and is potentially no longer relevant now Crostini is controlled by an enable flag looking at CL:2264086 No change in behavior, no new tests. Bug: 1002394 Change-Id: Ida7177b052f6fcb8db47e6181ffc4c5d708604c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275280Reviewed-by:
-
Noel Gordon authored
Remove a stray extra line. Add some in canPasteOrDrop_ to end the code squishing competition and instead promote code readability. No change in behavior, no new tests. Tbr: (mr-no-nbn) adanilo Bug: 1002394 Change-Id: I038646234385c7b0dd73b72752f8c5a160e70877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275161 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3f5d1ca9a8eb..9e100526c3df 2020-07-01 dberris@chromium.org sched: Show the queue in job results If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:981429 Tbr: wenbinzhang@google.com Change-Id: Iff5e096042bebac0ddac66f83451f851d619170d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276626Reviewed-by:
-
Ella Ge authored
All usage has been updated to base::Bind{Once,Repeating} and base::{Once,Repeating}Callback respectively. Fix: 1007641 Change-Id: Ieb7aaacdfa2df52a51092cc332e09951db3c3758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275103 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by: -
Melissa Zhang authored
This CL adds a temporary button to the toolbar that will be used to trigger the sharesheet during development. Bug: 1097623 Change-Id: Icb9029fbd508e6e358bd82381886dbd7b6050cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262400Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#784312}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I3292ad8d76e9b25e56f01f52db8c3fc9aedf3a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276660 Auto-Submit: Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7d5df44976ba63862d848176cc4eed2d90c19d9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277481Reviewed-by:
-
Ella Ge authored
All usage has been updated to base::Bind{Once,Repeating} and base::{Once,Repeating}Callback respectively. Fix: 1007638 Change-Id: I31ee3da38efebdd5cf402d3faa79d42dd2bed095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275471 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by: -
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I04c835a7e5557782e5b3e77fe6df20b061943196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277408Reviewed-by:
-
Haiyang Pan authored
Bug: 1098927 Change-Id: Ibd209ea32d8c47e115499c20741ef4dc9e851924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277051 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#784307}
-
Rachel Carpenter authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/Uu11Q1wqNSVwkH2IvVt8kSs867Nu-6mf0O9kxpQfckAC Release notes: http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202006240800_RC01.html Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: I1ca4c636d0049e09fc0c7517d7817862a838c19e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277364Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#784306}
-
Kyle Milka authored
Refactor SendTabToSelfNotificationReceiver out of NotificationManager. Bug: 1090917 Change-Id: I8cd10e739af093dc35138a8ac4478d4f251ce639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261174 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I88e2c0191af5e52e86b4a27e0caba52bd960e66a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276761 Auto-Submit: Robert Sesek <rsesek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#784304}
-
