- 15 Apr, 2018 2 commits
-
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0f4b32cc..ddfc6de6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I1f72eadfcb0ede5fec162a5b9b6f143f1b5951a5 Reviewed-on: https://chromium-review.googlesource.com/1013252Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#550913}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a2ca1996..0f4b32cc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I347e5d7a6d76a8f2688fc980f3c376ae723014c7 Reviewed-on: https://chromium-review.googlesource.com/1012526Reviewed-by:
-
- 14 Apr, 2018 38 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium fde64773. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15574 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley No-Export: true Change-Id: I8bdc068859a55a7e3c9512fe1925696744dc9ea7 Reviewed-on: https://chromium-review.googlesource.com/1012459 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#550911}
-
Victor Costan authored
The test now fails on the Linux CFI bot. Disabling until a fix is figured out. TBR=enne Bug: 832726 Change-Id: I7624c38747a1787fdd470233de358f2b093e86da Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.win:win_chrome_official;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1013538Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#550910}
-
Avi Drissman authored
Mark it and media/controls/closed-captions-dynamic-update.html as "skip" as marking it as "fails" doesn't seem to green the bot. BUG=775534 NOTRY=true TBR=steimel@chromium.org Change-Id: Icffb9647683c3475bfcbafbca02a3229d9ece3de Reviewed-on: https://chromium-review.googlesource.com/1013251Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550909}
-
Wez authored
Bug: 832728, 703346 Change-Id: I4f400986db39b957095a30dc7770f6e6e541a8ae Reviewed-on: https://chromium-review.googlesource.com/1012568 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#550908}
-
Avi Drissman authored
It fails on Windows. BUG=775534 NOTRY=true TBR=steimel@chromium.org Change-Id: I972cad540e5ee42207e60d1add32fcf31b7dd9ec Reviewed-on: https://chromium-review.googlesource.com/1012529Reviewed-by:
-
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:fuchsia_arm64_cast_audio;master.tryserver.chromium.linux:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I30c39ef3624eb46360e212fbd4e8f87e8ac963af Reviewed-on: https://chromium-review.googlesource.com/1013413 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550906}
-
Avi Drissman authored
It fails on the Mac. BUG=833100 NOTRY=true TBR=jrummell@chromium.org Change-Id: I8e58a4baede9f6a539f9d3ac39d2e37a21854b48 Reviewed-on: https://chromium-review.googlesource.com/1012528Reviewed-by:
-
Avi Drissman authored
It fails on the Mac. BUG=775534, 770691 NOTRY=true TBR=steimel@chromium.org Change-Id: I7d5c7650bb6ea0e2d443972d617e4eac0d82caac Reviewed-on: https://chromium-review.googlesource.com/1013248Reviewed-by:
-
Chris Harrelson authored
The non-GeometryMapper code path was already implemented in this way. Bug:832870 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If85f93113b737a749658c274c6d6ab9afa408362 Reviewed-on: https://chromium-review.googlesource.com/1013399 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#550903}
-
Avi Drissman authored
It leaks, and the CL is too big to analyze. BUG=775534 NOTRY=true TBR=steimel@chromium.org Change-Id: I0521b2d9a295970faa53027e1c9893fd92b94d21 Reviewed-on: https://chromium-review.googlesource.com/1012527Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1b30ce62. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15570 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox TBR=qyearsley No-Export: true Change-Id: I64530f7f35ccb5a24ab0dd1efaba6ca503b3bf7c Reviewed-on: https://chromium-review.googlesource.com/1013246 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Jeffrey Kardatzke authored
This adds a small D-Bus service framework to ash and then adds an initial service that has one call "OpenUrl" which will then open a new tab in Chrome with that URL. This is intended to be used by Chrome OS clients that want to open a URL with Chrome; initial usage will be from VMs. Bug: 822496 Bug: 831333 Test: Verified with dbus-send that links open properly Change-Id: I648af624817cd387f30aba751c7f465e0dcc60e0 Reviewed-on: https://chromium-review.googlesource.com/998081 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#550900}
-
Jay Civelli authored
Adding always_access_network to the content.mojom.ResourceLoadInfo. Bug: 816684 Change-Id: If4f53330199cf3487379ecdb8b8bfb5168f97f89 Reviewed-on: https://chromium-review.googlesource.com/1000719 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#550899}
-
Danyao Wang authored
When a URL is blocked due to Restrictions settings, WKWebView triggers |webView:didFailProvisionalNavigation| and automatically triggers a second navigation that loads an error page. Without this change, Chrome injects an extra navigation entry for displaying native error, which shows up after the system "Access Restricted" error. Bug: 831381,793317 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iaafcc8f1c5abde120ad10d0794832ab09abeec6d Reviewed-on: https://chromium-review.googlesource.com/1012470Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#550898}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8957aa60. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15569 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley No-Export: true Change-Id: Ic52871725544b00d3ab4882a57ab4cf4f8d77a62 Reviewed-on: https://chromium-review.googlesource.com/1012525 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Victor Costan authored
gmock objects don't support being moved via memcpy, as done by cc::ListContainer::AppendByMoving. In particular, each MOCK_METHODn macro creates a testing::FunctionMocker<> instance which (via testing::internal::FunctionMockerBase<> -> testing::internal::UntypedFunctionMockerBase) contains a list of expectations, which is std::vector<internal::linked_ptr<ExpectationBase>>. googletest's internal::linked_ptr is very similar to Chromium's version, and moving a node breaks the list pointers. This CL removes gmock usage in ListContainerTest and replaces it with hand-rolled mocking code that does support having its state moved via memcpy(). Bug: 832726 Change-Id: I9abfe3146931a11eda8d52bd0f5621e08736f7d1 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.win:win_chrome_official;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1013408Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#550896}
-
Stephen McGruer authored
This is a reland of 0ade0386 Original change's description: > Web Animations: Fix bugs in procedure to process a keyframes argument > > There were three minor bugs left in the implementation: > > - We threw on lists-in-custom-iterators instead of just ignoring them. > - We returned all properties on the keyframe rather than just those > defined on the keyframe itself (e.g. we would include prototype > properties, against spec). > - We didn't access the properties in ascending unicode order. > > Bug: 827573 > Change-Id: I213ae5b24e1f35d7f28d16625025122950a6ba88 > Reviewed-on: https://chromium-review.googlesource.com/989261 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550641} Bug: 827573 Change-Id: I6c49fa6ca36db16ecddfb520e0964bd231565a0b Reviewed-on: https://chromium-review.googlesource.com/1012897Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#550895}
-
Nico Weber authored
I removed the goma bots in https://chromium-review.googlesource.com/c/chromium/src/+/1012963, but I suppose the goma folks will want to keep testing MSVC with goma for the v8 webrtc pdfium angle waterfalls, so put them back. Removing mb and testing configs is blocked on https://bugs.chromium.org/p/chromium/issues/detail?id=833017 Bug: 820422 Change-Id: I1a35c59afd517eea2a5cbd0b7af2cc9ee5c7d659 Reviewed-on: https://chromium-review.googlesource.com/1013339Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#550894}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2e290076c8be..c90ccbc26d04 $ git log 2e290076c..c90ccbc26 --date=short --no-merges --format='%ad %ae %s' 2018-04-13 ihf chromeos_config: mark eve-arcnext-chrome-pfq not important. 2018-04-13 cmtice [chromite] Add script to set up env for locally testing fuzz targets. 2018-04-13 marcochen soraka: remove sign type - factory and accessory_rwsig 2017-11-03 dgarrett Reland "config_lib: Remove OverrideConfigForTrybot." 2018-04-13 dgarrett buildbucket_lib: Remove _ah from URLs. 2018-04-13 bmgordon cros lint: Look up pylintrc for all python files 2018-03-14 dgarrett report_stages: Use Logoland build URL for master builder. 2018-03-14 dgarrett validation_pool: Switch to Legoland build links. Created with: roll-dep src/third_party/chromite BUG=chromium:832736,chromium:776955,chromium:None,chromium:None,chromium:821618,chromium:821618 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6c3d1f6d83d8bfb7ea269da65c9f09901668cb37 Reviewed-on: https://chromium-review.googlesource.com/1013395Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550893}
-
Findit authored
This reverts commit b9d68c49. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 550884 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I5ZDY4YzQ5YTMxNDBhYTBhZTQyOWI3NDJkMjkzMjlmYWI1NGVlZjUM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27035 Sample Failed Step: mus_ash_unittests Original change's description: > splitview: Grab app for splitscreen only happen on long press. > > The indicators and the item enlarging only happen after long press, or > if the item has been dragged. > > This is preparation for fling to dismiss. It also removes a flicker of > the indidcators when you tap to open a item. > > Also renables a previous flaky test. Tested locally and it is not flaky > no more. > > Test: ash_unittests SplitViewWindowSelectorTest.* > Bug: 817863 > Change-Id: I9c20f2fa9a3c0a9218b3072c5b3d25711ad9c655 > Reviewed-on: https://chromium-review.googlesource.com/996528 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550884} Change-Id: I409e3401d6c171191ca58cece64bb0396b4956f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 817863 Reviewed-on: https://chromium-review.googlesource.com/1012477 Cr-Commit-Position: refs/heads/master@{#550892}
-
jdoerrie authored
This change fixes a crash when a BLE Security Key responds after kDeviceTimeout has passed. In the case of a timeout all future messages from the device will be ignored. Bug: 763303 Change-Id: I62ec334195324cadddedc8fea56830147001e555 Reviewed-on: https://chromium-review.googlesource.com/1007083 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550891}
-
Luum Habtemariam authored
Updating metav2 unitttests to reflect v2 case insensitive effective-make-and-model inputs. BUG=chromium:804014 TEST=chromeos_unittests all pass Change-Id: Id5bd86c3ade919588541db757381e41d01149fe9 Reviewed-on: https://chromium-review.googlesource.com/1011239Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#550890}
-
Victor Costan authored
The test had the following behavior: 1) Construct a first mock object. 2) Move the first mock object to a new buffer by memcpy-ing a void*. 3) Construct a second mock object at the first object's address via placement-new. 4) Create a call expectation on the (now moved) first object. 5) Create a call expectation on the second object. 6) Destroy the second object (built at the first object's address). 7) Destroy the (now moved) first object. gmock objects don't support being moved via memcpy, as done by cc::ListContainer::AppendByMoving. In particular, each MOCK_METHODn macro creates a testing::FunctionMocker<> instance which (via testing::internal::FunctionMockerBase<> -> testing::internal::UntypedFunctionMockerBase) contains a list of expectations, which is std::vector<internal::linked_ptr<ExpectationBase>>. googletest's internal::linked_ptr is very similar to Chromium's version, and moving a node breaks the list pointers. So, while the ListContainerTest.AppendByMoving* tests have always used gmock in an unsupported way, the latest googletest roll turned this usage into a crash (debug assert) on Windows debug builds. This CL disables the test that causes the assertion to get the bot green, while a CL fixing all the tests is prepared and reviewed. TBR=chrishtr Bug: 832726 Change-Id: Ice1ff1930d2d2d40231a82bdb29eb5200a05fac7 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.win:win_chrome_official;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1013407Reviewed-by:
-
Wenzhao Zang authored
All the AshTestBase inheritance in //chrome should be removed eventually. Bug: 827062 Change-Id: I78272914a03f75267b72d478bdfe2381a87203df Reviewed-on: https://chromium-review.googlesource.com/1012307Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#550888}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/79afb66c..a2ca1996 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ic7c49e6e9ab1082f3821264c5cfdd063401ba6ac Reviewed-on: https://chromium-review.googlesource.com/1012578Reviewed-by:
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I0562e9de04c878f2f31f9c074d3a061e03ecc571 Reviewed-on: https://chromium-review.googlesource.com/1013405Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550886}
-
Jennifer Apacible authored
Currently, when the Picture-in-Picture window is resized, the video (shown as the cc::SurfaceLayer) does not resize with it. This change makes the cc::SurfaceLayer resize with the window. Setting the new cc::SurfaceLayer size is required. |frame_size_in_dip_|, which is set when the SetShowPrimarySurface() is initially called, is used as the maximum size of cc::SurfaceLayer. This size needs to be up to date for cases where the window is resized to be larger than the initial size. BUG: 726621 Change-Id: I77ae4f08c204a84544565c63cc2412cc93746793 Reviewed-on: https://chromium-review.googlesource.com/1011645Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#550885}
-
Sammie Quon authored
The indicators and the item enlarging only happen after long press, or if the item has been dragged. This is preparation for fling to dismiss. It also removes a flicker of the indidcators when you tap to open a item. Also renables a previous flaky test. Tested locally and it is not flaky no more. Test: ash_unittests SplitViewWindowSelectorTest.* Bug: 817863 Change-Id: I9c20f2fa9a3c0a9218b3072c5b3d25711ad9c655 Reviewed-on: https://chromium-review.googlesource.com/996528 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#550884}
-
https://webrtc.googlesource.com/src.git/+log/3acffc3b1668..365381fdf1cd $ git log 3acffc3b1..365381fdf --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:831756,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id11b4397d911eda8fefc1ea35cf47e4e7f1fe30d Reviewed-on: https://chromium-review.googlesource.com/1013397Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550883}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e6bea7b2. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15540 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer TBR=danyao No-Export: true Change-Id: I713dc1bdf4b5f944c4314d400de5d3ac8604ce67 Reviewed-on: https://chromium-review.googlesource.com/1013419 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c23684514c93..2e290076c8be $ git log c23684514..2e290076c --date=short --no-merges --format='%ad %ae %s' 2018-04-12 pwang chromeos_config: Mark kevin-arcnext important 2018-04-11 dgarrett binhost_test: Update active config definition. 2018-04-13 dgarrett chromeos-config: Add hwtests to eve chrome tot informational. 2018-04-10 pprabhu cbuildbot: Add pre-cq builder to run infra specific unittests. 2018-04-12 manojgupta cros_setup_toolchains: Update list of post cross packages. 2018-04-12 dgarrett chromeos_config: Move chromiumos-sdk to 'utility' group. 2018-04-09 dgarrett remote_try: Remove buildbot specific behaviors. Created with: roll-dep src/third_party/chromite BUG=chromium:831929,chromium:829898,chromium:None,chromium:820330,chromium:None,chromium:None The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I15b87a3f6a81bd9abdfcc59147a98f0d59932383 Reviewed-on: https://chromium-review.googlesource.com/1013383Reviewed-by:
-
Fergal Daly authored
Move the docs inline as method docs and just link from the md file. Change-Id: I286db306b4f01553ac6fa09a271aa65457c76de8 Reviewed-on: https://chromium-review.googlesource.com/1011764Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#550880}
-
Jay Civelli authored
Relanding "Move replaying of redirects and response started to ResourceDispatcher". It was breaking when a renderer would access cookies after a redirect, when the NavigationMojoResponse was disabled. The non NavigationMojoResponse code path has been removed, so this should now work. Also addressing a crasher when replaying redirects for deferred responses. Original description: Moving the replaying of redirects and response started notifications for frames from WebURLLoaderImpl to the ResourceDispatcher. This allows to provide the actual ResourceResponseHead to URLLoaderClientImpl::OnReceiveResponse and fixes the bug where IP address and MIME type would not be reported in ResourceLoadComplete notifications for frames. Tbr: kinuko@chromium.org, clamy@chromium.org Bug: 826082 Change-Id: I250fa02e8f82fe4db5dec01ca4d736551464dbc4 Reviewed-on: https://chromium-review.googlesource.com/1007625 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#550879}
-
Dirk Pranke authored
This reverts commit 7a7c85f7. Reason for revert: This doesn't seem to have been the problem. I'm now guessing that https://crrev.com/c/996458 was the problem, because that was in the original blamelist, and was reverted, and the test stopped failing when that was reverted, but not this CL. Original change's description: > Revert "Fix custom titlebar minimize button stuck hovered when clicked." > > This reverts commit a6885b53. > > Reason for revert: Speculatively reverting to see if it fixes the failure for AutomationApiTest.CloseTab is failing in site_per_process_browser_tests on Linux Tests (dbg)(1); see crbug.com/833011 and https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/71426 > > Original change's description: > > Fix custom titlebar minimize button stuck hovered when clicked. > > > > Normally when a button is clicked we assume the mouse is still hovering > > over it, so we go back to the hovered state and wait for the mouse exit > > event. However, when the minimize button minimizes the window Windows > > gives us the mouse exit event before the mouse up event, so the button > > will get stuck in the hovered state. > > > > This patch fixes this by resetting the button state when it receives > > a window control action, the same way the opaque frame currently solves > > this problem. > > > > Bug: 828591 > > Change-Id: I6e3f27b8f92bcbf3fb8171555702b8cf5326ba21 > > Reviewed-on: https://chromium-review.googlesource.com/1006373 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#550733} > > TBR=sky@chromium.org,bsep@chromium.org > > Change-Id: I2809f8bbc666dd87b9a696eb87935cb3bd0f5e7c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 828591 > Reviewed-on: https://chromium-review.googlesource.com/1012476 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550847} TBR=sky@chromium.org,dpranke@chromium.org,bsep@chromium.org Change-Id: I24d630ab51c665b9df680cdcdbfd0ffe5a1b4fe7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 828591 Reviewed-on: https://chromium-review.googlesource.com/1013268Reviewed-by:
-
Dale Curtis authored
Per scheduler-dev@ the approach of constructing a dummy MessageLoop on the stack just for blink::Initialize() is not correct. Instead we must ensure that the loop we give is the main loop used for the rest of the test. This change provides a main loop to all media_blink_unittests via a ScopedTaskEnvironment; this requires removing all existing MessageLoop instantiations from other tests. This was straight forward in all but two cases: WatchTimeReporterTest and VideoDecodeStatsReporterTest. WTRT relied on pumping tasks one at a time, while VDSRT relies on a mock time task runner. The solution was to convert WTRT to a mock time task runner (including injecting a fake TickClock to the base::RepeatingTimer inside WatchTimeReporter) and then switch both tests over installing the base::TestMockTimeTaskRunner in the top level MessageLoop instead of creating their own. In terms of fixing run_all_unittests.cc, it now follows //third_party/blink/renderer/controller/tests/run_all_tests.cc where by blink::Initialize() isn't called until the RunTestSuiteCB is called. This is required because the multi-process test runner creates a scoped MessageLoopForIO and this will fail if we kept our initialization process in TestSuite::Initialize(). BUG=none TEST=all tests still pass. Change-Id: I0549cca4a72614504433271f6ed4b16a00019a71 Reviewed-on: https://chromium-review.googlesource.com/1011647 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#550877}
-
Klaus Weidner authored
The SurfaceTexture supplies a UV transform matrix which does a Y flip. Pass this matrix to the WebVrRenderer for the Surface path, and use an identity matrix for the SharedBuffer path. We had been ignoring the SurfaceTexture's transform and hardcoded an assumption that it's a Y flip, that is now no longer necessary. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I100c4be9211a9985df317c07d8c4906703e554a2 Reviewed-on: https://chromium-review.googlesource.com/1012777Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#550876}
-
Gabriel Charette authored
Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/957760 this will allow migrating the majority of callers of MessageLoop::current() to not even have to use message_loop.h :). R=thestig@chromium.org Bug: 825327 Change-Id: Idfca0575c363463442225a46dbadfc202aab4669 Reviewed-on: https://chromium-review.googlesource.com/1008265 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#550875}
-
tzik authored
This removes 'use_once_callback = false' flag from BUILD.gn in services/tracing/public/mojom, and fixes all implementations of the interface. Bug: 714018, Change-Id: If7cec8d89f304b314275239cde4c15aa40ce0386 Reviewed-on: https://chromium-review.googlesource.com/999074Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#550874}
-
