GitLab

BUG=broken build
TEST=fixes build

Review URL: http://codereview.chromium.org/8633005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111103 0039d316-1c4b-4281-b951-d872f2087c98

Added an std::max to prevent negative width calculation.

TODO(sail/msw): BubbleBorder::ALIGN_EDGE_TO_ANCHOR_EDGE.
I filed crbug.com/105014 for the placement regression on NTP.

BUG=98323
TEST=The avatar menu bubble works as before.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111018

Review URL: http://codereview.chromium.org/8500004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111102 0039d316-1c4b-4281-b951-d872f2087c98

This moves the functions into a pattern that is component-friendly.

BUG=98755
TEST=chrome test_shell test_shell_tests browser_tests DumpRenderTree

Review URL: http://codereview.chromium.org/8602002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111101 0039d316-1c4b-4281-b951-d872f2087c98

- Create ShellAcceleratorController that manages global keyboard accelerators and also processes several accelerators as a target.
- Create ShellAcceleratorFilter, which is used by DesktopEventFilter to handle accelerators.
- Add a function to Shell for accessing ShellAcceleratorController.

The 1st attempt (http://crrev.com/110637) broke aura_shell_unittests and this fixes it.
The differences are
- moving ShellAcceleratorFilter to Shell from DesktopEventFilter, and
- adding the ShellAcceleratorFilter in Shell initialization code to DesktopEventFilter.

BUG=97255
TEST=Manual, aura_shell_unittests succeeds.


Review URL: http://codereview.chromium.org/8561012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111100 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8623005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111099 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91241
TEST=


Review URL: http://codereview.chromium.org/8510069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111098 0039d316-1c4b-4281-b951-d872f2087c98

This moves the functions into a pattern that is component-friendly.

BUG=98755
TEST=Chrome, DRT, test_shell

Review URL: http://codereview.chromium.org/8591030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111097 0039d316-1c4b-4281-b951-d872f2087c98

Only one place was left using it (FirstRunSearchEngineView), and Brian said that didn't need to use it if it would just pick the first of the engine choices (prior to randomization) as the window was closed.

http://crbug.com/102581
TEST=unittests, and: run organic first run chrome, close the search engine selector, the Google should be the default. run organic first run Chrome, choose a non-Google engine, it should be the default.
Review URL: http://codereview.chromium.org/8618001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111096 0039d316-1c4b-4281-b951-d872f2087c98

Disables moar failing PPAPI tests on Mac.

BUG=105080
TEST=Valgrind on Mac goes green
TBR=viettrungluu@chromium.org

Review URL: http://codereview.chromium.org/8637003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111095 0039d316-1c4b-4281-b951-d872f2087c98

Fixes logic for USE_AURA=1 case in Mac compositor.  Changes the code to not rely on |IsOffscreen| test to determine NSView-based surface.

BUG=105036
TEST=Manual test according to bug.
R=jbates@chromium.org, kbr@chromium.org

Review URL: http://codereview.chromium.org/8620009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111094 0039d316-1c4b-4281-b951-d872f2087c98

(The accessor gtk_widget_get_window was added in 2.14, so it was never used in
initial linux port development.)

BUG=79722
TEST=none


Review URL: http://codereview.chromium.org/8625001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111091 0039d316-1c4b-4281-b951-d872f2087c98

BUG=79722
TEST=none
TBR=tony

Review URL: http://codereview.chromium.org/8586044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104685
TEST=


Review URL: http://codereview.chromium.org/8622006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111089 0039d316-1c4b-4281-b951-d872f2087c98

1. Change from using zoom levels to a range of preset zoom factors (percentages). Zoom levels are the values that WebKit uses for page zoom. While zoom levels are simple to implement, they result in undesirable percentages like 57%, 144%, 207%, etc. Changing to zoom factors gives us user-friendly zoom percentages.
2. Increase the range of supported zoom values. A user can now zoom between 25% to 500%.
3. Use an epsilon value when comparing zoom floating point values. The previous version was doing an equality comparison of double values which may not always work as expected.

BUG=71484
TEST=Exercise zoom in/out via the wrench menu; exercise default page zoom setting in options window
Review URL: http://codereview.chromium.org/8528011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111087 0039d316-1c4b-4281-b951-d872f2087c98

Get rid of view_messages.h include from chrome since TabContentsDelegate used a struct from it (ViewHostMsg_RunFileChooser_Params). Moved that to a struct in content/public/common.

BUG=98716

Review URL: http://codereview.chromium.org/8622005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111086 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98323
TEST=None


Review URL: http://codereview.chromium.org/8603010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111085 0039d316-1c4b-4281-b951-d872f2087c98

Files with .onc extension are not recognized as text/plain files. ONCNetworkParser should fail on non-text files, so this test is not necessary.

BUG=chromium-os:23248
TEST=Importing an onc file with .onc suffix should work.

Review URL: http://codereview.chromium.org/8623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111084 0039d316-1c4b-4281-b951-d872f2087c98

In one instance, we can simply use currying to remove the need to
inherit from Task; in the other, we retain the wrapper since it wraps an
Objective-C call. Also remove an overload of ui::Clipboard::WriteObjects
that's never used.

BUG=none
TEST=trybots


Review URL: http://codereview.chromium.org/8606002

TBR=dcheng@chromium.org
Review URL: http://codereview.chromium.org/8634002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111083 0039d316-1c4b-4281-b951-d872f2087c98

Disables failing PPAPI tests on Mac.

BUG=105080
TEST=Valgrind on Mac goes green
TBR=viettrungluu@chromium.org

Review URL: http://codereview.chromium.org/8635001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111082 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8549014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111081 0039d316-1c4b-4281-b951-d872f2087c98

In one instance, we can simply use currying to remove the need to
inherit from Task; in the other, we retain the wrapper since it wraps an
Objective-C call. Also remove an overload of ui::Clipboard::WriteObjects
that's never used.

BUG=none
TEST=trybots


Review URL: http://codereview.chromium.org/8606002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111080 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8586013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111079 0039d316-1c4b-4281-b951-d872f2087c98

R=ben@chromium.org
BUG=43070
TEST=none


Review URL: http://codereview.chromium.org/8624005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111078 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104039
R=ben@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110949

Review URL: http://codereview.chromium.org/8598031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111077 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:20009
TEST=None


Review URL: http://codereview.chromium.org/8558014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111076 0039d316-1c4b-4281-b951-d872f2087c98

scherkus says:
The protocol whitelist (added in r26746) was originally required to prevent issuing requests to the resource loader bridge that it didn't support (i.e., data://). To complicate matters there were protocols such as chrome-extension:// that required the embedder to override. None of this is required anymore since we switched to using Chromium WebKit API's resource loader in r69429.

BUG=98755
TEST=Chrome, DRT, test_shell, test_shell_tests

Review URL: http://codereview.chromium.org/8616008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111075 0039d316-1c4b-4281-b951-d872f2087c98

Increases the ASAN timeout multiplier in an attempt to avoid timeout errors in OutOfProcessPPAPITest.* test when running under ASAN.

BUG=104832
TEST=ASAN bot runs green
TBR=glider@chromium.org

Review URL: http://codereview.chromium.org/8618014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111074 0039d316-1c4b-4281-b951-d872f2087c98

r111013 inadvertently made non-Wayland builds prefer Mesa's
off-screen renderer over GL and EGL.

BUG=none
TEST=did an aura build and checked that it wasn't incredibly slow

Review URL: http://codereview.chromium.org/8623009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111073 0039d316-1c4b-4281-b951-d872f2087c98

It turns out that the position information in an event for a slave device
reported by X is always slightly behind than the actual position. However, it
turns out that the valuators do contain the correct information. So get the
event location from the valuator.

BUG=103981
TEST=manually

Review URL: http://codereview.chromium.org/8568044

TBR=sadrul@chromium.org
Review URL: http://codereview.chromium.org/8624010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111072 0039d316-1c4b-4281-b951-d872f2087c98

Valid states are normal, minimized and maximized. Actual behavior depends on OS and window type.

BUG=10828
TEST=ExtensionApiTest.UpdateWindowShowState


Review URL: http://codereview.chromium.org/8586045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111071 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=crypto_unittests


Review URL: http://codereview.chromium.org/8499032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111070 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105046
TEST=none


Review URL: http://codereview.chromium.org/8527025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111069 0039d316-1c4b-4281-b951-d872f2087c98

Cleanup pass from Cloud Print Proxy policy check implementation. See original CL at http://codereview.chromium.org/8438020/

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8620001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111068 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=trybots


Review URL: http://codereview.chromium.org/8586048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111067 0039d316-1c4b-4281-b951-d872f2087c98

This renames aura::WindowObserver's OnPropertyChanged()
method to have the word "window" in its name, as all of the
class's other methods do.

BUG=none
TEST=built it

Review URL: http://codereview.chromium.org/8621003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111066 0039d316-1c4b-4281-b951-d872f2087c98

GTK 2.24 deprecated all sorts of raw access to object internals in preparation
for GTK3.

BUG=79722
TEST=compiles
TBR=tony,jam

Review URL: http://codereview.chromium.org/8588068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111065 0039d316-1c4b-4281-b951-d872f2087c98

- To measure dropped frames/second.
- To calculate extrapolation of the utilization to play the test video.

Note: Moving Netflix helper functions to a separate class, so they can be reused easily for other Netflix tests.
Review URL: http://codereview.chromium.org/8562006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111063 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8620007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111062 0039d316-1c4b-4281-b951-d872f2087c98

This fixes InputMethodMenuButtonTest and
AccessibilityMenuButtonTest, which were failing due to the
same NULL-status-area problem as the tests fixed by r110851
and r111006.

BUG=103482,103492
TEST=ran them for both aura and non-aura chrome os

Review URL: http://codereview.chromium.org/8625004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111061 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=trybots


Review URL: http://codereview.chromium.org/8550010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111060 0039d316-1c4b-4281-b951-d872f2087c98