- 23 Oct, 2019 40 commits
-
-
Elly Fong-Jones authored
Migrate to the new DialogDelegate::set_button_label() pattern. Also, since the string is static, use it directly from the view. Bug: 1011446 Change-Id: I067d07b75d7d02c628f009328e36afdfd1d1f7ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876467Reviewed-by:
Siyu An <siyua@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#708699}
-
Lily Chen authored
Bug: None Change-Id: I62d87f2fcb30322e0f311de7dfdf1d0992d044e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876793 Commit-Queue: Lily Chen <chlily@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#708698}
-
Shivani Sharma authored
Populate NetworkIsolationKey in MockHttpRequest so that the tests are equipped to support partitioned Http cache. Also passes the generated cache key in various test utility functions instead of simply the URL. Bug: 1009621 Change-Id: I5c9577a8bffc9438902bd9c079a703a2dcf6e191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830094 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#708697}
-
Javier Ernesto Flores Robles authored
This adds a common method to our testing class that can be used in EG1 and EG2. |EarlGrey| has 2 methods to rotate the device, once for EG1 and another for EG2. Which makes this check pretty common in the EG2 migration. Adding it to the base test class instead of to |EarlGrey| to avoid creating a 3rd method signature for it. Once EG1 support is removed a simple search and replace can be used to clean this. Bug: 1016368 Change-Id: I24b2c4ae56266111e6069990252164090df80bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871874 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#708696}
-
Xiyuan Xia authored
This reverts commit 099f851f. Reason for revert: Breaks popup widget on Windows: https://crbug.com/1016672 https://crbug.com/1016980 Original change's description: > cros: Fix capturing orientation > > Instead of setting the rotation as part of the transform on > ash root window, call viz SetDisplayTransformHint so that > capturing code as a consumer of viz could get the correct > orientation. > > Bug: 847693 > Change-Id: Id70f91dc84fc9274145d5a160a51b8c7fa50deed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825892 > Reviewed-by: kylechar <kylechar@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707004} TBR=xiyuan@chromium.org,sky@chromium.org,oshima@chromium.org,dcastagna@chromium.org,khushalsagar@chromium.org,kylechar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 847693, 1016672, 1016980 Change-Id: Ic437d89b1cd43b3c9280dadeb45be93f5a21b753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876689Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#708695}
-
Tomasz Wiszkowski authored
This change ensures that the Suggestion icon's drawable area remains square. We cannot depend on vertical dimension of the embedded drawable because ColorDrawables, that (along with BitmapDrawables) are entirely handled by RoundedCornerImageView, do not have a fixed vertical size. Bug: 982818 Change-Id: Ib6966eaaaa21d85e61220c9631ae19cd269a2779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866921 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#708694}
-
Stephen McGruer authored
Bug: 788440 Change-Id: I0a208b7c363e912ed76f270dbcc1af3e16a44100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829355Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#708693}
-
Alex Cooper authored
Removes the "test" qualifier for WebVr, thus ensuring that all existing and any future WPTs or web_tests for WebVr will not work. Stops import of WebVr specific WPTs. As part of prepping to remove the runtime flag, also removes the feature policy mapping for WebVr and the corresponding webexposed feature policy Future changes will remove the browser tests and then the corresponding runtime flag and all remaining blink code. Bug: 960132 Change-Id: I884718d8644d5b95eded93c781cce2c410adb0bc No-Export: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865531Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#708692}
-
chrome://device-emulatordpapad authored
Fixed: 1015241 Test: Page still loads, no more HTML Imports warnings in DevTools. Change-Id: Id253682734ef7d456b5dd244657011f5de03d73d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874814Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#708691}
-
Fritz Koenig authored
CMAA was put in place to improve performance on Intel GPUs. Performance has improved on Gen9 GPUs to the point that MSAA 4x is faster than CMAA. On older GPUs run with MSAA 2x, which is comparable to CMAA in speed. Bug: 1003860 Test: chrome://gpu shows MSAA Test: https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-size-change.html?webglVersion=2 Change-Id: I3500881cbd74fa430eb0b209880b8b242fc708eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815768Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#708690}
-
Jonah Ryan-Davis authored
Tests became very flaky, suppressing to get the trybots green. TBR=ynovikov@chromium.org Bug: 1017162 Change-Id: Idac22c98879e4d4b44c24287e4a03ce87fb7452b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875275 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#708689}
-
Chris Mumford authored
TtsApiTest.PlatformSpeakError used testing::CreateFunctor which was unnecessary because gmock's testing::InvokeWithoutArgs currently supports invoking a method of an object. Making this change simplifies the test as well as an upcoming change to gmock_mutant.h. Bug: 1007833, 806952 Change-Id: Id8dbd560ba1233ba2288e8179b0aced29d02a110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874052Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#708688}
-
Klaus Weidner authored
ARCore's checkAvailability reads shared preferences via ArCoreContentProvider, need to turn off strict mode to avoid failing tests that run with enforcement enabled by default. Bug: 1015597 Change-Id: I55023029673498455fd673185ed9153be0af5148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874826Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#708687}
-
Lei Zhang authored
Build a binary for the PDFium fuzzer added in https://pdfium-review.googlesource.com/61470 . Change-Id: Ibec0fb7289691e446d62af5557385aef1253d30c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873397Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#708686}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1f4478ca7839..370eefceab98 git log 1f4478ca7839..370eefceab98 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 saklein@chromium.org call_templates: Fix artifacts examples and standardize to betty Created with: gclient setdep -r src/third_party/chromite@370eefceab98 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I60f81f9bece0c000a02cfde4b1fb8d0f32bfa4b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875343Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708685}
-
Yusuke Sato authored
With this change, the order of private functions in the class roughly match the order they are called. This is just to make the code slightly easier to read. BUG=None TEST=try, no real code change Change-Id: I02a5d090fb29b70e70b50802eda6b141774efc14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876727 Auto-Submit: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#708684}
-
Xinghui Lu authored
Password Reuse Detection is not fully functional on Android because it doesn't capture SetComposingText events and FinishComposingText events. In this CL, add SetComposingText and FinishComposingText events to ime_input_event_observers_. Changes on password manager which uses new APIs is in crrev.com/c/1873144. Bug: 1006430 Change-Id: Icb0e378d71bc0d1a2b42e70972ee4fd7cd97035c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824360 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#708683}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0cdd39db4443..1342a6ae6285 git log 0cdd39db4443..1342a6ae6285 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 treehugger-gerrit@google.com Merge "processor: Expose a C++ API for ExportJson to chrome" Created with: gclient setdep -r src/third_party/perfetto@1342a6ae6285 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I989a1ed0b1e0a6d65766ca1f525f60637841a387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875341Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a3f0da56e4c9..341701573a5d git log a3f0da56e4c9..341701573a5d --date=short --no-merges --format='%ad %ae %s' 2019-10-23 johnkslang@users.noreply.github.com Merge pull request #1946 from KhronosGroup/extend-web Created with: gclient setdep -r src/third_party/glslang/src@341701573a5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Bug: None Change-Id: Idde37ce3c894487c03465f24cab419403c668704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875344Reviewed-by:
-
Michael Spang authored
This fixes the following error in components builds on chromecast: ld.lld: error: undefined symbol: media::mojom::kMediaRendererServiceName >>> referenced by shell_content_browser_client.cc:301 (../../content/shell/browser/shell_content_browser_client.cc:301) >>> content_shell_lib/shell_content_browser_client.o:(content::ShellContentBrowserClient::RunServiceInstance(service_manager::Identity const&, mojo::PendingReceiver<service_manager::mojom::Service>*)) in archive obj/content/shell/libcontent_shell_lib.a clang: error: linker command failed with exit code 1 (use -v to see invocation) Change-Id: I4fa28fead6e003b1bfc9fe0448c53acf56864b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874331Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#708680}
-
Xing Liu authored
Starts from Android O MR1, Android code may resize the large icon. We don't need to check equality on the large icon bitmap. Bug: 999357 Change-Id: I65f38a0fb120608ea9d23611f6e93db5ec674bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864385Reviewed-by:
-
Ken Rockot authored
Ports ash usage of the Data Decoder service to use the service interface directly rather than going through a Service Manager Connector. Bug: 977637 Change-Id: I3cf24b34ab0eeff6665055b5add7fb1d90c591bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872918Reviewed-by:
-
Josh Nohle authored
This is an implementation of CryptAuthV2DeviceManager used for tests. It queues DeviceSync requests made via ForceDeviceSyncNow(). These requests are sequentially processed by calls to FinishNextForcedDeviceSync(), which also updates parameters such as the last DeviceSync time. Bug: 951969 Change-Id: I964425fcab12a25d58082f882d344146f324bacf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874196Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#708677}
-
Mohamed Amir Yosef authored
With the new parser in place, FormData should be used to check empty fields instead of PasswordForm Change-Id: I8242cc82524d14de4a82c2ffde6d8c059c7d3ee2 Bug: 949519,1017129, 1008798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849894 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
The tests were flaky because of inconsistent forcus status. Change-Id: Idb494efcc489a441446c4a9b12968cde86faf8e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872991Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#708675}
-
Lily Chen authored
This change adds different types with which CookieAccessDelegateImpl can be constructed. One type, USE_CONTENT_SETTINGS is the default behavior of checking the CookieSettings to determine whether a given cookie is Legacy or Nonlegacy. The other type, ALWAYS_LEGACY, always returns Legacy access semantics for every cookie. The ALWAYS_LEGACY type of CookieAccessDelegate is used for Android WebView, for compatibility reasons. (The SameSite cookie changes would break too much stuff, so we treat every cookie as Legacy to maintain compatibility.) Bug: 986319 Change-Id: I68384da121b025525da5fd2ef6f9dff25a8a2ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872782Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#708674}
-
James Cook authored
The method is only used in tests, so move the implementation to the test suites that need it. Bug: none Change-Id: I5dbdca6a56e4d753a85e3bba4ea816fe215eb749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875027 Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#708673}
-
Tim Volodine authored
In this patch: - add skeleton classes such as UrlCheckerDelegateImpl, UI manager, - add safebrowsing for weblayer feature, - add safebrowsing throttle, - add build configs, deps and owners files. In the skeleton classes most methods are not implemented yet and will be implemented where necessary in further CLs. Also proper init sequence will be implemented separately. BUG=1015418 Change-Id: I80a9a40b18204e760289c7f01a48c69370f6d7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866832 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#708672}
-
Leonard Grey authored
This reverts commit d3d72b4f. Reason for revert: crbug/1017263 Original change's description: > Fix cmd+w closing the browser window instead of just the dictionary popover. > > It's been said before and will be said again: keyboard event handling in > Chrome is a monster. Several things came together to make this happen: > > First, in most Mac apps, cmd+w closes the dictionary popover if it's > visible. This specifically happens through the `performClose:` action > sent by the main menu. But, in Chrome, cmd+w closes the tab and not the > window, so cmd+w sends a different action. This meant that cmd+w > originally closed the tab and left the dictionary popover floating. This > was fixed many years ago (see r118131 and r322075) by making > `-[AppController menuNeedsUpdate:]` check the current target of > `performClose:` and only map cmd+w to "close tab" when the target is a > browser window. > > This would work but for another layer of keyboard shortcut handling > trickery. For a number of reasons (see comment beginning "If this > keyEquivalent" added in r565490), Chrome doesn't actually let > `NSMenuItem`s send their own actions. Instead, > ChromeCommandDispatcherDelegate determines which menu item *would* have > been targeted by a given event, then handles the event itself. > > The end result is that, when the dictionary popover is visible, the menu > items are successfully remapped so that cmd+w means "Close Window". But, > any actual cmd+w event is grabbed by ChromeCommandDispatcherDelegate and > sent directly to Chrome's own keyboard shortcut handling… so the browser > window closes. > > This change adds a check that was proposed back in r322075, and makes > ChromeCommandDispatcherDelegate only grab the event when the found menu > item's action would be sent to its own window. > > Bug: 947752 > Change-Id: Ib32988d5fb69c79f899069feb02f7529ea05225f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849431 > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705275} TBR=avi@chromium.org,sdy@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 947752 Change-Id: I4d2aef624e111d4e14c4a0d36e7f6a08f2fa08cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876690Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#708671}
-
Alex Turner authored
This is a reland of 3a9215b3 DevTools tests are slow and need to be marked as such, including adding Timeout as an expected result to fix the fails/flakiness on WebKit Linux MSAN. Original change's description: > Adapt isolated-code-cache web tests to partitioned HTTP Cache > > The not-site-per-process isolated-code-cache web tests currently assume > that cross-origin resources are cached when code cache site isolation is > not active. This causes them to fail when the HTTP Cache is partitioned > by Network Isolation Key. We thus disable the partitioned HTTP Cache for > those tests and add a new test for when site isolation is not active, > but the HTTP Cache is still partitioned. > > Bug: 1009628 > Change-Id: I0d5d438d9564d3f659b93484a5bcc8aa56d2cd26 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865421 > Reviewed-by: Shivani Sharma <shivanisha@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Alex Turner <alexmt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707360} Bug: 1009628 Change-Id: I28a0df6d2751f7ac0463d9cb03c488e70ebe034e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873109Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#708670}
-
Chris Hall authored
R=dmazzoni,meredithl Change-Id: I96a67a64371aec7e005429eda668223fd12ab02f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874409 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Trent Apted authored
This only affects debug builds. Turns a console error like FATAL:web_ui_data_source_impl.cc(296)] Check failed: resource_id != -1 (-1 vs. -1) into something a like FATAL:web_ui_data_source_impl.cc(296)] Check failed: resource_id != -1 (-1 vs. -1) for assets/02_west.png Change-Id: Iac2ffb57ef7fe734b165edabb1cc2ddd00660f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874748 Auto-Submit: Trent Apted <tapted@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#708668}
-
Tatiana Buldina authored
Bug: chromedriver:3179 Change-Id: If5d9ad3884411d7c42307793d28e88ccd33538e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874243Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#708667}
-
Dominique Fauteux-Chapleau authored
Bug: 944625 Change-Id: Iccee30e7a2da35fc22ee895cf59dc129c0e8298f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865592 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#708666}
-
Steven Bennetts authored
Bug: 965089 Change-Id: Ib2161502c7e5c2a6051c66b43b911f2f9fdd7115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874688 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ie518520073986d8350b787f94d239f8759ca6776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875317Reviewed-by:
-
Jesse McKenna authored
This change adds function GetUserDataSuffix(), which returns the install suffix (e.g. "" for the primary install mode, " SxS", " Beta", or " Dev") given a path in the User Data folder. It is based on GetInstallSuffix(), which does the same given a path in the Application folder. This new function is the first part of finding the location of chrome.exe from within the User Data directory, where Progressive Web App (PWA) launchers are planned to be. The next step will be a function that uses the install mode from FindInstallMode(GetUserDataSuffix()) to get the full path of chrome.exe, which PWAs can then use to launch. Change-Id: If69859fc5f36b7d2d2c4262a1955bd432d983597 Bug: 960245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866977 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#708663}
-
Lucas Furukawa Gadani authored
Bug: 984550, 860403 Change-Id: Id41142246f83fa05153e97b93bee8ffaf73215d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854185Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#708662}
-
Oriol Brufau authored
When serializing grid-template-rows/columns of a grid container, we need to handle auto repeat() specially in order to insert the line names at the correct places. Before this patch, this was skipped for indices before the insertion point of the auto repeat, and in case the auto repeat had no line name. The latter logic was wrong, if there is an auto repeat we still need the special code after the insertion point, even if it has no line names. The proper condition to check is whether there is no auto repeat. The patch also avoids a 2nd call to GridAutoRepeatRows/Columns since we already have the value in a variable. BUG=1011329 TEST=external/wpt/css/css-grid/parsing/grid-template-columns-computed-nogrid.html TEST=external/wpt/css/css-grid/parsing/grid-template-columns-computed.html TEST=external/wpt/css/css-grid/parsing/grid-template-rows-computed-nogrid.html TEST=external/wpt/css/css-grid/parsing/grid-template-rows-computed-withcontent.html TEST=external/wpt/css/css-grid/parsing/grid-template-rows-computed.html There are some test failures because integer repeat() is still expanded at computed-value time (http://crbug.com/989004). Change-Id: I16d06275384ab8c7866b4981ba8dcc665258b29d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857125Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#708661}
-
Ben Pastene authored
I've received enough questions regarding led & chromium bots to warrant a small doc, I think. This isn't meant to be a full overview of what's possible with led, but might be a good starting point for someone that's not familiar with it. (ie: The target audience is someone that's not very familiar with our infra/bots.) Change-Id: I629f3872aa5f0b2da0ec4821ba1befea47bdd3da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518458Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#708660}
-
